15802 2007-11-02 11:33:31 -0700 [GTK] webkit_page_clear API 2007-11-04 17:15:44 -0800 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED WONTFIX Gtk P2 Normal --- 0 iwkse webkit-unassigned mrowe oldest_to_newest 60074 0 iwkse 2007-11-02 11:33:31 -0700 Allow a method to clear a WebKitPage. 60075 1 16996 iwkse 2007-11-02 11:34:27 -0700 Created attachment 16996 Add a API for clear a WebKitPage 60179 2 ddkilzer 2007-11-03 08:39:36 -0700 (In reply to comment #1) > Created an attachment (id=16996) [edit] > Add a API for clear a WebKitPage Please set the "review?" flag if you would like your patch reviewed. Thanks! 60189 3 16996 iwkse 2007-11-03 11:26:30 -0700 Comment on attachment 16996 Add a API for clear a WebKitPage >Index: WebKit/gtk/Api/webkitgtkpage.cpp >=================================================================== >--- WebKit/gtk/Api/webkitgtkpage.cpp (revision 27376) >+++ WebKit/gtk/Api/webkitgtkpage.cpp (working copy) >@@ -498,6 +498,11 @@ > frameData->frame->loader()->load(ResourceRequest(KURL(string))); > } > >+void webkit_page_clear(WebKitPage *page) >+{ >+ webkit_page_load_html_string(page, "<html><body></body></html>", "about:blank"); >+} >+ > void webkit_page_reload(WebKitPage* page) > { > WebKitPagePrivate* pageData = WEBKIT_PAGE_GET_PRIVATE(page); >Index: WebKit/gtk/Api/webkitgtkpage.h >=================================================================== >--- WebKit/gtk/Api/webkitgtkpage.h (revision 27376) >+++ WebKit/gtk/Api/webkitgtkpage.h (working copy) >@@ -136,6 +136,9 @@ > webkit_page_open (WebKitPage* page, const gchar* url); > > WEBKIT_API void >+webkit_page_clear (WebKitPage *page); >+ >+WEBKIT_API void > webkit_page_reload (WebKitPage *page); > > WEBKIT_API void 60237 4 mrowe 2007-11-04 08:22:14 -0800 You can trivially clear a page by loading about:blank into it. I don't see why this is desirable as API. 60238 5 16996 mrowe 2007-11-04 08:23:11 -0800 Comment on attachment 16996 Add a API for clear a WebKitPage As mentioned, I don't think this is desirable in the API. 16996 2007-11-02 11:34:27 -0700 2007-11-04 08:23:11 -0800 Add a API for clear a WebKitPage webkit_clear.patch text/plain 975 iwkse SW5kZXg6IFdlYktpdC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCShyZXZpc2lvbiAyNzM3NikKKysrIFdlYktp dC9ndGsvQXBpL3dlYmtpdGd0a3BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OTgsNiArNDk4 LDExIEBACiAgICAgZnJhbWVEYXRhLT5mcmFtZS0+bG9hZGVyKCktPmxvYWQoUmVzb3VyY2VSZXF1 ZXN0KEtVUkwoc3RyaW5nKSkpOwogfQogCit2b2lkIHdlYmtpdF9wYWdlX2NsZWFyKFdlYktpdFBh Z2UgKnBhZ2UpCit7CisJd2Via2l0X3BhZ2VfbG9hZF9odG1sX3N0cmluZyhwYWdlLCAiPGh0bWw+ PGJvZHk+PC9ib2R5PjwvaHRtbD4iLCAiYWJvdXQ6YmxhbmsiKTsKK30KKwogdm9pZCB3ZWJraXRf cGFnZV9yZWxvYWQoV2ViS2l0UGFnZSogcGFnZSkKIHsKICAgICBXZWJLaXRQYWdlUHJpdmF0ZSog cGFnZURhdGEgPSBXRUJLSVRfUEFHRV9HRVRfUFJJVkFURShwYWdlKTsKSW5kZXg6IFdlYktpdC9n dGsvQXBpL3dlYmtpdGd0a3BhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZ3RrL0FwaS93ZWJr aXRndGtwYWdlLmgJKHJldmlzaW9uIDI3Mzc2KQorKysgV2ViS2l0L2d0ay9BcGkvd2Via2l0Z3Rr cGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsNiArMTM2LDkgQEAKIHdlYmtpdF9wYWdlX29w ZW4gKFdlYktpdFBhZ2UqIHBhZ2UsIGNvbnN0IGdjaGFyKiB1cmwpOwogCiBXRUJLSVRfQVBJIHZv aWQKK3dlYmtpdF9wYWdlX2NsZWFyIChXZWJLaXRQYWdlKiBwYWdlKTsKKworV0VCS0lUX0FQSSB2 b2lkCiB3ZWJraXRfcGFnZV9yZWxvYWQgKFdlYktpdFBhZ2UgKnBhZ2UpOwogCiBXRUJLSVRfQVBJ IHZvaWQK