15800 2007-11-02 11:03:26 -0700 REGRESSION (r27299-r27305): RegExp leaks on Tiger 2007-11-03 01:51:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/trunk-mac-intel-debug/1950/DumpRenderTree2-leaks.txt Regression P1 Normal --- 1 mitz ap ap oldest_to_newest 60069 0 mitz 2007-11-02 11:03:26 -0700 The build bot is seeing leaks starting with build 1950 <http://build.webkit.org/builders/trunk-mac-intel-debug/builds/1950>. I cannot reproduce the leaks on my Leopard system. Given the backtraces I suspect <http://trac.webkit.org/projects/webkit/changeset/27303>. 60160 1 17021 ap 2007-11-03 01:15:40 -0700 Created attachment 17021 proposed fix 60161 2 17021 darin 2007-11-03 01:20:38 -0700 Comment on attachment 17021 proposed fix Looks good. Why did my code change cause the regression? Could we use OwnPtr here? r=me 60167 3 ap 2007-11-03 01:51:42 -0700 (In reply to comment #2) > Why did my code change cause the regression? It was my change that added RegExp.compile - I wrongly assumed setRegExp deleted the old value. > Could we use OwnPtr here? Oops, forgot about it somehow. Changed to use OwnPtr. > r=me Committed revision 27393. 17021 2007-11-03 01:15:40 -0700 2007-11-03 01:20:38 -0700 proposed fix 15800r1_patch.txt text/plain 2430 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzkyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEtMDMgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1ODAwCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzMwMyk6IFJlZ0V4cCBsZWFrcworCisg ICAgICAgICoga2pzL3JlZ2V4cF9vYmplY3QuaDogUmVuYW1lZCByZWcgbWVtYmVyIHZhcmlhYmxl IHRvIG1fcmVnRXhwLgorICAgICAgICAoS0pTOjpSZWdFeHBJbXA6OnNldFJlZ0V4cCk6IERlbGV0 ZSBleGlzdGluZyByZWdleHAgd2hlbiBzZXR0aW5nIHRvIGEgbmV3IG9uZS4KKyAgICAgICAgKEtK Uzo6UmVnRXhwSW1wOjpyZWdFeHApOgorICAgICAgICAoS0pTOjpSZWdFeHBJbXA6OmNsYXNzSW5m byk6CisgICAgICAgICoga2pzL3JlZ2V4cF9vYmplY3QuY3BwOiBSZW5hbWVkIHJlZyBtZW1iZXIg dmFyaWFibGUgdG8gbV9yZWdFeHAuCisgICAgICAgIChSZWdFeHBJbXA6OlJlZ0V4cEltcCk6Cisg ICAgICAgIChSZWdFeHBJbXA6On5SZWdFeHBJbXApOgorCiAyMDA3LTExLTAyICBNYWNpZWogU3Rh Y2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyLgpJ bmRleDogSmF2YVNjcmlwdENvcmUva2pzL3JlZ2V4cF9vYmplY3QuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL2tqcy9yZWdleHBfb2JqZWN0LmNwcAkocmV2aXNpb24gMjczNzMpCisr KyBKYXZhU2NyaXB0Q29yZS9ranMvcmVnZXhwX29iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE5MSwxNCArMTkxLDE1IEBAIEpTVmFsdWUgKlJlZ0V4cFByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rp b24KIAogY29uc3QgQ2xhc3NJbmZvIFJlZ0V4cEltcDo6aW5mbyA9IHsiUmVnRXhwIiwgMCwgMCwg MH07CiAKLVJlZ0V4cEltcDo6UmVnRXhwSW1wKFJlZ0V4cFByb3RvdHlwZSAqcmVnZXhwUHJvdG8p Ci0gIDogSlNPYmplY3QocmVnZXhwUHJvdG8pLCByZWcoMEwpCitSZWdFeHBJbXA6OlJlZ0V4cElt cChSZWdFeHBQcm90b3R5cGUqIHJlZ2V4cFByb3RvKQorICA6IEpTT2JqZWN0KHJlZ2V4cFByb3Rv KQorICAsIG1fcmVnRXhwKDApCiB7CiB9CiAKIFJlZ0V4cEltcDo6flJlZ0V4cEltcCgpCiB7Ci0g IGRlbGV0ZSByZWc7CisgIGRlbGV0ZSBtX3JlZ0V4cDsKIH0KIAogLy8gLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tIFJlZ0V4cE9iamVjdEltcCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9yZWdleHBfb2JqZWN0LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL3JlZ2V4cF9vYmplY3QuaAkocmV2aXNpb24gMjczNzMp CisrKyBKYXZhU2NyaXB0Q29yZS9ranMvcmVnZXhwX29iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBA IC00OSwxNSArNDksMTUgQEAgbmFtZXNwYWNlIEtKUyB7CiAKICAgY2xhc3MgUmVnRXhwSW1wIDog cHVibGljIEpTT2JqZWN0IHsKICAgcHVibGljOgotICAgIFJlZ0V4cEltcChSZWdFeHBQcm90b3R5 cGUgKnJlZ2V4cFByb3RvKTsKKyAgICBSZWdFeHBJbXAoUmVnRXhwUHJvdG90eXBlKiByZWdleHBQ cm90byk7CiAgICAgflJlZ0V4cEltcCgpOwotICAgIHZvaWQgc2V0UmVnRXhwKFJlZ0V4cCAqcikg eyByZWcgPSByOyB9Ci0gICAgUmVnRXhwKiByZWdFeHAoKSBjb25zdCB7IHJldHVybiByZWc7IH0K KyAgICB2b2lkIHNldFJlZ0V4cChSZWdFeHAqIHIpIHsgZGVsZXRlIG1fcmVnRXhwOyBtX3JlZ0V4 cCA9IHI7IH0KKyAgICBSZWdFeHAqIHJlZ0V4cCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVnRXhwOyB9 CiAKLSAgICB2aXJ0dWFsIGNvbnN0IENsYXNzSW5mbyAqY2xhc3NJbmZvKCkgY29uc3QgeyByZXR1 cm4gJmluZm87IH0KKyAgICB2aXJ0dWFsIGNvbnN0IENsYXNzSW5mbyogY2xhc3NJbmZvKCkgY29u c3QgeyByZXR1cm4gJmluZm87IH0KICAgICBzdGF0aWMgY29uc3QgQ2xhc3NJbmZvIGluZm87CiAg IHByaXZhdGU6Ci0gICAgUmVnRXhwICpyZWc7CisgICAgUmVnRXhwKiBtX3JlZ0V4cDsKICAgfTsK IAogICBzdHJ1Y3QgUmVnRXhwT2JqZWN0SW1wUHJpdmF0ZTsK