157986 2016-05-23 03:41:29 -0700 Add a few initiator tests to resource timing. 2016-05-24 12:48:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=158019 P2 Normal --- 1 yoav webkit-unassigned achristensen commit-queue ryanhaddad oldest_to_newest 1195483 0 yoav 2016-05-23 03:41:29 -0700 Add a few initiator tests to resource timing. 1195484 1 279559 yoav 2016-05-23 03:43:15 -0700 Created attachment 279559 Patch 1195485 2 yoav 2016-05-23 03:47:48 -0700 This adds some tests that make sure initiator info doesn't get overridden when later requests try to store RT info for the same resource. Currently implementation relies on the fact that HashMap avoids adding entries for keys that are already in the map. Is that part of the semantics of HashMap and can be relied on, or is it necessary to add a check before attempts to add initiator info for a resource? 1195529 3 achristensen 2016-05-23 11:15:47 -0700 HashMap::add does nothing if the key is already in the map, even if you're trying to add it with a different value. HashMap::set will overwrite an existing value for the given key. This behavior won't change. 1195548 4 yoav 2016-05-23 12:44:12 -0700 (In reply to comment #3) > HashMap::add does nothing if the key is already in the map, even if you're > trying to add it with a different value. HashMap::set will overwrite an > existing value for the given key. This behavior won't change. cool, didn't know that. In that case, no need to add further checks 1195740 5 279559 yoav 2016-05-23 23:07:38 -0700 Comment on attachment 279559 Patch Thanks for reviewing! :) 1195749 6 279559 commit-queue 2016-05-23 23:28:51 -0700 Comment on attachment 279559 Patch Clearing flags on attachment: 279559 Committed r201323: <http://trac.webkit.org/changeset/201323> 1195750 7 commit-queue 2016-05-23 23:28:54 -0700 All reviewed patches have been landed. Closing bug. 1195975 8 ryanhaddad 2016-05-24 12:47:52 -0700 Reverted r201323 for reason: One of the LayoutTests added with this change fails on all platforms. Rolling out until ResourceTiming flakiness fix is landed Committed r201343: <http://trac.webkit.org/changeset/201343> 279559 2016-05-23 03:43:15 -0700 2016-05-23 23:28:51 -0700 Patch bug-157986-20160523124419.patch text/plain 5059 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTE3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWNhMTA5NzI1ODNkYmZmYmE2MTMw YWU5NTIwNDE5ZGRlNGY4MDA4Ny4uNzIyMTlmYjQ5NDFmYzE1Yjc2MDNkNjI4ZWYwNWJhNDNiNDU1 NjAzOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA1LTIzICBZb2F2IFdlaXNzICA8eW9h dkB5b2F2LndzPgorCisgICAgICAgIEFkZCBhIGZldyBpbml0aWF0b3IgdGVzdHMgdG8gcmVzb3Vy Y2UgdGltaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3OTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkcyB0ZXN0cyB0aGF0IG1ha2Ugc3VyZSB0aGF0IHdoZW4gYSByZXNvdXJjZSBpcyByZXF1 ZXN0ZWQgbXVsdGlwbGUgdGltZXMgYnkgZGlmZmVyZW50CisgICAgICAgIGVsZW1lbnRzLCBpdHMg aW5pdGlhdG9yIHR5cGUgcmVtYWluIHRoZSBmaXJzdCBvbmUgdGhhdCB0cmlnZ2VyZWQgdGhlIGZl dGNoLgorCisgICAgICAgICogaHR0cC90ZXN0cy9wZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1yZXNv dXJjZS10aW1pbmctaW5pdGlhdG9yLWNzcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvdGVzdHMvcGVyZm9ybWFuY2UvcGVyZm9ybWFuY2UtcmVzb3VyY2UtdGltaW5nLWluaXRp YXRvci1jc3MuaHRtbDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9wZXJmb3JtYW5jZS9w ZXJmb3JtYW5jZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9yLW5vLW92ZXJyaWRlLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9wZXJmb3JtYW5jZS9wZXJmb3JtYW5j ZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9yLW5vLW92ZXJyaWRlLmh0bWw6IEFkZGVkLgorCiAy MDE2LTA1LTEzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWxs IHNjcm9sbGluZyBoZWlnaHQvd2lkdGggdmFsdWVzIHNob3VsZCBiZSBpbnRlZ3JhbCByb3VuZGVk LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wZXJmb3JtYW5jZS9wZXJmb3Jt YW5jZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9yLWNzcy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNlLXJlc291cmNlLXRpbWluZy1p bml0aWF0b3ItY3NzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wOTRlYWY4ZmM0NmZlNWVmNDQ3 NzQ1Y2EyOWEwZTY4NTQ5ZGE1ZjdmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9wZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9y LWNzcy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitQQVNTIGluaXRpYXRvciBpcyAiY3Nz IgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BlcmZvcm1hbmNlL3BlcmZv cm1hbmNlLXJlc291cmNlLXRpbWluZy1pbml0aWF0b3ItY3NzLmh0bWwgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNlLXJlc291cmNlLXRpbWluZy1pbml0aWF0 b3ItY3NzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZWQ5NjQzMWJkYWRiNmViNmI0ZDE1ZDFkMWM3NGI3Mzkx MzlhMzY4YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcGVyZm9y bWFuY2UvcGVyZm9ybWFuY2UtcmVzb3VyY2UtdGltaW5nLWluaXRpYXRvci1jc3MuaHRtbApAQCAt MCwwICsxLDM2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHNjcmlwdD4KKyAgICBpZiAo d2luZG93LmludGVybmFscykKKyAgICAgICAgaW50ZXJuYWxzLnNldFJlc291cmNlVGltaW5nU3Vw cG9ydCh0cnVlKTsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCkKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cisg ICAgfQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzxib2R5PgorPHN0eWxlPgorICAgIGJvZHkgeyBiYWNrZ3JvdW5kOiB1 cmwoIi4uLy4uL3Jlc291cmNlcy9zcXVhcmUxMDAucG5nIik7IH0KKzwvc3R5bGU+Cis8c2NyaXB0 PgorICAgIHZhciBpbml0aWF0b3I7CisgICAgdmFyIHJ1blRlc3QgPSBmdW5jdGlvbigpIHsKKyAg ICAgICAgdmFyIHJlc291cmNlcyA9IHBlcmZvcm1hbmNlLmdldEVudHJpZXNCeVR5cGUoJ3Jlc291 cmNlJyk7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVzb3VyY2VzLmxlbmd0aDsgKytp KSB7CisgICAgICAgICAgICBpZiAocmVzb3VyY2VzW2ldLm5hbWUuaW5kZXhPZigic3F1YXJlIikg IT0gLTEpIHsKKyAgICAgICAgICAgICAgICBpbml0aWF0b3IgPSByZXNvdXJjZXNbaV0uaW5pdGlh dG9yVHlwZTsKKyAgICAgICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImluaXRpYXRv ciIsICJjc3MiKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfTsKKyAgICAgICAgaWYgKHdpbmRv dy5pbnRlcm5hbHMpCisgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldFJlc291cmNlVGlt aW5nU3VwcG9ydChmYWxzZSk7CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAg ICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH07CisgICAgd2luZG93LmFkZEV2 ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsKKyAgICAgICAgcnVuVGVzdCgpOworICAg IH0pOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNlLXJlc291cmNlLXRpbWluZy1pbml0 aWF0b3Itbm8tb3ZlcnJpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9w ZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9yLW5vLW92ZXJy aWRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44YWE2ODM1YWI0OWNjYjA4MmE4Mzg0NDZmMjc2 ZTJlN2Y0MWU5ZDAzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9w ZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1yZXNvdXJjZS10aW1pbmctaW5pdGlhdG9yLW5vLW92ZXJy aWRlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1BBU1MgaW5pdGlhdG9yIGlzICJpbWci CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcGVyZm9ybWFuY2UvcGVyZm9y bWFuY2UtcmVzb3VyY2UtdGltaW5nLWluaXRpYXRvci1uby1vdmVycmlkZS5odG1sIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9wZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1yZXNvdXJjZS10aW1pbmct aW5pdGlhdG9yLW5vLW92ZXJyaWRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTk5MDQ1MWE4YTM0NWNmYjQ4 MTJlMjI3Y2JkNTQzNTBlYTk3NzIwNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvcGVyZm9ybWFuY2UvcGVyZm9ybWFuY2UtcmVzb3VyY2UtdGltaW5nLWluaXRpYXRv ci1uby1vdmVycmlkZS5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICBpbnRlcm5h bHMuc2V0UmVzb3VyY2VUaW1pbmdTdXBwb3J0KHRydWUpOworICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKQorICAgICAgICB0ZXN0UnVu bmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8u Li9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPGJvZHk+Cis8aW1nIHNyYz0i Li4vLi4vcmVzb3VyY2VzL3NxdWFyZTEwMC5wbmciPgorPHN0eWxlPgorICAgIGJvZHkgeyBiYWNr Z3JvdW5kOiB1cmwoIi4uLy4uL3Jlc291cmNlcy9zcXVhcmUxMDAucG5nIik7IH0KKzwvc3R5bGU+ Cis8c2NyaXB0PgorICAgIHZhciBpbml0aWF0b3I7CisgICAgdmFyIHJ1blRlc3QgPSBmdW5jdGlv bigpIHsKKyAgICAgICAgdmFyIHJlc291cmNlcyA9IHBlcmZvcm1hbmNlLmdldEVudHJpZXNCeVR5 cGUoJ3Jlc291cmNlJyk7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVzb3VyY2VzLmxl bmd0aDsgKytpKSB7CisgICAgICAgICAgICBpZiAocmVzb3VyY2VzW2ldLm5hbWUuaW5kZXhPZigi c3F1YXJlIikgIT0gLTEpIHsKKyAgICAgICAgICAgICAgICBpbml0aWF0b3IgPSByZXNvdXJjZXNb aV0uaW5pdGlhdG9yVHlwZTsKKyAgICAgICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmco ImluaXRpYXRvciIsICJpbWciKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfTsKKyAgICAgICAg aWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldFJl c291cmNlVGltaW5nU3VwcG9ydChmYWxzZSk7CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH07CisgICAgd2lu ZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsKKyAgICAgICAgcnVuVGVz dCgpOworICAgIH0pOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==