157977 2016-05-22 09:45:47 -0700 RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests 2016-08-23 09:39:00 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160782 InRadar P2 Normal --- 1 ap ap commit-queue ddkilzer lforschler webkit-bug-importer oldest_to_newest 1195421 0 ap 2016-05-22 09:45:47 -0700 This assertion is sometimes hit when running tests: 0 com.apple.JavaScriptCore 0x000000010f0eeaee WTFCrash + 62 1 WebKitTestRunner 0x000000010ef0c5bf 0x10eeff000 + 54719 2 com.apple.WebKit 0x000000010f9a11f9 std::__1::__function::__func<WKPageForceRepaint::$_1, std::__1::allocator<WKPageForceRepaint::$_1>, void (WebKit::CallbackBase::Error)>::operator()(WebKit::CallbackBase::Error&&) + 77 3 com.apple.WebKit 0x000000010f85f9e4 WebKit::GenericCallback<>::performCallbackWithReturnValue() + 44 4 com.apple.WebKit 0x000000010f78ef21 WebKit::WebPageProxy::voidCallback(unsigned long long) + 45 5 com.apple.WebKit 0x000000010f9366c6 WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 9224 6 com.apple.WebKit 0x000000010f7f7ed5 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) + 113 rdar://problem/20874156 1195422 1 279550 ap 2016-05-22 09:53:55 -0700 Created attachment 279550 proposed fix I'm not quite certain if this eliminates every possibility for race, but it does seem to prevent the crash in my testing. 1195449 2 279550 ddkilzer 2016-05-22 15:33:38 -0700 Comment on attachment 279550 proposed fix r=me 1195450 3 ddkilzer 2016-05-22 15:35:41 -0700 <rdar://problem/20874156> 1195453 4 279550 commit-queue 2016-05-22 15:54:18 -0700 Comment on attachment 279550 proposed fix Clearing flags on attachment: 279550 Committed r201263: <http://trac.webkit.org/changeset/201263> 1195454 5 commit-queue 2016-05-22 15:54:22 -0700 All reviewed patches have been landed. Closing bug. 279550 2016-05-22 09:53:55 -0700 2016-05-22 15:54:18 -0700 proposed fix ReleaseAssert.txt text/plain 2934 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMTI0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA1LTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFTEVBU0VfQVNTRVJUKFRlc3RDb250cm9sbGVyOjpzaW5nbGV0b24oKS5p c0N1cnJlbnRJbnZvY2F0aW9uKHRlc3RJbnZvY2F0aW9uKSkgaXMgc29tZXRpbWVzIGhpdCB3aGVu IHJ1bm5pbmcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1Nzk3NworICAgICAgICByZGFyOi8vcHJvYmxlbS8yMDg3NDE1NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9UZXN0SW52b2NhdGlvbi5jcHA6CisgICAgICAgIChXVFI6OlRlc3RJbnZvY2F0aW9uOjppbnZv a2UpOiBCZSBtb3JlIGNlcnRhaW4gdG8gbGF1bmNoIGEgbmV3IHByb2Nlc3Mgd2hlbiB0aGVyZSB3 YXMKKyAgICAgICAgYSB0aW1lb3V0IGRldGVjdGVkLiBJZiB3ZSBkb24ndCwgdGhlcmUgaXMgYSBj aGFuY2UgdGhhdCB0aGUgcHJvY2VzcyBpcyBub3QgcXVpdGUgZnJvemVuLAorICAgICAgICBhbmQg d2lsbCBzdGlsbCBzZW5kIGEgcmVzcG9uc2UgdGhhdCB3ZSBubyBsb25nZXIgZXhwZWN0LgorICAg ICAgICAoV1RSOjpUZXN0SW52b2NhdGlvbjo6ZHVtcFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNz KTogUHJpbnQgdGltZW91dCBkZXRhaWxzIHRvIHN0ZGVycgorICAgICAgICB0b28sIGFzIHN0ZG91 dCBpcyBub3QgYXZhaWxhYmxlLCBhdCBsZWFzdCBub3QgaW4gdGhlIGNhc2UgdGhhdCBJIHdhcyBv YnNlcnZpbmcuCisKIDIwMTYtMDUtMjEgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFNpbXVsYXRvciBsYXVuY2ggZmFpbHMgaW50ZXJtaXR0ZW50bHkgZHVl IHRvIGZhaWx1cmUgaW4gY2hlY2tpbmcgc2ltdWxhdG9yIGJvb3Qgc3RhdHVzCkluZGV4OiBUb29s cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAkocmV2aXNpb24gMjAxMjAyKQor KysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE3MiwxMyArMTcyLDE1IEBAIGVuZDoKIAogICAgIGlmIChtX3dlYlByb2Nlc3NJc1Vu cmVzcG9uc2l2ZSkKICAgICAgICAgZHVtcFdlYlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCk7Ci0g ICAgZWxzZSBpZiAoIVRlc3RDb250cm9sbGVyOjpzaW5nbGV0b24oKS5yZXNldFN0YXRlVG9Db25z aXN0ZW50VmFsdWVzKG1fb3B0aW9ucykpIHsKLSAgICAgICAgLy8gVGhlIHByb2Nlc3MgZnJvemUg d2hpbGUgbG9hZGluZyBhYm91dDpibGFuaywgbGV0J3Mgc3RhcnQgYSBmcmVzaCBvbmUuCi0gICAg ICAgIC8vIEl0IHdvdWxkIGJlIG5pY2UgdG8gcmVwb3J0IHRoYXQgdGhlIHByZXZpb3VzIHRlc3Qg ZnJvemUgYWZ0ZXIgZHVtcGluZyByZXN1bHRzLCBidXQgd2UgaGF2ZSBubyB3YXkgdG8gZG8gdGhh dC4KLSAgICAgICAgVGVzdENvbnRyb2xsZXI6OnNpbmdsZXRvbigpLnRlcm1pbmF0ZVdlYkNvbnRl bnRQcm9jZXNzKCk7Ci0gICAgICAgIC8vIE1ha2Ugc3VyZSB0aGF0IHdlIGhhdmUgYSBwcm9jZXNz LCBhcyBpbnZva2UoKSB3aWxsIG5lZWQgb25lIHRvIHNlbmQgYnVuZGxlIG1lc3NhZ2VzIGZvciB0 aGUgbmV4dCB0ZXN0LgotICAgICAgICBUZXN0Q29udHJvbGxlcjo6c2luZ2xldG9uKCkucmVhdHRh Y2hQYWdlVG9XZWJQcm9jZXNzKCk7Ci0gICAgfQorICAgIGVsc2UgaWYgKFRlc3RDb250cm9sbGVy OjpzaW5nbGV0b24oKS5yZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKG1fb3B0aW9ucykpCisg ICAgICAgIHJldHVybjsKKyAgICBlbHNlCisgICAgICAgIGR1bXBXZWJQcm9jZXNzVW5yZXNwb25z aXZlbmVzcygiVGVzdENvbnRyb2xsZXI6OnJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMgZmFp bGVkXG4iKTsKKworICAgIC8vIFRoZSBwcm9jZXNzIGlzIHVucmVzcG9uc2l2ZSwgc28gbGV0J3Mg c3RhcnQgYSBuZXcgb25lLgorICAgIFRlc3RDb250cm9sbGVyOjpzaW5nbGV0b24oKS50ZXJtaW5h dGVXZWJDb250ZW50UHJvY2VzcygpOworICAgIC8vIE1ha2Ugc3VyZSB0aGF0IHdlIGhhdmUgYSBw cm9jZXNzLCBhcyBpbnZva2UoKSB3aWxsIG5lZWQgb25lIHRvIHNlbmQgYnVuZGxlIG1lc3NhZ2Vz IGZvciB0aGUgbmV4dCB0ZXN0LgorICAgIFRlc3RDb250cm9sbGVyOjpzaW5nbGV0b24oKS5yZWF0 dGFjaFBhZ2VUb1dlYlByb2Nlc3MoKTsKIH0KIAogdm9pZCBUZXN0SW52b2NhdGlvbjo6ZHVtcFdl YlByb2Nlc3NVbnJlc3BvbnNpdmVuZXNzKCkKQEAgLTE4OCw2ICsxOTAsNyBAQCB2b2lkIFRlc3RJ bnZvY2F0aW9uOjpkdW1wV2ViUHJvY2Vzc1VucmVzCiAKIHZvaWQgVGVzdEludm9jYXRpb246OmR1 bXBXZWJQcm9jZXNzVW5yZXNwb25zaXZlbmVzcyhjb25zdCBjaGFyKiBlcnJvck1lc3NhZ2UpCiB7 CisgICAgZnByaW50ZihzdGRlcnIsICIlcyIsIGVycm9yTWVzc2FnZSk7CiAgICAgY2hhciBlcnJv ck1lc3NhZ2VUb1N0ZGVyclsxMDI0XTsKICNpZiBQTEFURk9STShDT0NPQSkKICAgICBwaWRfdCBw aWQgPSBXS1BhZ2VHZXRQcm9jZXNzSWRlbnRpZmllcihUZXN0Q29udHJvbGxlcjo6c2luZ2xldG9u KCkubWFpbldlYlZpZXcoKS0+cGFnZSgpKTsK