157969 2016-05-20 21:59:36 -0700 check-webkit-style gets flags std::literals::chrono_literals as bad naming 2016-05-23 09:45:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson achristensen commit-queue ddkilzer glenn lforschler oldest_to_newest 1195337 0 beidson 2016-05-20 21:59:36 -0700 check-webkit-style gets flags some std: namespaces as bogus Example: https://bugs.webkit.org/show_bug.cgi?id=157948#c6 "std::literals::chrono_literals is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]" A good rule for our types, but std::literals::chrono_literals is in the stdlib 1195341 1 beidson 2016-05-20 22:20:37 -0700 For the underscore rule, we just have a whole bunch of one-off exceptions. I'll add another. 1195342 2 279538 beidson 2016-05-20 22:21:16 -0700 Created attachment 279538 Patch WIP Don't have time to do the ChangeLog dance tonight before bed, but otherwise this patch is probably good to go. 1195354 3 279542 beidson 2016-05-21 08:17:44 -0700 Created attachment 279542 Patch 1195383 4 achristensen 2016-05-21 17:42:25 -0700 I'm not sure this will come up often after the latest patch from https://bugs.webkit.org/show_bug.cgi?id=157948 makes there be just one using namespace std::literals::chrono_literals; Why does std::numeric_limits::... pass the style check? 1195390 5 beidson 2016-05-21 18:44:34 -0700 (In reply to comment #4) > I'm not sure this will come up often after the latest patch from > https://bugs.webkit.org/show_bug.cgi?id=157948 makes there be just one using > namespace std::literals::chrono_literals; While strictly true, any patch that would add such a line itself would be wrongly flagged. > Why does std::numeric_limits::... pass the style check? It's explicitly exempted in a different section. 1195512 6 279542 commit-queue 2016-05-23 09:45:32 -0700 Comment on attachment 279542 Patch Clearing flags on attachment: 279542 Committed r201288: <http://trac.webkit.org/changeset/201288> 1195513 7 commit-queue 2016-05-23 09:45:36 -0700 All reviewed patches have been landed. Closing bug. 279538 2016-05-20 22:21:16 -0700 2016-05-21 08:17:44 -0700 Patch WIP patch text/plain 1678 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggOWYx YTM1OC4uYWRiOTQ1ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTM0MDAsNyArMzQwMCw4IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVf aW5fZGVjbGFyYXRpb24oZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCBsaW5lLCBmaWxlX3N0YXRlCiAg ICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJzo6X3FfJykg Pj0gMAogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiY29u c3RfaXRlcmF0b3IiCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVy ID09ICJ2bV90aHJvdyIKLSAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZp ZXIgPT0gIkRGR19PUEVSQVRJT04iKToKKyAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVk X2lkZW50aWZpZXIgPT0gIkRGR19PUEVSQVRJT04iCisgICAgICAgICAgICAgICAgYW5kIG5vdCBt b2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJ2Nocm9ub19saXRlcmFscycpID49IDApOgogICAgICAg ICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2Nv cmVzJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVzZSB1 bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuIikKIAogICAgICAgICAjIENoZWNr IGZvciB2YXJpYWJsZXMgbmFtZWQgJ2wnLCB0aGVzZSBhcmUgdG9vIGVhc3kgdG8gY29uZnVzZSB3 aXRoICcxJyBpbiBzb21lIGZvbnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IGVlMzNlZWYuLjM2NzRkN2UgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CkBAIC01MTcyLDYgKzUxNzIsOSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICMgY29uc3RfaXRlcmF0b3IgaXMgYWxsb3dlZCBhcyB3 ZWxsLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIFZlY3RvclR5cGU6OmNvbnN0 X2l0ZXJhdG9yIGNvbnN0X2l0ZXJhdG9yOycsICcnKQogCisgICAgICAgICMgY2hyb25vX2xpdGVy YWxzIGlzIGFsbG93ZWQgYXMgd2VsbC4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndXNpbmcg bmFtZXNwYWNlIHN0ZDo6bGl0ZXJhbHM6OmNocm9ub19saXRlcmFsczsnLCAnJykKKwogICAgICAg ICAjIHZtX3Rocm93IGlzIGFsbG93ZWQgYXMgd2VsbC4KICAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgnaW50IHZtX3Rocm93OycsICcnKQogCg== 279542 2016-05-21 08:17:44 -0700 2016-05-23 09:45:32 -0700 Patch patch text/plain 2392 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWMy NjJkLi5mZmZlNDA1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDUtMjEgIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBnZXRzIGZsYWdzIHN0 ZDo6bGl0ZXJhbHM6OmNocm9ub19saXRlcmFscyBhcyBiYWQgbmFtaW5nLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3OTY5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9k ZWNsYXJhdGlvbik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHk6CisgICAgICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF9uYW1lcyk6CisK IDIwMTYtMDUtMjAgIFNyaW5pdmFzYW4gVmlqYXlhcmFnaGF2YW4gIDxzdmlqYXlhcmFnaGF2YW5A YXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBjbGVhcmVyIG5hbWVzIGZvciBKU09OIG91dHB1dCBv ZiBqYXZhc2NyaXB0Y29yZSB0ZXN0IHJlc3VsdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggOWYxYTM1OC4uYWRiOTQ1ZSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTM0MDAsNyArMzQwMCw4 IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5hbWUsIGxp bmVfbnVtYmVyLCBsaW5lLCBmaWxlX3N0YXRlCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2Rp ZmllZF9pZGVudGlmaWVyLmZpbmQoJzo6X3FfJykgPj0gMAogICAgICAgICAgICAgICAgIGFuZCBu b3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiY29uc3RfaXRlcmF0b3IiCiAgICAgICAgICAgICAg ICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyID09ICJ2bV90aHJvdyIKLSAgICAgICAgICAg ICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIgPT0gIkRGR19PUEVSQVRJT04iKToKKyAg ICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIgPT0gIkRGR19PUEVSQVRJ T04iCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJ2No cm9ub19saXRlcmFscycpID49IDApOgogICAgICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVy LCAncmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzJywgNCwgaWRlbnRpZmllciArICIgaXMg aW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVzZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZp ZXIgbmFtZXMuIikKIAogICAgICAgICAjIENoZWNrIGZvciB2YXJpYWJsZXMgbmFtZWQgJ2wnLCB0 aGVzZSBhcmUgdG9vIGVhc3kgdG8gY29uZnVzZSB3aXRoICcxJyBpbiBzb21lIGZvbnRzCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CmluZGV4IGVlMzNlZWYuLjM2NzRkN2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC01MTcyLDYgKzUxNzIs OSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICMg Y29uc3RfaXRlcmF0b3IgaXMgYWxsb3dlZCBhcyB3ZWxsLgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCd0eXBlZGVmIFZlY3RvclR5cGU6OmNvbnN0X2l0ZXJhdG9yIGNvbnN0X2l0ZXJhdG9yOycs ICcnKQogCisgICAgICAgICMgY2hyb25vX2xpdGVyYWxzIGlzIGFsbG93ZWQgYXMgd2VsbC4KKyAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgndXNpbmcgbmFtZXNwYWNlIHN0ZDo6bGl0ZXJhbHM6OmNo cm9ub19saXRlcmFsczsnLCAnJykKKwogICAgICAgICAjIHZtX3Rocm93IGlzIGFsbG93ZWQgYXMg d2VsbC4KICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IHZtX3Rocm93OycsICcnKQogCg==