157953 2016-05-20 12:52:42 -0700 reifyAllStaticProperties makes two copies of every string 2016-05-23 09:15:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren cdumez commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1195198 0 ggaren 2016-05-20 12:52:42 -0700 reifyAllStaticProperties makes two copies of every string 1195199 1 279497 ggaren 2016-05-20 12:54:24 -0700 Created attachment 279497 Patch 1195216 2 279497 mark.lam 2016-05-20 14:13:28 -0700 Comment on attachment 279497 Patch r=me 1195221 3 ggaren 2016-05-20 14:16:55 -0700 Committed r201225: <http://trac.webkit.org/changeset/201225> 1195222 4 279497 saam 2016-05-20 14:17:13 -0700 Comment on attachment 279497 Patch LGTM too 1195508 5 cdumez 2016-05-23 09:15:59 -0700 Looks like a ~1% Speedometer progression on iOS. 279497 2016-05-20 12:54:24 -0700 2016-05-20 14:13:28 -0700 Patch bug-157953-20160520125525.patch text/plain 3266 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMjIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTA1LTIwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgcmVpZnlBbGxTdGF0aWNQcm9wZXJ0aWVzIG1ha2VzIHR3byBjb3BpZXMgb2YgZXZlcnkgc3Ry aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc5 NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQn cyBub3QgZG8gdGhhdC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAg ICAoSlNDOjpKU09iamVjdDo6cmVpZnlBbGxTdGF0aWNQcm9wZXJ0aWVzKTogUGFzcyBvdXIgSWRl bnRpZmllciB0bworICAgICAgICByZWlmeVN0YXRpY1Byb3BlcnR5IHNvIGl0IGRvZXNuJ3QgaGF2 ZSB0byBtYWtlIGl0cyBvd24uCisKKyAgICAgICAgKiBydW50aW1lL0xvb2t1cC5oOgorICAgICAg ICAoSlNDOjpyZWlmeVN0YXRpY1Byb3BlcnR5KTogTm8gbmVlZCB0byBudWxsIGNoZWNrIGJlY2F1 c2UgY2FsbGVycyBuZXZlcgorICAgICAgICBwYXNzIG51bGwgYW55bW9yZS4gTm8gbmVlZCB0byBt YWtlIGFuIGlkZW50aWZpZXIgYmVjYXVzZSBjYWxsZXJzIHBhc3MKKyAgICAgICAgdXMgb25lLgor CisgICAgICAgIChKU0M6OnJlaWZ5U3RhdGljUHJvcGVydGllcyk6IEhvbm9yIG5ldyBpbnRlcmZh Y2UuCisKIDIwMTYtMDUtMjAgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU0JlbmNoIHJlZ3Jlc3Npb246IENvZGVCbG9jayBsaW5raW5nIGFsd2F5cyBjb3Bp ZXMgdGhlIHN5bWJvbCB0YWJsZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmNwcAkocmV2aXNpb24gMjAxMjIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTUxLDkgKzE5NTEsMTAg QEAgdm9pZCBKU09iamVjdDo6cmVpZnlBbGxTdGF0aWNQcm9wZXJ0aWVzKAogCiAgICAgICAgIGZv ciAoYXV0byYgdmFsdWUgOiAqaGFzaFRhYmxlKSB7CiAgICAgICAgICAgICB1bnNpZ25lZCBhdHRy aWJ1dGVzOwotICAgICAgICAgICAgUHJvcGVydHlPZmZzZXQgb2Zmc2V0ID0gZ2V0RGlyZWN0T2Zm c2V0KHZtLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZ2bSwgdmFsdWUubV9rZXkpLCBhdHRyaWJ1 dGVzKTsKKyAgICAgICAgICAgIGF1dG8ga2V5ID0gSWRlbnRpZmllcjo6ZnJvbVN0cmluZygmdm0s IHZhbHVlLm1fa2V5KTsKKyAgICAgICAgICAgIFByb3BlcnR5T2Zmc2V0IG9mZnNldCA9IGdldERp cmVjdE9mZnNldCh2bSwga2V5LCBhdHRyaWJ1dGVzKTsKICAgICAgICAgICAgIGlmICghaXNWYWxp ZE9mZnNldChvZmZzZXQpKQotICAgICAgICAgICAgICAgIHJlaWZ5U3RhdGljUHJvcGVydHkodm0s IHZhbHVlLCAqdGhpcyk7CisgICAgICAgICAgICAgICAgcmVpZnlTdGF0aWNQcm9wZXJ0eSh2bSwg a2V5LCB2YWx1ZSwgKnRoaXMpOwogICAgICAgICB9CiAgICAgfQogCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Mb29rdXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9Mb29rdXAuaAkocmV2aXNpb24gMjAxMjIyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgJKHdvcmtpbmcgY29weSkKQEAgLTMzNywxMiAr MzM3LDggQEAgaW5saW5lIGJvb2wgbG9va3VwUHV0KEV4ZWNTdGF0ZSogZXhlYywgUAogICAgIHJl dHVybiB0cnVlOwogfQogCi1pbmxpbmUgdm9pZCByZWlmeVN0YXRpY1Byb3BlcnR5KFZNJiB2bSwg Y29uc3QgSGFzaFRhYmxlVmFsdWUmIHZhbHVlLCBKU09iamVjdCYgdGhpc09iaikKK2lubGluZSB2 b2lkIHJlaWZ5U3RhdGljUHJvcGVydHkoVk0mIHZtLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0 eU5hbWUsIGNvbnN0IEhhc2hUYWJsZVZhbHVlJiB2YWx1ZSwgSlNPYmplY3QmIHRoaXNPYmopCiB7 Ci0gICAgaWYgKCF2YWx1ZS5tX2tleSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgSWRlbnRpZmll ciBwcm9wZXJ0eU5hbWUgPSBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZ2bSwgcmVpbnRlcnByZXRf Y2FzdDxjb25zdCBMQ2hhcio+KHZhbHVlLm1fa2V5KSwgc3RybGVuKHZhbHVlLm1fa2V5KSk7CiAg ICAgaWYgKHZhbHVlLmF0dHJpYnV0ZXMoKSAmIEJ1aWx0aW4pIHsKICAgICAgICAgaWYgKHZhbHVl LmF0dHJpYnV0ZXMoKSAmIEFjY2Vzc29yKQogICAgICAgICAgICAgcmVpZnlTdGF0aWNBY2Nlc3Nv cih2bSwgdmFsdWUsIHRoaXNPYmosIHByb3BlcnR5TmFtZSk7CkBAIC0zOTcsOCArMzkzLDEyIEBA IHRlbXBsYXRlPHVuc2lnbmVkIG51bWJlck9mVmFsdWVzPgogaW5saW5lIHZvaWQgcmVpZnlTdGF0 aWNQcm9wZXJ0aWVzKFZNJiB2bSwgY29uc3QgSGFzaFRhYmxlVmFsdWUgKCZ2YWx1ZXMpW251bWJl ck9mVmFsdWVzXSwgSlNPYmplY3QmIHRoaXNPYmopCiB7CiAgICAgQmF0Y2hlZFRyYW5zaXRpb25P cHRpbWl6ZXIgdHJhbnNpdGlvbk9wdGltaXplcih2bSwgJnRoaXNPYmopOwotICAgIGZvciAoYXV0 byYgdmFsdWUgOiB2YWx1ZXMpCi0gICAgICAgIHJlaWZ5U3RhdGljUHJvcGVydHkodm0sIHZhbHVl LCB0aGlzT2JqKTsKKyAgICBmb3IgKGF1dG8mIHZhbHVlIDogdmFsdWVzKSB7CisgICAgICAgIGlm ICghdmFsdWUubV9rZXkpCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgYXV0byBrZXkg PSBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZ2bSwgdmFsdWUubV9rZXkpOworICAgICAgICByZWlm eVN0YXRpY1Byb3BlcnR5KHZtLCBrZXksIHZhbHVlLCB0aGlzT2JqKTsKKyAgICB9CiB9CiAKIH0g Ly8gbmFtZXNwYWNlIEpTQwo=