157952 2016-05-20 12:25:24 -0700 We should have JSBench in PerformanceTests 2016-05-25 02:10:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller cdumez commit-queue ossy rniwa ysuzuki oldest_to_newest 1195193 0 keith_miller 2016-05-20 12:25:24 -0700 We should have JSBench in PerformanceTests 1195197 1 279496 keith_miller 2016-05-20 12:40:43 -0700 Created attachment 279496 Patch 1195233 2 commit-queue 2016-05-20 14:58:38 -0700 Attachment 279496 did not pass style-queue: ERROR: PerformanceTests/JSBench/harness.py:5: trailing whitespace [pep8/W291] [5] ERROR: PerformanceTests/JSBench/harness.py:8: trailing whitespace [pep8/W291] [5] ERROR: PerformanceTests/JSBench/harness.py:14: trailing whitespace [pep8/W291] [5] ERROR: PerformanceTests/JSBench/harness.py:40: whitespace before '}' [pep8/E202] [5] ERROR: PerformanceTests/JSBench/harness.py:91: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: PerformanceTests/JSBench/harness.py:124: whitespace before '}' [pep8/E202] [5] ERROR: PerformanceTests/JSBench/harness.py:144: whitespace before ')' [pep8/E202] [5] ERROR: PerformanceTests/JSBench/harness.py:182: trailing whitespace [pep8/W291] [5] ERROR: PerformanceTests/JSBench/harness.py:202: whitespace before '}' [pep8/E202] [5] Total errors found: 9 in 59 files If any of these errors are false positives, please file a bug against check-webkit-style. 1195244 3 rniwa 2016-05-20 15:13:45 -0700 Wait, we already have this. Just run: run-benchmark --plan jsbench --browser safari --platform osx 1195249 4 keith_miller 2016-05-20 15:23:15 -0700 (In reply to comment #3) > Wait, we already have this. Just run: > run-benchmark --plan jsbench --browser safari --platform OS X This for run-jsc-benchmarks, which AB tests two different builds for regressions directly. It's easier to have everything managed by the one script rather than have to compute results on our own. 1195313 5 279496 saam 2016-05-20 18:47:12 -0700 Comment on attachment 279496 Patch rs=me 1195793 6 ysuzuki 2016-05-24 02:51:17 -0700 Hm, it seems that cq does not work well... 1195871 7 keith_miller 2016-05-24 09:32:45 -0700 (In reply to comment #6) > Hm, it seems that cq does not work well... Yeah, I guess I'll have to land this by hand :/ 1195942 8 keith_miller 2016-05-24 11:59:47 -0700 Committed r201339: <http://trac.webkit.org/changeset/201339> 1196232 9 ossy 2016-05-25 00:03:10 -0700 (In reply to comment #8) > Committed r201339: <http://trac.webkit.org/changeset/201339> These new tests fail on all performace bots, please fix or skip them. Otherwise why didn't you run them before committing? 1196235 10 keith_miller 2016-05-25 00:27:53 -0700 (In reply to comment #9) > (In reply to comment #8) > > Committed r201339: <http://trac.webkit.org/changeset/201339> > > These new tests fail on all performace bots, please fix or skip them. > Otherwise why didn't you run them before committing? I didn't know the run-perf-tests script existed. I'll disable the tests for now, although I'll have to figure out how to do that. 1196245 11 ossy 2016-05-25 01:59:01 -0700 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Committed r201339: <http://trac.webkit.org/changeset/201339> > > > > These new tests fail on all performace bots, please fix or skip them. > > Otherwise why didn't you run them before committing? Log: ERROR: layer at (0,0) size 800x600 Maybe it is trivial to fix them, the general rule that a performance tests shouldn't dump any extra output. Otherwise it will fail. > I didn't know the run-perf-tests script existed. I'll disable the tests for > now, although I'll have to figure out how to do that. Use PerformanceTests/Skipped file to skip them. 1196246 12 keith_miller 2016-05-25 02:06:53 -0700 (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #9) > > > (In reply to comment #8) > > > > Committed r201339: <http://trac.webkit.org/changeset/201339> > > > > > > These new tests fail on all performace bots, please fix or skip them. > > > Otherwise why didn't you run them before committing? > > Log: > ERROR: layer at (0,0) size 800x600 > > Maybe it is trivial to fix them, the general rule that a performance > tests shouldn't dump any extra output. Otherwise it will fail. Interesting, I'll look into that. I'm not sure if the run-jsc-benchmarks test harness uses that information or not however. > > > I didn't know the run-perf-tests script existed. I'll disable the tests for > > now, although I'll have to figure out how to do that. > > Use PerformanceTests/Skipped file to skip them. Should be fixed in http://trac.webkit.org/changeset/201372, hopefully. 1196247 13 ysuzuki 2016-05-25 02:10:42 -0700 (In reply to comment #9) > (In reply to comment #8) > > Committed r201339: <http://trac.webkit.org/changeset/201339> > > These new tests fail on all performace bots, please fix or skip them. > Otherwise why didn't you run them before committing? FYI, EFL / GTK ports can run this JSBench from run-jsc-benchmark script now :) http://trac.webkit.org/changeset/201365 279496 2016-05-20 12:40:43 -0700 2016-05-23 17:57:10 -0700 Patch bug-157952-20160520124137.patch text/plain 0 keith_miller