157951 2016-05-20 11:53:50 -0700 JSBench regression: CodeBlock linking always copies the symbol table 2016-05-20 12:12:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1195184 0 ggaren 2016-05-20 11:53:50 -0700 JSBench regression: CodeBlock linking always copies the symbol table 1195185 1 279493 ggaren 2016-05-20 11:55:46 -0700 Created attachment 279493 Patch 1195186 2 279493 saam 2016-05-20 11:59:05 -0700 Comment on attachment 279493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279493&action=review r=me > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1673 > + ASSERT(var.symbolTableConstantIndex()); Style: I think its nicer to put asserts validating inputs before we assign something to the input. 1195188 3 ggaren 2016-05-20 12:12:00 -0700 Committed r201221: <http://trac.webkit.org/changeset/201221> 279493 2016-05-20 11:55:46 -0700 2016-05-20 11:59:05 -0700 Patch bug-157951-20160520115647.patch text/plain 2847 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMjE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTA1LTIwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgSlNCZW5jaCByZWdyZXNzaW9uOiBDb2RlQmxvY2sgbGlua2luZyBhbHdheXMgY29waWVzIHRo ZSBzeW1ib2wgdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1Nzk1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIGFsd2F5cyBwdXQgYSBTeW1ib2xUYWJsZSBpbnRvIHRoZSBjb25zdGFudCBwb29s LCBldmVuIGluIHNpbXBsZQorICAgICAgICBmdW5jdGlvbnMgaW4gd2hpY2ggaXQgd29uJ3QgYmUg dXNlZCAtLSBpLmUuLCB0aGVyZSdzIG9uIGV2YWwgYW5kIHRoZXJlCisgICAgICAgIGFyZSBubyBj YXB0dXJlZCB2YXJpYWJsZXMgYW5kIHNvIG9uLgorCisgICAgICAgIFRoaXMgaXMgY29zdGx5IGJl Y2F1c2UgbGlua2luZyBtdXN0IGNvcHkgYW55IHByb3ZpZGVkIHN5bWJvbCB0YWJsZXMuCisKKyAg ICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlND OjpCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IpOgorICAgICAgICAoSlNDOjpC eXRlY29kZUdlbmVyYXRvcjo6ZW1pdFByb2ZpbGVUeXBlKTogT25seSBhZGQgdGhlIHN5bWJvbCB0 YWJsZQorICAgICAgICBhcyBhIGNvbnN0YW50IGlmIHdlIHdpbGwgdXNlIGl0IGF0IHJ1bnRpbWUu CisKIDIwMTYtMDUtMTkgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW0pTQ10gSW1wcm92ZSBpbnQtPmZsb2F0IGNvbnZlcnNpb24gaW4gRlRMCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMjAxMTcwKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIyMyw3ICsyMjMsNyBAQCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoVk0m CiAgICAgCiAgICAgU3ltYm9sVGFibGUqIGZ1bmN0aW9uU3ltYm9sVGFibGUgPSBTeW1ib2xUYWJs ZTo6Y3JlYXRlKCptX3ZtKTsKICAgICBmdW5jdGlvblN5bWJvbFRhYmxlLT5zZXRVc2VzTm9uU3Ry aWN0RXZhbChtX3VzZXNOb25TdHJpY3RFdmFsKTsKLSAgICBpbnQgc3ltYm9sVGFibGVDb25zdGFu dEluZGV4ID0gYWRkQ29uc3RhbnRWYWx1ZShmdW5jdGlvblN5bWJvbFRhYmxlKS0+aW5kZXgoKTsK KyAgICBpbnQgc3ltYm9sVGFibGVDb25zdGFudEluZGV4ID0gMDsKIAogICAgIEZ1bmN0aW9uUGFy YW1ldGVycyYgcGFyYW1ldGVycyA9ICpmdW5jdGlvbk5vZGUtPnBhcmFtZXRlcnMoKTsgCiAgICAg Ly8gaHR0cDovL3d3dy5lY21hLWludGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYuMC9pbmRleC5o dG1sI3NlYy1mdW5jdGlvbmRlY2xhcmF0aW9uaW5zdGFudGlhdGlvbgpAQCAtMzI0LDYgKzMyNCw5 IEBAIEJ5dGVjb2RlR2VuZXJhdG9yOjpCeXRlY29kZUdlbmVyYXRvcihWTSYKICAgICBpZiAoc2hv dWxkQ2FwdHVyZVNvbWVPZlRoZVRoaW5ncykKICAgICAgICAgbV9sZXhpY2FsRW52aXJvbm1lbnRS ZWdpc3RlciA9IGFkZFZhcigpOwogCisgICAgaWYgKHNob3VsZENhcHR1cmVTb21lT2ZUaGVUaGlu Z3MgfHwgdm0udHlwZVByb2ZpbGVyKCkpCisgICAgICAgIHN5bWJvbFRhYmxlQ29uc3RhbnRJbmRl eCA9IGFkZENvbnN0YW50VmFsdWUoZnVuY3Rpb25TeW1ib2xUYWJsZSktPmluZGV4KCk7CisKICAg ICAvLyBXZSBjYW4gYWxsb2NhdGUgdGhlICJ2YXIiIGVudmlyb25tZW50IGlmIHdlIGRvbid0IGhh dmUgZGVmYXVsdCBwYXJhbWV0ZXIgZXhwcmVzc2lvbnMuIElmIHdlIGhhdmUKICAgICAvLyBkZWZh dWx0IHBhcmFtZXRlciBleHByZXNzaW9ucywgd2UgaGF2ZSB0byBob2xkIG9mZiBvbiBhbGxvY2F0 aW5nIHRoZSAidmFyIiBlbnZpcm9ubWVudCBiZWNhdXNlCiAgICAgLy8gdGhlIHBhcmVudCBzY29w ZSBvZiB0aGUgInZhciIgZW52aXJvbm1lbnQgaXMgdGhlIHBhcmFtZXRlciBlbnZpcm9ubWVudC4K QEAgLTE2NjcsNiArMTY3MCw3IEBAIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRQcm9maWxl VHlwZSgKICAgICBpZiAodmFyLmxvY2FsKCkgfHwgdmFyLm9mZnNldCgpLmlzU2NvcGUoKSkgewog ICAgICAgICBmbGFnID0gUHJvZmlsZVR5cGVCeXRlY29kZUxvY2FsbHlSZXNvbHZlZDsKICAgICAg ICAgc3ltYm9sVGFibGVPclNjb3BlRGVwdGggPSB2YXIuc3ltYm9sVGFibGVDb25zdGFudEluZGV4 KCk7CisgICAgICAgIEFTU0VSVCh2YXIuc3ltYm9sVGFibGVDb25zdGFudEluZGV4KCkpOwogICAg IH0gZWxzZSB7CiAgICAgICAgIGZsYWcgPSBQcm9maWxlVHlwZUJ5dGVjb2RlQ2xvc3VyZVZhcjsK ICAgICAgICAgc3ltYm9sVGFibGVPclNjb3BlRGVwdGggPSBsb2NhbFNjb3BlRGVwdGgoKTsK