157933 2016-05-19 16:37:45 -0700 The baseline JIT crashes when compiling "(1,1)/1" 2016-05-23 15:45:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver saam sukolsak ysuzuki oldest_to_newest 1195035 0 oliver 2016-05-19 16:37:45 -0700 Super simple test case: for(;;)(1,1)/1 It looks (from the back trace) like some places are correctly considering (1,1) as constant, but other places aren't. The net effect is that we assert/emit breakpoint in a case where we think we should have constant folded (or something) --Oliver 1195590 1 saam 2016-05-23 15:01:17 -0700 *** Bug 158000 has been marked as a duplicate of this bug. *** 1195592 2 279587 saam 2016-05-23 15:02:26 -0700 Created attachment 279587 patch 1195598 3 279588 saam 2016-05-23 15:15:25 -0700 Created attachment 279588 patch for landing 1195599 4 279589 saam 2016-05-23 15:16:21 -0700 Created attachment 279589 patch for landing 1195620 5 279589 commit-queue 2016-05-23 15:45:34 -0700 Comment on attachment 279589 patch for landing Clearing flags on attachment: 279589 Committed r201301: <http://trac.webkit.org/changeset/201301> 1195621 6 commit-queue 2016-05-23 15:45:39 -0700 All reviewed patches have been landed. Closing bug. 279587 2016-05-23 15:02:26 -0700 2016-05-23 15:15:25 -0700 patch b-backup.diff text/plain 2401 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMjk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTA1LTIzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBiYXNlbGluZSBKSVQgY3Jhc2hlcyB3aGVuIGNvbXBpbGluZyAiKDEsMSkvMSIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODAwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG9wX2RpdiBpbiB0aGUg YmFzZWxpbmUgSklUIG5lZWRlZCB0byBsZWFybiB0aGF0IGJvdGggdGhlIGxocyBhbmQgcmhzIGNh bgorICAgICAgICBiZSBjb25zdGFudHMuCisKKyAgICAgICAgKiBqaXQvSklUQXJpdGhtZXRpYy5j cHA6CisgICAgICAgIChKU0M6OkpJVDo6ZW1pdF9vcF9kaXYpOgorICAgICAgICAqIHRlc3RzL3N0 cmVzcy9qaXQtZ3JhY2VmdWxseS1oYW5kbGUtZG91YmxlLWNvbnN0YW50cy1pbi1tYXRoLW9wZXJh dG9ycy5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAodGVzdCk6CisKIDIw MTYtMDUtMjMgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgU3Ry aW5nIHRlbXBsYXRlIGRvbid0IGhhbmRsZSBsZXQgaW5pdGlhbGl6YXRpb24gcHJvcGVybHkgaW5z aWRlIGV2YWwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGlj LmNwcAkocmV2aXNpb24gMjAxMjkwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRB cml0aG1ldGljLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODE2LDggKzgxNiw3IEBAIHZvaWQgSklU OjplbWl0X29wX2RpdihJbnN0cnVjdGlvbiogY3VycmUKICAgICBlbHNlIGlmIChpc09wZXJhbmRD b25zdGFudERvdWJsZShvcDEpKQogICAgICAgICBsZWZ0T3BlcmFuZC5zZXRDb25zdERvdWJsZShn ZXRPcGVyYW5kQ29uc3RhbnREb3VibGUob3AxKSk7CiAjZW5kaWYKLQotICAgIGlmIChpc09wZXJh bmRDb25zdGFudEludChvcDIpKQorICAgIGVsc2UgaWYgKGlzT3BlcmFuZENvbnN0YW50SW50KG9w MikpCiAgICAgICAgIHJpZ2h0T3BlcmFuZC5zZXRDb25zdEludDMyKGdldE9wZXJhbmRDb25zdGFu dEludChvcDIpKTsKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgIGVsc2UgaWYgKGlzT3BlcmFuZENv bnN0YW50RG91YmxlKG9wMikpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3Ry ZXNzL2ppdC1ncmFjZWZ1bGx5LWhhbmRsZS1kb3VibGUtY29uc3RhbnRzLWluLW1hdGgtb3BlcmF0 b3JzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mv aml0LWdyYWNlZnVsbHktaGFuZGxlLWRvdWJsZS1jb25zdGFudHMtaW4tbWF0aC1vcGVyYXRvcnMu anMJKG5vbmV4aXN0ZW50KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9q aXQtZ3JhY2VmdWxseS1oYW5kbGUtZG91YmxlLWNvbnN0YW50cy1pbi1tYXRoLW9wZXJhdG9ycy5q cwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDI1IEBACitmdW5jdGlvbiBhc3NlcnQoYikgewor ICAgIGlmICghYikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJiYWQgYXNzZXJ0aW9uISIpOwor fQorCisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgbGV0IGNhc2VzID0gWworICAgICAgICBbIi8i LCAxXSwKKyAgICAgICAgWyIqIiwgMV0sCisgICAgICAgIFsiKyIsIDJdLAorICAgICAgICBbIi0i LCAwXSwKKyAgICAgICAgWyI+PiIsIDBdLAorICAgICAgICBbIj4+PiIsIDBdLAorICAgICAgICBb Ijw8IiwgMl0sCisgICAgICAgIFsiXiIsIDBdLAorICAgICAgICBbIiYiLCAxXSwKKyAgICBdOwor CisgICAgZm9yIChsZXQgW29wLCByZXN1bHRdIG9mIGNhc2VzKSB7CisgICAgICAgIGxldCBwcm9n cmFtID0gYGZvciAobGV0IGkgPSAwOyBpIDwgNTAwOyBpKyspIHsgYXNzZXJ0KCgxLDEpJHtvcH0x ID09PSAke3Jlc3VsdH0pOyB9YDsKKyAgICAgICAgZXZhbChwcm9ncmFtKTsKKyAgICB9Cit9Cit0 ZXN0KCk7Cg== 279588 2016-05-23 15:15:25 -0700 2016-05-23 15:16:21 -0700 patch for landing b-backup.diff text/plain 2571 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMjk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTA1LTIzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBiYXNlbGluZSBKSVQgY3Jhc2hlcyB3aGVuIGNvbXBpbGluZyAiKDEsMSkvMSIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzkzMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG9wX2RpdiBpbiB0aGUg YmFzZWxpbmUgSklUIG5lZWRlZCB0byBiZXR0ZXIgaGFuZGxlIHdoZW4gYm90aCB0aGUgbGhzCisg ICAgICAgIGFuZCByaHMgYXJlIGNvbnN0YW50cy4gSXQgbmVlZHMgdG8gbWFrZSBzdXJlIHRvIGxv YWQgZWl0aGVyIHRoZSBsaHMgb3IKKyAgICAgICAgdGhlIHJocyBpbnRvIGEgcmVnaXN0ZXIgc2lu Y2UgdGhlIGRpdiBnZW5lcmF0b3IgY2FuJ3QgaGFuZGxlIGJvdGgKKyAgICAgICAgdGhlIGxocyBh bmQgcmhzIGJlaW5nIGNvbnN0YW50cy4KKworICAgICAgICAqIGppdC9KSVRBcml0aG1ldGljLmNw cDoKKyAgICAgICAgKEpTQzo6SklUOjplbWl0X29wX2Rpdik6CisgICAgICAgICogdGVzdHMvc3Ry ZXNzL2ppdC1ncmFjZWZ1bGx5LWhhbmRsZS1kb3VibGUtY29uc3RhbnRzLWluLW1hdGgtb3BlcmF0 b3JzLmpzOiBBZGRlZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAgICh0ZXN0KToKKwogMjAx Ni0wNS0yMyAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHJp bmcgdGVtcGxhdGUgZG9uJ3QgaGFuZGxlIGxldCBpbml0aWFsaXphdGlvbiBwcm9wZXJseSBpbnNp ZGUgZXZhbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMu Y3BwCShyZXZpc2lvbiAyMDEyOTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFy aXRobWV0aWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MTYsOCArODE2LDcgQEAgdm9pZCBKSVQ6 OmVtaXRfb3BfZGl2KEluc3RydWN0aW9uKiBjdXJyZQogICAgIGVsc2UgaWYgKGlzT3BlcmFuZENv bnN0YW50RG91YmxlKG9wMSkpCiAgICAgICAgIGxlZnRPcGVyYW5kLnNldENvbnN0RG91YmxlKGdl dE9wZXJhbmRDb25zdGFudERvdWJsZShvcDEpKTsKICNlbmRpZgotCi0gICAgaWYgKGlzT3BlcmFu ZENvbnN0YW50SW50KG9wMikpCisgICAgZWxzZSBpZiAoaXNPcGVyYW5kQ29uc3RhbnRJbnQob3Ay KSkKICAgICAgICAgcmlnaHRPcGVyYW5kLnNldENvbnN0SW50MzIoZ2V0T3BlcmFuZENvbnN0YW50 SW50KG9wMikpOwogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgZWxzZSBpZiAoaXNPcGVyYW5kQ29u c3RhbnREb3VibGUob3AyKSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJl c3Mvaml0LWdyYWNlZnVsbHktaGFuZGxlLWRvdWJsZS1jb25zdGFudHMtaW4tbWF0aC1vcGVyYXRv cnMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9q aXQtZ3JhY2VmdWxseS1oYW5kbGUtZG91YmxlLWNvbnN0YW50cy1pbi1tYXRoLW9wZXJhdG9ycy5q cwkobm9uZXhpc3RlbnQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2pp dC1ncmFjZWZ1bGx5LWhhbmRsZS1kb3VibGUtY29uc3RhbnRzLWluLW1hdGgtb3BlcmF0b3JzLmpz CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7Cisg ICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoImJhZCBhc3NlcnRpb24hIik7Cit9 CisKKworZnVuY3Rpb24gdGVzdCgpIHsKKyAgICBsZXQgY2FzZXMgPSBbCisgICAgICAgIFsiLyIs IDFdLAorICAgICAgICBbIioiLCAxXSwKKyAgICAgICAgWyIrIiwgMl0sCisgICAgICAgIFsiLSIs IDBdLAorICAgICAgICBbIj4+IiwgMF0sCisgICAgICAgIFsiPj4+IiwgMF0sCisgICAgICAgIFsi PDwiLCAyXSwKKyAgICAgICAgWyJeIiwgMF0sCisgICAgICAgIFsiJiIsIDFdLAorICAgIF07CisK KyAgICBmb3IgKGxldCBbb3AsIHJlc3VsdF0gb2YgY2FzZXMpIHsKKyAgICAgICAgbGV0IHByb2dy YW0gPSBgZm9yIChsZXQgaSA9IDA7IGkgPCA1MDA7IGkrKykgeyBhc3NlcnQoKDEsMSkke29wfTEg PT09ICR7cmVzdWx0fSk7IH1gOworICAgICAgICBldmFsKHByb2dyYW0pOworICAgIH0KK30KK3Rl c3QoKTsK 279589 2016-05-23 15:16:21 -0700 2016-05-23 15:45:34 -0700 patch for landing b-backup.diff text/plain 2573 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMjk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTA1LTIzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBiYXNlbGluZSBKSVQgY3Jhc2hlcyB3aGVuIGNvbXBpbGluZyAiKDEsMSkvMSIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzkzMworCisgICAg ICAgIFJldmlld2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCisKKyAgICAgICAgb3BfZGl2IGluIHRo ZSBiYXNlbGluZSBKSVQgbmVlZGVkIHRvIGJldHRlciBoYW5kbGUgd2hlbiBib3RoIHRoZSBsaHMK KyAgICAgICAgYW5kIHJocyBhcmUgY29uc3RhbnRzLiBJdCBuZWVkcyB0byBtYWtlIHN1cmUgdG8g bG9hZCBlaXRoZXIgdGhlIGxocyBvcgorICAgICAgICB0aGUgcmhzIGludG8gYSByZWdpc3RlciBz aW5jZSB0aGUgZGl2IGdlbmVyYXRvciBjYW4ndCBoYW5kbGUgYm90aAorICAgICAgICB0aGUgbGhz IGFuZCByaHMgYmVpbmcgY29uc3RhbnRzLgorCisgICAgICAgICogaml0L0pJVEFyaXRobWV0aWMu Y3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfZGl2KToKKyAgICAgICAgKiB0ZXN0cy9z dHJlc3Mvaml0LWdyYWNlZnVsbHktaGFuZGxlLWRvdWJsZS1jb25zdGFudHMtaW4tbWF0aC1vcGVy YXRvcnMuanM6IEFkZGVkLgorICAgICAgICAoYXNzZXJ0KToKKyAgICAgICAgKHRlc3QpOgorCiAy MDE2LTA1LTIzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFN0 cmluZyB0ZW1wbGF0ZSBkb24ndCBoYW5kbGUgbGV0IGluaXRpYWxpemF0aW9uIHByb3Blcmx5IGlu c2lkZSBldmFsCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRp Yy5jcHAJKHJldmlzaW9uIDIwMTI5MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU QXJpdGhtZXRpYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxNiw4ICs4MTYsNyBAQCB2b2lkIEpJ VDo6ZW1pdF9vcF9kaXYoSW5zdHJ1Y3Rpb24qIGN1cnJlCiAgICAgZWxzZSBpZiAoaXNPcGVyYW5k Q29uc3RhbnREb3VibGUob3AxKSkKICAgICAgICAgbGVmdE9wZXJhbmQuc2V0Q29uc3REb3VibGUo Z2V0T3BlcmFuZENvbnN0YW50RG91YmxlKG9wMSkpOwogI2VuZGlmCi0KLSAgICBpZiAoaXNPcGVy YW5kQ29uc3RhbnRJbnQob3AyKSkKKyAgICBlbHNlIGlmIChpc09wZXJhbmRDb25zdGFudEludChv cDIpKQogICAgICAgICByaWdodE9wZXJhbmQuc2V0Q29uc3RJbnQzMihnZXRPcGVyYW5kQ29uc3Rh bnRJbnQob3AyKSk7CiAjaWYgVVNFKEpTVkFMVUU2NCkKICAgICBlbHNlIGlmIChpc09wZXJhbmRD b25zdGFudERvdWJsZShvcDIpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9qaXQtZ3JhY2VmdWxseS1oYW5kbGUtZG91YmxlLWNvbnN0YW50cy1pbi1tYXRoLW9wZXJh dG9ycy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNz L2ppdC1ncmFjZWZ1bGx5LWhhbmRsZS1kb3VibGUtY29uc3RhbnRzLWluLW1hdGgtb3BlcmF0b3Jz LmpzCShub25leGlzdGVudCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mv aml0LWdyYWNlZnVsbHktaGFuZGxlLWRvdWJsZS1jb25zdGFudHMtaW4tbWF0aC1vcGVyYXRvcnMu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorZnVuY3Rpb24gYXNzZXJ0KGIpIHsK KyAgICBpZiAoIWIpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigiYmFkIGFzc2VydGlvbiEiKTsK K30KKworCitmdW5jdGlvbiB0ZXN0KCkgeworICAgIGxldCBjYXNlcyA9IFsKKyAgICAgICAgWyIv IiwgMV0sCisgICAgICAgIFsiKiIsIDFdLAorICAgICAgICBbIisiLCAyXSwKKyAgICAgICAgWyIt IiwgMF0sCisgICAgICAgIFsiPj4iLCAwXSwKKyAgICAgICAgWyI+Pj4iLCAwXSwKKyAgICAgICAg WyI8PCIsIDJdLAorICAgICAgICBbIl4iLCAwXSwKKyAgICAgICAgWyImIiwgMV0sCisgICAgXTsK KworICAgIGZvciAobGV0IFtvcCwgcmVzdWx0XSBvZiBjYXNlcykgeworICAgICAgICBsZXQgcHJv Z3JhbSA9IGBmb3IgKGxldCBpID0gMDsgaSA8IDUwMDsgaSsrKSB7IGFzc2VydCgoMSwxKSR7b3B9 MSA9PT0gJHtyZXN1bHR9KTsgfWA7CisgICAgICAgIGV2YWwocHJvZ3JhbSk7CisgICAgfQorfQor dGVzdCgpOwo=