15793 2007-11-02 07:38:14 -0700 [GTK] tooltip position doesn't update when hovering consecutive links 2009-03-25 07:32:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED FIXED Gtk P2 Enhancement --- 1 iwkse webkit-unassigned alp christian grahamperrin gustavo jakub.rusinek jmalonzo kris oldest_to_newest 60054 0 iwkse 2007-11-02 07:38:14 -0700 While loading a picture, if it contains a title tag, this isn't showed in a tooltip. 60060 1 dev+webkit 2007-11-02 08:04:21 -0700 *** Bug 15794 has been marked as a duplicate of this bug. *** 62111 2 17469 christian 2007-11-23 12:40:02 -0800 Created attachment 17469 Implement tooltips 62113 3 17469 aroben 2007-11-23 12:53:22 -0800 Comment on attachment 17469 Implement tooltips + if (toolTip.isEmpty()) + g_object_set(G_OBJECT(m_webPage), "has-tooltip", FALSE, NULL); + else + gtk_widget_set_tooltip_text(GTK_WIDGET(m_webPage), toolTip.utf8().data()); Is it a problem that has-tooltip is never set to TRUE? + static GtkTooltips* tooltips; + if (!tooltips) + tooltips = gtk_tooltips_new(); You should be able to do this in one line, since this is C++ code: static GtkTooltips* tooltips = gtk_tooltips_new(); 62193 4 17469 alp 2007-11-24 13:50:47 -0800 Comment on attachment 17469 Implement tooltips The use of the new API is correct, so r+ for that half. The implementation for the old tooltip API was incorrect and displayed tooltips at wrong times, eg on the www.google.com search entry. Please attach an additional fix for this. Also, remember to include a ChangeLog entry. Thanks! 62194 5 alp 2007-11-24 13:52:51 -0800 First half of the fix landed in r28000. 62197 6 alp 2007-11-24 14:10:34 -0800 Christian, Can you also look into the tooltips that appear on the right side of http://planet.gnome.org/ ? The tooltip bubble always seems to stay in the same place when you move up and down. 62399 7 17538 jmalonzo 2007-11-26 14:24:21 -0800 Created attachment 17538 Fix the tooltip being in stuck at one place when hovering on consecutive links This patch fixes the situation when tooltips get stuck at one location when hovering on links with title attribute consecutively (e.g., planet.gnome.org sidebar feed list). 62402 8 alp 2007-11-26 15:36:24 -0800 Do we really need to construct a whole new GtkWindow instance every time the tooltip text changes? I'm wondering why we can't get the built-in tooltip API to work the way we want and have to resort to creating our own window in the first place. 62428 9 jmalonzo 2007-11-26 19:32:54 -0800 (In reply to comment #8) > Do we really need to construct a whole new GtkWindow instance every time the > tooltip text changes? I tried the single GtkWindow instance but it exhibited the same issue we are having (i.e., same behaviour as current implementation). > > I'm wondering why we can't get the built-in tooltip API to work the way we want > and have to resort to creating our own window in the first place. I must admit that my patch is a band-aid as I can't seem to find a better way using the existing (2.12) tooltips API to fix the issue. It seems that the only way to interact with the tooltip properly is to connect to the GtkWidget::query-tooltip signal as per documentation of GtkTooltip. But sending query-tooltip seems to duplicate functionality with ChromeClient::setToolTip (in terms of saying "show me a tooltip"), at least AFAIC. I hope that clears things a bit. 62534 10 17469 alp 2007-11-27 22:10:31 -0800 Comment on attachment 17469 Implement tooltips Patch already landed, but the bug report needs to remain open. Removing r+ flag to clear the commit queue. 63251 11 17538 alp 2007-12-04 09:48:43 -0800 Comment on attachment 17538 Fix the tooltip being in stuck at one place when hovering on consecutive links Kris (author of the new GtkTooltip API) suggested that this workaround shouldn't be necessary. r- based on this, though we might have to re-visit it if we can't find an alternative. One suggestion was to usegtk_tooltip_set_tip_area() but that requires that we have knowledge of existing tooltip areas, and the area has to be rectangular, neither of which is always true. The drawing area example in testtooltips might be a source of inspiration apparently. Jan, could you coordinate this effort with the GTK+ team? If it doesn't work out, we'll have to look at the hacks again. Thanks! 113878 12 28648 gustavo 2009-03-16 09:10:41 -0700 Created attachment 28648 my own proposed work-around 114071 13 28694 gustavo 2009-03-17 11:20:11 -0700 Created attachment 28694 my own proposed workaround Addressed comments by zecke on IRC: basically take the GdkDisplay from the toplevel, if available, and do our thing before emitting the hovering-link signal. 115112 14 28694 zecke 2009-03-25 00:11:24 -0700 Comment on attachment 28694 my own proposed workaround afterwards in which way? after we disable it and then query again (nitpicking at the language even when not qualified to do so...)? :) 115139 15 gustavo 2009-03-25 07:32:12 -0700 Landed as r41971 with a fix for the nitpick hehe. 17469 2007-11-23 12:40:02 -0800 2007-11-27 22:10:31 -0800 Implement tooltips tooltips.diff text/plain 957 christian SW5kZXg6IFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAJ KFJldmlzaW9uIDI3OTg5KQorKysgV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGll bnRHdGsuY3BwCShBcmJlaXRza29waWUpCkBAIC0yODMsOSArMjgzLDIyIEBACiAgICAgfQogfQog Ci12b2lkIENocm9tZUNsaWVudDo6c2V0VG9vbFRpcChjb25zdCBTdHJpbmcmKQordm9pZCBDaHJv bWVDbGllbnQ6OnNldFRvb2xUaXAoY29uc3QgU3RyaW5nJiB0b29sVGlwKQogewotICAgIG5vdElt cGxlbWVudGVkKCk7CisjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwgMTIsIDApCisgICAgaWYgKHRv b2xUaXAuaXNFbXB0eSgpKQorICAgICAgICBnX29iamVjdF9zZXQoR19PQkpFQ1QobV93ZWJQYWdl KSwgImhhcy10b29sdGlwIiwgRkFMU0UsIE5VTEwpOworICAgIGVsc2UKKyAgICAgICAgZ3RrX3dp ZGdldF9zZXRfdG9vbHRpcF90ZXh0KEdUS19XSURHRVQobV93ZWJQYWdlKSwgdG9vbFRpcC51dGY4 KCkuZGF0YSgpKTsKKyNlbHNlCisgICAgc3RhdGljIEd0a1Rvb2x0aXBzKiB0b29sdGlwczsKKyAg ICBpZiAoIXRvb2x0aXBzKQorICAgICAgICB0b29sdGlwcyA9IGd0a190b29sdGlwc19uZXcoKTsK KyAgICBpZiAodG9vbFRpcC5pc0VtcHR5KCkpCisgICAgICAgIGd0a190b29sdGlwc19kaXNhYmxl KHRvb2x0aXBzKTsKKyAgICBlbHNlCisgICAgICAgIGd0a190b29sdGlwc19zZXRfdGlwKHRvb2x0 aXBzLCBHVEtfV0lER0VUKG1fd2ViUGFnZSksIHRvb2xUaXAudXRmOCgpLmRhdGEoKSwgMCk7Cisj ZW5kaWYKIH0KIAogdm9pZCBDaHJvbWVDbGllbnQ6OnByaW50KEZyYW1lKikK 17538 2007-11-26 14:24:21 -0800 2009-03-16 09:10:41 -0700 Fix the tooltip being in stuck at one place when hovering on consecutive links webkit-tooltip-enhancement.patch text/plain 2737 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZDcwZGNlNS4uNzVmNjQ5MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0xMS0yNiAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9AdW5wbHVnZ2FibGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU3OTMKKwlbR1RLXSBXZWJraXQgZG9lc24ndCBzaG93IHRpdGxlIGF0 dHJpYnV0ZSB0b29sdGlwIHdoZW4gaG92ZXJpbmcgb3ZlciBhbiBpbWFnZQorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hy b21lQ2xpZW50OjpzZXRUb29sVGlwKToKKwljcmVhdGUgd2luZG93cyBmb3IgdGhlIHRvb2x0aXBz IHNvIHRoYXQgdGhleSBhcmUgc2hvd24gYXQKKwl0aGUgcmlnaHQgbG9jYXRpb24gZXNwZWNpYWxs eSBvbiBjb25zZWN1dGl2ZSBjYWxsIHRvIHNob3cgdGhlIHRvb2x0aXAKKwogMjAwNy0xMS0yNCAg QWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBS b3dlLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRH dGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmlu ZGV4IGJkMDY2OWMuLmQ4YzIyNjAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvQ2hyb21lQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudEd0ay5jcHAKQEAgLTI4OCw4ICsyODgsMzUgQEAgdm9pZCBDaHJvbWVDbGllbnQ6 OnNldFRvb2xUaXAoY29uc3QgU3RyaW5nJiB0b29sVGlwKQogI2lmIEdUS19DSEVDS19WRVJTSU9O KDIsMTIsMCkKICAgICBpZiAodG9vbFRpcC5pc0VtcHR5KCkpCiAgICAgICAgIGdfb2JqZWN0X3Nl dChHX09CSkVDVChtX3dlYlBhZ2UpLCAiaGFzLXRvb2x0aXAiLCBGQUxTRSwgTlVMTCk7Ci0gICAg ZWxzZQotICAgICAgICBndGtfd2lkZ2V0X3NldF90b29sdGlwX3RleHQoR1RLX1dJREdFVChtX3dl YlBhZ2UpLCB0b29sVGlwLnV0ZjgoKS5kYXRhKCkpOworICAgIGVsc2UgeworICAgICAgICAvKiBz ZXQgdXAgb3VyIHRvb2x0aXAgd2lkZ2V0ICovCisgICAgICAgIEd0a1dpZGdldCogd2luZG93ID0g Z3RrX3dpbmRvd19uZXcoR1RLX1dJTkRPV19QT1BVUCk7CisgICAgICAgIGd0a193aWRnZXRfc2V0 X25hbWUod2luZG93LCAiZ3RrLXRvb2x0aXAiKTsKKyAgICAgICAgZ3RrX3dpbmRvd19zZXRfdHlw ZV9oaW50KEdUS19XSU5ET1cod2luZG93KSwgR0RLX1dJTkRPV19UWVBFX0hJTlRfVE9PTFRJUCk7 CisKKyAgICAgICAgR3RrV2lkZ2V0KiBhbGlnbm1lbnQgPSBndGtfYWxpZ25tZW50X25ldygwLjUs IDAuNSwgMS4wLCAxLjApOworICAgICAgICBndGtfYWxpZ25tZW50X3NldF9wYWRkaW5nKEdUS19B TElHTk1FTlQoYWxpZ25tZW50KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 aW5kb3ctPnN0eWxlLT55dGhpY2tuZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHdpbmRvdy0+c3R5bGUtPnl0aGlja25lc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgd2luZG93LT5zdHlsZS0+eHRoaWNrbmVzcywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB3aW5kb3ctPnN0eWxlLT54dGhpY2tuZXNzKTsKKyAgICAgICAgZ3RrX2Nv bnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUih3aW5kb3cpLCBhbGlnbm1lbnQpOworICAgICAgICBn dGtfd2lkZ2V0X3Nob3coYWxpZ25tZW50KTsKKworICAgICAgICBHdGtXaWRnZXQqIGJveCA9IGd0 a19oYm94X25ldyhGQUxTRSwgd2luZG93LT5zdHlsZS0+eHRoaWNrbmVzcyk7CisgICAgICAgIGd0 a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIoYWxpZ25tZW50KSwgYm94KTsKKyAgICAgICAg Z3RrX3dpZGdldF9zaG93KGJveCk7CisgICAgICAgICAgICAgICAgCisgICAgICAgIEd0a1dpZGdl dCogbGFiZWwgPSBndGtfbGFiZWxfbmV3KHRvb2xUaXAudXRmOCgpLmRhdGEoKSk7CisgICAgICAg IGd0a19sYWJlbF9zZXRfbGluZV93cmFwKEdUS19MQUJFTChsYWJlbCksIFRSVUUpOyAgCisgICAg ICAgIGd0a19ib3hfcGFja19zdGFydChHVEtfQk9YKGJveCksIGxhYmVsLCBGQUxTRSwgRkFMU0Us IDApOworICAgICAgICBndGtfd2lkZ2V0X3Nob3cobGFiZWwpOworICAgICAgICAKKyAgICAgICAg Z3RrX3dpZGdldF9zZXRfdG9vbHRpcF93aW5kb3coR1RLX1dJREdFVChtX3dlYlBhZ2UpLCBHVEtf V0lORE9XKHdpbmRvdykpOworCisgICAgICAgIGdfb2JqZWN0X3NldChHX09CSkVDVChtX3dlYlBh Z2UpLCAidG9vbHRpcC10ZXh0IiwgdG9vbFRpcC51dGY4KCkuZGF0YSgpLCAwKTsKKyAgICAgICAg Z19vYmplY3Rfc2V0KEdfT0JKRUNUKG1fd2ViUGFnZSksICJoYXMtdG9vbHRpcCIsIFRSVUUsIDAp OworICAgIH0KICNlbHNlCiAgICAgLy8gVE9ETzogU3VwcG9ydCBvbGRlciBHVEsrIHZlcnNpb25z CiAgICAgLy8gU2VlIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzkz Cg== 28648 2009-03-16 09:10:41 -0700 2009-03-17 11:20:11 -0700 my own proposed work-around tooltips.patch text/plain 2331 gustavo RnJvbSA5Zjg2MDQ2NzNmNjk5YjMwMTA2NTdlNzFjMWE5NTViN2VlNzNiNGNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBNb24sIDE2IE1hciAyMDA5IDEzOjAzOjIyIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc5MwogICAgICAgIFtHVEtdIHRvb2x0aXAgcG9zaXRp b24gZG9lc24ndCB1cGRhdGUgd2hlbiBob3ZlcmluZyBjb25zZWN1dGl2ZSBsaW5rcwoKICAgICAg ICBXb3JrLWFyb3VuZCB0b29sdGlwcyBub3QgdXBkYXRpbmcgdGhlaXIgbG9jYXRpb24gd2hlbiB0 aGUgZWxlbWVudHMKICAgICAgICBhcmUgY29uc2VjdXRpdmUuCgogICAgICAgICogV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcDoKICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6 Om1vdXNlRGlkTW92ZU92ZXJFbGVtZW50KToKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcCB8ICAgIDYgKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBlOTM4YWI5Li5k ZTZlZWI1IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTAzLTE2ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTc5MworICAgICAgICBbR1RLXSB0b29sdGlwIHBvc2l0aW9uIGRvZXNuJ3QgdXBkYXRlIHdoZW4g aG92ZXJpbmcgY29uc2VjdXRpdmUgbGlua3MKKworICAgICAgICBXb3JrLWFyb3VuZCB0b29sdGlw cyBub3QgdXBkYXRpbmcgdGhlaXIgbG9jYXRpb24gd2hlbiB0aGUgZWxlbWVudHMKKyAgICAgICAg YXJlIGNvbnNlY3V0aXZlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50Ojptb3VzZURpZE1vdmVPdmVy RWxlbWVudCk6CisKIDIwMDktMDMtMTUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9t ZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIvV2ViS2l0 L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmluZGV4IDM1NTdhM2YuLjAx NjI4ZWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5j cHAKQEAgLTM3Miw2ICszNzIsMTIgQEAgdm9pZCBDaHJvbWVDbGllbnQ6Om1vdXNlRGlkTW92ZU92 ZXJFbGVtZW50KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdCwgdW5zaWduZWQgbW8KICAgICAgICAg Z19zaWduYWxfZW1pdF9ieV9uYW1lKG1fd2ViVmlldywgImhvdmVyaW5nLW92ZXItbGluayIsIDAs IDApOwogICAgICAgICBtX2hvdmVyZWRMaW5rVVJMID0gS1VSTCgpOwogICAgIH0KKworICAgIC8v IElmIGEgdG9vbHRpcCBtdXN0IGJlIGRpc3BsYXllZCBpdCB3aWxsIGJlLCBhZnRlcndhcmRzOyB0 aGlzIGlzCisgICAgLy8ganVzdCBhIHdvcmstYXJvdW5kIHRvIG1ha2Ugc3VyZSBpdCB1cGRhdGVz IGl0cyBsb2NhdGlvbgorICAgIC8vIGNvcnJlY3RseTsgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc5My4KKyAgICBnX29iamVjdF9zZXQobV93ZWJWaWV3LCAi aGFzLXRvb2x0aXAiLCBGQUxTRSwgTlVMTCk7CisgICAgZ3RrX3Rvb2x0aXBfdHJpZ2dlcl90b29s dGlwX3F1ZXJ5KGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCkpOwogfQogCiB2b2lkIENocm9tZUNs aWVudDo6c2V0VG9vbFRpcChjb25zdCBTdHJpbmcmIHRvb2xUaXApCi0tIAoxLjYuMgoK 28694 2009-03-17 11:20:11 -0700 2009-03-25 00:11:24 -0700 my own proposed workaround tooltips.patch text/plain 2588 gustavo RnJvbSA4NzVjYjJhZmMxMzI0YzY2NDZmOTQ5MWEzYTQxNDlhZDNjMGM1Y2Y2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBNb24sIDE2IE1hciAyMDA5IDEzOjAzOjIyIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc5MwogICAgICAgIFtHVEtdIHRvb2x0aXAgcG9zaXRp b24gZG9lc24ndCB1cGRhdGUgd2hlbiBob3ZlcmluZyBjb25zZWN1dGl2ZSBsaW5rcwoKICAgICAg ICBXb3JrLWFyb3VuZCB0b29sdGlwcyBub3QgdXBkYXRpbmcgdGhlaXIgbG9jYXRpb24gd2hlbiB0 aGUgZWxlbWVudHMKICAgICAgICBhcmUgY29uc2VjdXRpdmUuCgogICAgICAgICogV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcDoKICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnQ6 Om1vdXNlRGlkTW92ZU92ZXJFbGVtZW50KToKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcCB8ICAgMTMgKysrKysrKysrKysrKwogMiBm aWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNzcy MTllYi4uYjQwZjI1ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMy0xNiAgR3VzdGF2byBO b3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU3OTMKKyAgICAgICAgW0dUS10gdG9vbHRpcCBwb3NpdGlvbiBkb2Vzbid0IHVwZGF0 ZSB3aGVuIGhvdmVyaW5nIGNvbnNlY3V0aXZlIGxpbmtzCisKKyAgICAgICAgV29yay1hcm91bmQg dG9vbHRpcHMgbm90IHVwZGF0aW5nIHRoZWlyIGxvY2F0aW9uIHdoZW4gdGhlIGVsZW1lbnRzCisg ICAgICAgIGFyZSBjb25zZWN1dGl2ZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudDo6bW91c2VEaWRN b3ZlT3ZlckVsZW1lbnQpOgorCiAyMDA5LTAzLTE2ICBDaHJpc3RpYW4gRHl3YW4gIDxjaHJpc3Rp YW5AdHdvdG9hc3RzLmRlPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRpZmYg LS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAgYi9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKaW5kZXggMzU1N2Ez Zi4uOTYyZDUxMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 R3RrLmNwcApAQCAtMzU4LDYgKzM1OCwxOSBAQCB2b2lkIENocm9tZUNsaWVudDo6Y29udGVudHNT aXplQ2hhbmdlZChGcmFtZSosIGNvbnN0IEludFNpemUmKSBjb25zdAogCiB2b2lkIENocm9tZUNs aWVudDo6bW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYgaGl0LCB1 bnNpZ25lZCBtb2RpZmllckZsYWdzKQogeworICAgIC8vIElmIGEgdG9vbHRpcCBtdXN0IGJlIGRp c3BsYXllZCBpdCB3aWxsIGJlLCBhZnRlcndhcmRzOyB0aGlzIGlzCisgICAgLy8ganVzdCBhIHdv cmstYXJvdW5kIHRvIG1ha2Ugc3VyZSBpdCB1cGRhdGVzIGl0cyBsb2NhdGlvbgorICAgIC8vIGNv cnJlY3RseTsgc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc5 My4KKyAgICBnX29iamVjdF9zZXQobV93ZWJWaWV3LCAiaGFzLXRvb2x0aXAiLCBGQUxTRSwgTlVM TCk7CisKKyAgICBHZGtEaXNwbGF5KiBnZGtEaXNwbGF5OworICAgIEd0a1dpZGdldCogd2luZG93 ID0gZ3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwoR1RLX1dJREdFVChtX3dlYlZpZXcpKTsKKyAgICBp ZiAoR1RLX1dJREdFVF9UT1BMRVZFTCh3aW5kb3cpKQorICAgICAgICBnZGtEaXNwbGF5ID0gZ3Rr X3dpZGdldF9nZXRfZGlzcGxheSh3aW5kb3cpOworICAgIGVsc2UKKyAgICAgICAgZ2RrRGlzcGxh eSA9IGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCk7CisgICAgZ3RrX3Rvb2x0aXBfdHJpZ2dlcl90 b29sdGlwX3F1ZXJ5KGdka0Rpc3BsYXkpOworCiAgICAgLy8gY2hlY2sgaWYgdGhlIGVsZW1lbnQg aXMgYSBsaW5rLi4uCiAgICAgYm9vbCBpc0xpbmsgPSBoaXQuaXNMaXZlTGluaygpOwogICAgIGlm IChpc0xpbmspIHsKLS0gCjEuNi4yCgo=