157923 2016-05-19 14:32:51 -0700 Web Inspector: Heap Snapshots taken before timeline view has a zero time do not get shown 2016-05-19 15:24:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1194963 0 joepeck 2016-05-19 14:32:51 -0700 * SUMMARY Heap Snapshots taken before timeline view has a zero time do not get shown. * STEPS TO REPRODUCE 1. Inspect this page 2. Show Timelines tab 3. Show JavaScript Allocations Timeline 4. Click "Take Snapshot" button => Heap Snapshot doesn't show up, it should! 1194964 1 webkit-bug-importer 2016-05-19 14:33:47 -0700 <rdar://problem/26377366> 1194976 2 279435 joepeck 2016-05-19 14:41:54 -0700 Created attachment 279435 [PATCH] Proposed Fix 1194981 3 mattbaker 2016-05-19 14:51:26 -0700 Snapshots taken before the recording starts will have execution stopwatch times which occur before the recording zero time (once the recording starts). How should this be depicted in the UI? If a snapshot is taken before starting a recording, the recording zero time could be set to the snapshot timestamp. This would fix the issue, but create large gaps in the recording (similar to starting/stopping a recording does now). 1195005 4 279435 commit-queue 2016-05-19 15:24:13 -0700 Comment on attachment 279435 [PATCH] Proposed Fix Clearing flags on attachment: 279435 Committed r201191: <http://trac.webkit.org/changeset/201191> 1195006 5 commit-queue 2016-05-19 15:24:17 -0700 All reviewed patches have been landed. Closing bug. 279435 2016-05-19 14:41:54 -0700 2016-05-19 15:24:13 -0700 [PATCH] Proposed Fix workaround-1.patch text/plain 5332 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlNTdkZDguLjE4NGFkYWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE2LTA1LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGVhcCBT bmFwc2hvdHMgdGFrZW4gYmVmb3JlIHRpbWVsaW5lIHZpZXcgaGFzIGEgemVybyB0aW1lIGRvIG5v dCBnZXQgc2hvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NzkyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYzNzczNjY+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZS5wcm90b3R5 cGUuY3JlYXRlQ2VsbENvbnRlbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBBbGxvY2F0 aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlLnByb3RvdHlwZS51cGRhdGVUaW1lc3RhbXApOgorICAg ICAgICBTaG93IGVtRGFzaCBmb3IgdGhlIHRpbWVzdGFtcCBpZiB3ZSBkb24ndCB5ZXQgaGF2ZSBh IHplcm8gdGltZS4KKyAgICAgICAgVXBkYXRlIHdoZW4gd2UgZ2V0IGEgemVybyB0aW1lLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3KToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcucHJvdG90 eXBlLmxheW91dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxp bmVWaWV3LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAgIFNhdmUgYSBsaXN0IG9mIG5vZGVzIHBy ZS16ZXJvIHRpbWUgYW5kIHVwZGF0ZSB0aGVtIHdoZW4gd2UgZ2V0IGEgemVybyB0aW1lLgorCisy MDE2LTA1LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogSGVhcFNuYXBzaG90IEluc3RhbmNlcyB2aWV3IHNob3VsZCByZW1v dmUgZGVhZCBvYmplY3RzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTc5MjAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2Mzc1ODY2PgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9j YXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZS5qcwpp bmRleCBmZmI5OGEwLi4wNjZmZjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZS5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxs b2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZS5qcwpAQCAtMzQsNyArMzQsNyBAQCBXZWJJbnNw ZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVEYXRhR3JpZE5vZGUgPSBjbGFzcyBIZWFwQWxs b2NhdGlvbnNUaW1lbGluZQogCiAgICAgICAgIHRoaXMuX2RhdGEgPSB7CiAgICAgICAgICAgICBu YW1lOiB0aGlzLmRpc3BsYXlOYW1lKCksCi0gICAgICAgICAgICB0aW1lc3RhbXA6IHRoaXMuX3Jl Y29yZC50aW1lc3RhbXAgLSB6ZXJvVGltZSwKKyAgICAgICAgICAgIHRpbWVzdGFtcDogemVyb1Rp bWUgPyB0aGlzLl9yZWNvcmQudGltZXN0YW1wIC0gemVyb1RpbWUgOiBOYU4sCiAgICAgICAgICAg ICBzaXplOiB0aGlzLl9yZWNvcmQuaGVhcFNuYXBzaG90LnRvdGFsU2l6ZSwKICAgICAgICAgfTsK ICAgICB9CkBAIC02MCw3ICs2MCw3IEBAIFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1l bGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lCiAgICAgICAg ICAgICByZXR1cm4gZnJhZ21lbnQ7CiAKICAgICAgICAgY2FzZSAidGltZXN0YW1wIjoKLSAgICAg ICAgICAgIHJldHVybiBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHRoaXMuX2RhdGEudGltZXN0YW1w LCB0cnVlKTsKKyAgICAgICAgICAgIHJldHVybiBpc05hTih0aGlzLl9kYXRhLnRpbWVzdGFtcCkg PyBlbURhc2ggOiBOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKHRoaXMuX2RhdGEudGltZXN0YW1wLCB0 cnVlKTsKIAogICAgICAgICBjYXNlICJzaXplIjoKICAgICAgICAgICAgIHJldHVybiBOdW1iZXIu Ynl0ZXNUb1N0cmluZyh0aGlzLl9kYXRhLnNpemUpOwpAQCAtNzgsNCArNzgsMTEgQEAgV2ViSW5z cGVjdG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lRGF0YUdyaWROb2RlID0gY2xhc3MgSGVhcEFs bG9jYXRpb25zVGltZWxpbmUKICAgICB7CiAgICAgICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3Qu cmVtb3ZlKCJiYXNlbGluZSIpOwogICAgIH0KKworICAgIHVwZGF0ZVRpbWVzdGFtcCh6ZXJvVGlt ZSkKKyAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGlzTmFOKHRoaXMuX2RhdGEudGltZXN0 YW1wKSk7CisgICAgICAgIHRoaXMuX2RhdGEudGltZXN0YW1wID0gdGhpcy5fcmVjb3JkLnRpbWVz dGFtcCAtIHplcm9UaW1lOworICAgICAgICB0aGlzLm5lZWRzUmVmcmVzaCgpOworICAgIH0KIH07 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9I ZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanMKaW5kZXggNjQy MWVjYy4uYWQ1NmFmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5l Vmlldy5qcwpAQCAtODcsNiArODcsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25zVGlt ZWxpbmVWaWV3ID0gY2xhc3MgSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3IGV4dAogICAgICAg ICBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu Q29udGVudFZpZXcuRXZlbnQuU2VsZWN0aW9uUGF0aENvbXBvbmVudHNEaWRDaGFuZ2UsIHRoaXMu X2NvbnRlbnRWaWV3U2VsZWN0aW9uUGF0aENvbXBvbmVudERpZENoYW5nZSwgdGhpcyk7CiAKICAg ICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKKyAgICAgICAgdGhpcy5fcGVuZGluZ1pl cm9UaW1lRGF0YUdyaWROb2RlcyA9IFtdOwogCiAgICAgICAgIHRpbWVsaW5lLmFkZEV2ZW50TGlz dGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lLkV2ZW50LlJlY29yZEFkZGVkLCB0aGlzLl9oZWFw QWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZEFkZGVkLCB0aGlzKTsKIApAQCAtMjM1LDEyICsyMzYs MTkgQEAgV2ViSW5zcGVjdG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNsYXNzIEhl YXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyBleHQKIAogICAgIGxheW91dCgpCiAgICAgewotICAg ICAgICAvLyBXYWl0IHRvIHNob3cgcmVjb3JkcyB1bnRpbCBvdXIgemVyb1RpbWUgaGFzIGJlZW4g c2V0LgotICAgICAgICAvLyBGSVhNRTogV2FpdGluZyB1bnRpbCB6ZXJvIHRpbWUgY2F1c2VzIHNu YXBzaG90cyB0YWtlbiB3aXRob3V0IHJlY29yZGluZyB0byBub3Qgc2hvdyB1cCBpbiB0aGUgbGlz dC4KLSAgICAgICAgaWYgKHRoaXMuX3BlbmRpbmdSZWNvcmRzLmxlbmd0aCAmJiB0aGlzLnplcm9U aW1lKSB7CisgICAgICAgIGlmICh0aGlzLl9wZW5kaW5nWmVyb1RpbWVEYXRhR3JpZE5vZGVzLmxl bmd0aCAmJiB0aGlzLnplcm9UaW1lKSB7CisgICAgICAgICAgICBmb3IgKGxldCBkYXRhR3JpZE5v ZGUgb2YgdGhpcy5fcGVuZGluZ1plcm9UaW1lRGF0YUdyaWROb2RlcykKKyAgICAgICAgICAgICAg ICBkYXRhR3JpZE5vZGUudXBkYXRlVGltZXN0YW1wKHRoaXMuemVyb1RpbWUpOworICAgICAgICAg ICAgdGhpcy5fcGVuZGluZ1plcm9UaW1lRGF0YUdyaWROb2RlcyA9IFtdOworICAgICAgICAgICAg dGhpcy5fZGF0YUdyaWQuX3NvcnQoKTsKKyAgICAgICAgfQorCisgICAgICAgIGlmICh0aGlzLl9w ZW5kaW5nUmVjb3Jkcy5sZW5ndGgpIHsKICAgICAgICAgICAgIGZvciAobGV0IGhlYXBBbGxvY2F0 aW9uc1RpbWVsaW5lUmVjb3JkIG9mIHRoaXMuX3BlbmRpbmdSZWNvcmRzKSB7CiAgICAgICAgICAg ICAgICAgbGV0IGRhdGFHcmlkTm9kZSA9IG5ldyBXZWJJbnNwZWN0b3IuSGVhcEFsbG9jYXRpb25z VGltZWxpbmVEYXRhR3JpZE5vZGUoaGVhcEFsbG9jYXRpb25zVGltZWxpbmVSZWNvcmQsIHRoaXMu emVyb1RpbWUsIHRoaXMpOwogICAgICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFkZFJvd0lu U29ydE9yZGVyKG51bGwsIGRhdGFHcmlkTm9kZSk7CisgICAgICAgICAgICAgICAgaWYgKCF0aGlz Lnplcm9UaW1lKQorICAgICAgICAgICAgICAgICAgICB0aGlzLl9wZW5kaW5nWmVyb1RpbWVEYXRh R3JpZE5vZGVzLnB1c2goZGF0YUdyaWROb2RlKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKQEAgLTI1Niw2ICsyNjQsNyBAQCBXZWJJbnNw ZWN0b3IuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3ID0gY2xhc3MgSGVhcEFsbG9jYXRpb25z VGltZWxpbmVWaWV3IGV4dAogCiAgICAgICAgIHRoaXMuc2hvd0hlYXBTbmFwc2hvdExpc3QoKTsK ICAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKKyAgICAgICAgdGhpcy5fcGVuZGlu Z1plcm9UaW1lRGF0YUdyaWROb2RlcyA9IFtdOwogICAgICAgICB0aGlzLl91cGRhdGVDb21wYXJl SGVhcFNuYXBzaG90QnV0dG9uKCk7CiAgICAgfQogCg==