157879 2016-05-18 19:52:01 -0700 Silence warnings from svn propget when using newer versions of Subversion 2016-05-21 10:09:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz ap commit-queue dbates lforschler oldest_to_newest 1194584 0 mitz 2016-05-18 19:52:01 -0700 Silence warnings from svn propget when using newer versions of Subversion 1194585 1 279340 mitz 2016-05-18 19:52:25 -0700 Created attachment 279340 Patch 1194586 2 commit-queue 2016-05-18 19:55:11 -0700 Attachment 279340 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1194642 3 279340 dbates 2016-05-18 22:21:41 -0700 Comment on attachment 279340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279340&action=review > Tools/ChangeLog:4 > + Silence warnings from svn propget when using newer versions of Subversion. > + As mentioned by the style bot in comment #2, this ChangeLog is missing a bug URL. Please add the bug URL before landing. > Tools/Scripts/prepare-ChangeLog:2000 > + my $attrib = $attributeCache{$attr}{$subPath} || `$command 2> /dev/null`; Please use File::Spec->devnull() instead of hardcoding /dev/null since this script should be platform agnostic. > Tools/Scripts/svn-create-patch:175 > + open PROPGET, "svn propget svn:mime-type $args '$escapedFile' 2> /dev/null |" or die; Ditto. 1194647 4 ap 2016-05-18 22:38:19 -0700 What are these warnings, can they fixed for good? 1195359 5 mitz 2016-05-21 10:05:42 -0700 (In reply to comment #4) > What are these warnings, can they fixed for good? svn propget warns if the property isn’t found: $ svn propget myproperty . svn: warning: W200017: Property 'myproperty' not found on '' svn: E200000: A problem occurred; see other errors for details I couldn’t find a way to fix it. One could avoid the warning by using svn proplist first to check for the property, but that seems unnecessarily more complex. 1195360 6 mitz 2016-05-21 10:09:49 -0700 Committed <http://trac.webkit.org/r201242>. 279340 2016-05-18 19:52:25 -0700 2016-05-18 22:21:41 -0700 Patch bug-157879-20160518195324.patch text/plain 1950 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMTEyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA1LTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgU2lsZW5jZSB3YXJuaW5ncyBmcm9tIHN2biBwcm9wZ2V0IHdoZW4gdXNpbmcgbmV3 ZXIgdmVyc2lvbnMgb2YgU3VidmVyc2lvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2c6CisgICAgICAg IChhdHRyaWJ1dGVDb21tYW5kKTogUmVkaXJlY3Qgc3ZuIHByb3BnZXQgc3RkZXJyIHRvIC9kZXYv bnVsbC4KKyAgICAgICAgKiBTY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2g6CisgICAgICAgIChmaW5k TWltZVR5cGUpOiBEaXR0by4KKwogMjAxNi0wNS0xOCAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFp bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVuZGVybGluZSBmcm9tIFN0YXR1cyBCdWJi bGVzIG9uIGRhc2hib2FyZApJbmRleDogVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCShyZXZpc2lvbiAy MDEwNzEpCisrKyBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xOTk3LDcgKzE5OTcsNyBAQCBzdWIgYXR0cmlidXRlQ29tbWFuZCgkJCkKICAgICAgICAg ICAgICAgICBuZXh0OwogICAgICAgICAgICAgfQogICAgICAgICAgICAgbXkgJGNvbW1hbmQgPSBT Vk4gLiAiIHByb3BnZXQgJGF0dHIgJyRzdWJQYXRoJyI7Ci0gICAgICAgICAgICBteSAkYXR0cmli ID0gJGF0dHJpYnV0ZUNhY2hleyRhdHRyfXskc3ViUGF0aH0gfHwgYCRjb21tYW5kYDsKKyAgICAg ICAgICAgIG15ICRhdHRyaWIgPSAkYXR0cmlidXRlQ2FjaGV7JGF0dHJ9eyRzdWJQYXRofSB8fCBg JGNvbW1hbmQgMj4gL2Rldi9udWxsYDsKICAgICAgICAgICAgIGNob21wICRhdHRyaWI7CiAgICAg ICAgICAgICBpZiAoJGF0dHJpYiBlcSAiMSIpIHsKICAgICAgICAgICAgICAgICAkZm91bmRBdHRy aWJ1dGUgPSAxOwpJbmRleDogVG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAkocmV2aXNpb24gMjAxMDcxKQor KysgVG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBAIC0xNzIs NyArMTcyLDcgQEAgc3ViIGZpbmRNaW1lVHlwZSgkOyQpCiAgICAgbXkgKCRmaWxlLCAkcmV2aXNp b24pID0gQF87CiAgICAgbXkgJGFyZ3MgPSAkcmV2aXNpb24gPyAiLS1yZXZpc2lvbiAkcmV2aXNp b24iIDogIiI7CiAgICAgbXkgJGVzY2FwZWRGaWxlID0gZXNjYXBlU3VidmVyc2lvblBhdGgoJGZp bGUpOwotICAgIG9wZW4gUFJPUEdFVCwgInN2biBwcm9wZ2V0IHN2bjptaW1lLXR5cGUgJGFyZ3Mg JyRlc2NhcGVkRmlsZScgfCIgb3IgZGllOworICAgIG9wZW4gUFJPUEdFVCwgInN2biBwcm9wZ2V0 IHN2bjptaW1lLXR5cGUgJGFyZ3MgJyRlc2NhcGVkRmlsZScgMj4gL2Rldi9udWxsIHwiIG9yIGRp ZTsKICAgICBteSAkbWltZVR5cGUgPSA8UFJPUEdFVD47CiAgICAgY2xvc2UgUFJPUEdFVDsKICAg ICAjIHN2biBtYXkgb3V0cHV0IGEgZGlmZmVyZW50IEVPTCBzZXF1ZW5jZSB0aGFuICQvLCBzbyBh dm9pZCBjaG9tcC4K