157877 2016-05-18 18:58:42 -0700 Analysis task should look for a git commit based on abridged hashes 2016-05-18 19:38:55 -0700 1 1 1 Unclassified WebKit Perf Dashboard Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu rniwa slewis oldest_to_newest 1194572 0 rniwa 2016-05-18 18:58:42 -0700 Analysis task should be able to find the right commit based on 8-character hash. 1194573 1 rniwa 2016-05-18 18:59:18 -0700 <rdar://problem/26254374> 1194574 2 279336 rniwa 2016-05-18 19:08:52 -0700 Created attachment 279336 Fixes the bug 1194575 3 279336 cdumez 2016-05-18 19:10:37 -0700 Comment on attachment 279336 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=279336&action=review r=me with comment. > Websites/perf.webkit.org/public/privileged-api/associate-commit.php:36 > + exit_with_error('AmbigiousRevision', $commit_info); Typo: Ambiguous > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:499 > + if (error == 'AmbigiousRevision') Same typo. 1194582 4 rniwa 2016-05-18 19:38:55 -0700 Committed r201123: <http://trac.webkit.org/changeset/201123> 279336 2016-05-18 19:08:52 -0700 2016-05-18 19:10:37 -0700 Fixes the bug bug-157877-20160518190951.patch text/plain 5404 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMTIyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDE2LTA1LTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFuYWx5c2lzIHRhc2sgc2hvdWxkIGxvb2sgZm9yIGEgZ2l0IGNvbW1pdCBiYXNl ZCBvbiBhYnJpZGdlZCBoYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1Nzg3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYyNTQzNzQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFkZSAvcHJp dmlsZWdlZC1hcGkvYXNzb2NpYXRlLWNvbW1pdCBsb29rIGZvciBjb21taXRzIHVzaW5nIExJS0Ug aW5zdGVhZCBvZiBhbiBleGFjdCBtYXRjaC4KKyAgICAgICAgQXNzb2NpYXRlIHRoZSBjb21taXQg d2hlbiB0aGVyZSBpcyBleGFjdGx5IG9uZSBtYXRjaC4KKworICAgICAgICAqIHB1YmxpYy9pbmNs dWRlL2NvbW1pdC1sb2ctZmV0Y2hlci5waHA6CisgICAgICAgIChDb21taXRMb2dGZXRjaGVyOjpm ZXRjaF9iZXR3ZWVuKToKKyAgICAgICAgKiBwdWJsaWMvaW5jbHVkZS9kYi5waHA6CisgICAgICAg IChEYXRhYmFzZTo6ZXNjYXBlX2Zvcl9saWtlKTogRXh0cmFjdGVkIGZyb20gQ29tbWl0TG9nRmV0 Y2hlcjo6ZmV0Y2hfYmV0d2Vlbi4KKyAgICAgICAgKiBwdWJsaWMvcHJpdmlsZWdlZC1hcGkvYXNz b2NpYXRlLWNvbW1pdC5waHA6CisgICAgICAgIChtYWluKTogTG9vayBmb3IgdGhlIGNvbW1pdHMg dXNpbmcgTElLRS4gUmVqZWN0IHdoZW5ldmVyIHRoZXJlIGFyZSBtdWx0aXBsZSBjb21taXRzLiBX ZSBsaW1pdCB0aGUgbnVtYmVyIG9mCisgICAgICAgIG1hdGNoZXMgdG8gdHdvIGZvciBwZXJmb3Jt YW5jZSB3aGVuIHRoZSB1c2VyIHNwZWNpZmllcyBzb21ldGhpbmcgdGhhdCBhbG1vc3QgdGhvdXNh bmRzIG9mIGNvbW1pdHM6IGUuZy4gIjEiLgorICAgICAgICAqIHB1YmxpYy92My9wYWdlcy9hbmFs eXNpcy10YXNrLXBhZ2UuanM6CisgICAgICAgIChBbmFseXNpc1Rhc2tQYWdlLnByb3RvdHlwZS5f YXNzb2NpYXRlQ29tbWl0KTogQWRkZWQgaHVtYW4gZnJpZW5kbHkgZXJyb3IgbWVzc2FnZXMgZm9y IG1pc21hdGNoaW5nIGNvbW1pdHMuCisKIDIwMTYtMDUtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIFVzZSAtLWRhdGUt b3JkZXIgc28gdGhhdCBldmVyeSBjaGlsZCBjb21taXQgYXBwZWFycyBhZnRlciBpdHMgcGFyZW50 LgpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL2NvbW1pdC1s b2ctZmV0Y2hlci5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy9pbmNsdWRlL2NvbW1pdC1sb2ctZmV0Y2hlci5waHAJKHJldmlzaW9uIDIwMTEwOSkKKysr IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9jb21taXQtbG9nLWZldGNo ZXIucGhwCSh3b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIGNsYXNzIENvbW1pdExvZ0Zl dGNoZXIgewogICAgICAgICB9CiAKICAgICAgICAgaWYgKCRrZXl3b3JkKSB7Ci0gICAgICAgICAg ICBhcnJheV9wdXNoKCR2YWx1ZXMsICclJyAuIHN0cl9yZXBsYWNlKGFycmF5KCdcXCcsICdfJywg JyUnKSwgYXJyYXkoJ1xcXFwnLCAnXFxfJywgJ1xcJScpLCAka2V5d29yZCkgLiAnJScpOworICAg ICAgICAgICAgYXJyYXlfcHVzaCgkdmFsdWVzLCAnJScgLiBEYXRhYmFzZTo6ZXNjYXBlX2Zvcl9s aWtlKCRrZXl3b3JkKSAuICclJyk7CiAgICAgICAgICAgICAka2V5d29yZF9pbmRleCA9ICckJyAu IGNvdW50KCR2YWx1ZXMpOwogICAgICAgICAgICAgYXJyYXlfcHVzaCgkdmFsdWVzLCBsdHJpbSgk a2V5d29yZCwgJ3InKSk7CiAgICAgICAgICAgICAkcmV2aXNpb25faW5kZXggPSAnJCcgLiBjb3Vu dCgkdmFsdWVzKTsKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVk ZS9kYi5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9p bmNsdWRlL2RiLnBocAkocmV2aXNpb24gMjAxMTA5KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy9pbmNsdWRlL2RiLnBocAkod29ya2luZyBjb3B5KQpAQCAtODQsNiArODQsMTAg QEAgY2xhc3MgRGF0YWJhc2UKICAgICAgICAgcmV0dXJuIGludHZhbCgkdGltZXN0YW1wX2luX3Mg KiAxMDAwKTsKICAgICB9CiAKKyAgICBzdGF0aWMgZnVuY3Rpb24gZXNjYXBlX2Zvcl9saWtlKCRz dHJpbmcpIHsKKyAgICAgICAgcmV0dXJuIHN0cl9yZXBsYWNlKGFycmF5KCdcXCcsICdfJywgJyUn KSwgYXJyYXkoJ1xcXFwnLCAnXFxfJywgJ1xcJScpLCAkc3RyaW5nKTsKKyAgICB9CisKICAgICBm dW5jdGlvbiBjb25uZWN0KCkgewogICAgICAgICAkZGF0YWJhc2VDb25maWcgPSBjb25maWcoJ2Rh dGFiYXNlJyk7CiAgICAgICAgICR0aGlzLT5jb25uZWN0aW9uID0gQHBnX2Nvbm5lY3QoJ2hvc3Q9 JyAuICRkYXRhYmFzZUNvbmZpZ1snaG9zdCddIC4gJyBwb3J0PScgLiAkZGF0YWJhc2VDb25maWdb J3BvcnQnXQpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9wcml2aWxlZ2Vk LWFwaS9hc3NvY2lhdGUtY29tbWl0LnBocAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvcHVibGljL3ByaXZpbGVnZWQtYXBpL2Fzc29jaWF0ZS1jb21taXQucGhwCShyZXZp c2lvbiAyMDExMDkpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3ByaXZpbGVn ZWQtYXBpL2Fzc29jaWF0ZS1jb21taXQucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMiArMjks MTcgQEAgZnVuY3Rpb24gbWFpbigpIHsKICAgICAgICAgcmVxdWlyZV9mb3JtYXQoJ0tpbmQnLCAk a2luZCwgJy9eKGNhdXNlfGZpeCkkLycpOwogCiAgICAgICAgICRjb21taXRfaW5mbyA9IGFycmF5 KCdyZXBvc2l0b3J5JyA9PiAkcmVwb3NpdG9yeV9pZCwgJ3JldmlzaW9uJyA9PiAkcmV2aXNpb24p OwotICAgICAgICAkY29tbWl0X3JvdyA9ICRkYi0+c2VsZWN0X2ZpcnN0X3JvdygnY29tbWl0cycs ICdjb21taXQnLCAkY29tbWl0X2luZm8pOwotICAgICAgICBpZiAoISRjb21taXRfcm93KSB7Cisg ICAgICAgICRjb21taXRfcm93cyA9ICRkYi0+cXVlcnlfYW5kX2ZldGNoX2FsbCgnU0VMRUNUIGNv bW1pdF9pZCBGUk9NIGNvbW1pdHMgV0hFUkUgY29tbWl0X3JlcG9zaXRvcnkgPSAkMSBBTkQgY29t bWl0X3JldmlzaW9uIExJS0UgJDIgTElNSVQgMicsCisgICAgICAgICAgICBhcnJheSgkcmVwb3Np dG9yeV9pZCwgJyUnIC4gRGF0YWJhc2U6OmVzY2FwZV9mb3JfbGlrZSgkcmV2aXNpb24pIC4gJyUn KSk7CisgICAgICAgIGlmIChjb3VudCgkY29tbWl0X3Jvd3MpID4gMSkgeworICAgICAgICAgICAg JGRiLT5yb2xsYmFja190cmFuc2FjdGlvbigpOworICAgICAgICAgICAgZXhpdF93aXRoX2Vycm9y KCdBbWJpZ2lvdXNSZXZpc2lvbicsICRjb21taXRfaW5mbyk7ICAgICAgICAgICAgCisgICAgICAg IH0gZWxzZSBpZiAoISRjb21taXRfcm93cykgewogICAgICAgICAgICAgJGRiLT5yb2xsYmFja190 cmFuc2FjdGlvbigpOwogICAgICAgICAgICAgZXhpdF93aXRoX2Vycm9yKCdDb21taXROb3RGb3Vu ZCcsICRjb21taXRfaW5mbyk7CiAgICAgICAgIH0KLSAgICAgICAgJGNvbW1pdF9pZCA9ICRjb21t aXRfcm93Wydjb21taXRfaWQnXTsKKworICAgICAgICAkY29tbWl0X2lkID0gJGNvbW1pdF9yb3dz WzBdWydjb21taXRfaWQnXTsKIAogICAgICAgICAkYXNzb2NpYXRpb24gPSBhcnJheSgndGFzaycg PT4gJGFuYWx5c2lzX3Rhc2tfaWQsICdjb21taXQnID0+ICRjb21taXRfaWQsICdpc19maXgnID0+ IERhdGFiYXNlOjp0b19kYXRhYmFzZV9ib29sZWFuKCRraW5kID09ICdmaXgnKSk7CiAgICAgICAg ICRjb21taXRfaWQgPSAkZGItPnVwZGF0ZV9vcl9pbnNlcnRfcm93KCd0YXNrX2NvbW1pdHMnLCAn dGFza2NvbW1pdCcsCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL3Bh Z2VzL2FuYWx5c2lzLXRhc2stcGFnZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvcHVibGljL3YzL3BhZ2VzL2FuYWx5c2lzLXRhc2stcGFnZS5qcwkocmV2aXNpb24g MjAxMTA5KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9hbmFs eXNpcy10YXNrLXBhZ2UuanMJKHdvcmtpbmcgY29weSkKQEAgLTQ5Niw3ICs0OTYsMTIgQEAgY2xh c3MgQW5hbHlzaXNUYXNrUGFnZSBleHRlbmRzIFBhZ2VXaXRoSAogICAgICAgICB2YXIgcmVuZGVy ID0gdGhpcy5yZW5kZXIuYmluZCh0aGlzKTsKICAgICAgICAgcmV0dXJuIHRoaXMuX3Rhc2suYXNz b2NpYXRlQ29tbWl0KGtpbmQsIHJlcG9zaXRvcnksIHJldmlzaW9uKS50aGVuKHJlbmRlciwgZnVu Y3Rpb24gKGVycm9yKSB7CiAgICAgICAgICAgICByZW5kZXIoKTsKLSAgICAgICAgICAgIGFsZXJ0 KCdGYWlsZWQgdG8gYXNzb2NpYXRlIHRoZSBjb21taXQ6ICcgKyBlcnJvcik7CisgICAgICAgICAg ICBpZiAoZXJyb3IgPT0gJ0FtYmlnaW91c1JldmlzaW9uJykKKyAgICAgICAgICAgICAgICBhbGVy dCgnVGhlcmUgYXJlIG11bHRpcGxlIHJldmlzaW9ucyB0aGF0IG1hdGNoIHRoZSBzcGVjaWZpZWQg c3RyaW5nOiAnICsgcmV2aXNpb24pOworICAgICAgICAgICAgZWxzZSBpZiAoZXJyb3IgPT0gJ0Nv bW1pdE5vdEZvdW5kJykKKyAgICAgICAgICAgICAgICBhbGVydCgnVGhlcmUgYXJlIG5vIHJldmlz aW9ucyB0aGF0IG1hdGNoIHRoZSBzcGVjaWZpZWQgc3RyaW5nOicgKyByZXZpc2lvbik7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgYWxlcnQoJ0ZhaWxlZCB0byBhc3NvY2lhdGUg dGhlIGNvbW1pdDogJyArIGVycm9yKTsKICAgICAgICAgfSk7CiAgICAgfQogCg==