157871 2016-05-18 16:26:44 -0700 Make LayoutUnit::operator bool() explicit. 2016-05-18 20:10:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1194501 0 zalan 2016-05-18 16:26:44 -0700 This is in preparation to get LayoutUnit operator int() removed. 1194504 1 279314 zalan 2016-05-18 16:29:21 -0700 Created attachment 279314 Patch 1194513 2 279314 simon.fraser 2016-05-18 16:48:03 -0700 Comment on attachment 279314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279314&action=review > Source/WebCore/rendering/RenderView.cpp:280 > + state.m_isPaginated = !!state.m_pageLogicalHeight; I really think != 0 is better in these situations, and damn the style checker. 1194523 3 zalan 2016-05-18 17:01:41 -0700 (In reply to comment #2) > Comment on attachment 279314 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279314&action=review > > > Source/WebCore/rendering/RenderView.cpp:280 > > + state.m_isPaginated = !!state.m_pageLogicalHeight; > > I really think != 0 is better in these situations, and damn the style > checker. Agree! It might even be more correct to check if state.m_pageLogicalHeight > 0 1194570 4 279335 zalan 2016-05-18 18:48:52 -0700 Created attachment 279335 Patch 1194590 5 279335 commit-queue 2016-05-18 20:10:42 -0700 Comment on attachment 279335 Patch Clearing flags on attachment: 279335 Committed r201124: <http://trac.webkit.org/changeset/201124> 1194591 6 commit-queue 2016-05-18 20:10:47 -0700 All reviewed patches have been landed. Closing bug. 279314 2016-05-18 16:29:21 -0700 2016-05-18 18:48:48 -0700 Patch bug-157871-20160518163020.patch text/plain 2239 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkwMTAxNWYyMmM4MjVj ODYyMmEzN2RlN2E5MTQxMGM1ZGNlMjA3OS4uOWQ3YmVmYTkwNzJkMDkxZjVlNDE0NzFjNTY3M2I3 YjU1NmIyMTA1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA1LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBMYXlvdXRVbml0Ojpv cGVyYXRvciBib29sKCkgZXhwbGljaXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc4NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvciBnZXR0aW5nIExheW91 dFVuaXQ6Om9wZXJhdG9yIGludCgpIHJlbW92ZWQuCisKKyAgICAgICAgTm8gYmVoYXZpb3VyIGNo YW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL0xheW91dFVuaXQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dFVuaXQ6Om9wZXJhdG9yIGJvb2wpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OmluaXRpYWxpemVMYXlv dXRTdGF0ZSk6CisKKzIwMTYtMDUtMTggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K KwogICAgICAgICBSZW1vdmUgTGF5b3V0VW5pdDo6b3BlcmF0b3IgdW5zaWduZWQoKS4KICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzg1NgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MYXlvdXRVbml0LmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9MYXlvdXRVbml0LmgKaW5kZXggN2RlNjliODVhOTk4YWZmNTc1YTNmMDc2 ZWUxMzhlOGViNjdhZGFlZC4uZTQ3Y2ZiZWFjODM3YzM1YzQyNWY4NzAyYjViYjNmNTkxNGZkZGIx MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaApAQCAtMTE2LDcgKzExNiw3IEBA IHB1YmxpYzoKICAgICBvcGVyYXRvciBpbnQoKSBjb25zdCB7IHJldHVybiB0b0ludCgpOyB9CiAg ICAgb3BlcmF0b3IgZmxvYXQoKSBjb25zdCB7IHJldHVybiB0b0Zsb2F0KCk7IH0KICAgICBvcGVy YXRvciBkb3VibGUoKSBjb25zdCB7IHJldHVybiB0b0RvdWJsZSgpOyB9Ci0gICAgb3BlcmF0b3Ig Ym9vbCgpIGNvbnN0IHsgcmV0dXJuIG1fdmFsdWU7IH0KKyAgICBleHBsaWNpdCBvcGVyYXRvciBi b29sKCkgY29uc3QgeyByZXR1cm4gbV92YWx1ZTsgfQogCiAgICAgTGF5b3V0VW5pdCYgb3BlcmF0 b3IrKygpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4 IDQ5MGU2M2FmM2Y0MWU3NTlkYjU2YzljM2UxMTQzMGI2MWE0OTE0NmMuLmUzYTlmNWUxOGRjNjI2 MDVmOTJjYWEyZTAxMTY5ZmZkY2UxY2JkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlldy5jcHAKQEAgLTI3Nyw3ICsyNzcsNyBAQCB2b2lkIFJlbmRlclZpZXc6OmluaXRpYWxp emVMYXlvdXRTdGF0ZShMYXlvdXRTdGF0ZSYgc3RhdGUpCiAKICAgICBzdGF0ZS5tX3BhZ2VMb2dp Y2FsSGVpZ2h0ID0gbV9wYWdlTG9naWNhbEhlaWdodDsKICAgICBzdGF0ZS5tX3BhZ2VMb2dpY2Fs SGVpZ2h0Q2hhbmdlZCA9IG1fcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkOwotICAgIHN0YXRlLm1f aXNQYWdpbmF0ZWQgPSBzdGF0ZS5tX3BhZ2VMb2dpY2FsSGVpZ2h0OworICAgIHN0YXRlLm1faXNQ YWdpbmF0ZWQgPSAhIXN0YXRlLm1fcGFnZUxvZ2ljYWxIZWlnaHQ7CiB9CiAKIC8vIFRoZSBhbGdv cml0aG0gYmVsb3cgYXNzdW1lcyB0aGlzIGlzIGEgZnVsbCBsYXlvdXQuIEluIGNhc2UgdGhlcmUg YXJlIHByZXZpb3VzbHkgY29tcHV0ZWQgdmFsdWVzIGZvciByZWdpb25zLCBzdXBwbGVtZW50YWwg c3RlcHMgYXJlIHRha2VuCg== 279335 2016-05-18 18:48:52 -0700 2016-05-18 20:10:42 -0700 Patch bug-157871-20160518184951.patch text/plain 2317 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkwMTAxNWYyMmM4MjVj ODYyMmEzN2RlN2E5MTQxMGM1ZGNlMjA3OS4uMGIwMTM3NDA0YmM4YWVlNThkYzM2NzMwMGMwMGM4 MWY3ZWZmMWRiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA1LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBMYXlvdXRVbml0Ojpv cGVyYXRvciBib29sKCkgZXhwbGljaXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc4NzEKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFz ZXIuCisKKyAgICAgICAgVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3IgZ2V0dGluZyBMYXlvdXRV bml0OjpvcGVyYXRvciBpbnQoKSByZW1vdmVkLgorCisgICAgICAgIE5vIGJlaGF2aW91ciBjaGFu Z2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9MYXlvdXRVbml0Lmg6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXRVbml0OjpvcGVyYXRvciBib29sKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy Vmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3Ojppbml0aWFsaXplTGF5b3V0 U3RhdGUpOiBOZWdhdGl2ZSBwYWdlIGhlaWdodCBpcyBpbnZhbGlkLgorCisyMDE2LTA1LTE4ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3ZlIExheW91dFVu aXQ6Om9wZXJhdG9yIHVuc2lnbmVkKCkuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc4NTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vTGF5b3V0VW5pdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5o CmluZGV4IDdkZTY5Yjg1YTk5OGFmZjU3NWEzZjA3NmVlMTM4ZThlYjY3YWRhZWQuLmU0N2NmYmVh YzgzN2MzNWM0MjVmODcwMmI1YmIzZjU5MTRmZGRiMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9M YXlvdXRVbml0LmgKQEAgLTExNiw3ICsxMTYsNyBAQCBwdWJsaWM6CiAgICAgb3BlcmF0b3IgaW50 KCkgY29uc3QgeyByZXR1cm4gdG9JbnQoKTsgfQogICAgIG9wZXJhdG9yIGZsb2F0KCkgY29uc3Qg eyByZXR1cm4gdG9GbG9hdCgpOyB9CiAgICAgb3BlcmF0b3IgZG91YmxlKCkgY29uc3QgeyByZXR1 cm4gdG9Eb3VibGUoKTsgfQotICAgIG9wZXJhdG9yIGJvb2woKSBjb25zdCB7IHJldHVybiBtX3Zh bHVlOyB9CisgICAgZXhwbGljaXQgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIG1fdmFs dWU7IH0KIAogICAgIExheW91dFVuaXQmIG9wZXJhdG9yKysoKQogICAgIHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAppbmRleCA0OTBlNjNhZjNmNDFlNzU5ZGI1NmM5YzNl MTE0MzBiNjFhNDkxNDZjLi5lMWVhMzNlYTE3YWVlZWMyOTQ4MDVlYTNmNjcyMjliNTQ1OGQ5ZDQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCkBAIC0yNzcsNyArMjc3 LDggQEAgdm9pZCBSZW5kZXJWaWV3Ojppbml0aWFsaXplTGF5b3V0U3RhdGUoTGF5b3V0U3RhdGUm IHN0YXRlKQogCiAgICAgc3RhdGUubV9wYWdlTG9naWNhbEhlaWdodCA9IG1fcGFnZUxvZ2ljYWxI ZWlnaHQ7CiAgICAgc3RhdGUubV9wYWdlTG9naWNhbEhlaWdodENoYW5nZWQgPSBtX3BhZ2VMb2dp Y2FsSGVpZ2h0Q2hhbmdlZDsKLSAgICBzdGF0ZS5tX2lzUGFnaW5hdGVkID0gc3RhdGUubV9wYWdl TG9naWNhbEhlaWdodDsKKyAgICBBU1NFUlQoc3RhdGUubV9wYWdlTG9naWNhbEhlaWdodCA+PSAw KTsKKyAgICBzdGF0ZS5tX2lzUGFnaW5hdGVkID0gc3RhdGUubV9wYWdlTG9naWNhbEhlaWdodCA+ IDA7CiB9CiAKIC8vIFRoZSBhbGdvcml0aG0gYmVsb3cgYXNzdW1lcyB0aGlzIGlzIGEgZnVsbCBs YXlvdXQuIEluIGNhc2UgdGhlcmUgYXJlIHByZXZpb3VzbHkgY29tcHV0ZWQgdmFsdWVzIGZvciBy ZWdpb25zLCBzdXBwbGVtZW50YWwgc3RlcHMgYXJlIHRha2VuCg==