157868 2016-05-18 15:55:02 -0700 StringBuilder::appendQuotedJSONString doesn't properly protect against the math it's doing. Make the math fit the assertion. 2016-05-18 18:00:27 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin cdumez cmarcelo commit-queue darin fpizlo ggaren gskachkov keith_miller kling mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1194477 0 saam 2016-05-18 15:55:02 -0700 ... 1194486 1 279307 saam 2016-05-18 16:08:03 -0700 Created attachment 279307 patch 1194494 2 279310 saam 2016-05-18 16:18:46 -0700 Created attachment 279310 patch changed name of the bug 1194495 3 279311 saam 2016-05-18 16:19:55 -0700 Created attachment 279311 patch change variable name 1194550 4 279311 commit-queue 2016-05-18 18:00:21 -0700 Comment on attachment 279311 patch Clearing flags on attachment: 279311 Committed r201121: <http://trac.webkit.org/changeset/201121> 1194551 5 commit-queue 2016-05-18 18:00:27 -0700 All reviewed patches have been landed. Closing bug. 279307 2016-05-18 16:08:03 -0700 2016-05-18 16:18:46 -0700 patch b-backup.diff text/plain 2349 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDExMTEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTE4ICBTYWFtIGJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OmFwcGVuZFF1b3RlZEpTT05T dHJpbmcgZG9lc24ndCBwcm9wZXJseSBwcm90ZWN0IGFnYWluc3QgdGhlIG1hdGggaXQncyBkb2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3ODY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYXBwZW5k UXVvdGVkSlNPTlN0cmluZyB3YXMgcm91bmRpbmcgdXAgdG8gdGhlIG5leHQgcG93ZXIgb2YgdHdv IHdoZW4gcmVzaXppbmcKKyAgICAgICAgaXRzIGJ1ZmZlci4gTGV0cyBjYWxsIHRoZSBhbGxvY2F0 aW9uIHNpemUgWC4gSWYgWCA+IDJeMzEsIHRoZW4KKyAgICAgICAgcm91bmRVcFRvUG93ZXJPZlR3 byhYKSA9PSAwLiBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkgbWFraW5nIHRoZQorICAgICAgICBh c3NlcnRpb24gcmVmbGVjdCB3aGF0IHRoZSBjb2RlIGlzIGRvaW5nLiBXZSBub3cgYWxsb2NhdGUg dG8gYSBzaXplCisgICAgICAgIG9mIFggPSBzdGQ6Om1heChtYXhpbXVtQ2FwYWNpdHlSZXF1aXJl ZCAsIHJvdW5kVXBUb1Bvd2VyT2ZUd28obWF4aW11bUNhcGFjaXR5UmVxdWlyZWQpKQorCisgICAg ICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZ0J1 aWxkZXI6OmFwcGVuZFF1b3RlZEpTT05TdHJpbmcpOgorCiAyMDE2LTA1LTE3ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTkyODU1 KTogTWF0aC5yYW5kb20oKSBhbHdheXMgcHJvZHVjZXMgdGhlIHNhbWUgZmlyc3QgNyBkZWNpbWFs IHBvaW50cyB0aGUgZmlyc3QgdHdvIGludm9jYXRpb25zCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90 ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQv U3RyaW5nQnVpbGRlci5jcHAJKHJldmlzaW9uIDIwMTExMCkKKysrIFNvdXJjZS9XVEYvd3RmL3Rl eHQvU3RyaW5nQnVpbGRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxNCwxMSArNDE0LDE0IEBA IHZvaWQgU3RyaW5nQnVpbGRlcjo6YXBwZW5kUXVvdGVkSlNPTlN0cmkKICAgICAvLyBUaGUgNiBp cyBmb3IgY2hhcmFjdGVycyB0aGF0IG5lZWQgdG8gYmUgXHVOTk5OIGVuY29kZWQuCiAgICAgc2l6 ZV90IG1heGltdW1DYXBhY2l0eVJlcXVpcmVkID0gbGVuZ3RoKCkgKyAyICsgc3RyaW5nLmxlbmd0 aCgpICogNjsKICAgICBSRUxFQVNFX0FTU0VSVChtYXhpbXVtQ2FwYWNpdHlSZXF1aXJlZCA8IHN0 ZDo6bnVtZXJpY19saW1pdHM8dW5zaWduZWQ+OjptYXgoKSk7CisgICAgdW5zaWduZWQgbmV3QWxs b2NhdGlvblNpemUgPSBtYXhpbXVtQ2FwYWNpdHlSZXF1aXJlZDsKKyAgICAvLyBUaGlzIG1heCgp IGlzIGhlcmUgdG8gYWxsb3cgdXMgdG8gYWxsb2NhdGUgc2l6ZXMgYmV0d2VlbiB0aGUgcmFuZ2Ug WzJeMzEsIDJeMzIgLSAyXSBiZWNhdXNlIHJvdW5kVXBUb1Bvd2VyT2ZUd28oMTw8MzEgKyBzb21l IGludCBzbWFsbGVyIHRoYW4gMTw8MzEpID09IDAuCisgICAgbmV3QWxsb2NhdGlvblNpemUgPSBz dGQ6Om1heChuZXdBbGxvY2F0aW9uU2l6ZSwgcm91bmRVcFRvUG93ZXJPZlR3byhuZXdBbGxvY2F0 aW9uU2l6ZSkpOwogCiAgICAgaWYgKGlzOEJpdCgpICYmICFzdHJpbmcuaXM4Qml0KCkpCi0gICAg ICAgIGFsbG9jYXRlQnVmZmVyVXBDb252ZXJ0KG1fYnVmZmVyQ2hhcmFjdGVyczgsIHJvdW5kVXBU b1Bvd2VyT2ZUd28obWF4aW11bUNhcGFjaXR5UmVxdWlyZWQpKTsKKyAgICAgICAgYWxsb2NhdGVC dWZmZXJVcENvbnZlcnQobV9idWZmZXJDaGFyYWN0ZXJzOCwgbmV3QWxsb2NhdGlvblNpemUpOwog ICAgIGVsc2UKLSAgICAgICAgcmVzZXJ2ZUNhcGFjaXR5KHJvdW5kVXBUb1Bvd2VyT2ZUd28obWF4 aW11bUNhcGFjaXR5UmVxdWlyZWQpKTsKKyAgICAgICAgcmVzZXJ2ZUNhcGFjaXR5KG5ld0FsbG9j YXRpb25TaXplKTsKIAogICAgIGlmIChpczhCaXQoKSkgewogICAgICAgICBBU1NFUlQoc3RyaW5n LmlzOEJpdCgpKTsK 279310 2016-05-18 16:18:46 -0700 2016-05-18 16:19:55 -0700 patch b-backup.diff text/plain 2383 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDExMTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTE4ICBTYWFtIGJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OmFwcGVuZFF1b3RlZEpTT05T dHJpbmcgZG9lc24ndCBwcm9wZXJseSBwcm90ZWN0IGFnYWluc3QgdGhlIG1hdGggaXQncyBkb2lu Zy4gTWFrZSB0aGUgbWF0aCBmaXQgdGhlIGFzc2VydGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzg2OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFwcGVuZFF1b3RlZEpTT05TdHJpbmcgd2FzIHJv dW5kaW5nIHVwIHRvIHRoZSBuZXh0IHBvd2VyIG9mIHR3byB3aGVuIHJlc2l6aW5nCisgICAgICAg IGl0cyBidWZmZXIuIExldHMgY2FsbCB0aGUgYWxsb2NhdGlvbiBzaXplIFguIElmIFggPiAyXjMx LCB0aGVuCisgICAgICAgIHJvdW5kVXBUb1Bvd2VyT2ZUd28oWCkgPT0gMC4gVGhpcyBwYXRjaCBm aXhlcyB0aGlzIGJ5IG1ha2luZyB0aGUKKyAgICAgICAgYXNzZXJ0aW9uIHJlZmxlY3Qgd2hhdCB0 aGUgY29kZSBpcyBkb2luZy4gV2Ugbm93IGFsbG9jYXRlIHRvIGEgc2l6ZQorICAgICAgICBvZiBY ID0gc3RkOjptYXgobWF4aW11bUNhcGFjaXR5UmVxdWlyZWQgLCByb3VuZFVwVG9Qb3dlck9mVHdv KG1heGltdW1DYXBhY2l0eVJlcXVpcmVkKSkKKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0J1 aWxkZXIuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmdCdWlsZGVyOjphcHBlbmRRdW90ZWRKU09O U3RyaW5nKToKKwogMjAxNi0wNS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE5Mjg1NSk6IE1hdGgucmFuZG9tKCkgYWx3YXlz IHByb2R1Y2VzIHRoZSBzYW1lIGZpcnN0IDcgZGVjaW1hbCBwb2ludHMgdGhlIGZpcnN0IHR3byBp bnZvY2F0aW9ucwpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCShyZXZp c2lvbiAyMDExMTApCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00MTQsMTEgKzQxNCwxNCBAQCB2b2lkIFN0cmluZ0J1aWxkZXI6OmFw cGVuZFF1b3RlZEpTT05TdHJpCiAgICAgLy8gVGhlIDYgaXMgZm9yIGNoYXJhY3RlcnMgdGhhdCBu ZWVkIHRvIGJlIFx1Tk5OTiBlbmNvZGVkLgogICAgIHNpemVfdCBtYXhpbXVtQ2FwYWNpdHlSZXF1 aXJlZCA9IGxlbmd0aCgpICsgMiArIHN0cmluZy5sZW5ndGgoKSAqIDY7CiAgICAgUkVMRUFTRV9B U1NFUlQobWF4aW11bUNhcGFjaXR5UmVxdWlyZWQgPCBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2ln bmVkPjo6bWF4KCkpOworICAgIHVuc2lnbmVkIG5ld0FsbG9jYXRpb25TaXplID0gbWF4aW11bUNh cGFjaXR5UmVxdWlyZWQ7CisgICAgLy8gVGhpcyBtYXgoKSBpcyBoZXJlIHRvIGFsbG93IHVzIHRv IGFsbG9jYXRlIHNpemVzIGJldHdlZW4gdGhlIHJhbmdlIFsyXjMxLCAyXjMyIC0gMl0gYmVjYXVz ZSByb3VuZFVwVG9Qb3dlck9mVHdvKDE8PDMxICsgc29tZSBpbnQgc21hbGxlciB0aGFuIDE8PDMx KSA9PSAwLgorICAgIG5ld0FsbG9jYXRpb25TaXplID0gc3RkOjptYXgobmV3QWxsb2NhdGlvblNp emUsIHJvdW5kVXBUb1Bvd2VyT2ZUd28obmV3QWxsb2NhdGlvblNpemUpKTsKIAogICAgIGlmIChp czhCaXQoKSAmJiAhc3RyaW5nLmlzOEJpdCgpKQotICAgICAgICBhbGxvY2F0ZUJ1ZmZlclVwQ29u dmVydChtX2J1ZmZlckNoYXJhY3RlcnM4LCByb3VuZFVwVG9Qb3dlck9mVHdvKG1heGltdW1DYXBh Y2l0eVJlcXVpcmVkKSk7CisgICAgICAgIGFsbG9jYXRlQnVmZmVyVXBDb252ZXJ0KG1fYnVmZmVy Q2hhcmFjdGVyczgsIG5ld0FsbG9jYXRpb25TaXplKTsKICAgICBlbHNlCi0gICAgICAgIHJlc2Vy dmVDYXBhY2l0eShyb3VuZFVwVG9Qb3dlck9mVHdvKG1heGltdW1DYXBhY2l0eVJlcXVpcmVkKSk7 CisgICAgICAgIHJlc2VydmVDYXBhY2l0eShuZXdBbGxvY2F0aW9uU2l6ZSk7CiAKICAgICBpZiAo aXM4Qml0KCkpIHsKICAgICAgICAgQVNTRVJUKHN0cmluZy5pczhCaXQoKSk7Cg== 279311 2016-05-18 16:19:55 -0700 2016-05-18 18:00:21 -0700 patch b-backup.diff text/plain 2365 saam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDExMTMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTE4ICBTYWFtIGJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OmFwcGVuZFF1b3RlZEpTT05T dHJpbmcgZG9lc24ndCBwcm9wZXJseSBwcm90ZWN0IGFnYWluc3QgdGhlIG1hdGggaXQncyBkb2lu Zy4gTWFrZSB0aGUgbWF0aCBmaXQgdGhlIGFzc2VydGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzg2OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFwcGVuZFF1b3RlZEpTT05TdHJpbmcgd2FzIHJv dW5kaW5nIHVwIHRvIHRoZSBuZXh0IHBvd2VyIG9mIHR3byB3aGVuIHJlc2l6aW5nCisgICAgICAg IGl0cyBidWZmZXIuIExldHMgY2FsbCB0aGUgYWxsb2NhdGlvbiBzaXplIFguIElmIFggPiAyXjMx LCB0aGVuCisgICAgICAgIHJvdW5kVXBUb1Bvd2VyT2ZUd28oWCkgPT0gMC4gVGhpcyBwYXRjaCBm aXhlcyB0aGlzIGJ5IG1ha2luZyB0aGUKKyAgICAgICAgYXNzZXJ0aW9uIHJlZmxlY3Qgd2hhdCB0 aGUgY29kZSBpcyBkb2luZy4gV2Ugbm93IGFsbG9jYXRlIHRvIGEgc2l6ZQorICAgICAgICBvZiBY ID0gc3RkOjptYXgobWF4aW11bUNhcGFjaXR5UmVxdWlyZWQgLCByb3VuZFVwVG9Qb3dlck9mVHdv KG1heGltdW1DYXBhY2l0eVJlcXVpcmVkKSkKKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0J1 aWxkZXIuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmdCdWlsZGVyOjphcHBlbmRRdW90ZWRKU09O U3RyaW5nKToKKwogMjAxNi0wNS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE5Mjg1NSk6IE1hdGgucmFuZG9tKCkgYWx3YXlz IHByb2R1Y2VzIHRoZSBzYW1lIGZpcnN0IDcgZGVjaW1hbCBwb2ludHMgdGhlIGZpcnN0IHR3byBp bnZvY2F0aW9ucwpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCShyZXZp c2lvbiAyMDExMTApCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00MTQsMTEgKzQxNCwxNCBAQCB2b2lkIFN0cmluZ0J1aWxkZXI6OmFw cGVuZFF1b3RlZEpTT05TdHJpCiAgICAgLy8gVGhlIDYgaXMgZm9yIGNoYXJhY3RlcnMgdGhhdCBu ZWVkIHRvIGJlIFx1Tk5OTiBlbmNvZGVkLgogICAgIHNpemVfdCBtYXhpbXVtQ2FwYWNpdHlSZXF1 aXJlZCA9IGxlbmd0aCgpICsgMiArIHN0cmluZy5sZW5ndGgoKSAqIDY7CiAgICAgUkVMRUFTRV9B U1NFUlQobWF4aW11bUNhcGFjaXR5UmVxdWlyZWQgPCBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2ln bmVkPjo6bWF4KCkpOworICAgIHVuc2lnbmVkIGFsbG9jYXRpb25TaXplID0gbWF4aW11bUNhcGFj aXR5UmVxdWlyZWQ7CisgICAgLy8gVGhpcyBtYXgoKSBpcyBoZXJlIHRvIGFsbG93IHVzIHRvIGFs bG9jYXRlIHNpemVzIGJldHdlZW4gdGhlIHJhbmdlIFsyXjMxLCAyXjMyIC0gMl0gYmVjYXVzZSBy b3VuZFVwVG9Qb3dlck9mVHdvKDE8PDMxICsgc29tZSBpbnQgc21hbGxlciB0aGFuIDE8PDMxKSA9 PSAwLgorICAgIGFsbG9jYXRpb25TaXplID0gc3RkOjptYXgoYWxsb2NhdGlvblNpemUsIHJvdW5k VXBUb1Bvd2VyT2ZUd28oYWxsb2NhdGlvblNpemUpKTsKIAogICAgIGlmIChpczhCaXQoKSAmJiAh c3RyaW5nLmlzOEJpdCgpKQotICAgICAgICBhbGxvY2F0ZUJ1ZmZlclVwQ29udmVydChtX2J1ZmZl ckNoYXJhY3RlcnM4LCByb3VuZFVwVG9Qb3dlck9mVHdvKG1heGltdW1DYXBhY2l0eVJlcXVpcmVk KSk7CisgICAgICAgIGFsbG9jYXRlQnVmZmVyVXBDb252ZXJ0KG1fYnVmZmVyQ2hhcmFjdGVyczgs IGFsbG9jYXRpb25TaXplKTsKICAgICBlbHNlCi0gICAgICAgIHJlc2VydmVDYXBhY2l0eShyb3Vu ZFVwVG9Qb3dlck9mVHdvKG1heGltdW1DYXBhY2l0eVJlcXVpcmVkKSk7CisgICAgICAgIHJlc2Vy dmVDYXBhY2l0eShhbGxvY2F0aW9uU2l6ZSk7CiAKICAgICBpZiAoaXM4Qml0KCkpIHsKICAgICAg ICAgQVNTRVJUKHN0cmluZy5pczhCaXQoKSk7Cg==