157862 2016-05-18 14:53:13 -0700 Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon 2016-05-18 16:01:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg buildbot commit-queue graouts joepeck mattbaker nvasilyev rniwa timothy webkit-bug-importer oldest_to_newest 1194427 0 mattbaker 2016-05-18 14:53:13 -0700 * SUMMARY Checkbox disappears when unchecking CSS property with value containing a semicolon. The regex used by CSSStyleDeclarationTextEditor to match commented properties fails to match the following forms: content: ";"; background: url(data:image/png;base64,…); 1194428 1 mattbaker 2016-05-18 14:53:30 -0700 <rdar://problem/16214480> 1194438 2 279293 mattbaker 2016-05-18 15:00:17 -0700 Created attachment 279293 [Patch] Proposed Fix 1194481 3 279293 buildbot 2016-05-18 16:00:49 -0700 Comment on attachment 279293 [Patch] Proposed Fix Attachment 279293 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1344773 New failing tests: storage/websql/open-database-over-quota.html 1194483 4 279293 commit-queue 2016-05-18 16:00:54 -0700 Comment on attachment 279293 [Patch] Proposed Fix Clearing flags on attachment: 279293 Committed r201111: <http://trac.webkit.org/changeset/201111> 1194484 5 commit-queue 2016-05-18 16:01:02 -0700 All reviewed patches have been landed. Closing bug. 279293 2016-05-18 15:00:17 -0700 2016-05-18 16:00:54 -0700 [Patch] Proposed Fix bug-157862-20160518150116.patch text/plain 1982 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj ZDk3MzZjMDAyMTQ2MThjNjBkNDI2OWFjZGM1Y2ZlOThkYjAwMDEzLi4xZjVkZTViOGI0YjU0MDE0 ZGIwMzVkYWVmODljNjE4MmE0YjhhZjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNi0wNS0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2hlY2tib3ggZGlzYXBwZWFycyB3aGVuIHVuY2hl Y2tpbmcgQ1NTIHByb3BlcnR5IHdpdGggdmFsdWUgY29udGFpbmluZyBhIHNlbWljb2xvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3ODYyCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xNjIxNDQ4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IucHJvdG90eXBlLl9jcmVhdGVDb21tZW50ZWRDaGVja2JveE1hcmtl cik6CisgICAgICAgIE1vZGlmeSByZWdleCB0byBtYXRjaCBDU1MgcHJvcGVydGllcyB3aXRoIHVy bCgpIGFuZCBxdW90ZWQgdmFsdWVzLAorICAgICAgICB3aGljaCBjYW4gY29udGFpbiBzZW1pY29s b25zLgorCisyMDE2LTA1LTE4ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIxOTc0ODgpOiBJbmNvcnJlY3Qgc3Rh cnQgdGltZSBpbiBSZW5kZXJpbmcgRnJhbWVzIHRpbWVsaW5lIGdyaWQKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzg0MAogICAgICAgICA8cmRhcjov L3Byb2JsZW0vMjYzNDQ5Mzc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25U ZXh0RWRpdG9yLmpzCmluZGV4IDU4M2ViMTg5OTM4ZDNmZDlmNjA5OGY1ODQ3YmE4NTk1YzVlM2Y2 YTAuLjc0NWUxMDI5MDQ0MzY0ZmMxNjg4N2ViMjA3ZTgxZDQwMTE5NmJiYjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFy YXRpb25UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCkBAIC04MzUsNyArODM1 LDcgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3Mg Q1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IKICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICAvLyBNYXRjaGVzIGEgY29tbWVudCBsaWtlOiAvKiAtd2Via2l0LWZvbzogYmFyOyAqLwot ICAgICAgICB2YXIgY29tbWVudGVkUHJvcGVydHlSZWdleCA9IC9cL1wqXHMqWy1cd10rXHMqOlxz KlteO10rOz9ccypcKlwvL2c7CisgICAgICAgIGxldCBjb21tZW50ZWRQcm9wZXJ0eVJlZ2V4ID0g L1wvXCpccypbLVx3XStccypcOlxzKig/Oig/OlwiLipcInx1cmxcKC4rXCl8W147XSlccyopKzs/ XHMqXCpcLy9nOwogCiAgICAgICAgIHZhciBtYXRjaCA9IGNvbW1lbnRlZFByb3BlcnR5UmVnZXgu ZXhlYyhsaW5lSGFuZGxlLnRleHQpOwogICAgICAgICBpZiAoIW1hdGNoKQo=