157859 2016-05-18 13:56:29 -0700 WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg) 2016-05-24 14:02:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned commit-queue eric.carlson oldest_to_newest 1194405 0 adam.bergkvist 2016-05-18 13:56:29 -0700 According to the latest spec [1]: - Attributes should be readonly - Constructor argument is mandatory [1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#rtcicecandidate-interface 1195909 1 279673 adam.bergkvist 2016-05-24 11:06:39 -0700 Created attachment 279673 Proposed patch 1196004 2 279673 adam.bergkvist 2016-05-24 13:40:36 -0700 Comment on attachment 279673 Proposed patch Thanks Eric! 1196019 3 279673 commit-queue 2016-05-24 14:02:44 -0700 Comment on attachment 279673 Proposed patch Clearing flags on attachment: 279673 Committed r201350: <http://trac.webkit.org/changeset/201350> 1196020 4 commit-queue 2016-05-24 14:02:48 -0700 All reviewed patches have been landed. Closing bug. 279673 2016-05-24 11:06:39 -0700 2016-05-24 14:02:44 -0700 Proposed patch update-rtcicecandidate_0.patch text/plain 6274 adam.bergkvist ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NDdmNDFlLi5hZDM0ZGJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDUt MjQgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgorCisgICAg ICAgIFdlYlJUQzogUlRDSWNlQ2FuZGlkYXRlOiBNYWtlIGF0dHJpYnV0ZXMgcmVhZG9ubHkgKGFu ZCB1cGRhdGUgY29uc3RydWN0b3IgYXJnKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU3ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRpZGF0ZS1leHBl Y3RlZC50eHQ6CisgICAgICAgIFNtYWxsIHVucmVsYXRlZCBmaXg6IHMvYSBhcmd1bWVudC9hbiBh cmd1bWVudC8gKHRlc3Qgd2FzIHByZXZpb3VzbHkgYnJva2VuKS4KKyAgICAgICAgKiBmYXN0L21l ZGlhc3RyZWFtL1JUQ0ljZUNhbmRpZGF0ZS5odG1sOgorICAgICAgICBUZXN0IHdpdGhvdXQgY29u c3RydWN0b3IgYXJndW1lbnRzIGFuZCB3cml0aW5nIHRvIHRoZSByZWFkLW9ubHkgYXR0cmlidXRl cy4KKwogMjAxNi0wNS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcgYWZ0ZXIgcjIwMTIzNyBleHBvc2Vk IGFuIGlzc3VlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENJ Y2VDYW5kaWRhdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9S VENJY2VDYW5kaWRhdGUtZXhwZWN0ZWQudHh0CmluZGV4IDk4YTAwNzEuLmU5ZWRiOGQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDSWNlQ2FuZGlkYXRlLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRpZGF0 ZS1leHBlY3RlZC50eHQKQEAgLTgsNiArOCwxNiBAQCBQQVNTIGNhbmRpZGF0ZS5jYW5kaWRhdGUg aXMgImZvbyIKIFBBU1MgY2FuZGlkYXRlLnNkcE1pZCBpcyAiYmFyIgogUEFTUyBjYW5kaWRhdGUu c2RwTUxpbmVJbmRleCBpcyA2CiAKK0F0dHJpYnV0ZXMgYXJlIHJlYWRvbmx5CitjYW5kaWRhdGUu Y2FuZGlkYXRlID0gImZvby11cGRhdGVkIgorUEFTUyBjYW5kaWRhdGUuY2FuZGlkYXRlIGlzICJm b28iCitjYW5kaWRhdGUuc2RwTWlkID0gImJhci11cGRhdGVkIgorUEFTUyBjYW5kaWRhdGUuc2Rw TWlkIGlzICJiYXIiCitjYW5kaWRhdGUuc2RwTUxpbmVJbmRleCA9IDcKK1BBU1MgY2FuZGlkYXRl LnNkcE1MaW5lSW5kZXggaXMgNgorCitEaWN0aW9uYXJ5IGFyZ3VtZW50IGlzIG1hbmRhdG9yeS4K K1BBU1MgbmV3IFJUQ0ljZUNhbmRpZGF0ZSgpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBO b3QgZW5vdWdoIGFyZ3VtZW50cy4KIERpY3Rpb25hcnkgbWVtYmVyICdjYW5kaWRhdGUnIGlzIHJl cXVpcmVkLgogUEFTUyBuZXcgUlRDSWNlQ2FuZGlkYXRlKHt9KTsgdGhyZXcgZXhjZXB0aW9uIFR5 cGVFcnJvcjogVHlwZSBlcnJvci4KIFBBU1MgbmV3IFJUQ0ljZUNhbmRpZGF0ZSh7c2RwTWlkOiJi YXIiLCBzZHBNTGluZUluZGV4OjZ9KTsgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVHlwZSBl cnJvci4KQEAgLTMxLDcgKzQxLDcgQEAgUEFTUyBuZXcgUlRDSWNlQ2FuZGlkYXRlKHtjYW5kaWRh dGU6ImZvbyIsIHNkcE1MaW5lSW5kZXg6LTF9KTsgdGhyZXcgZXhjZXB0aW9uIFQKIFBBU1MgbmV3 IFJUQ0ljZUNhbmRpZGF0ZSh7Y2FuZGlkYXRlOiJmb28iLCBzZHBNTGluZUluZGV4OjY1NTM2fSk7 IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFR5cGUgZXJyb3IuCiBQQVNTIG5ldyBSVENJY2VD YW5kaWRhdGUoNSk7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFR5cGUgZXJyb3IuCiBQQVNT IG5ldyBSVENJY2VDYW5kaWRhdGUoImZvb2JhciIpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9y OiBUeXBlIGVycm9yLgotUEFTUyBuZXcgUlRDSWNlQ2FuZGlkYXRlKGNhbmRpZGF0ZToiIik7IHRo cmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0b2tlbiAnOicuIEV4cGVjdGVk ICcpJyB0byBlbmQgYSBhcmd1bWVudCBsaXN0Li4KK1BBU1MgbmV3IFJUQ0ljZUNhbmRpZGF0ZShj YW5kaWRhdGU6IiIpOyB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgdG9r ZW4gJzonLiBFeHBlY3RlZCAnKScgdG8gZW5kIGFuIGFyZ3VtZW50IGxpc3QuLgogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRpZGF0ZS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9SVENJY2VDYW5kaWRhdGUuaHRtbAppbmRleCA0YzllMzg1Li5i Y2Q5OWIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ0ljZUNh bmRpZGF0ZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDSWNlQ2Fu ZGlkYXRlLmh0bWwKQEAgLTE1LDYgKzE1LDE4IEBACiAgICAgICAgICAgICBzaG91bGRCZSgnY2Fu ZGlkYXRlLnNkcE1MaW5lSW5kZXgnLCAnNicpOwogICAgICAgICAgICAgZGVidWcoIiIpOwogCisg ICAgICAgICAgICBkZWJ1ZygiQXR0cmlidXRlcyBhcmUgcmVhZG9ubHkiKTsKKyAgICAgICAgICAg IGV2YWxBbmRMb2coJ2NhbmRpZGF0ZS5jYW5kaWRhdGUgPSAiZm9vLXVwZGF0ZWQiJyk7CisgICAg ICAgICAgICBzaG91bGRCZSgnY2FuZGlkYXRlLmNhbmRpZGF0ZScsICciZm9vIicpOworICAgICAg ICAgICAgZXZhbEFuZExvZygnY2FuZGlkYXRlLnNkcE1pZCA9ICJiYXItdXBkYXRlZCInKTsKKyAg ICAgICAgICAgIHNob3VsZEJlKCdjYW5kaWRhdGUuc2RwTWlkJywgJyJiYXIiJyk7CisgICAgICAg ICAgICBldmFsQW5kTG9nKCdjYW5kaWRhdGUuc2RwTUxpbmVJbmRleCA9IDcnKTsKKyAgICAgICAg ICAgIHNob3VsZEJlKCdjYW5kaWRhdGUuc2RwTUxpbmVJbmRleCcsICc2Jyk7CisgICAgICAgICAg ICBkZWJ1ZygiIik7CisKKyAgICAgICAgICAgIGRlYnVnKCJEaWN0aW9uYXJ5IGFyZ3VtZW50IGlz IG1hbmRhdG9yeS4iKTsKKyAgICAgICAgICAgIHNob3VsZFRocm93KCduZXcgUlRDSWNlQ2FuZGlk YXRlKCk7Jyk7CisKICAgICAgICAgICAgIGRlYnVnKCJEaWN0aW9uYXJ5IG1lbWJlciAnY2FuZGlk YXRlJyBpcyByZXF1aXJlZC4iKTsKICAgICAgICAgICAgIHNob3VsZFRocm93KCduZXcgUlRDSWNl Q2FuZGlkYXRlKHt9KTsnKTsKICAgICAgICAgICAgIHNob3VsZFRocm93KCduZXcgUlRDSWNlQ2Fu ZGlkYXRlKHtzZHBNaWQ6ImJhciIsIHNkcE1MaW5lSW5kZXg6Nn0pOycpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGY0N2ViZTMuLmUyOWRmNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxNi0wNS0y NCAgQWRhbSBCZXJna3Zpc3QgIDxhZGFtLmJlcmdrdmlzdEBlcmljc3Nvbi5jb20+CisKKyAgICAg ICAgV2ViUlRDOiBSVENJY2VDYW5kaWRhdGU6IE1ha2UgYXR0cmlidXRlcyByZWFkb25seSAoYW5k IHVwZGF0ZSBjb25zdHJ1Y3RvciBhcmcpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIHRoZSBSVENJY2VDYW5kaWRhdGUgY29uc3RydWN0b3IgYXJn dW1lbnQgbWFuZGF0b3J5IGFuZCB0aGUgYXR0cmlidXRlcworICAgICAgICByZWFkLW9ubHkgKGlu IGFjY29yZGFuY2Ugd2l0aCB0aGUgV2ViUlRDIDEuMCBzcGVjaWZpY2F0aW9uIFsxXSkuCisKKyAg ICAgICAgWzFdIGh0dHBzOi8vdzNjLmdpdGh1Yi5pby93ZWJydGMtcGMvYXJjaGl2ZXMvMjAxNjA1 MTMvd2VicnRjLmh0bWwjcnRjaWNlY2FuZGlkYXRlLWludGVyZmFjZQorCisgICAgICAgIFVwZGF0 ZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDSWNl Q2FuZGlkYXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpSVENJY2VDYW5kaWRhdGU6OnNldENhbmRp ZGF0ZSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSVENJY2VDYW5kaWRhdGU6OnNldFNk cE1pZCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSVENJY2VDYW5kaWRhdGU6OnNldFNk cE1MaW5lSW5kZXgpOiBEZWxldGVkLgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRD SWNlQ2FuZGlkYXRlLmlkbDoKKwogMjAxNi0wNS0yMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeGVkIFVTRShBUFBMRV9JTlRFUk5BTF9TREspIGJ1aWxkcy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDSWNlQ2Fu ZGlkYXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRp ZGF0ZS5oCmluZGV4IGEyMjg0NzcuLjkzMGNiYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDSWNlQ2FuZGlkYXRlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENJY2VDYW5kaWRhdGUuaApAQCAtNTIsMTMgKzUyLDgg QEAgcHVibGljOgogICAgIHZpcnR1YWwgflJUQ0ljZUNhbmRpZGF0ZSgpIHsgfQogCiAgICAgY29u c3QgU3RyaW5nJiBjYW5kaWRhdGUoKSBjb25zdCB7IHJldHVybiBtX2NhbmRpZGF0ZTsgfQotICAg IHZvaWQgc2V0Q2FuZGlkYXRlKGNvbnN0IFN0cmluZyYgY2FuZGlkYXRlKSB7IG1fY2FuZGlkYXRl ID0gY2FuZGlkYXRlOyB9Ci0KICAgICBjb25zdCBTdHJpbmcmIHNkcE1pZCgpIGNvbnN0IHsgcmV0 dXJuIG1fc2RwTWlkOyB9Ci0gICAgdm9pZCBzZXRTZHBNaWQoY29uc3QgU3RyaW5nJiBzZHBNaWQp IHsgbV9zZHBNaWQgPSBzZHBNaWQ7IH0KLQogICAgIE9wdGlvbmFsPHVuc2lnbmVkIHNob3J0PiBz ZHBNTGluZUluZGV4KCkgY29uc3QgeyByZXR1cm4gbV9zZHBNTGluZUluZGV4OyB9Ci0gICAgdm9p ZCBzZXRTZHBNTGluZUluZGV4KE9wdGlvbmFsPHVuc2lnbmVkIHNob3J0PiBzZHBNTGluZUluZGV4 KSB7IG1fc2RwTUxpbmVJbmRleCA9IHNkcE1MaW5lSW5kZXg7IH0KIAogcHJpdmF0ZToKICAgICBl eHBsaWNpdCBSVENJY2VDYW5kaWRhdGUoY29uc3QgU3RyaW5nJiBjYW5kaWRhdGUsIGNvbnN0IFN0 cmluZyYgc2RwTWlkLCBPcHRpb25hbDx1bnNpZ25lZCBzaG9ydD4gc2RwTUxpbmVJbmRleCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRp ZGF0ZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0ljZUNhbmRp ZGF0ZS5pZGwKaW5kZXggYzU3ODk2Ni4uOTFiYTg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENJY2VDYW5kaWRhdGUuaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDSWNlQ2FuZGlkYXRlLmlkbApAQCAtMzEsMTEg KzMxLDExIEBACiAKIFsKICAgICBDb25kaXRpb25hbD1XRUJfUlRDLAotICAgIENvbnN0cnVjdG9y KG9wdGlvbmFsIERpY3Rpb25hcnkgZGljdGlvbmFyeSksCisgICAgQ29uc3RydWN0b3IoRGljdGlv bmFyeSBkaWN0aW9uYXJ5KSwKICAgICBDb25zdHJ1Y3RvclJhaXNlc0V4Y2VwdGlvbgogXSBpbnRl cmZhY2UgUlRDSWNlQ2FuZGlkYXRlIHsKLSAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNhbmRpZGF0 ZTsKLSAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nPyBzZHBNaWQ7Ci0gICAgYXR0cmlidXRlIHVuc2ln bmVkIHNob3J0PyBzZHBNTGluZUluZGV4OworICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJp bmcgY2FuZGlkYXRlOworICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmc/IHNkcE1pZDsK KyAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgc2hvcnQ/IHNkcE1MaW5lSW5kZXg7CiB9 OwogCg==