157850 2016-05-18 11:18:40 -0700 Web Inspector: race between frontend and backend both starting timeline recordings causes console assert 2016-05-18 12:28:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1194328 0 bburg 2016-05-18 11:18:40 -0700 This is mostly harmless but now that I understand it, might as well fix it until we clean up TimelineManager. 1194329 1 webkit-bug-importer 2016-05-18 11:20:07 -0700 <rdar://problem/26349229> 1194346 2 279267 bburg 2016-05-18 11:59:31 -0700 Created attachment 279267 Proposed Fix I tested auto-capturing on new navigations, which still works. I also tested that there is no longer an assert when Automation.inspectBrowsingContext starts profiling via InspectorFrontendAPI.togglePageProfiling. 1194350 3 279267 joepeck 2016-05-18 12:04:53 -0700 Comment on attachment 279267 Proposed Fix r=me 1194368 4 279267 commit-queue 2016-05-18 12:28:16 -0700 Comment on attachment 279267 Proposed Fix Clearing flags on attachment: 279267 Committed r201092: <http://trac.webkit.org/changeset/201092> 1194369 5 commit-queue 2016-05-18 12:28:21 -0700 All reviewed patches have been landed. Closing bug. 279267 2016-05-18 11:59:31 -0700 2016-05-18 12:28:16 -0700 Proposed Fix bug-157850-20160518120029.patch text/plain 4101 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 NDY0OGIzNDAxYzYwZmIzYTc0ZjJjZjA1OGU0MWZkNDkxN2EyZDNkLi4xMmMwNGI1NzBhYjRjMWU5 YWIzNWVlYmEwNzYwODUyMjMyYmFmYjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxNi0wNS0xOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiByYWNlIGJldHdlZW4gZnJvbnRlbmQgYW5kIGJhY2tlbmQg Ym90aCBzdGFydGluZyB0aW1lbGluZSByZWNvcmRpbmdzIGNhdXNlcyBjb25zb2xlIGFzc2VydAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3ODUwCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjM0OTIyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBUaW1lbGluZU1hbmFnZXIgaGFzIGNyZWF0ZWQg YSBmcmVzaCByZWNvcmRpbmcgYW5kIHRoZSBUaW1lbGluZS5hdXRvQ2FwdHVyZVN0YXJ0ZWQKKyAg ICAgICAgZXZlbnQgY29tZXMgYmVmb3JlIFRpbWVsaW5lLnJlY29yZGluZ1N0YXJ0ZWQsIHRoZW4g dGhlIG1hbmFnZXIgd2lsbCB0cnkgdG8gc3RhcnQgdGhlCisgICAgICAgIHNhbWUgcmVjb3JkaW5n IHR3aWNlLiBJbiB0aGlzIHNjZW5hcmlvLCB0aGUgbWFuYWdlciBzaG91bGQganVzdCB3YWl0IHVu dGlsIHRoZQorICAgICAgICBUaW1lbGluZS5yZWNvcmRpbmdTdGFydGVkIGV2ZW50IGNvbWVzLCBz aW5jZSBpdCBjYXVzZXMgVGltZWxpbmVNYW5nYXJlIHRvIHNldCB1cAorICAgICAgICB0aGUgaXND YXB0dXJpbmcgZmxhZyBhbmQgb3RoZXIgc3RhdGUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZU1hbmFnZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5w cm90b3R5cGUuc3RhcnRDYXB0dXJpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l TWFuYWdlci5wcm90b3R5cGUuY2FwdHVyaW5nU3RhcnRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGltZWxpbmVNYW5hZ2VyLnByb3RvdHlwZS5hdXRvQ2FwdHVyZVN0YXJ0ZWQpOgorICAgICAg ICBBZGQgYSBuZXcgZmxhZywgdGhpcy5fd2FpdGluZ0ZvckNhcHR1cmluZ1N0YXJ0ZWRFdmVudC4g SWYgdHJ1ZSwgZG9uJ3Qgc3RhcnQgdGhlCisgICAgICAgIHJlY29yZGluZyBpbiByZXNwb25zZSB0 byB0aGlzIGV2ZW50LgorCisyMDE2LTA1LTE4ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29t PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluc3BlY3RvckZyb250ZW5kQVBJLnNldFRpbWVs aW5lUHJvZmlsaW5nRW5hYmxlZCBzaG91bGQgbm90IGltcGxpY2l0bHkgc2hvdyBUaW1lbGluZXMg dGFiCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc4 NDYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IGZkNDBhOGEyMTEz ZjEwZmM5ZWViODRjYjMwMGUyOTJhYTk4NDYxY2UuLjM2NDI4NjM5NDAxODliMTViYzUyM2E5MTNi OWE0MzI5YjI1NjI5MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAg LTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEzIEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMywgMjAxNiBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTQy LDYgKzQyLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVsaW5l TWFuYWdlciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgdGhpcy5fcGVyc2lz dGVudE5ldHdvcmtUaW1lbGluZSA9IG5ldyBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lOwog CiAgICAgICAgIHRoaXMuX2lzQ2FwdHVyaW5nID0gZmFsc2U7CisgICAgICAgIHRoaXMuX3dhaXRp bmdGb3JDYXB0dXJpbmdTdGFydGVkRXZlbnQgPSBmYWxzZTsKICAgICAgICAgdGhpcy5faXNDYXB0 dXJpbmdQYWdlUmVsb2FkID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2F1dG9DYXB0dXJlT25QYWdl TG9hZCA9IGZhbHNlOwogICAgICAgICB0aGlzLl9tYWluUmVzb3VyY2VGb3JBdXRvQ2FwdHVyaW5n ID0gbnVsbDsKQEAgLTE3MCw2ICsxNzEsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2Vy ID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICBpZiAoIXRoaXMuX2FjdGl2ZVJlY29yZGluZyB8fCBzaG91bGRDcmVhdGVSZWNvcmRpbmcp CiAgICAgICAgICAgICB0aGlzLl9sb2FkTmV3UmVjb3JkaW5nKCk7CiAKKyAgICAgICAgdGhpcy5f d2FpdGluZ0ZvckNhcHR1cmluZ1N0YXJ0ZWRFdmVudCA9IHRydWU7CisKICAgICAgICAgdGhpcy5k aXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5FdmVu dC5DYXB0dXJpbmdXaWxsU3RhcnQpOwogCiAgICAgICAgIHRoaXMuX2FjdGl2ZVJlY29yZGluZy5z dGFydCgpOwpAQCAtMjIxLDYgKzIyNCw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIg PSBjbGFzcyBUaW1lbGluZU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAg ICAgIGlmICh0aGlzLl9pc0NhcHR1cmluZykKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAg ICB0aGlzLl93YWl0aW5nRm9yQ2FwdHVyaW5nU3RhcnRlZEV2ZW50ID0gZmFsc2U7CiAgICAgICAg IHRoaXMuX2lzQ2FwdHVyaW5nID0gdHJ1ZTsKIAogICAgICAgICB0aGlzLl9sYXN0RGVhZFRpbWVU aWNrbGUgPSAwOwpAQCAtMjY1LDcgKzI2OSwxMSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5h Z2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAog ICAgICAgICBpZiAodGhpcy5faXNDYXB0dXJpbmcpCiAgICAgICAgICAgICB0aGlzLnN0b3BDYXB0 dXJpbmcoKTsKIAotICAgICAgICB0aGlzLnN0YXJ0Q2FwdHVyaW5nKHRydWUpOworICAgICAgICAv LyBXZSBtYXkgYWxyZWFkeSBoYXZlIGFuIGZyZXNoIFRpbWVsaW5lUmVjb3JkaW5nIGNyZWF0ZWQg aWYgYXV0b0NhcHR1cmVTdGFydGVkIGlzIHJlY2VpdmVkCisgICAgICAgIC8vIGJldHdlZW4gc2Vu ZGluZyB0aGUgVGltZWxpbmUuc3RhcnQgY29tbWFuZCBhbmQgcmVjZWl2aW5nIFRpbWVsaW5lLmNh cHR1cmluZ1N0YXJ0ZWQgZXZlbnQuCisgICAgICAgIC8vIEluIHRoYXQgY2FzZSwgdGhlcmUgaXMg bm8gbmVlZCB0byBjYWxsIHN0YXJ0Q2FwdHVyaW5nIGFnYWluLiBSZXVzZSB0aGUgZnJlc2ggcmVj b3JkaW5nLgorICAgICAgICBpZiAoIXRoaXMuX3dhaXRpbmdGb3JDYXB0dXJpbmdTdGFydGVkRXZl bnQpCisgICAgICAgICAgICB0aGlzLnN0YXJ0Q2FwdHVyaW5nKHRydWUpOwogCiAgICAgICAgIHRo aXMuX3Nob3VsZFNldEF1dG9DYXB0dXJpbmdNYWluUmVzb3VyY2UgPSB0cnVlOwogICAgIH0K