157844 2016-05-18 09:27:21 -0700 Allow RenderStyles marked unique in matched properties cache 2016-05-18 11:33:45 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned webkit-bug-importer oldest_to_newest 1194291 0 koivisto 2016-05-18 09:27:21 -0700 This can improve hit rate considerably. 1194320 1 279262 koivisto 2016-05-18 10:43:47 -0700 Created attachment 279262 patch 1194326 2 279262 kling 2016-05-18 11:13:47 -0700 Comment on attachment 279262 patch View in context: https://bugs.webkit.org/attachment.cgi?id=279262&action=review r=me We should rename RenderStyle's "unique" flag to reflect that it's all about preventing style sharing. Separately. > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:230 > + unsigned m_hasAttrContent : 1; initializers for bitfields when 1194334 3 koivisto 2016-05-18 11:32:31 -0700 http://trac.webkit.org/changeset/201086 1194335 4 webkit-bug-importer 2016-05-18 11:33:45 -0700 <rdar://problem/26349642> 279262 2016-05-18 10:43:47 -0700 2016-05-18 11:13:47 -0700 patch matched-properties-cached-allow-unique.patch text/plain 6938 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTA4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQxIEBACisyMDE2LTA1LTE4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyBSZW5kZXJTdHlsZXMg bWFya2VkIHVuaXF1ZSBpbiBtYXRjaGVkIHByb3BlcnRpZXMgY2FjaGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzg0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlcGVuZGluZyBvbiBjb250ZW50IHRo aXMgY2FuIGltcHJvdmUgbWF0Y2hlZCBwcm9wZXJ0aWVzIGNhY2hlIGhpdCByYXRlIHF1aXRlIGEg Yml0IGFuZCBzbyByZWR1Y2UKKyAgICAgICAgdGltZSBzcGVudCBidWlsZGluZyBzdHlsZXMuCisK KyAgICAgICAgKiBjc3MvU3R5bGVCdWlsZGVyQ3VzdG9tLmg6CisgICAgICAgIChXZWJDb3JlOjpT dHlsZUJ1aWxkZXJDdXN0b206OmFwcGx5VmFsdWVDb250ZW50KToKKworICAgICAgICAgICAgU2V0 IHRoZSBhdHRyIGJpdCBvbiByZW5kZXIgc3R5bGUuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNv bHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0NhY2hlYWJsZUluTWF0Y2hlZFByb3BlcnRp ZXNDYWNoZSk6CisKKyAgICAgICAgICAgIEFsbG93IGNhY2hpbmcgb2Ygc3R5bGVzIG1hcmtlZCAi dW5pcXVlIi4gSXQgb25seSBtZWFucyB0aGF0IHRoZXkgYXJlIG5vdCBzaGFyZWFibGUgYnkgc3R5 bGUKKyAgICAgICAgICAgIHNoYXJpbmcgY29kZSBiZWNhdXNlIHRoZXJlIHdlcmUgc29tZSBjb21w bGV4IHNlbGVjdG9ycyBpbiB0aGUgcnVsZXMgdXNlZCBmb3IgYnVpbGRpbmcgdGhlbS4gSXQKKyAg ICAgICAgICAgIGRvZXNuJ3QgYWZmZWN0IG1hdGNoZWQgcHJvcGVydGllcyBjYWNoZSB0aGUgY2Fj aGUgaG93IHRoZSBwcm9wZXJ0aWVzIHdlcmUgcmVzb2x2ZWQuCisKKyAgICAgICAgICAgIFdlIHN0 aWxsIG5lZWQgdG8gdGVzdCBhZ2FpbnN0ICJjb250ZW50OiBhdHRyKCkiIGFzIHRoYXQgbWFrZXMg dGhlIHN0eWxlIGRlcGVuZCBvbiB0aGUgZWxlbWVudAorICAgICAgICAgICAgYmVpbmcgbWF0Y2hl ZC4gSXQgbm93IGhhcyBhIHNlcGFyYXRlIGJpdCBpbiBSZW5kZXJTdHlsZS4KKworICAgICAgICAq IHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJTdHlsZTo6c2V0SGFzQXR0ckNvbnRlbnQpOgorCisgICAgICAgICAgICBCaXQgZm9yICJjb250 ZW50OiBhdHRyKCkiLiBJdCBhbHNvIHNldHMgdW5pcXVlKCkgdG8ga2VlcCBzdHlsZSBzaGFyaW5n IGNvZGUgaGFwcHkuCisKKyAgICAgICAgKFdlYkNvcmU6OnJlcXVpcmVUcmFuc2Zvcm1PcmlnaW4p OgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyU3R5bGU6Omhhc0F0dHJDb250ZW50KToKKyAgICAgICAgKiByZW5kZXJpbmcv c3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT dHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKToKKyAg ICAgICAgKFdlYkNvcmU6OlN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE6Om9wZXJhdG9yPT0pOgor ICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmg6CisK IDIwMTYtMDUtMTggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4K IAogICAgICAgICBTeW5jIERPTSBleGNlcHRpb24gdHlwZXMgd2l0aCBXZWJJREwgYW5kIHVwZGF0 ZSBwcm9taXNlIHJlamVjdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxk ZXJDdXN0b20uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVCdWlsZGVy Q3VzdG9tLmgJKHJldmlzaW9uIDIwMTA3MikKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1 aWxkZXJDdXN0b20uaAkod29ya2luZyBjb3B5KQpAQCAtMTMzNSw5ICsxMzM1LDkgQEAgaW5saW5l IHZvaWQgU3R5bGVCdWlsZGVyQ3VzdG9tOjphcHBseVZhbAogICAgICAgICB9IGVsc2UgaWYgKGNv bnRlbnRWYWx1ZS5pc0F0dHIoKSkgewogICAgICAgICAgICAgLy8gRklYTUU6IENhbiBhIG5hbWVz cGFjZSBiZSBzcGVjaWZpZWQgZm9yIGFuIGF0dHIoZm9vKT8KICAgICAgICAgICAgIGlmIChzdHls ZVJlc29sdmVyLnN0eWxlKCktPnN0eWxlVHlwZSgpID09IE5PUFNFVURPKQotICAgICAgICAgICAg ICAgIHN0eWxlUmVzb2x2ZXIuc3R5bGUoKS0+c2V0VW5pcXVlKCk7CisgICAgICAgICAgICAgICAg c3R5bGVSZXNvbHZlci5zdHlsZSgpLT5zZXRIYXNBdHRyQ29udGVudCgpOwogICAgICAgICAgICAg ZWxzZQotICAgICAgICAgICAgICAgIGNvbnN0X2Nhc3Q8UmVuZGVyU3R5bGUqPihzdHlsZVJlc29s dmVyLnBhcmVudFN0eWxlKCkpLT5zZXRVbmlxdWUoKTsKKyAgICAgICAgICAgICAgICBjb25zdF9j YXN0PFJlbmRlclN0eWxlKj4oc3R5bGVSZXNvbHZlci5wYXJlbnRTdHlsZSgpKS0+c2V0SGFzQXR0 ckNvbnRlbnQoKTsKICAgICAgICAgICAgIFF1YWxpZmllZE5hbWUgYXR0cihudWxsQXRvbSwgY29u dGVudFZhbHVlLmdldFN0cmluZ1ZhbHVlKCkuaW1wbCgpLCBudWxsQXRvbSk7CiAgICAgICAgICAg ICBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlID0gc3R5bGVSZXNvbHZlci5lbGVtZW50KCktPmdl dEF0dHJpYnV0ZShhdHRyKTsKICAgICAgICAgICAgIHN0eWxlUmVzb2x2ZXIuc3R5bGUoKS0+c2V0 Q29udGVudCh2YWx1ZS5pc051bGwoKSA/IGVtcHR5QXRvbSA6IHZhbHVlLmltcGwoKSwgZGlkU2V0 KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJKHJldmlzaW9uIDIwMTA3 NSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTI0NSw3ICsxMjQ1LDggQEAgc3RhdGljIGJvb2wgaXNDYWNoZWFibGVJbk1hdGNoZWRQ cm9wZXJ0aQogICAgIC8vIERvY3VtZW50OjpzZXRXcml0aW5nTW9kZS9EaXJlY3Rpb25TZXRPbkRv Y3VtZW50RWxlbWVudC4gV2UgY2FuJ3Qgc2tpcCB0aGUgYXBwbHlpbmcgYnkgY2FjaGluZy4KICAg ICBpZiAoJmVsZW1lbnQgPT0gZWxlbWVudC5kb2N1bWVudCgpLmRvY3VtZW50RWxlbWVudCgpKQog ICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgaWYgKHN0eWxlLT51bmlxdWUoKSB8fCAoc3R5bGUt PnN0eWxlVHlwZSgpICE9IE5PUFNFVURPICYmIHBhcmVudFN0eWxlLT51bmlxdWUoKSkpCisgICAg Ly8gY29udGVudDphdHRyKCkgdmFsdWUgZGVwZW5kcyBvbiB0aGUgZWxlbWVudCBpdCBpcyBiZWlu ZyBhcHBsaWVkIHRvLgorICAgIGlmIChzdHlsZS0+aGFzQXR0ckNvbnRlbnQoKSB8fCAoc3R5bGUt PnN0eWxlVHlwZSgpICE9IE5PUFNFVURPICYmIHBhcmVudFN0eWxlLT5oYXNBdHRyQ29udGVudCgp KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmIChzdHlsZS0+aGFzQXBwZWFyYW5jZSgp KQogICAgICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUmVuZGVyU3R5bGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAJKHJldmlzaW9uIDIwMTA3MikKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEwNzMsNiArMTA3MywxMiBAQCBjb25zdCBTdHJpbmcmIFJlbmRlclN0eWxlOjpjb250ZW50QWx0 VGV4CiAgICAgcmV0dXJuIHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX2FsdFRleHQ7CiB9CiAKK3Zv aWQgUmVuZGVyU3R5bGU6OnNldEhhc0F0dHJDb250ZW50KCkKK3sKKyAgICBzZXRVbmlxdWUoKTsK KyAgICBTRVRfVkFSKHJhcmVOb25Jbmhlcml0ZWREYXRhLCBtX2hhc0F0dHJDb250ZW50LCB0cnVl KTsKK30KKwogLy8gRklYTUU6IHVzZSBhZmZlY3RlZEJ5VHJhbnNmb3JtT3JpZ2luKCkuCiBzdGF0 aWMgaW5saW5lIGJvb2wgcmVxdWlyZVRyYW5zZm9ybU9yaWdpbihjb25zdCBWZWN0b3I8UmVmUHRy PFRyYW5zZm9ybU9wZXJhdGlvbj4+JiB0cmFuc2Zvcm1PcGVyYXRpb25zLCBSZW5kZXJTdHlsZTo6 QXBwbHlUcmFuc2Zvcm1PcmlnaW4gYXBwbHlPcmlnaW4pCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkocmV2aXNpb24gMjAxMDcyKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTE4MzQsNiArMTgzNCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldENvbnRlbnQoUXVv dGVUeXBlLCBib29sIGFkZCA9IGZhbHNlKTsKICAgICB2b2lkIHNldENvbnRlbnRBbHRUZXh0KGNv bnN0IFN0cmluZyYpOwogICAgIGNvbnN0IFN0cmluZyYgY29udGVudEFsdFRleHQoKSBjb25zdDsK KyAgICBib29sIGhhc0F0dHJDb250ZW50KCkgY29uc3QgeyByZXR1cm4gcmFyZU5vbkluaGVyaXRl ZERhdGEtPm1faGFzQXR0ckNvbnRlbnQ7IH0KKyAgICB2b2lkIHNldEhhc0F0dHJDb250ZW50KCk7 CiAKICAgICBjb25zdCBDb3VudGVyRGlyZWN0aXZlTWFwKiBjb3VudGVyRGlyZWN0aXZlcygpIGNv bnN0OwogICAgIENvdW50ZXJEaXJlY3RpdmVNYXAmIGFjY2Vzc0NvdW50ZXJEaXJlY3RpdmVzKCk7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJp dGVkRGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuY3BwCShyZXZpc2lvbiAyMDEwNzIpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksNyBAQCBTdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhOjpTdHlsZVJhcmVOb25JCiAgICAgLCBtX2JyZWFrQWZ0ZXIoUmVuZGVyU3R5bGU6OmluaXRp YWxCcmVha0JldHdlZW4oKSkKICAgICAsIG1fYnJlYWtJbnNpZGUoUmVuZGVyU3R5bGU6OmluaXRp YWxCcmVha0luc2lkZSgpKQogICAgICwgbV9yZXNpemUoUmVuZGVyU3R5bGU6OmluaXRpYWxSZXNp emUoKSkKKyAgICAsIG1faGFzQXR0ckNvbnRlbnQoZmFsc2UpCiAgICAgLCBtX2lzUGxhY2Vob2xk ZXJTdHlsZShmYWxzZSkKIHsKICAgICBtX21hc2tCb3hJbWFnZS5zZXRNYXNrRGVmYXVsdHMoKTsK QEAgLTIwNCw2ICsyMDUsNyBAQCBpbmxpbmUgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5 bGVSCiAgICAgLCBtX2JyZWFrQWZ0ZXIoby5tX2JyZWFrQWZ0ZXIpCiAgICAgLCBtX2JyZWFrSW5z aWRlKG8ubV9icmVha0luc2lkZSkKICAgICAsIG1fcmVzaXplKG8ubV9yZXNpemUpCisgICAgLCBt X2hhc0F0dHJDb250ZW50KG8ubV9oYXNBdHRyQ29udGVudCkKICAgICAsIG1faXNQbGFjZWhvbGRl clN0eWxlKG8ubV9pc1BsYWNlaG9sZGVyU3R5bGUpCiB7CiB9CkBAIC0zMTAsNiArMzEyLDcgQEAg Ym9vbCBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpvcGVyYXRvcgogICAgICAgICAmJiBtX2Jy ZWFrQmVmb3JlID09IG8ubV9icmVha0JlZm9yZQogICAgICAgICAmJiBtX2JyZWFrSW5zaWRlID09 IG8ubV9icmVha0luc2lkZQogICAgICAgICAmJiBtX3Jlc2l6ZSA9PSBvLm1fcmVzaXplCisgICAg ICAgICYmIG1faGFzQXR0ckNvbnRlbnQgPT0gby5tX2hhc0F0dHJDb250ZW50CiAgICAgICAgICYm IG1faXNQbGFjZWhvbGRlclN0eWxlID09IG8ubV9pc1BsYWNlaG9sZGVyU3R5bGU7CiB9CiAKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxl UmFyZU5vbkluaGVyaXRlZERhdGEuaAkocmV2aXNpb24gMjAxMDcyKQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAkod29ya2luZyBj b3B5KQpAQCAtMjI3LDYgKzIyNyw4IEBAIHB1YmxpYzoKICAgICB1bnNpZ25lZCBtX2JyZWFrSW5z aWRlIDogMzsgLy8gQnJlYWtJbnNpZGUKICAgICB1bnNpZ25lZCBtX3Jlc2l6ZSA6IDI7IC8vIEVS ZXNpemUKIAorICAgIHVuc2lnbmVkIG1faGFzQXR0ckNvbnRlbnQgOiAxOworCiAgICAgdW5zaWdu ZWQgbV9pc1BsYWNlaG9sZGVyU3R5bGUgOiAxOwogCiBwcml2YXRlOgo=