157840 2016-05-18 08:06:53 -0700 Web Inspector: REGRESSION(r197488): Incorrect start time in Rendering Frames timeline grid 2016-05-18 09:32:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1194262 0 mattbaker 2016-05-18 08:06:53 -0700 This broke during the Timeline UI redesign: https://trac.webkit.org/changeset/197488. 1194263 1 webkit-bug-importer 2016-05-18 08:07:13 -0700 <rdar://problem/26344937> 1194264 2 279250 mattbaker 2016-05-18 08:14:31 -0700 Created attachment 279250 [Patch] Proposed Fix 1194284 3 279250 bburg 2016-05-18 09:11:32 -0700 Comment on attachment 279250 [Patch] Proposed Fix r=bburg 1194296 4 279250 commit-queue 2016-05-18 09:32:20 -0700 Comment on attachment 279250 [Patch] Proposed Fix Clearing flags on attachment: 279250 Committed r201082: <http://trac.webkit.org/changeset/201082> 1194297 5 commit-queue 2016-05-18 09:32:25 -0700 All reviewed patches have been landed. Closing bug. 279250 2016-05-18 08:14:31 -0700 2016-05-18 09:32:20 -0700 [Patch] Proposed Fix bug-157840-20160518081530.patch text/plain 3347 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MWQ3ODcxNzA0NDJlYjdlNDRkMDVlZWE2OGIzMzQ4YWIxYjNhMzg2Li5iZjYxMTY2ZTgzNDQ0MzFm MjhmN2UxZmVlYTEzZTI3ZmZlN2U2ZTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wNS0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMTk3NDg4KTogSW5jb3JyZWN0 IHN0YXJ0IHRpbWUgaW4gUmVuZGVyaW5nIEZyYW1lcyB0aW1lbGluZSBncmlkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc4NDAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzI2MzQ0OTM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0Nv bnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29u dGVudFZpZXcucHJvdG90eXBlLl91cGRhdGVUaW1lcyk6CisgICAgICAgIFRoZSBSZW5kZXJpbmcg RnJhbWVzIHRpbWVsaW5lIHZpZXcgbmVlZHMgYSB2YWxpZCB6ZXJvIHRpbWUuCisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3RpbWVS YW5nZVNlbGVjdGlvbkNoYW5nZWQpOgorICAgICAgICBBZGp1c3QgcnVsZXIgc2VsZWN0aW9uIHBh dGggY29tcG9uZW50IHZhbHVlcyBieSB0aGUgemVybyB0aW1lIHVubGVzcworICAgICAgICB0aGUg Y3VycmVudCB2aWV3IGlzIHRoZSBSZW5kZXJpbmcgRnJhbWVzIHRpbWVsaW5lIHZpZXcuCisKIDIw MTYtMDUtMTcgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgc2hvdWxkIGNvb3JkaW5hdGUgaXRl bSBzZWxlY3Rpb24gYmV0d2VlbiBpdHMgdHJlZSBvdXRsaW5lcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rp bWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggZmYwMmE2OWMxNzZlMzEwNTYyYzdk NDg0Yzk0ODhkNWM3YWE2YTdmYS4uYjQwNGU1ZmM5MTA0MDIzMTUwYjUxMDI2ZjE3Zjg3YTE2ZDQz NjNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3Lmpz CkBAIC0zNzUsMTIgKzM3NSw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyBlCiAgICAgICAgIGlm ICh0aGlzLl9zdGFydFRpbWVOZWVkc1Jlc2V0ICYmICFpc05hTihzdGFydFRpbWUpKSB7CiAgICAg ICAgICAgICB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LnN0YXJ0VGltZSA9IHN0YXJ0VGltZTsKICAg ICAgICAgICAgIHRoaXMuX292ZXJ2aWV3VGltZWxpbmVWaWV3Lnplcm9UaW1lID0gc3RhcnRUaW1l OwotICAgICAgICAgICAgZm9yICh2YXIgdGltZWxpbmVWaWV3IG9mIHRoaXMuX3RpbWVsaW5lVmll d01hcC52YWx1ZXMoKSkgewotICAgICAgICAgICAgICAgIGlmICh0aW1lbGluZVZpZXcucmVwcmVz ZW50ZWRPYmplY3QudHlwZSA9PT0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkLlR5cGUuUmVu ZGVyaW5nRnJhbWUpCi0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotCisgICAgICAgICAg ICBmb3IgKGxldCB0aW1lbGluZVZpZXcgb2YgdGhpcy5fdGltZWxpbmVWaWV3TWFwLnZhbHVlcygp KQogICAgICAgICAgICAgICAgIHRpbWVsaW5lVmlldy56ZXJvVGltZSA9IHN0YXJ0VGltZTsKLSAg ICAgICAgICAgIH0KIAogICAgICAgICAgICAgdGhpcy5fc3RhcnRUaW1lTmVlZHNSZXNldCA9IGZh bHNlOwogICAgICAgICB9CkBAIC02MTUsOCArNjExLDEzIEBAIFdlYkluc3BlY3Rvci5UaW1lbGlu ZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmll dyBlCiAgICAgICAgICAgICBzZWxlY3RlZFBhdGhDb21wb25lbnQgPSB0aGlzLl9lbnRpcmVSZWNv cmRpbmdQYXRoQ29tcG9uZW50OwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIGxldCB0aW1l bGluZVJhbmdlID0gdGhpcy5fdGltZWxpbmVTZWxlY3Rpb25QYXRoQ29tcG9uZW50LnJlcHJlc2Vu dGVkT2JqZWN0OwotICAgICAgICAgICAgdGltZWxpbmVSYW5nZS5zdGFydFZhbHVlID0gdGhpcy5j dXJyZW50VGltZWxpbmVWaWV3LnN0YXJ0VGltZSAtIHRoaXMuY3VycmVudFRpbWVsaW5lVmlldy56 ZXJvVGltZTsKLSAgICAgICAgICAgIHRpbWVsaW5lUmFuZ2UuZW5kVmFsdWUgPSB0aGlzLmN1cnJl bnRUaW1lbGluZVZpZXcuZW5kVGltZSAtIHRoaXMuY3VycmVudFRpbWVsaW5lVmlldy56ZXJvVGlt ZTsKKyAgICAgICAgICAgIHRpbWVsaW5lUmFuZ2Uuc3RhcnRWYWx1ZSA9IHRoaXMuY3VycmVudFRp bWVsaW5lVmlldy5zdGFydFRpbWU7CisgICAgICAgICAgICB0aW1lbGluZVJhbmdlLmVuZFZhbHVl ID0gdGhpcy5jdXJyZW50VGltZWxpbmVWaWV3LmVuZFRpbWU7CisKKyAgICAgICAgICAgIGlmICgh KHRoaXMuY3VycmVudFRpbWVsaW5lVmlldyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5SZW5kZXJp bmdGcmFtZVRpbWVsaW5lVmlldykpIHsKKyAgICAgICAgICAgICAgICB0aW1lbGluZVJhbmdlLnN0 YXJ0VmFsdWUgLT0gdGhpcy5jdXJyZW50VGltZWxpbmVWaWV3Lnplcm9UaW1lOworICAgICAgICAg ICAgICAgIHRpbWVsaW5lUmFuZ2UuZW5kVmFsdWUgLT0gdGhpcy5jdXJyZW50VGltZWxpbmVWaWV3 Lnplcm9UaW1lOworICAgICAgICAgICAgfQogCiAgICAgICAgICAgICB0aGlzLl91cGRhdGVUaW1l UmFuZ2VQYXRoQ29tcG9uZW50cygpOwogICAgICAgICAgICAgc2VsZWN0ZWRQYXRoQ29tcG9uZW50 ID0gdGhpcy5fdGltZWxpbmVTZWxlY3Rpb25QYXRoQ29tcG9uZW50Owo=