157836 2016-05-18 06:35:38 -0700 Resolve !important properties from different shadow trees in a single pass. 2016-05-18 07:33:18 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned kling rniwa oldest_to_newest 1194235 0 koivisto 2016-05-18 06:35:38 -0700 Currently we do multiple passes. 1194241 1 279245 koivisto 2016-05-18 06:53:16 -0700 Created attachment 279245 patch 1194243 2 279245 kling 2016-05-18 07:13:16 -0700 Comment on attachment 279245 patch r=me, fine. 1194247 3 koivisto 2016-05-18 07:33:18 -0700 https://trac.webkit.org/r201075 279245 2016-05-18 06:53:16 -0700 2016-05-18 07:13:16 -0700 patch tree-context-ordinal-single-pass.patch text/plain 3363 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTA3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTE4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXNvbHZlICFpbXBvcnRhbnQg cHJvcGVydGllcyBmcm9tIGRpZmZlcmVudCBzaGFkb3cgdHJlZXMgaW4gYSBzaW5nbGUgcGFzcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzgzNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6Q2FzY2Fk ZWRQcm9wZXJ0aWVzOjphZGRJbXBvcnRhbnRNYXRjaGVzKToKKworICAgICAgICBJbnN0ZWFkIG9m IGRvaW5nIG11bHRpcGxlIHBhc3NlcyBvdmVyIGluY3JlYXNpbmcgdHJlZUNvbnRleHRPcmRpbmFs cyBjb2xsZWN0IG1hdGNoZXMgd2l0aAorICAgICAgICBub24temVybyBvcmRpbmFscyB0byBhIHZl Y3RvciBhbmQgc29ydCBpdCB0byBhc2NlbmRpbmcgb3JkZXIuCisKIDIwMTYtMDUtMTggIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggdGhlIGFsbGlu b25lLWJ1aWxkIGFmdGVyIHIxOTg2NjkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJl c29sdmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5jcHAJKHJldmlzaW9uIDIwMTA3MykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29s dmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQxOCwyNCArMjQxOCwzNyBAQCB2b2lkIFN0eWxl UmVzb2x2ZXI6OkNhc2NhZGVkUHJvcGVydGllczo6CiAgICAgaWYgKHN0YXJ0SW5kZXggPT0gLTEp CiAgICAgICAgIHJldHVybjsKIAotICAgIHVuc2lnbmVkIGhpZ2hlc3RUcmVlQ29udGV4dE9yZGlu YWwgPSAwOwotICAgIGZvciAodW5zaWduZWQgdHJlZUNvbnRleHRQYXNzID0gMDsgdHJlZUNvbnRl eHRQYXNzIDw9IGhpZ2hlc3RUcmVlQ29udGV4dE9yZGluYWw7ICsrdHJlZUNvbnRleHRQYXNzKSB7 Ci0gICAgICAgIGZvciAoaW50IGkgPSBzdGFydEluZGV4OyBpIDw9IGVuZEluZGV4OyArK2kpIHsK LSAgICAgICAgICAgIGNvbnN0IE1hdGNoZWRQcm9wZXJ0aWVzJiBtYXRjaGVkUHJvcGVydGllcyA9 IG1hdGNoUmVzdWx0Lm1hdGNoZWRQcm9wZXJ0aWVzKClbaV07Ci0KLSAgICAgICAgICAgIGlmICgh aGFzSW1wb3J0YW50UHJvcGVydGllcygqbWF0Y2hlZFByb3BlcnRpZXMucHJvcGVydGllcykpCi0g ICAgICAgICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAgICAgIC8vIEZvciAhaW1wb3J0YW50 IHByb3BlcnRpZXMgYSBsYXRlciBzaGFkb3cgdHJlZSB3aW5zLiBEbyBtdWx0aXBsZSBwYXNzZXMg dG8gYXBwbHkgaW4gY29ycmVjdCBvcmRlciBpZiBuZWVkZWQuCi0gICAgICAgICAgICAvLyBNYXRj aGVkIHByb3BlcnRpZXMgYXJlIHNvcnRlZCBpbiByZXZlcnNlIHRyZWUgY29udGV4dCBvcmRlciBz byB0aGlzIGlzIG5vdCBuZWVkZWQgZm9yIG5vcm1hbCBwcm9wZXJ0aWVzLgotICAgICAgICAgICAg aWYgKG1hdGNoZWRQcm9wZXJ0aWVzLnRyZWVDb250ZXh0T3JkaW5hbCAhPSB0cmVlQ29udGV4dFBh c3MpIHsKLSAgICAgICAgICAgICAgICBoaWdoZXN0VHJlZUNvbnRleHRPcmRpbmFsID0gc3RkOjpt YXgobWF0Y2hlZFByb3BlcnRpZXMudHJlZUNvbnRleHRPcmRpbmFsLCBoaWdoZXN0VHJlZUNvbnRl eHRPcmRpbmFsKTsKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgIH0KKyAg ICBzdHJ1Y3QgSW5kZXhBbmRPcmRpbmFsIHsKKyAgICAgICAgaW50IGluZGV4OworICAgICAgICB1 bnNpZ25lZCBvcmRpbmFsOworICAgIH07CisgICAgVmVjdG9yPEluZGV4QW5kT3JkaW5hbD4gc2hh ZG93VHJlZU1hdGNoZXM7CiAKLSAgICAgICAgICAgIGFkZE1hdGNoKG1hdGNoUmVzdWx0LCBpLCB0 cnVlLCBpbmhlcml0ZWRPbmx5KTsKKyAgICBmb3IgKGludCBpID0gc3RhcnRJbmRleDsgaSA8PSBl bmRJbmRleDsgKytpKSB7CisgICAgICAgIGNvbnN0IE1hdGNoZWRQcm9wZXJ0aWVzJiBtYXRjaGVk UHJvcGVydGllcyA9IG1hdGNoUmVzdWx0Lm1hdGNoZWRQcm9wZXJ0aWVzKClbaV07CisKKyAgICAg ICAgaWYgKCFoYXNJbXBvcnRhbnRQcm9wZXJ0aWVzKCptYXRjaGVkUHJvcGVydGllcy5wcm9wZXJ0 aWVzKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIGlmIChtYXRjaGVkUHJvcGVy dGllcy50cmVlQ29udGV4dE9yZGluYWwpIHsKKyAgICAgICAgICAgIHNoYWRvd1RyZWVNYXRjaGVz LmFwcGVuZCh7IGksIG1hdGNoZWRQcm9wZXJ0aWVzLnRyZWVDb250ZXh0T3JkaW5hbCB9KTsKKyAg ICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CisKKyAgICAgICAgYWRkTWF0Y2gobWF0Y2hS ZXN1bHQsIGksIHRydWUsIGluaGVyaXRlZE9ubHkpOwogICAgIH0KKworICAgIGlmIChzaGFkb3dU cmVlTWF0Y2hlcy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIEZvciAhaW1w b3J0YW50IHByb3BlcnRpZXMgYSBsYXRlciBzaGFkb3cgdHJlZSB3aW5zLgorICAgIC8vIE1hdGNo IHJlc3VsdHMgYXJlIHNvcnRlZCBpbiByZXZlcnNlIHRyZWUgY29udGV4dCBvcmRlciBzbyB0aGlz IGlzIG5vdCBuZWVkZWQgZm9yIG5vcm1hbCBwcm9wZXJ0aWVzLgorICAgIHN0ZDo6c3RhYmxlX3Nv cnQoc2hhZG93VHJlZU1hdGNoZXMuYmVnaW4oKSwgc2hhZG93VHJlZU1hdGNoZXMuZW5kKCksIFtd IChjb25zdCBJbmRleEFuZE9yZGluYWwmIGEsIGNvbnN0IEluZGV4QW5kT3JkaW5hbCYgYikgewor ICAgICAgICByZXR1cm4gYS5vcmRpbmFsIDwgYi5vcmRpbmFsOworICAgIH0pOworCisgICAgZm9y IChhdXRvJiBtYXRjaCA6IHNoYWRvd1RyZWVNYXRjaGVzKQorICAgICAgICBhZGRNYXRjaChtYXRj aFJlc3VsdCwgbWF0Y2guaW5kZXgsIHRydWUsIGluaGVyaXRlZE9ubHkpOwogfQogCiB2b2lkIFN0 eWxlUmVzb2x2ZXI6OkNhc2NhZGVkUHJvcGVydGllczo6YXBwbHlEZWZlcnJlZFByb3BlcnRpZXMo U3R5bGVSZXNvbHZlciYgcmVzb2x2ZXIsIGNvbnN0IE1hdGNoUmVzdWx0KiBtYXRjaFJlc3VsdCkK