157818 2016-05-17 16:08:43 -0700 AX: Adding children incorrectly when there are nested inline continuations 2016-05-17 19:14:10 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1194040 0 n_wang 2016-05-17 16:08:43 -0700 When we have nested inline continuations, we are adding some children repeatedly. <rdar://problem/25971444> 1194052 1 279181 n_wang 2016-05-17 16:33:00 -0700 Created attachment 279181 Initial patch 1194085 2 279181 cfleizach 2016-05-17 18:12:12 -0700 Comment on attachment 279181 Initial patch Great! 1194111 3 279181 commit-queue 2016-05-17 19:13:58 -0700 Comment on attachment 279181 Initial patch Clearing flags on attachment: 279181 Committed r201067: <http://trac.webkit.org/changeset/201067> 1194112 4 commit-queue 2016-05-17 19:14:10 -0700 All reviewed patches have been landed. Closing bug. 279181 2016-05-17 16:33:00 -0700 2016-05-17 19:13:58 -0700 Initial patch patch.txt text/plain 5189 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTA1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA1LTE3ICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEFkZGluZyBjaGlsZHJlbiBpbmNv cnJlY3RseSB3aGVuIHRoZXJlIGFyZSBuZXN0ZWQgaW5saW5lIGNvbnRpbnVhdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzgxOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZ2V0dGluZyB0 aGUgaW5saW5lIGVsZW1lbnQgY29udGludWF0aW9uJ3MgbmV4dCBzaWJsaW5nLCBpZiB3ZSBmYWxs IGJhY2sgb24gdG8gdGhlIHBhcmVudAorICAgICAgICBjYXNlLCB3ZSBtaWdodCBlbmQgdXAgYWRk aW5nIHRoZSBzYW1lIG5vZGUgcmVwZWF0ZWRseS4gRml4ZWQgaXQgYnkgc2tpcHBpbmcgdGhpcyBj YXNlLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvbWFjL25lc3RlZC1pbmxpbmUtZWxl bWVudHMtY2hpbGRyZW4uaHRtbAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5k ZXJPYmplY3Q6Om5leHRTaWJsaW5nKToKKwogMjAxNi0wNS0xNyAgQmV0aCBEYWtpbiAgPGJkYWtp bkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBoYW5kbGVBY2NlcHRlZENhbmRpZGF0ZSBhIHB1 YmxpYyBmdW5jdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAyMDA5NTAp CisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTksNiArMzk5LDEzIEBAIEFjY2Vzc2liaWxpdHlP YmplY3QqIEFjY2Vzc2liaWxpdHlSZW5kZXIKICAgICAgICAgLy8gQ2FzZSA1YjogY29udGludWF0 aW9uIGlzIGFuIGlubGluZSAtIGluIHRoaXMgY2FzZSB0aGUgaW5saW5lJ3MgZmlyc3QgY2hpbGQg aXMgdGhlIG5leHQgc2libGluZwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBuZXh0U2libGlu ZyA9IGZpcnN0Q2hpbGRDb25zaWRlcmluZ0NvbnRpbnVhdGlvbihjb250aW51YXRpb24pOworICAg ICAgICAKKyAgICAgICAgLy8gQWZ0ZXIgY2FzZSA0LCB0aGVyZSBhcmUgY2hhbmNlcyB0aGF0IG5l eHRTaWJsaW5nIGhhcyB0aGUgc2FtZSBub2RlIGFzIHRoZSBjdXJyZW50IHJlbmRlcmVyLAorICAg ICAgICAvLyB3aGljaCBtaWdodCBsZWFkIHRvIGFkZGluZyB0aGUgc2FtZSBjaGlsZCByZXBlYXRl ZGx5LgorICAgICAgICBpZiAobmV4dFNpYmxpbmcgJiYgbmV4dFNpYmxpbmctPm5vZGUoKSA9PSBt X3JlbmRlcmVyLT5ub2RlKCkpIHsKKyAgICAgICAgICAgIGlmIChBY2Nlc3NpYmlsaXR5T2JqZWN0 KiBuZXh0T2JqID0gYXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShuZXh0U2libGluZykpCisg ICAgICAgICAgICAgICAgcmV0dXJuIG5leHRPYmotPm5leHRTaWJsaW5nKCk7CisgICAgICAgIH0K ICAgICB9CiAKICAgICBpZiAoIW5leHRTaWJsaW5nKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwOTUw KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDUtMTcgIE5hbiBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KKworICAgICAgICBB WDogQWRkaW5nIGNoaWxkcmVuIGluY29ycmVjdGx5IHdoZW4gdGhlcmUgYXJlIG5lc3RlZCBpbmxp bmUgY29udGludWF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU3ODE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9uZXN0ZWQtaW5saW5lLWVsZW1lbnRzLWNoaWxk cmVuLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvbmVz dGVkLWlubGluZS1lbGVtZW50cy1jaGlsZHJlbi5odG1sOiBBZGRlZC4KKwogMjAxNi0wNS0xNiAg TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdFeHAgL3kg ZmxhZyBpbmNvcnJlY3QgaGFuZGxpbmcgb2YgbWl4ZWQtbGVuZ3RoIGFsdGVybmF0aW9uCkluZGV4 OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9uZXN0ZWQtaW5saW5lLWVsZW1lbnRzLWNo aWxkcmVuLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L21hYy9uZXN0ZWQtaW5saW5lLWVsZW1lbnRzLWNoaWxkcmVuLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL25lc3RlZC1pbmxpbmUt ZWxlbWVudHMtY2hpbGRyZW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MTggQEAKK3Rlc3QxCit0ZXN0MgordGVzdDMKK1RoaXMgdGVzdHMgdGhhdCB3aGVuIHlvdSBoYXZl IG5lc3RlZCBpbmxpbmUgY29udGludWF0aW9ucywgd2UgYWRkIHRoZSBjaGlsZHJlbiBjb3JyZWN0 bHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitBWFJvbGU6IEFYR3JvdXAgQVhW YWx1ZTogCisgIEFYUm9sZTogQVhTdGF0aWNUZXh0IEFYVmFsdWU6IHRlc3QxCisgIEFYUm9sZTog QVhTdGF0aWNUZXh0IEFYVmFsdWU6IHRlc3QyCisgIEFYUm9sZTogQVhHcm91cCBBWFZhbHVlOiAK KyAgICBBWFJvbGU6IEFYU3RhdGljVGV4dCBBWFZhbHVlOiB0ZXN0MworUEFTUyBjb250ZW50LmNo aWxkcmVuQ291bnQgaXMgMworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNU IENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL25lc3RlZC1p bmxpbmUtZWxlbWVudHMtY2hpbGRyZW4uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L21hYy9uZXN0ZWQtaW5saW5lLWVsZW1lbnRzLWNoaWxkcmVuLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9uZXN0ZWQtaW5saW5l LWVsZW1lbnRzLWNoaWxkcmVuLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1MyBAQAor PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8 aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBkdW1wQWNjZXNzaWJpbGl0eUNoaWxkcmVuKGVs ZW1lbnQsIGxldmVsKSB7CisgICAgICAgIGlmIChlbGVtZW50LnN0cmluZ1ZhbHVlLmluZGV4T2Yo J0VuZCBvZiB0ZXN0JykgPj0gMCkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAg ICB2YXIgaW5kZW50ID0gIiI7CisgICAgICAgIGZvciAodmFyIGsgPSAwOyBrIDwgbGV2ZWw7IGsr KykgeyBpbmRlbnQgKz0gIiAgIjsgfQorICAgICAgICBkZWJ1ZyhpbmRlbnQgKyBlbGVtZW50LnJv bGUgKyAiICIgKyBlbGVtZW50LnN0cmluZ1ZhbHVlKTsKKyAgICAgICAgdmFyIGNoaWxkcmVuQ291 bnQgPSBlbGVtZW50LmNoaWxkcmVuQ291bnQ7CisgICAgICAgIGZvciAodmFyIGsgPSAwOyBrIDwg Y2hpbGRyZW5Db3VudDsgaysrKSB7CisgICAgICAgICAgICBpZiAoIWR1bXBBY2Nlc3NpYmlsaXR5 Q2hpbGRyZW4oZWxlbWVudC5jaGlsZEF0SW5kZXgoayksIGxldmVsKzEpKQorICAgICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9 Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgaWQ9ImJvZHkiPgorCis8ZGl2PgorPHNwYW4+ CisgICAgPHNwYW4+CisgICAgICAgIHRlc3QxCisgICAgICAgIDxkaXY+PC9kaXY+CisgICAgICAg IDxzcGFuPiB0ZXN0Mjwvc3Bhbj4KKyAgICA8L3NwYW4+PGRpdj4KKyAgICB0ZXN0MworICAgIDwv ZGl2PgorPC9zcGFuPgorPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBp ZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB3aGVu IHlvdSBoYXZlIG5lc3RlZCBpbmxpbmUgY29udGludWF0aW9ucywgd2UgYWRkIHRoZSBjaGlsZHJl biBjb3JyZWN0bHkuIik7CisKKyAgICAgICAgdmFyIGNvbnRlbnQgPSBhY2Nlc3NpYmlsaXR5Q29u dHJvbGxlci5yb290RWxlbWVudC5jaGlsZEF0SW5kZXgoMCkuY2hpbGRBdEluZGV4KDApOworICAg ICAgICBkdW1wQWNjZXNzaWJpbGl0eUNoaWxkcmVuKGNvbnRlbnQsIDApOworICAgICAgICAKKyAg ICAgICAgc2hvdWxkQmUoImNvbnRlbnQuY2hpbGRyZW5Db3VudCIsICIzIik7CisgICAgfQorICAg IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=