157814 2016-05-17 15:15:59 -0700 REGRESSION: JetStream crashes on some iPhones 2016-05-17 15:26:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren fpizlo msaboff oldest_to_newest 1194003 0 ggaren 2016-05-17 15:15:59 -0700 REGRESSION: JetStream crashes on some iPhones 1194006 1 279170 ggaren 2016-05-17 15:20:46 -0700 Created attachment 279170 Patch 1194008 2 ggaren 2016-05-17 15:21:34 -0700 Here's the memory win: ~/OpenSource/PerformanceTests/MallocBench> ./run-malloc-benchmarks --benchmark "jetstream --runs 1" Baseline:/Users/ggaren/OpenSource/WebKitBuildBaseline/ Patch:/Users/ggaren/OpenSource/WebKitBuild/Release/ Baseline Patch Δ Execution Time: jetstream --runs 1 5,269ms 5,285ms ! 1.0x slower <geometric mean> 5,269ms 5,285ms ! 1.0x slower <arithmetic mean> 5,269ms 5,285ms ! 1.0x slower <harmonic mean> 5,269ms 5,285ms ! 1.0x slower Peak Memory: jetstream --runs 1 1,269,532kB 1,137,040kB ^ 1.12x smaller <geometric mean> 1,269,532kB 1,137,040kB ^ 1.12x smaller <arithmetic mean> 1,269,532kB 1,137,040kB ^ 1.12x smaller <harmonic mean> 1,269,532kB 1,137,040kB ^ 1.12x smaller 1194009 3 ggaren 2016-05-17 15:22:07 -0700 Octane splay (and Octane overall) is OK with this: Baseline Patch encrypt 0.19483+-0.00094 ? 0.19562+-0.00130 ? decrypt 3.43557+-0.05172 ? 3.44904+-0.02291 ? deltablue x2 0.15733+-0.00478 ? 0.16024+-0.00694 ? might be 1.0185x slower earley 0.36196+-0.00224 ? 0.36252+-0.00153 ? boyer 5.79808+-0.01359 5.79511+-0.06196 navier-stokes x2 5.36963+-0.00812 ? 5.37160+-0.01836 ? raytrace x2 0.96771+-0.01209 0.95949+-0.00898 richards x2 0.10679+-0.00229 0.10582+-0.00125 splay x2 0.38585+-0.00202 ? 0.38934+-0.00491 ? regexp x2 19.73298+-0.07684 ? 19.86209+-0.08336 ? pdfjs x2 46.21900+-0.80682 46.07309+-0.69264 mandreel x2 51.22570+-0.48006 51.11198+-0.21479 gbemu x2 43.63421+-8.62700 38.98809+-0.31607 might be 1.1192x faster closure 0.68696+-0.00272 0.68326+-0.00444 jquery 8.56558+-0.03242 ? 8.59034+-0.05483 ? box2d x2 12.24223+-0.13089 12.21356+-0.14817 zlib x2 411.37925+-2.31866 402.43274+-24.12873 might be 1.0222x faster typescript x2 870.34131+-3.97328 867.75671+-12.64601 <geometric> 6.24665+-0.08206 6.19660+-0.02566 might be 1.0081x faster 1194011 4 279170 msaboff 2016-05-17 15:23:38 -0700 Comment on attachment 279170 Patch r=me 1194014 5 ggaren 2016-05-17 15:26:24 -0700 Committed r201050: <http://trac.webkit.org/changeset/201050> 279170 2016-05-17 15:20:46 -0700 2016-05-17 15:23:38 -0700 Patch bug-157814-20160517152144.patch text/plain 1917 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMTA0OCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA1LTE3ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogSmV0U3Ry ZWFtIGNyYXNoZXMgb24gc29tZSBpUGhvbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvU2l6ZXMuaDogUmVkdWNlIHNtYWxsTWF4IHRv IDMya0IuIAorCisgICAgICAgIFByZXZpb3VzIGp1c3RpZmljYXRpb24gZm9yIDY0a0Igd2FzOgor CisgICAgICAgICAgICAqIGJtYWxsb2MvU2l6ZXMuaDogVXBwZWQgc21hbGxNYXggdG8gNjRrQi4g VXBwaW5nIHRvIDMya0IgaXMgcHJldHR5CisgICAgICAgICAgICByZWFzb25hYmxlLCBzaW5jZSBz aXplcyBiZXR3ZWVuIDE2a0IgYW5kIDMya0Igc2hhcmUgcGFnZSBzaXplcy4gSSB3ZW50CisgICAg ICAgICAgICBhbGwgdGhlIHdheSB1cCB0byA2NGtCIGJlY2F1c2UgdGhlIEdDIHVzZXMgNjRrQiBi bG9ja3MsIGFuZCBhbHNvIGp1c3QKKyAgICAgICAgICAgIGZvciBleHRyYSBwYWRkaW5nIHRvIGVu c3VyZSB0aGF0IGxhcmdlIGFsbG9jYXRpb25zIGFyZSBpbmRlZWQgcmFyZS4KKworICAgICAgICBJ dCB0dXJucyBvdXQgdGhhdCB0aGUgYnVtcCB0byA2NGtCIHN1YnN0YW50aWFsbHkgaW5jcmVhc2Vz IG91ciBtZW1vcnkKKyAgICAgICAgaGlnaCB3YXRlciBtYXJrIG9uIEpldFN0cmVhbSwgbGVhZGlu ZyB0byBqZXRzYW0gY3Jhc2hlcy4gQWxzbywgdGhlcmUKKyAgICAgICAgZG9lc24ndCBzZWVtIHRv IGJlIGEgcHJhY3RpY2FsIHBlcmZvcm1hbmNlIHByb2JsZW0gdG8gcHV0dGluZyBvYmplY3RzIGlu CisgICAgICAgIHRoZSAoMzJrQiAtIDY0a0IpIHJhbmdlIGluIHRoZSBsYXJnZSBhbGxvY2F0b3Iu CisKIDIwMTYtMDUtMTYgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OICgyMDAwMzUpOiBjaGFuZ2VzIGluICJXZWJLaXQgTWFsbG9jIiBWTSBy ZWdpb25zIGFyZSBjYXVzaW5nICdsZWFrcycgdG8gc3BldyAiRmFpbGVkIHRvIG1hcCByZW1vdGUg cmVnaW9uIiBtZXNzYWdlcwpJbmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TaXplcy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvU2l6ZXMuaAkocmV2aXNpb24gMjAx MDM4KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9TaXplcy5oCSh3b3JraW5nIGNvcHkpCkBA IC01NCw3ICs1NCw3IEBAIG5hbWVzcGFjZSBTaXplcyB7CiAgICAgc3RhdGljIGNvbnN0IHNpemVf dCBzbWFsbFBhZ2VMaW5lQ291bnQgPSBzbWFsbFBhZ2VTaXplIC8gc21hbGxMaW5lU2l6ZTsKIAog ICAgIHN0YXRpYyBjb25zdCBzaXplX3QgbWFza1NpemVDbGFzc01heCA9IDUxMjsKLSAgICBzdGF0 aWMgY29uc3Qgc2l6ZV90IHNtYWxsTWF4ID0gNjQgKiBrQjsKKyAgICBzdGF0aWMgY29uc3Qgc2l6 ZV90IHNtYWxsTWF4ID0gMzIgKiBrQjsKIAogICAgIHN0YXRpYyBjb25zdCBzaXplX3QgcGFnZVNp emVNYXggPSBzbWFsbE1heCAqIDI7CiAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBwYWdlQ2xhc3ND b3VudCA9IHBhZ2VTaXplTWF4IC8gc21hbGxQYWdlU2l6ZTsK