<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>157807</bug_id>
          
          <creation_ts>2016-05-17 13:02:58 -0700</creation_ts>
          <short_desc>Add test262 test files/yaml.</short_desc>
          <delta_ts>2016-08-30 11:27:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>achristensen</cc>
    
    <cc>benjamin</cc>
    
    <cc>keith_miller</cc>
    
    <cc>ossy</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1193947</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2016-05-17 13:02:58 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193955</commentid>
    <comment_count>1</comment_count>
      <attachid>279157</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2016-05-17 13:09:42 -0700</bug_when>
    <thetext>Created attachment 279157
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193960</commentid>
    <comment_count>2</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2016-05-17 13:26:11 -0700</bug_when>
    <thetext>I&apos;m just going to land this. This patch adds a bunch of files that won&apos;t be run yet anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1194195</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-05-18 01:13:14 -0700</bug_when>
    <thetext>Please don&apos;t land it now, we could and should make 
the test262.yaml file less verbose and redundant.

For example, harness/assert.js and harness.sta js are included
by all &quot;runTest262&quot; test. I prefer adding these common harness
files to includeFiles in runTest262 function instead.

Additionally we could remove the ugly relative paths to 
harness files, all of them are in the same harness directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1194211</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-05-18 02:25:51 -0700</bug_when>
    <thetext>typo: donePrintHandle.js -&gt; doneprintHandle.js in the generated yaml file

It would be great to mention which revision of test262 is checked in.
At least in the bug report and commit log, but it would be better
to have a revision.txt file or something similar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1195110</commentid>
    <comment_count>5</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-05-20 00:41:48 -0700</bug_when>
    <thetext>Should this still be r?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1211362</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-07-15 01:52:27 -0700</bug_when>
    <thetext>landed in https://trac.webkit.org/changeset/203270

(In reply to comment #4)
&gt; It would be great to mention which revision of test262 is checked in.
&gt; At least in the bug report and commit log, but it would be better
&gt; to have a revision.txt file or something similar.

I can&apos;t find the revision of test262 in that commit log. :(
Please add a revision file, or mention it in the commit log
which updates something in the test262 directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1212440</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-07-19 11:35:12 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; landed in https://trac.webkit.org/changeset/203270
&gt; 
&gt; (In reply to comment #4)
&gt; &gt; It would be great to mention which revision of test262 is checked in.
&gt; &gt; At least in the bug report and commit log, but it would be better
&gt; &gt; to have a revision.txt file or something similar.
&gt; 
&gt; I can&apos;t find the revision of test262 in that commit log. :(
&gt; Please add a revision file, or mention it in the commit log
&gt; which updates something in the test262 directory.

Ping?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1212493</commentid>
    <comment_count>8</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2016-07-19 13:25:44 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; landed in https://trac.webkit.org/changeset/203270
&gt; &gt; 
&gt; &gt; (In reply to comment #4)
&gt; &gt; &gt; It would be great to mention which revision of test262 is checked in.
&gt; &gt; &gt; At least in the bug report and commit log, but it would be better
&gt; &gt; &gt; to have a revision.txt file or something similar.
&gt; &gt; 
&gt; &gt; I can&apos;t find the revision of test262 in that commit log. :(
&gt; &gt; Please add a revision file, or mention it in the commit log
&gt; &gt; which updates something in the test262 directory.
&gt; 
&gt; Ping?

Good idea. I opened a bugzilla: https://bugs.webkit.org/show_bug.cgi?id=159937</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1224644</commentid>
    <comment_count>9</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2016-08-30 11:27:27 -0700</bug_when>
    <thetext>*** Bug 144241 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>279157</attachid>
            <date>2016-05-17 13:09:42 -0700</date>
            <delta_ts>2016-07-15 02:17:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>0001-add-test262-yaml-and-sources.patch</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64"></data>

          </attachment>
      

    </bug>

</bugzilla>