157802 2016-05-17 11:04:10 -0700 Web Inspector: inspector tests should redirect and log console.trace() calls in test output 2016-05-17 15:03:55 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1193878 0 bburg 2016-05-17 11:04:10 -0700 Not sure how to implement 1193880 1 webkit-bug-importer 2016-05-17 11:06:54 -0700 <rdar://problem/26325671> 1193890 2 bburg 2016-05-17 11:41:20 -0700 Output from current patch: -- Running test case: ShortTaskCompletesWithoutYielding LOG: Hit TRACE: #0: _didFinish (TestCombined.js:3619:22) #1: _processPendingItems (TestCombined.js:3607:24) #2: start (TestCombined.js:3571:34) #3: (anonymous) (unknown) #4: initializePromise [native code] #5: Promise [native code] #6: (anonymous) (TestCombined.js:1214:35) #7: promiseReactionJob [native code] Looks pretty good to me! 1193937 3 279151 bburg 2016-05-17 12:52:40 -0700 Created attachment 279151 Proposed Fix 1193997 4 279151 joepeck 2016-05-17 14:59:40 -0700 Comment on attachment 279151 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=279151&action=review > Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:144 > + throw new Exception(); This seems rather ambiguous. "new Exception" alone is a runtime exception because there is no such thing as "Exception", which makes the `throw` unnecessary. I tend to write something obvious that causes an exception, like: "({}).x.x" or "this.property.does.not.exist" 1193999 5 279151 commit-queue 2016-05-17 15:03:50 -0700 Comment on attachment 279151 Proposed Fix Clearing flags on attachment: 279151 Committed r201048: <http://trac.webkit.org/changeset/201048> 1194000 6 commit-queue 2016-05-17 15:03:55 -0700 All reviewed patches have been landed. Closing bug. 279151 2016-05-17 12:52:40 -0700 2016-05-17 15:03:50 -0700 Proposed Fix bug-157802-20160517125337.patch text/plain 4404 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz M2JiMmY3ZDY5ZjUzNGE2NGQwNzUzNDQyMjJiNjhmY2VmY2UxOGY3Li5mYjA5MmUwNTJlNzg0YzFh NGQ2NDYzZWQ0NWQxYTIwZWQ4YTlkMzNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxNi0wNS0xNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbnNwZWN0b3IgdGVzdHMgc2hvdWxkIHJlZGlyZWN0IGFu ZCBsb2cgY29uc29sZS50cmFjZSgpIGNhbGxzIGluIHRlc3Qgb3V0cHV0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc4MDIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2MzI1NjcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanM6 CisgICAgICAgIChGcm9udGVuZFRlc3RIYXJuZXNzLnByb3RvdHlwZS5yZWRpcmVjdENvbnNvbGVU b1Rlc3RPdXRwdXQuY3JlYXRlUHJveHlDb25zb2xlSGFuZGxlcik6CisgICAgICAgIFJlbW92ZSBi aW5kKCkgdGhhdCBpcyBub3cgdW5uZWNlc3NhcnkuIEFsc28gcmVkaXJlY3QgY29uc29sZS53YXJu LgorCisgICAgICAgIChGcm9udGVuZFRlc3RIYXJuZXNzLnByb3RvdHlwZS5yZWRpcmVjdENvbnNv bGVUb1Rlc3RPdXRwdXQpOgorICAgICAgICBGb3IgY29uc29sZS50cmFjZSgpLCB0aHJvdyBhbmQg Y2F0Y2ggYSBkdW1teSBFcnJvciB0byBnZXQgYSBzdGFjayB0cmFjZS4KKyAgICAgICAgRG8gc29t ZSBwb3N0IHByb2Nlc3Npbmcgb24gaXQgdG8gcmVtb3ZlIHVzZWxlc3MgZnJhbWVzIGFuZCBzYW5p dGl6ZSBmaWxlIHBhdGhzLgorCisyMDE2LTA1LTE3ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUu Y29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJyZWFrcG9pbnRzIGluIHNvdXJjZVVSTCBu YW1lZCBzY3JpcHRzIGFyZSBub3QgcGVyc2lzdGVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3MTQKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2 Mjg3MDk5PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv VGVzdC9Gcm9udGVuZFRlc3RIYXJuZXNzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVGVzdC9Gcm9udGVuZFRlc3RIYXJuZXNzLmpzCmluZGV4IDNhMWRlZTEyMzAzYTJk YWQ5NDkzNTk2YzRhNTU3NWJiMjhmOTgwYTAuLmQzYjc4YTVkYjBlMmQ0YjY4NmQ4MmNjNDQxZjYx MTAwZDE1MjU1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1Rlc3QvRnJvbnRlbmRUZXN0SGFybmVzcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9UZXN0L0Zyb250ZW5kVGVzdEhhcm5lc3MuanMKQEAgLTEzNCwxNyAr MTM0LDUxIEBAIEZyb250ZW5kVGVzdEhhcm5lc3MgPSBjbGFzcyBGcm9udGVuZFRlc3RIYXJuZXNz IGV4dGVuZHMgVGVzdEhhcm5lc3MKICAgICAgICAgbGV0IHNlbGYgPSB0aGlzOwogICAgICAgICBm dW5jdGlvbiBjcmVhdGVQcm94eUNvbnNvbGVIYW5kbGVyKHR5cGUpIHsKICAgICAgICAgICAgIHJl dHVybiBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICBzZWxmLmFkZFJlc3VsdChgJHt0eXBl fTogYCArIEFycmF5LmZyb20oYXJndW1lbnRzKS5qb2luKCIgIikpOyAKKyAgICAgICAgICAgICAg ICBzZWxmLmFkZFJlc3VsdChgJHt0eXBlfTogYCArIEFycmF5LmZyb20oYXJndW1lbnRzKS5qb2lu KCIgIikpOwogICAgICAgICAgICAgfTsKICAgICAgICAgfQogCisgICAgICAgIGZ1bmN0aW9uIGNy ZWF0ZVByb3h5Q29uc29sZVRyYWNlSGFuZGxlcigpeworICAgICAgICAgICAgcmV0dXJuIGZ1bmN0 aW9uKCkgeworICAgICAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgICAgIHRocm93 IG5ldyBFeGNlcHRpb24oKTsKKyAgICAgICAgICAgICAgICB9IGNhdGNoIChlKSB7CisgICAgICAg ICAgICAgICAgICAgIC8vIFNraXAgdGhlIGZpcnN0IGZyYW1lIHdoaWNoIGlzIGFkZGVkIGJ5IHRo aXMgZnVuY3Rpb24uCisgICAgICAgICAgICAgICAgICAgIGxldCBmcmFtZXMgPSBlLnN0YWNrLnNw bGl0KCJcbiIpLnNsaWNlKDEpOworICAgICAgICAgICAgICAgICAgICBsZXQgc2FuaXRpemVkRnJh bWVzID0gZnJhbWVzLm1hcCgoZnJhbWUsIGkpID0+IHsKKyAgICAgICAgICAgICAgICAgICAgICAg IC8vIE1vc3QgZnJhbWVzIGFyZSBvZiB0aGUgZm9ybSAiZnVuY3Rpb25OYW1lQGZpbGU6Ly8vZm9v L2Jhci9GaWxlLmpzOjM0NSIuCisgICAgICAgICAgICAgICAgICAgICAgICAvLyBCdXQsIHNvbWUg ZnJhbWVzIGRvIG5vdCBoYXZlIGEgZnVuY3Rpb25OYW1lLiBHZXQgcmlkIG9mIHRoZSBmaWxlIHBh dGguCisgICAgICAgICAgICAgICAgICAgICAgICBsZXQgbmFtZUFuZFVSTFNlcGFyYXRvciA9IGZy YW1lLmluZGV4T2YoIkAiKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGxldCBmcmFtZU5hbWUg PSAobmFtZUFuZFVSTFNlcGFyYXRvciA+IDApID8gZnJhbWUuc3Vic3RyKDAsIG5hbWVBbmRVUkxT ZXBhcmF0b3IpIDogIihhbm9ueW1vdXMpIjsKKworICAgICAgICAgICAgICAgICAgICAgICAgbGV0 IGxhc3RQYXRoU2VwYXJhdG9yID0gTWF0aC5tYXgoZnJhbWUubGFzdEluZGV4T2YoIi8iKSwgZnJh bWUubGFzdEluZGV4T2YoIlxcIikpOworICAgICAgICAgICAgICAgICAgICAgICAgbGV0IGZyYW1l TG9jYXRpb24gPSAobGFzdFBhdGhTZXBhcmF0b3IgPiAwKSA/IGZyYW1lLnN1YnN0cihsYXN0UGF0 aFNlcGFyYXRvciArIDEpIDogZnJhbWU7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWZy YW1lTG9jYXRpb24ubGVuZ3RoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZyYW1lTG9j YXRpb24gPSAidW5rbm93biI7CisKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIENsZWFuIHVw IHRoZSBsb2NhdGlvbiBzbyBpdCBpcyBicmFja2V0ZWQgb3IgaW4gcGFyZW50aGVzaXMuCisgICAg ICAgICAgICAgICAgICAgICAgICBpZiAoZnJhbWUuaW5kZXhPZigiW25hdGl2ZSBjb2RlXSIpICE9 PSAtMSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBmcmFtZUxvY2F0aW9uID0gIltuYXRp dmUgY29kZV0iOworICAgICAgICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGZyYW1lTG9jYXRpb24gPSAiKCIgKyBmcmFtZUxvY2F0aW9uICsgIikiCisK KyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgIyR7aX06ICR7ZnJhbWVOYW1lfSAke2Zy YW1lTG9jYXRpb259YDsKKyAgICAgICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAgICAg ICAgIHNlbGYuYWRkUmVzdWx0KCJUUkFDRTogIiArIEFycmF5LmZyb20oYXJndW1lbnRzKS5qb2lu KCIgIikpOworICAgICAgICAgICAgICAgICAgICBzZWxmLmFkZFJlc3VsdChzYW5pdGl6ZWRGcmFt ZXMuam9pbigiXG4iKSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAg ICB9CisKICAgICAgICAgbGV0IHJlZGlyZWN0ZWRNZXRob2RzID0ge307Ci0gICAgICAgIGZvciAo bGV0IGtleSBpbiB3aW5kb3cuY29uc29sZSkgCi0gICAgICAgICAgICByZWRpcmVjdGVkTWV0aG9k c1trZXldID0gd2luZG93LmNvbnNvbGVba2V5XS5iaW5kKHdpbmRvdy5jb25zb2xlKTsKKyAgICAg ICAgZm9yIChsZXQga2V5IGluIHdpbmRvdy5jb25zb2xlKQorICAgICAgICAgICAgcmVkaXJlY3Rl ZE1ldGhvZHNba2V5XSA9IHdpbmRvdy5jb25zb2xlW2tleV07CiAKLSAgICAgICAgZm9yIChsZXQg dHlwZSBvZiBbImxvZyIsICJlcnJvciIsICJpbmZvIl0pCisgICAgICAgIGZvciAobGV0IHR5cGUg b2YgWyJsb2ciLCAiZXJyb3IiLCAiaW5mbyIsICJ3YXJuIl0pCiAgICAgICAgICAgICByZWRpcmVj dGVkTWV0aG9kc1t0eXBlXSA9IGNyZWF0ZVByb3h5Q29uc29sZUhhbmRsZXIodHlwZS50b1VwcGVy Q2FzZSgpKTsKIAorICAgICAgICByZWRpcmVjdGVkTWV0aG9kc1sidHJhY2UiXSA9IGNyZWF0ZVBy b3h5Q29uc29sZVRyYWNlSGFuZGxlcigpOworCiAgICAgICAgIHRoaXMuX29yaWdpbmFsQ29uc29s ZSA9IHdpbmRvdy5jb25zb2xlOwogICAgICAgICB3aW5kb3cuY29uc29sZSA9IHJlZGlyZWN0ZWRN ZXRob2RzOwogICAgIH0K