157800 2016-05-17 10:32:44 -0700 Fix the allinone-build on Linux in Source/WebCore/html/HTMLElementsAllInOne.cpp 2016-05-18 13:45:38 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cdumez commit-queue esprehn+autocc gyuyoung.kim ossy ryanhaddad oldest_to_newest 1193866 0 ossy 2016-05-17 10:32:44 -0700 The allinone build is broken if HTMLCanvasElement.cpp is included in Source/WebCore/html/HTMLElementsAllInOne.cpp In file included from ../../Source/WebCore/html/HTMLCanvasElement.cpp:33:0, from ../../Source/WebCore/html/HTMLElementsAllInOne.cpp:47: ../../Source/WebCore/html/canvas/CanvasRenderingContext2D.h:131:15: error: anonymous scoped enum is not allowed In file included from ../../Source/WebCore/html/HTMLCanvasElement.cpp:33:0, from ../../Source/WebCore/html/HTMLElementsAllInOne.cpp:47: ../../Source/WebCore/html/canvas/CanvasRenderingContext2D.h:131:5: error: elaborated-type-specifier for a scoped enum must not use the 'class' keyword [-Werror] In file included from ../../Source/WebCore/html/HTMLCanvasElement.cpp:33:0, from ../../Source/WebCore/html/HTMLElementsAllInOne.cpp:47: ../../Source/WebCore/html/canvas/CanvasRenderingContext2D.h:131:15: error: expected identifier before numeric constant ../../Source/WebCore/html/canvas/CanvasRenderingContext2D.h:131:15: error: expected unqualified-id before numeric constant 1193867 1 279136 ossy 2016-05-17 10:35:04 -0700 Created attachment 279136 Patch Removing HTMLCanvasElement.cpp from Source/WebCore/html/HTMLElementsAllInOne.cpp fixes the broken build. But maybe we can find better fix for it. 1194204 2 279136 ossy 2016-05-18 01:54:37 -0700 Comment on attachment 279136 Patch Let's land it as is, I don't have time to investigate magic build failures. 1194310 3 279136 commit-queue 2016-05-18 10:24:52 -0700 Comment on attachment 279136 Patch Clearing flags on attachment: 279136 Committed r201084: <http://trac.webkit.org/changeset/201084> 1194311 4 commit-queue 2016-05-18 10:24:57 -0700 All reviewed patches have been landed. Closing bug. 1194380 5 ryanhaddad 2016-05-18 12:42:31 -0700 And it looks like this change broke the Apple Windows build :/ <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/77812> 1194404 6 ryanhaddad 2016-05-18 13:45:38 -0700 (In reply to comment #4) > All reviewed patches have been landed. Closing bug. Well, I take that back. My first attempt at a clean build failed because the bot mangled its tools. Another bot successfully built after the clean <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/94901> Sorry for the noise. 279136 2016-05-17 10:35:04 -0700 2016-05-18 10:24:52 -0700 Patch bug-157800-20160517103600.patch text/plain 1279 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY3OGQxYTFhMmQ3NDQ5 Y2VmNWQwNGY0ZDIzMzY2MGNlNDU3ZTEyZC4uNjFjYzBkYTA0ZjI0ZmY4YjJmNGEwNzIwZGM3NTM0 ZWQyMDc3MzgzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTA1LTE3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgRml4IHRoZSBhbGxp bm9uZS1idWlsZCBvbiBMaW51eCBpbiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50c0Fs bEluT25lLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3ODAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBodG1sL0hUTUxFbGVtZW50c0FsbEluT25lLmNwcDoKKworMjAxNi0wNS0xNyAgQ3NhYmEg T3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAgICAgIEZpeCB0aGUgIUVOQUJM RShXRUJfVElNSU5HKSBidWlsZCBhZnRlciByMjAwODg3CiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3OTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRWxlbWVudHNBbGxJbk9uZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxFbGVtZW50c0FsbEluT25lLmNwcAppbmRleCA0ZTZlMTE4MjA5YzQ1YjgwOTEwZTI0ZWRk ZWEyNmYxNzA5YTZmNzlkLi5hNmY2OGNhNzY4YmM5NzQ0NmZkNjE5NWMwOTVjMWNmYWNmOGQxMjE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50c0FsbEluT25lLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50c0FsbEluT25lLmNwcApAQCAt NDQsNyArNDQsNiBAQAogI2luY2x1ZGUgIkhUTUxCYXNlRm9udEVsZW1lbnQuY3BwIgogI2luY2x1 ZGUgIkhUTUxCb2R5RWxlbWVudC5jcHAiCiAjaW5jbHVkZSAiSFRNTEJ1dHRvbkVsZW1lbnQuY3Bw IgotI2luY2x1ZGUgIkhUTUxDYW52YXNFbGVtZW50LmNwcCIKICNpbmNsdWRlICJIVE1MRGF0YUVs ZW1lbnQuY3BwIgogI2luY2x1ZGUgIkhUTUxEYXRhTGlzdEVsZW1lbnQuY3BwIgogI2luY2x1ZGUg IkhUTUxEZXRhaWxzRWxlbWVudC5jcHAiCg==