157798 2016-05-17 09:51:03 -0700 Fix the allinone-build after r198669 2016-05-18 02:14:49 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 155871 1 ossy ossy achristensen bfulgham commit-queue ossy oldest_to_newest 1193855 0 ossy 2016-05-17 09:51:03 -0700 $ Tools/Scripts/build-webkit --efl --allinone-build ... In file included from ../../Source/WebCore/DerivedSources.cpp:34:0: DerivedSources/WebCore/ExceptionCodeDescription.h:41:5: error: "ENABLE" is not defined [-Werror=undef] #if ENABLE(INDEXED_DATABASE) ^ DerivedSources/WebCore/ExceptionCodeDescription.h:41:11: error: missing binary operator before token "(" #if ENABLE(INDEXED_DATABASE) ^ cc1plus: all warnings being treated as errors ... It's incorrect to use ENABLE macros anywhere without including config.h. It's surprising how it builds on Apple Windows build. 1193857 1 279134 ossy 2016-05-17 10:06:12 -0700 Created attachment 279134 Patch 1193879 2 achristensen 2016-05-17 11:05:50 -0700 I think a better solution would be to #include config.h in DerivedSources.cpp. 1194125 3 279134 mcatanzaro 2016-05-17 19:46:05 -0700 Comment on attachment 279134 Patch (Reviewed this before reading Alex's comment.) 1194200 4 ossy 2016-05-18 01:33:05 -0700 (In reply to comment #2) > I think a better solution would be to #include config.h in > DerivedSources.cpp. Unfortunately it doesn't work. Including config.h causes more problems: In file included from ../../Source/WebCore/bindings/js/JSDOMPromise.h:29:0, from ../../Source/WebCore/html/HTMLMediaElement.h:35, from ../../Source/WebCore/html/HTMLAudioElement.h:31, from DerivedSources/WebCore/HTMLElementFactory.cpp:128, from ../../Source/WebCore/DerivedSources.cpp:36: ../../Source/WebCore/bindings/js/JSDOMBinding.h: In instantiation of 'void WebCore::uncacheWrapper(WebCore::DOMWrapperWorld&, DOMClass*, WrapperClass*) [with DOMClass = JSC::Profile; WrapperClass = WebCore::JSScriptProfile]': DerivedSources/WebCore/JSScriptProfile.cpp:174:71: required from here ../../Source/WebCore/bindings/js/JSDOMBinding.h:457:44: error: cannot convert 'JSC::Profile*' to 'JSC::ArrayBuffer*' for argument '1' to 'void* WebCore::wrapperKey(JSC::ArrayBuffer*)' ../../Source/WebCore/bindings/js/JSDOMBinding.h: In instantiation of 'void WebCore::uncacheWrapper(WebCore::DOMWrapperWorld&, DOMClass*, WrapperClass*) [with DOMClass = JSC::ProfileNode; WrapperClass = WebCore::JSScriptProfileNode]': DerivedSources/WebCore/JSScriptProfileNode.cpp:229:79: required from here ../../Source/WebCore/bindings/js/JSDOMBinding.h:457:44: error: cannot convert 'JSC::ProfileNode*' to 'JSC::ArrayBuffer*' for argument '1' to 'void* WebCore::wrapperKey(JSC::ArrayBuffer*)' I don't have time to investigate newer and newer failures, I still would like to propose my original patch. 1194203 5 279134 ossy 2016-05-18 01:53:37 -0700 Comment on attachment 279134 Patch Let's land it as is. And then let anybody to fix DerivedSources.cpp if there is any interest in it. 1194207 6 279134 commit-queue 2016-05-18 02:14:45 -0700 Comment on attachment 279134 Patch Clearing flags on attachment: 279134 Committed r201074: <http://trac.webkit.org/changeset/201074> 1194208 7 commit-queue 2016-05-18 02:14:49 -0700 All reviewed patches have been landed. Closing bug. 279134 2016-05-17 10:06:12 -0700 2016-05-18 02:14:45 -0700 Patch bug-157798-20160517100709.patch text/plain 1509 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFiYzE3Njg4YTc4MTBk OGQ0NzY0NDk1ZjcyYjk4OWRhNzlkY2QzNC4uODk4Y2E4OTcyM2VkNjhjMDk2ODcwNGE1ODE1YmU4 ZWMyY2NjMWZjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA1LTE3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBhbGxp bm9uZS1idWlsZCBhZnRlciByMTk4NjY5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTc3OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBVc2UgRGVyaXZlZFNvdXJjZXMuY3Bw IG9ubHkgb24gV2luZG93cywgaXQncyBicm9rZW4gZXZlcnl3aGVyZSBlbHNlLgorCiAyMDE2LTA1 LTE3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTihyNTQ3MjkpOiBMaW5lIGJyZWFraW5nIGluIGNvbXBsZXggbWl4ZWQtZGlyZWN0 aW9uIHRleHQgaXMgaW5jb25zaXN0ZW50IGFjcm9zcyBwYWdlIHJlZnJlc2hlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp c3RzLnR4dAppbmRleCBiYjFhMDg5NDI3MzQxNWYwMzgxNDc4ODM1OGU2NGUyMGNlN2YzOWY1Li5k NjExZTJkM2QwNWJmMmM5NDEyYjQ2YzRhZDE2ZDVhYTFiOGY3ZGY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dApAQCAtMzgwOCw3ICszODA4LDcgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9ERVJJVkVEX1NP VVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L1hNTE5TTmFtZXMuY3AKIEdFTkVS QVRFX0RPTV9OQU1FUyhYTUwgJHtXRUJDT1JFX0RJUn0veG1sL3htbGF0dHJzLmluKQogbGlzdChB UFBFTkQgV2ViQ29yZV9ERVJJVkVEX1NPVVJDRVMgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9E SVJ9L1hNTE5hbWVzLmNwcCkKIAotaWYgKEVOQUJMRV9BTExJTk9ORV9CVUlMRCkKK2lmIChFTkFC TEVfQUxMSU5PTkVfQlVJTEQgQU5EIFdJTjMyKQogICAgIG1lc3NhZ2UoU1RBVFVTICJBbGwtaW4t T25lIERlcml2ZWRTb3VyY2VzIGJ1aWxkIGlzIGVuYWJsZWQuIikKICAgICBQUk9DRVNTX0FMTElO T05FX0ZJTEUoIiR7V2ViQ29yZV9ERVJJVkVEX1NPVVJDRVN9IiBEZXJpdmVkU291cmNlcy5jcHAg bmV3U291cmNlcyBUUlVFKQogICAgIHNldChXZWJDb3JlX0RFUklWRURfU09VUkNFUyBEZXJpdmVk U291cmNlcy5jcHAgJHtuZXdTb3VyY2VzfSkK