<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>157780</bug_id>
          
          <creation_ts>2016-05-16 19:40:04 -0700</creation_ts>
          <short_desc>Tidy unused parameters with build flags in isValidKeywordPropertyAndValue</short_desc>
          <delta_ts>2016-05-17 12:04:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dean Jackson">dino</reporter>
          <assigned_to name="Dean Jackson">dino</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1193671</commentid>
    <comment_count>0</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2016-05-16 19:40:04 -0700</bug_when>
    <thetext>Tidy unused parameters with build flags in isValidKeywordPropertyAndValue</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193672</commentid>
    <comment_count>1</comment_count>
      <attachid>279083</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2016-05-16 19:44:33 -0700</bug_when>
    <thetext>Created attachment 279083
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193760</commentid>
    <comment_count>2</comment_count>
      <attachid>279083</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-05-16 23:34:12 -0700</bug_when>
    <thetext>Comment on attachment 279083
Patch

Rejecting attachment 279083 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 279083, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1334951</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193905</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-05-17 12:00:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/26327312&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1193909</commentid>
    <comment_count>4</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2016-05-17 12:04:09 -0700</bug_when>
    <thetext>Committed r201036: &lt;http://trac.webkit.org/changeset/201036&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>279083</attachid>
            <date>2016-05-16 19:44:33 -0700</date>
            <delta_ts>2016-05-16 23:34:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-157780-20160517124528.patch</filename>
            <type>text/plain</type>
            <size>1758</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFmMTU4MWQzNmE0ZTZi
NmIwMmE1NTAzNDM1YTg4MzUyMDkzNTE3NC4uM2Q3ZTY1NTJjMDkyNTJkOTFhODhjZWVkNDk1YmFk
YzdmNzFmNGEwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA1LTE2ICBEZWFu
IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBUaWR5IHVudXNlZCBwYXJhbWV0
ZXJzIHdpdGggYnVpbGQgZmxhZ3MgaW4gaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVlCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3ODAKKwor
ICAgICAgICBDU1NfQ09NUE9TSVRJTkcgYW5kIENTU19SRUdJT05TIGFyZW4ndCBydW50aW1lIGZs
YWdzIGFueSBtb3JlLCBzbworICAgICAgICBkb24ndCBuZWVkIGEgcGFyc2VyIGNvbnRleHQuIE1l
YW53aGlsZSBDU1NfR1JJRF9MQVlPVVQgZG9lcywgZXZlbgorICAgICAgICB0aG91Z2ggaXQgd2Fz
bid0IGluIHRoZSBjb25kaXRpb24gZm9yIHRoZSBVTlVTRURfUEFSQU0uCisKKyAgICAgICAgKiBj
c3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzVmFsaWRLZXl3b3JkUHJvcGVy
dHlBbmRWYWx1ZSk6CisKIDIwMTYtMDUtMTYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z
ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgWW91VHViZSBzaXRlLXNwZWNpZmljIGhh
Y2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNl
L1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNDE5MjYyMjQ1MWNlNGYzODEzMmI3YTU2
YTBiZmFmYzliYjYzYzAxNi4uNzUzYmMxZTJiMDBjMDM1YWZhNGFlMDZhYjY0M2Q3YjZhMGRlNjcy
MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291
cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTY3Nyw4ICs2NzcsNiBAQCBzdGF0aWMg
aW5saW5lIGJvb2wgaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVlKENTU1Byb3BlcnR5SUQg
cHJvcGVydHlJZCwgaW50CiAjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKICAgICAgICAgaWYg
KHBhcnNlckNvbnRleHQuY3NzR3JpZExheW91dEVuYWJsZWQgJiYgKHZhbHVlSUQgPT0gQ1NTVmFs
dWVHcmlkIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVJbmxpbmVHcmlkKSkKICAgICAgICAgICAgIHJl
dHVybiB0cnVlOwotI2Vsc2UKLSAgICAgICAgVU5VU0VEX1BBUkFNKHBhcnNlckNvbnRleHQpOwog
I2VuZGlmCiAgICAgICAgIGJyZWFrOwogCkBAIC0xMDQ5LDcgKzEwNDcsNyBAQCBzdGF0aWMgaW5s
aW5lIGJvb2wgaXNWYWxpZEtleXdvcmRQcm9wZXJ0eUFuZFZhbHVlKENTU1Byb3BlcnR5SUQgcHJv
cGVydHlJZCwgaW50CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICByZXR1
cm4gZmFsc2U7CiAgICAgfQotI2lmICFFTkFCTEUoQ1NTX0NPTVBPU0lUSU5HKSAmJiAhRU5BQkxF
KENTU19SRUdJT05TKQorI2lmICFFTkFCTEUoQ1NTX0dSSURfTEFZT1VUKQogICAgIFVOVVNFRF9Q
QVJBTShwYXJzZXJDb250ZXh0KTsKICNlbmRpZgogICAgIHJldHVybiBmYWxzZTsK
</data>
<flag name="review"
          id="303152"
          type_id="1"
          status="+"
          setter="achristensen"
    />
    <flag name="commit-queue"
          id="303175"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>