157777 2016-05-16 17:45:52 -0700 WebCoreJSBuiltinInternals won't compile if some build flags are off 2016-05-16 18:05:37 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino cdumez webkit-bug-importer oldest_to_newest 1193642 0 dino 2016-05-16 17:45:52 -0700 We need to work around the situation when build flags are off. 1193644 1 webkit-bug-importer 2016-05-16 17:46:54 -0700 <rdar://problem/26312967> 1193646 2 279076 dino 2016-05-16 17:48:52 -0700 Created attachment 279076 Patch 1193647 3 279076 simon.fraser 2016-05-16 17:50:01 -0700 Comment on attachment 279076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279076&action=review > Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.cpp:56 > + (void)vm; I think UNUSED_PARAM would also work. 1193651 4 dino 2016-05-16 18:05:37 -0700 Committed r200985: <http://trac.webkit.org/changeset/200985> 279076 2016-05-16 17:48:52 -0700 2016-05-16 17:50:01 -0700 Patch bug-157777-20160517104947.patch text/plain 1705 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM3ODBmMWM1ZTI0NWE0 OGI5NzlmNDU0ZjdhNTA5ZjNmY2Q0NmQzZi4uY2JlNWU5MzIxNWIzYmI4M2NiMDI3NjJkMjVmYTI1 OTI4NTEyYjRhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTE2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlSlNCdWlsdGluSW50 ZXJuYWxzIHdvbid0IGNvbXBpbGUgaWYgc29tZSBidWlsZCBmbGFncyBhcmUgb2ZmCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3NzcKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI2MzEyOTY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFsbG93IHRoaXMgZmlsZSB0byBjb21waWxlIHdoZW4gc29tZSBi dWlsZCBmbGFncyBhcmUgZGlzYWJsZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9XZWJDb3Jl SlNCdWlsdGluSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTQnVpbHRpbkludGVy bmFsRnVuY3Rpb25zOjpKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9ucyk6CisKIDIwMTYtMDUtMTYg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5kZXJMYXllcjo6 aGl0VGVzdExpc3QgY291bGQgbXV0YXRlIHRoZSBsaXN0IG9mIGNhbmRpZGF0ZSBsYXllcnMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50 ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5J bnRlcm5hbHMuY3BwCmluZGV4IDczZjNmYjE3NmEwYjM2YjMwZmZiNjJkODAxZGQ4NTY2NjA2ZTJj MmYuLmFkYzM1YTdkODc2NzJlYjE3MThhNTNmZmIzMzQ4ODk0YzliNTliYjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5h bHMuY3BwCkBAIC00OSw2ICs0OSwxMiBAQCBKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9uczo6SlNC dWlsdGluSW50ZXJuYWxGdW5jdGlvbnMoSlNDOjpWTSYgdikKICAgICAsIG1fd3JpdGFibGVTdHJl YW1JbnRlcm5hbHNGdW5jdGlvbnModm0pCiAjZW5kaWYKIHsKKyNpZiAhRU5BQkxFKFNUUkVBTVNf QVBJKSAmJiAhRU5BQkxFKFdFQl9SVEMpCisgICAgLy8gRklYTUU6IFdoZW4gbm9uZSBvZiB0aGUg ZmVhdHVyZXMgdGhhdCB1c2UgdGhpcyBjbGFzcyBhcmUgZW5hYmxlZCwgd2UKKyAgICAvLyBkb24n dCBldmVyIHVzZSB0aGUgdm0gbWVtYmVyLiBIb3dldmVyLCB0aGUgbG9naWMgb2YgaW5pdGlhbGl6 aW5nCisgICAgLy8gaXQgd2hlbiBhbnkgb2YgdGhlIGZlYXR1cmVzIGFyZSBlbmFibGVkIGdldHMg cHJldHR5IG1lc3N5LgorICAgICh2b2lkKXZtOworI2VuZGlmCiB9CiAKIHZvaWQgSlNCdWlsdGlu SW50ZXJuYWxGdW5jdGlvbnM6OnZpc2l0KEpTQzo6U2xvdFZpc2l0b3ImIHZpc2l0b3IpCg==