157765 2016-05-16 16:00:40 -0700 Don't include CSSParser.h from other headers 2016-05-23 17:53:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1193581 0 achristensen 2016-05-16 16:00:40 -0700 Don't include CSSParser.h from other headers 1193582 1 279059 achristensen 2016-05-16 16:02:29 -0700 Created attachment 279059 Patch 1193584 2 279059 zalan 2016-05-16 16:04:30 -0700 Comment on attachment 279059 Patch lovely 1193592 3 achristensen 2016-05-16 16:10:27 -0700 http://trac.webkit.org/changeset/200977 1195559 4 279059 darin 2016-05-23 13:23:04 -0700 Comment on attachment 279059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279059&action=review > Source/WebCore/css/CSSProperty.h:107 > +typedef Vector<CSSProperty, 256> ParsedPropertyVector; This could be using instead of typedef. Why did we chose to change style? I thought that we were preferring using instead of typedef now in almost all cases. 1195561 5 achristensen 2016-05-23 13:25:04 -0700 (In reply to comment #4) > Comment on attachment 279059 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=279059&action=review > > > Source/WebCore/css/CSSProperty.h:107 > > +typedef Vector<CSSProperty, 256> ParsedPropertyVector; > > This could be using instead of typedef. Why did we chose to change style? I > thought that we were preferring using instead of typedef now in almost all > cases. I was not aware of this. We have a lot of typedefs, and I hadn't seen many usings, so I changed it. Is there any benefit either way? 1195670 6 279059 darin 2016-05-23 17:53:45 -0700 Comment on attachment 279059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279059&action=review >>> Source/WebCore/css/CSSProperty.h:107 >>> +typedef Vector<CSSProperty, 256> ParsedPropertyVector; >> >> This could be using instead of typedef. Why did we chose to change style? I thought that we were preferring using instead of typedef now in almost all cases. > > I was not aware of this. We have a lot of typedefs, and I hadn't seen many usings, so I changed it. Is there any benefit either way? http://stackoverflow.com/questions/10747810/what-is-the-difference-between-typedef-and-using-in-c11 279059 2016-05-16 16:02:29 -0700 2016-05-16 16:04:30 -0700 Patch bug-157765-20160516160325.patch text/plain 6363 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDk3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTA1LTE2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRG9uJ3QgaW5j bHVkZSBDU1NQYXJzZXIuaCBmcm9tIG90aGVyIGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzc2NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4gIFRoaXMg anVzdCBtYWtlcyBpdCBzbyB0b3VjaGluZyBDU1NQYXJzZXIuaCBkb2Vzbid0IHJlYnVpbGQgYXMg bWFueSBmaWxlcy4KKworICAgICAgICAqIGNzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcDoKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 c291cmNlU2l6ZSk6CisgICAgICAgIChXZWJDb3JlOjpmaWx0ZXJQcm9wZXJ0aWVzKToKKyAgICAg ICAgKiBjc3MvQ1NTUGFyc2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OlZhbHVl V2l0aENhbGN1bGF0aW9uOjpWYWx1ZVdpdGhDYWxjdWxhdGlvbik6CisgICAgICAgICogY3NzL0NT U1Byb3BlcnR5Lmg6CisgICAgICAgIChXZWJDb3JlOjpwcmVmaXhpbmdWYXJpYW50Rm9yUHJvcGVy dHlJZCk6CisgICAgICAgICogY3NzL0ZvbnRGYWNlLmNwcDoKKyAgICAgICAgKiBjc3MvU3R5bGVQ cm9wZXJ0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok11dGFibGVTdHlsZVByb3BlcnRpZXM6 OnBhcnNlRGVjbGFyYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TXV0YWJsZVN0eWxlUHJvcGVy dGllczo6YWRkUGFyc2VkUHJvcGVydGllcyk6CisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydGll cy5oOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmg6CisgICAgICAgICogcmVuZGVyaW5n L3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKwogMjAxNi0wNS0xNiAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgcm9sbG91dCByMjAwOTI0 LiBDYXVzZWQganMvcmVncmVzcy9zdHJpbmctcmVwbGFjZS1nZW5lcmljLmh0bWwgdG8gZmFpbC4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHAJKHJldmlz aW9uIDIwMDk1MSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgIkNTU0NhbGN1bGF0aW9uVmFsdWUuaCIKIAorI2luY2x1ZGUgIkNTU1BhcnNlci5o IgogI2luY2x1ZGUgIkNTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCIKICNpbmNsdWRlICJTdHls ZVJlc29sdmVyLmgiCiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDA5NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU5NCw3ICsxNTk0LDcgQEAgQ1NTUGFy c2VyOjpTb3VyY2VTaXplIENTU1BhcnNlcjo6c291cmNlUwogICAgIHJldHVybiBTb3VyY2VTaXpl KFdURk1vdmUoZXhwcmVzc2lvbiksIFdURk1vdmUodmFsdWUpKTsKIH0KIAotc3RhdGljIGlubGlu ZSB2b2lkIGZpbHRlclByb3BlcnRpZXMoYm9vbCBpbXBvcnRhbnQsIGNvbnN0IENTU1BhcnNlcjo6 UGFyc2VkUHJvcGVydHlWZWN0b3ImIGlucHV0LCBWZWN0b3I8Q1NTUHJvcGVydHksIDI1Nj4mIG91 dHB1dCwgc2l6ZV90JiB1bnVzZWRFbnRyaWVzLCBzdGQ6OmJpdHNldDxudW1DU1NQcm9wZXJ0aWVz PiYgc2VlblByb3BlcnRpZXMsIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiYgc2VlbkN1c3RvbVByb3Bl cnRpZXMpCitzdGF0aWMgaW5saW5lIHZvaWQgZmlsdGVyUHJvcGVydGllcyhib29sIGltcG9ydGFu dCwgY29uc3QgUGFyc2VkUHJvcGVydHlWZWN0b3ImIGlucHV0LCBWZWN0b3I8Q1NTUHJvcGVydHks IDI1Nj4mIG91dHB1dCwgc2l6ZV90JiB1bnVzZWRFbnRyaWVzLCBzdGQ6OmJpdHNldDxudW1DU1NQ cm9wZXJ0aWVzPiYgc2VlblByb3BlcnRpZXMsIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiYgc2VlbkN1 c3RvbVByb3BlcnRpZXMpCiB7CiAgICAgLy8gQWRkIHByb3BlcnRpZXMgaW4gcmV2ZXJzZSBvcmRl ciBzbyB0aGF0IGhpZ2hlc3QgcHJpb3JpdHkgZGVmaW5pdGlvbnMgYXJlIHJlYWNoZWQgZmlyc3Qu IER1cGxpY2F0ZSBkZWZpbml0aW9ucyBjYW4gdGhlbiBiZSBpZ25vcmVkIHdoZW4gZm91bmQuCiAg ICAgZm9yIChpbnQgaSA9IGlucHV0LnNpemUoKSAtIDE7IGkgPj0gMDsgLS1pKSB7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5oCShyZXZpc2lvbiAyMDA5NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg4LDggKzg4LDYgQEAgcHVibGljOgog ICAgICAgICBFcnJvcgogICAgIH07CiAKLSAgICB1c2luZyBQYXJzZWRQcm9wZXJ0eVZlY3RvciA9 IFZlY3RvcjxDU1NQcm9wZXJ0eSwgMjU2PjsKLQogICAgIGNsYXNzIFZhbHVlV2l0aENhbGN1bGF0 aW9uIHsKICAgICBwdWJsaWM6CiAgICAgICAgIGV4cGxpY2l0IFZhbHVlV2l0aENhbGN1bGF0aW9u KENTU1BhcnNlclZhbHVlJiB2YWx1ZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9w ZXJ0eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eS5oCShy ZXZpc2lvbiAyMDA5NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydHkuaAkod29y a2luZyBjb3B5KQpAQCAtMTA0LDYgKzEwNCw4IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPENTU1Zh bHVlPiBtX3ZhbHVlOwogfTsKIAordHlwZWRlZiBWZWN0b3I8Q1NTUHJvcGVydHksIDI1Nj4gUGFy c2VkUHJvcGVydHlWZWN0b3I7CisKIGlubGluZSBDU1NQcm9wZXJ0eUlEIHByZWZpeGluZ1Zhcmlh bnRGb3JQcm9wZXJ0eUlkKENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCkKIHsKICAgICBBU1NFUlQo cHJvcGVydHlJRCAhPSBDU1NQcm9wZXJ0eUludmFsaWQpOwpJbmRleDogU291cmNlL1dlYkNvcmUv Y3NzL0ZvbnRGYWNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvRm9udEZh Y2UuY3BwCShyZXZpc2lvbiAyMDA5NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpbmNsdWRlICJDU1NGb250 RmFjZVNvdXJjZS5oIgogI2luY2x1ZGUgIkNTU0ZvbnRGZWF0dXJlVmFsdWUuaCIKKyNpbmNsdWRl ICJDU1NQYXJzZXIuaCIKICNpbmNsdWRlICJDU1NVbmljb2RlUmFuZ2VWYWx1ZS5oIgogI2luY2x1 ZGUgIkNTU1ZhbHVlUG9vbC5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmNwcAkocmV2aXNpb24gMjAwOTUxKQorKysgU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxOCw3 ICs4MTgsNyBAQCBib29sIE11dGFibGVTdHlsZVByb3BlcnRpZXM6OnBhcnNlRGVjbGFyCiAgICAg cmV0dXJuIG9sZFByb3BlcnRpZXMgIT0gbV9wcm9wZXJ0eVZlY3RvcjsKIH0KIAotYm9vbCBNdXRh YmxlU3R5bGVQcm9wZXJ0aWVzOjphZGRQYXJzZWRQcm9wZXJ0aWVzKGNvbnN0IENTU1BhcnNlcjo6 UGFyc2VkUHJvcGVydHlWZWN0b3ImIHByb3BlcnRpZXMpCitib29sIE11dGFibGVTdHlsZVByb3Bl cnRpZXM6OmFkZFBhcnNlZFByb3BlcnRpZXMoY29uc3QgUGFyc2VkUHJvcGVydHlWZWN0b3ImIHBy b3BlcnRpZXMpCiB7CiAgICAgYm9vbCBhbnlDaGFuZ2VkID0gZmFsc2U7CiAgICAgbV9wcm9wZXJ0 eVZlY3Rvci5yZXNlcnZlQ2FwYWNpdHkobV9wcm9wZXJ0eVZlY3Rvci5zaXplKCkgKyBwcm9wZXJ0 aWVzLnNpemUoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5oCShyZXZp c2lvbiAyMDA5NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0aWVzLmgJKHdv cmtpbmcgY29weSkKQEAgLTIyLDcgKzIyLDYgQEAKICNpZm5kZWYgU3R5bGVQcm9wZXJ0aWVzX2gK ICNkZWZpbmUgU3R5bGVQcm9wZXJ0aWVzX2gKIAotI2luY2x1ZGUgIkNTU1BhcnNlci5oIgogI2lu Y2x1ZGUgIkNTU1BhcnNlck1vZGUuaCIKICNpbmNsdWRlICJDU1NQcmltaXRpdmVWYWx1ZS5oIgog I2luY2x1ZGUgIkNTU1Byb3BlcnR5LmgiCkBAIC0yMDEsNyArMjAwLDcgQEAgcHVibGljOgogCiAg ICAgUHJvcGVydHlTZXRDU1NTdHlsZURlY2xhcmF0aW9uKiBjc3NTdHlsZURlY2xhcmF0aW9uKCk7 CiAKLSAgICBib29sIGFkZFBhcnNlZFByb3BlcnRpZXMoY29uc3QgQ1NTUGFyc2VyOjpQYXJzZWRQ cm9wZXJ0eVZlY3RvciYpOworICAgIGJvb2wgYWRkUGFyc2VkUHJvcGVydGllcyhjb25zdCBQYXJz ZWRQcm9wZXJ0eVZlY3RvciYpOwogICAgIGJvb2wgYWRkUGFyc2VkUHJvcGVydHkoY29uc3QgQ1NT UHJvcGVydHkmKTsKIAogICAgIC8vIFRoZXNlIGV4cGFuZCBzaG9ydGhhbmQgcHJvcGVydGllcyBp bnRvIG11bHRpcGxlIHByb3BlcnRpZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVS ZXNvbHZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmgJKHJldmlzaW9uIDIwMDk1MSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYyLDcgQEAgY2xhc3MgQ1NTUHJvcGVydHk7CiBj bGFzcyBDU1NTZWxlY3RvcjsKIGNsYXNzIENTU1N0eWxlU2hlZXQ7CiBjbGFzcyBDU1NWYWx1ZTsK K2NsYXNzIENTU1ZhcmlhYmxlRGVwZW5kZW50VmFsdWU7CiBjbGFzcyBDb250YWluZXJOb2RlOwog Y2xhc3MgRG9jdW1lbnQ7CiBjbGFzcyBFbGVtZW50OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCShyZXZpc2lvbiAyMDA5NTEpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNSw2ICsyNSw3IEBACiAKICNpbmNsdWRlICJDb250ZW50RGF0YS5oIgogI2luY2x1 ZGUgIkNTU0N1c3RvbVByb3BlcnR5VmFsdWUuaCIKKyNpbmNsdWRlICJDU1NQYXJzZXIuaCIKICNp bmNsdWRlICJDU1NQcm9wZXJ0eU5hbWVzLmgiCiAjaW5jbHVkZSAiQ1NTVmFyaWFibGVEZXBlbmRl bnRWYWx1ZS5oIgogI2luY2x1ZGUgIkN1cnNvckxpc3QuaCIK