157764 2016-05-16 15:53:08 -0700 REGRESSION (200035): changes in "WebKit Malloc" VM regions are causing 'leaks' to spew "Failed to map remote region" messages 2016-05-22 11:33:12 -0700 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren ggaren msaboff oliver oldest_to_newest 1193576 0 ggaren 2016-05-16 15:53:08 -0700 REGRESSION (200035): changes in "WebKit Malloc" VM regions are causing 'leaks' to spew "Failed to map remote region" messages 1193579 1 279058 ggaren 2016-05-16 15:57:35 -0700 Created attachment 279058 Patch 1193580 2 ggaren 2016-05-16 15:58:51 -0700 <rdar://problem/26133021> 1193630 3 ggaren 2016-05-16 17:14:34 -0700 Committed r200983: <http://trac.webkit.org/changeset/200983> 1195430 4 279058 darin 2016-05-22 11:33:12 -0700 Comment on attachment 279058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279058&action=review > Source/bmalloc/bmalloc/VMHeap.cpp:53 > + m_zone.addRange(Range(chunk->bytes(), size)); Great style for this in new code: m_zone.addRange({ chunk->bytes(), size }); Nice to not state the class name again, and also does tighter type checking than the old style, which is sometimes better, sometimes worse. > Source/bmalloc/bmalloc/VMHeap.cpp:88 > + m_zone.addRange(Range(begin.address(), end.address() - begin.address())); Ditto. 279058 2016-05-16 15:57:35 -0700 2016-05-16 16:49:40 -0700 Patch bug-157764-20160516155831.patch text/plain 5087 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMDk3NSkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBACisyMDE2LTA1LTE2ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoMjAwMDM1 KTogY2hhbmdlcyBpbiAiV2ViS2l0IE1hbGxvYyIgVk0gcmVnaW9ucyBhcmUgY2F1c2luZyAnbGVh a3MnIHRvIHNwZXcgIkZhaWxlZCB0byBtYXAgcmVtb3RlIHJlZ2lvbiIgbWVzc2FnZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzc2NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gYWxs b3cgZm9yIGd1YXJkIHBhZ2VzIGFuZCBvbmx5IHJlcG9ydCB1bmd1YXJkZWQgcGFnZXMgdG8gdGhl CisgICAgICAgIGxlYWtzIHRvb2wgLS0gb3RoZXJ3aXNlLCBpdCB3aWxsIHRyeSB0byByZW1vdGUg bWFwIG91ciBndWFyZGVkIHBhZ2VzLAorICAgICAgICBhbmQgY3Jhc2guCisKKyAgICAgICAgKiBi bWFsbG9jL1ZNSGVhcC5jcHA6CisgICAgICAgIChibWFsbG9jOjpWTUhlYXA6OnRyeUFsbG9jYXRl TGFyZ2VDaHVuayk6CisgICAgICAgIChibWFsbG9jOjpWTUhlYXA6OmFsbG9jYXRlU21hbGxDaHVu ayk6IEFkb3B0IHRoZSBuZXcgQVBJIGZvciByZXBvcnRpbmcKKyAgICAgICAgYSByYW5nZSBpbnN0 ZWFkIG9mIGEgQ2h1bmsqLCBhbmQgcmVwb3J0IHRoZSB1bmd1YXJkZWQgcmFuZ2UuCisKKyAgICAg ICAgVGhpcyBhbHNvIGZpeGVzIGEgc2VwYXJhdGUgYnVnIC0tIHZlcnkgbGFyZ2UgYWxsb2NhdGlv bnMgd291bGQgbm90CisgICAgICAgIGZ1bGx5IHBhcnRpY2lwYXRlIGluIHBvaW50ZXIgc2Nhbm5p bmcgYmVjYXVzZSB0aGV5IHdvdWxkIG9ubHkgcmVwb3J0IDJNQgorICAgICAgICAoY2h1bmtTaXpl KSBpbiBzaXplLiBUaGlzIGNvdWxkIGNhdXNlIGZhbHNlLXBvc2l0aXZlIGxlYWsgcmVwb3J0cy4K KworICAgICAgICAqIGJtYWxsb2MvWm9uZS5jcHA6CisgICAgICAgIChibWFsbG9jOjplbnVtZXJh dG9yKTogVXBkYXRlZCB0byBzY2FuIHJhbmdlcyBpbnN0ZWFkIG9mIGZpeGVkLXNpemVkCisgICAg ICAgIENodW5rIHBvaW50ZXJzLgorCisgICAgICAgICogYm1hbGxvYy9ab25lLmg6CisgICAgICAg IChibWFsbG9jOjpab25lOjpyYW5nZXMpOgorICAgICAgICAoYm1hbGxvYzo6Wm9uZTo6YWRkUmFu Z2UpOiBTdG9yZSByYW5nZXMgaW5zdGVhZCBvZiBmaXhlZC1zaXplZCBDaHVuayAKKyAgICAgICAg cG9pbnRlcnMgYmVjYXVzZSBvdXIgVk0gcmFuZ2VzIGhhdmUgdmFyaWFibGUgc2l6ZXMgLS0gYm90 aCBkdWUgdG8gZ3VhcmQKKyAgICAgICAgcGFnZXMgYW5kIGR1ZSB0byBsYXJnZSBhbGxvY2F0aW9u cy4KKworICAgICAgICAoYm1hbGxvYzo6Wm9uZTo6Y2h1bmtzKTogRGVsZXRlZC4KKyAgICAgICAg KGJtYWxsb2M6OlpvbmU6OmFkZENodW5rKTogRGVsZXRlZC4KKwogMjAxNi0wNS0xMCAgRGF2aWQg S2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGJtYWxsb2Mgc2hvdWxkIGF1 dG9tYXRpY2FsbHkgZGlzYWJsZSBpdHNlbGYgd2hlbiBUaHJlYWRTYW5pdGl6ZXIgaXMgdXNlZApJ bmRleDogU291cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUhlYXAuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9ibWFsbG9jL2JtYWxsb2MvVk1IZWFwLmNwcAkocmV2aXNpb24gMjAwOTcxKQorKysgU291 cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUhlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1 MCw3IEBAIFhMYXJnZVJhbmdlIFZNSGVhcDo6dHJ5QWxsb2NhdGVMYXJnZUNodW4KICAgICBDaHVu ayogY2h1bmsgPSBzdGF0aWNfY2FzdDxDaHVuayo+KG1lbW9yeSk7CiAgICAgCiAjaWYgQk9TKERB UldJTikKLSAgICBtX3pvbmUuYWRkQ2h1bmsoY2h1bmspOworICAgIG1fem9uZS5hZGRSYW5nZShS YW5nZShjaHVuay0+Ynl0ZXMoKSwgc2l6ZSkpOwogI2VuZGlmCiAKICAgICByZXR1cm4gWExhcmdl UmFuZ2UoY2h1bmstPmJ5dGVzKCksIHNpemUsIDApOwpAQCAtODUsNyArODUsNyBAQCB2b2lkIFZN SGVhcDo6YWxsb2NhdGVTbWFsbENodW5rKHN0ZDo6bG9jCiAgICAgbmV3IChjaHVuaykgQ2h1bmso bG9jayk7CiAKICNpZiBCT1MoREFSV0lOKQotICAgIG1fem9uZS5hZGRDaHVuayhjaHVuayk7Cisg ICAgbV96b25lLmFkZFJhbmdlKFJhbmdlKGJlZ2luLmFkZHJlc3MoKSwgZW5kLmFkZHJlc3MoKSAt IGJlZ2luLmFkZHJlc3MoKSkpOwogI2VuZGlmCiAKICAgICBmb3IgKE9iamVjdCBpdCA9IGJlZ2lu OyBpdCArIHBhZ2VTaXplIDw9IGVuZDsgaXQgPSBpdCArIHBhZ2VTaXplKSB7CkluZGV4OiBTb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL1pvbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9j L2JtYWxsb2MvWm9uZS5jcHAJKHJldmlzaW9uIDIwMDk3MSkKKysrIFNvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvWm9uZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4LDE0ICs4OCwxNCBAQCBzdGF0aWMg c2l6ZV90IHpvbmVTaXplKG1hbGxvY196b25lX3QqLCBjCiBzdGF0aWMga2Vybl9yZXR1cm5fdCBl bnVtZXJhdG9yKHRhc2tfdCB0YXNrLCB2b2lkKiBjb250ZXh0LCB1bnNpZ25lZCB0eXBlX21hc2ss IHZtX2FkZHJlc3NfdCB6b25lX2FkZHJlc3MsIG1lbW9yeV9yZWFkZXJfdCByZWFkZXIsIHZtX3Jh bmdlX3JlY29yZGVyX3QgcmVjb3JkZXIpCiB7CiAgICAgWm9uZSByZW1vdGVab25lKHRhc2ssIHJl YWRlciwgem9uZV9hZGRyZXNzKTsKLSAgICBmb3IgKGF1dG8qIGNodW5rIDogcmVtb3RlWm9uZS5j aHVua3MoKSkgewotICAgICAgICB2bV9yYW5nZV90IHJhbmdlID0geyByZWludGVycHJldF9jYXN0 PHZtX2FkZHJlc3NfdD4oY2h1bmspLCBjaHVua1NpemUgfTsKKyAgICBmb3IgKGF1dG8mIHJhbmdl IDogcmVtb3RlWm9uZS5yYW5nZXMoKSkgeworICAgICAgICB2bV9yYW5nZV90IHZtUmFuZ2UgPSB7 IHJlaW50ZXJwcmV0X2Nhc3Q8dm1fYWRkcmVzc190PihyYW5nZS5iZWdpbigpKSwgcmFuZ2Uuc2l6 ZSgpIH07CiAKICAgICAgICAgaWYgKCh0eXBlX21hc2sgJiBNQUxMT0NfUFRSX1JFR0lPTl9SQU5H RV9UWVBFKSkKLSAgICAgICAgICAgICgqcmVjb3JkZXIpKHRhc2ssIGNvbnRleHQsIE1BTExPQ19Q VFJfUkVHSU9OX1JBTkdFX1RZUEUsICZyYW5nZSwgMSk7CisgICAgICAgICAgICAoKnJlY29yZGVy KSh0YXNrLCBjb250ZXh0LCBNQUxMT0NfUFRSX1JFR0lPTl9SQU5HRV9UWVBFLCAmdm1SYW5nZSwg MSk7CiAKICAgICAgICAgaWYgKCh0eXBlX21hc2sgJiBNQUxMT0NfUFRSX0lOX1VTRV9SQU5HRV9U WVBFKSkKLSAgICAgICAgICAgICgqcmVjb3JkZXIpKHRhc2ssIGNvbnRleHQsIE1BTExPQ19QVFJf SU5fVVNFX1JBTkdFX1RZUEUsICZyYW5nZSwgMSk7CisgICAgICAgICAgICAoKnJlY29yZGVyKSh0 YXNrLCBjb250ZXh0LCBNQUxMT0NfUFRSX0lOX1VTRV9SQU5HRV9UWVBFLCAmdm1SYW5nZSwgMSk7 CiAgICAgfQogCiAgICAgcmV0dXJuIDA7CkluZGV4OiBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1pv bmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1pvbmUuaAkocmV2aXNp b24gMjAwOTcxKQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9ab25lLmgJKHdvcmtpbmcgY29w eSkKQEAgLTI3LDYgKzI3LDcgQEAKICNkZWZpbmUgWm9uZV9oCiAKICNpbmNsdWRlICJGaXhlZFZl Y3Rvci5oIgorI2luY2x1ZGUgIlJhbmdlLmgiCiAjaW5jbHVkZSA8bWFsbG9jL21hbGxvYy5oPgog CiBuYW1lc3BhY2UgYm1hbGxvYyB7CkBAIC00MSw4ICs0Miw4IEBAIHB1YmxpYzoKICAgICBab25l KCk7CiAgICAgWm9uZSh0YXNrX3QsIG1lbW9yeV9yZWFkZXJfdCwgdm1fYWRkcmVzc190KTsKIAot ICAgIHZvaWQgYWRkQ2h1bmsoQ2h1bmsqKTsKLSAgICBGaXhlZFZlY3RvcjxDaHVuayosIGNhcGFj aXR5PiYgY2h1bmtzKCkgeyByZXR1cm4gbV9jaHVua3M7IH0KKyAgICB2b2lkIGFkZFJhbmdlKFJh bmdlKTsKKyAgICBGaXhlZFZlY3RvcjxSYW5nZSwgY2FwYWNpdHk+JiByYW5nZXMoKSB7IHJldHVy biBtX3JhbmdlczsgfQogICAgIAogcHJpdmF0ZToKICAgICAvLyBUaGlzIHZlY3RvciBoYXMgdHdv IHB1cnBvc2VzOgpAQCAtNTYsMTUgKzU3LDE1IEBAIHByaXZhdGU6CiAgICAgLy8gVGhpcyBwcmV2 ZW50cyB0aGUgbGVha3MgdG9vbCBmcm9tIHJlcG9ydGluZyBmYWxzZSBwb3NpdGl2ZSBsZWFrcyBm b3IKICAgICAvLyBvYmplY3RzIHBvaW50ZWQgdG8gZnJvbSBibWFsbG9jIG1lbW9yeSAtLSB0aG91 Z2ggaXQgYWxzbyBwcmV2ZW50cyB0aGUKICAgICAvLyBsZWFrcyB0b29sIGZyb20gZmluZGluZyBh bnkgbGVha3MgaW4gYm1hbGxvYyBtZW1vcnkuCi0gICAgRml4ZWRWZWN0b3I8Q2h1bmsqLCBjYXBh Y2l0eT4gbV9jaHVua3M7CisgICAgRml4ZWRWZWN0b3I8UmFuZ2UsIGNhcGFjaXR5PiBtX3Jhbmdl czsKIH07CiAKLWlubGluZSB2b2lkIFpvbmU6OmFkZENodW5rKENodW5rKiBjaHVuaykKK2lubGlu ZSB2b2lkIFpvbmU6OmFkZFJhbmdlKFJhbmdlIHJhbmdlKQogewotICAgIGlmIChtX2NodW5rcy5z aXplKCkgPT0gbV9jaHVua3MuY2FwYWNpdHkoKSkKKyAgICBpZiAobV9yYW5nZXMuc2l6ZSgpID09 IG1fcmFuZ2VzLmNhcGFjaXR5KCkpCiAgICAgICAgIHJldHVybjsKICAgICAKLSAgICBtX2NodW5r cy5wdXNoKGNodW5rKTsKKyAgICBtX3Jhbmdlcy5wdXNoKHJhbmdlKTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgYm1hbGxvYwo=