157747 2016-05-16 12:42:31 -0700 Use WTF::Optional for ScrollView's m_deferredScrollDelta / m_deferredScrollOffsets 2016-05-16 13:24:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue simon.fraser thorton zalan oldest_to_newest 1193472 0 cdumez 2016-05-16 12:42:31 -0700 Use WTF::Optional for ScrollView's m_deferredScrollDelta / m_deferredScrollOffsets instead of std::unique_ptr as it is more suited for this purpose. 1193474 1 279036 cdumez 2016-05-16 12:43:29 -0700 Created attachment 279036 Patch 1193492 2 279036 commit-queue 2016-05-16 13:23:56 -0700 Comment on attachment 279036 Patch Clearing flags on attachment: 279036 Committed r200963: <http://trac.webkit.org/changeset/200963> 1193493 3 commit-queue 2016-05-16 13:24:01 -0700 All reviewed patches have been landed. Closing bug. 279036 2016-05-16 12:43:29 -0700 2016-05-16 13:23:56 -0700 Patch bug-157747-20160516124425.patch text/plain 4000 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAwZTlhNGY0ZjY0NTJh OWExOWMyOTNhMzdmZGQyNjhiYzI2YTU4Yy4uZDYzN2QxNmUxY2ViMDBlNTJmZWFjZTU1ZDg5ZjQ0 ZTliYWQ1NTI5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA1LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFdURjo6T3B0aW9uYWwg Zm9yIFNjcm9sbFZpZXcncyBtX2RlZmVycmVkU2Nyb2xsRGVsdGEgLyBtX2RlZmVycmVkU2Nyb2xs T2Zmc2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU3NzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIFdURjo6T3B0aW9uYWwgZm9yIFNjcm9sbFZpZXcncyBtX2RlZmVycmVkU2Nyb2xsRGVsdGEg LyBtX2RlZmVycmVkU2Nyb2xsT2Zmc2V0cworICAgICAgICBpbnN0ZWFkIG9mIHN0ZDo6dW5pcXVl X3B0ciBhcyBpdCBpcyBtb3JlIHN1aXRlZCBmb3IgdGhpcyBwdXJwb3NlLgorCisgICAgICAgICog cGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojpz Y3JvbGxPZmZzZXRDaGFuZ2VkVmlhUGxhdGZvcm1XaWRnZXQpOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsVmlldzo6aGFuZGxlRGVmZXJyZWRTY3JvbGxVcGRhdGVBZnRlckNvbnRlbnRTaXplQ2hh bmdlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OnNjcm9sbFRvKToKKyAgICAgICAg KiBwbGF0Zm9ybS9TY3JvbGxWaWV3Lmg6CisKIDIwMTYtMDUtMTYgIFphbGFuIEJ1anRhcyAgPHph bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBjb250YWluaW5nQmxvY2tGb3IqUG9zaXRpb24gZnVu Y3Rpb25zIHNob3VsZCB0YWtlIHRoZSByZW5kZXJlciBpbnN0ZWFkIG9mIHRoZSBwYXJlbnQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IGM2MjlmYjJlOGEzNTRjZWRl M2UyOGQ2MDIwNGFhZjY3YWRiYzcxNTEuLjliNzhiZDRlNzg3ZDQxMDllYzQxNWVmYWI2ZDlkYjc3 ZWJiMmI4MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC00NDgs NyArNDQ4LDcgQEAgdm9pZCBTY3JvbGxWaWV3OjpzY3JvbGxPZmZzZXRDaGFuZ2VkVmlhUGxhdGZv cm1XaWRnZXQoY29uc3QgU2Nyb2xsT2Zmc2V0JiBvbGRPZmYKICAgICAvLyBpcyBub3QgY29tcGxl dGUuIEluc3RlYWQsIGRlZmVyIHRoZSBzY3JvbGwgZXZlbnQgdW50aWwgdGhlIGxheW91dCBmaW5p c2hlcy4KICAgICBpZiAoc2hvdWxkRGVmZXJTY3JvbGxVcGRhdGVBZnRlckNvbnRlbnRTaXplQ2hh bmdlKCkpIHsKICAgICAgICAgLy8gV2Ugb25seSBjYXJlIGFib3V0IHRoZSBtb3N0IHJlY2VudCBz Y3JvbGwgcG9zaXRpb24gY2hhbmdlIHJlcXVlc3QKLSAgICAgICAgbV9kZWZlcnJlZFNjcm9sbE9m ZnNldHMgPSBzdGQ6Om1ha2VfdW5pcXVlPHN0ZDo6cGFpcjxTY3JvbGxPZmZzZXQsIFNjcm9sbE9m ZnNldD4+KHN0ZDo6bWFrZV9wYWlyKG9sZE9mZnNldCwgbmV3T2Zmc2V0KSk7CisgICAgICAgIG1f ZGVmZXJyZWRTY3JvbGxPZmZzZXRzID0gc3RkOjptYWtlX3BhaXIob2xkT2Zmc2V0LCBuZXdPZmZz ZXQpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkBAIC00NjUsMTIgKzQ2NSwxMiBAQCB2b2lk IFNjcm9sbFZpZXc6OmhhbmRsZURlZmVycmVkU2Nyb2xsVXBkYXRlQWZ0ZXJDb250ZW50U2l6ZUNo YW5nZSgpCiAgICAgQVNTRVJUKHN0YXRpY19jYXN0PGJvb2w+KG1fZGVmZXJyZWRTY3JvbGxEZWx0 YSkgIT0gc3RhdGljX2Nhc3Q8Ym9vbD4obV9kZWZlcnJlZFNjcm9sbE9mZnNldHMpKTsKIAogICAg IGlmIChtX2RlZmVycmVkU2Nyb2xsRGVsdGEpCi0gICAgICAgIGNvbXBsZXRlVXBkYXRlc0FmdGVy U2Nyb2xsVG8oKm1fZGVmZXJyZWRTY3JvbGxEZWx0YSk7CisgICAgICAgIGNvbXBsZXRlVXBkYXRl c0FmdGVyU2Nyb2xsVG8obV9kZWZlcnJlZFNjcm9sbERlbHRhLnZhbHVlKCkpOwogICAgIGVsc2Ug aWYgKG1fZGVmZXJyZWRTY3JvbGxPZmZzZXRzKQotICAgICAgICBzY3JvbGxPZmZzZXRDaGFuZ2Vk VmlhUGxhdGZvcm1XaWRnZXRJbXBsKG1fZGVmZXJyZWRTY3JvbGxPZmZzZXRzLT5maXJzdCwgbV9k ZWZlcnJlZFNjcm9sbE9mZnNldHMtPnNlY29uZCk7CisgICAgICAgIHNjcm9sbE9mZnNldENoYW5n ZWRWaWFQbGF0Zm9ybVdpZGdldEltcGwobV9kZWZlcnJlZFNjcm9sbE9mZnNldHMudmFsdWUoKS5m aXJzdCwgbV9kZWZlcnJlZFNjcm9sbE9mZnNldHMudmFsdWUoKS5zZWNvbmQpOwogICAgIAotICAg IG1fZGVmZXJyZWRTY3JvbGxEZWx0YSA9IG51bGxwdHI7Ci0gICAgbV9kZWZlcnJlZFNjcm9sbE9m ZnNldHMgPSBudWxscHRyOworICAgIG1fZGVmZXJyZWRTY3JvbGxEZWx0YSA9IE51bGxvcHQ7Cisg ICAgbV9kZWZlcnJlZFNjcm9sbE9mZnNldHMgPSBOdWxsb3B0OwogfQogCiB2b2lkIFNjcm9sbFZp ZXc6OnNjcm9sbFRvKGNvbnN0IFNjcm9sbFBvc2l0aW9uJiBuZXdQb3NpdGlvbikKQEAgLTQ5Niw3 ICs0OTYsNyBAQCB2b2lkIFNjcm9sbFZpZXc6OnNjcm9sbFRvKGNvbnN0IFNjcm9sbFBvc2l0aW9u JiBuZXdQb3NpdGlvbikKICAgICAvLyBpcyBub3QgY29tcGxldGUuIEluc3RlYWQsIGRlZmVyIHRo ZSBzY3JvbGwgZXZlbnQgdW50aWwgdGhlIGxheW91dCBmaW5pc2hlcy4KICAgICBpZiAoc2hvdWxk RGVmZXJTY3JvbGxVcGRhdGVBZnRlckNvbnRlbnRTaXplQ2hhbmdlKCkpIHsKICAgICAgICAgQVNT RVJUKCFtX2RlZmVycmVkU2Nyb2xsRGVsdGEpOwotICAgICAgICBtX2RlZmVycmVkU2Nyb2xsRGVs dGEgPSBzdGQ6Om1ha2VfdW5pcXVlPEludFNpemU+KHNjcm9sbERlbHRhKTsKKyAgICAgICAgbV9k ZWZlcnJlZFNjcm9sbERlbHRhID0gc2Nyb2xsRGVsdGE7CiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaAppbmRleCA0ZjgwNWEyMTc4MDQ2OWYx YmQzMWM2NzA0MDU3MDRjYzJlYmEyNDBlLi5kZDlkYjNkYWNmNzY2NDAzYzQxOWUyODdkNTdmNTA2 MTZjOWVmMTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCkBAIC00NjEsOCAr NDYxLDggQEAgcHJpdmF0ZToKICAgICBJbnRTaXplIG1fZml4ZWRMYXlvdXRTaXplOwogICAgIElu dFNpemUgbV9jb250ZW50c1NpemU7CiAKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8SW50U2l6ZT4gbV9k ZWZlcnJlZFNjcm9sbERlbHRhOyAvLyBOZWVkZWQgZm9yIFdlYktpdCBzY3JvbGxpbmcKLSAgICBz dGQ6OnVuaXF1ZV9wdHI8c3RkOjpwYWlyPFNjcm9sbE9mZnNldCwgU2Nyb2xsT2Zmc2V0Pj4gbV9k ZWZlcnJlZFNjcm9sbE9mZnNldHM7IC8vIE5lZWRlZCBmb3IgcGxhdGZvcm0gd2lkZ2V0IHNjcm9s bGluZworICAgIE9wdGlvbmFsPEludFNpemU+IG1fZGVmZXJyZWRTY3JvbGxEZWx0YTsgLy8gTmVl ZGVkIGZvciBXZWJLaXQgc2Nyb2xsaW5nCisgICAgT3B0aW9uYWw8c3RkOjpwYWlyPFNjcm9sbE9m ZnNldCwgU2Nyb2xsT2Zmc2V0Pj4gbV9kZWZlcnJlZFNjcm9sbE9mZnNldHM7IC8vIE5lZWRlZCBm b3IgcGxhdGZvcm0gd2lkZ2V0IHNjcm9sbGluZwogCiAgICAgYm9vbCBtX3Njcm9sbGJhcnNTdXBw cmVzc2VkOwogCg==