157740 2016-05-16 08:43:30 -0700 Random CachedFont.cpp cleanup 2016-05-23 17:50:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson cdumez commit-queue japhet koivisto mmaxfield oldest_to_newest 1193388 0 beidson 2016-05-16 08:43:30 -0700 Clean up RefPtr misuse in CachedFont.cpp 1193391 1 beidson 2016-05-16 08:52:32 -0700 style checker noticed a couple of "misnamed protector refs" in this file. While there's discussion in https://bugs.webkit.org/show_bug.cgi?id=157591 on the future of the style-checker enforcement of the new naming rule, running it against this file pointed to some tiny opportunities for cleanup. 1193394 2 279019 beidson 2016-05-16 08:56:06 -0700 Created attachment 279019 Patch 1193405 3 279019 commit-queue 2016-05-16 10:21:17 -0700 Comment on attachment 279019 Patch Clearing flags on attachment: 279019 Committed r200944: <http://trac.webkit.org/changeset/200944> 1193406 4 commit-queue 2016-05-16 10:21:21 -0700 All reviewed patches have been landed. Closing bug. 1195669 5 279019 darin 2016-05-23 17:50:38 -0700 Comment on attachment 279019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279019&action=review > Source/WebCore/loader/cache/CachedFont.cpp:116 > + auto buffer = SharedBuffer::adoptVector(convertedFont); > + return createFontCustomPlatformData(*buffer); I’d like this better without a local variable. 279019 2016-05-16 08:56:06 -0700 2016-05-16 10:21:17 -0700 Patch bug-157740-20160516085702.patch text/plain 2962 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThjZWE5YzA1YTNiYmEz NGNiZjI5NDJhOGZlOGNiNjU3NTJjMWUwYy4uYWVhMzRkNWJmY2ZmYTBhMzNhZDZmNzZkNWY2OWU2 NzY0ODQ4MmZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTE2ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSYW5kb20gQ2FjaGVkRm9u dC5jcHAgY2xlYW51cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1Nzc0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyAoUmVmYWN0b3IvY2xlYW51cCwgbm8gYmVoYXZpb3IgY2hhbmdl KQorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZEZvbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q2FjaGVkRm9udDo6ZW5zdXJlQ3VzdG9tRm9udERhdGEpOiBSZW1vdmUgdW5uZWVkZWQg bG9jYWwgUmVmUHRyPD4KKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZEZvbnQ6OmNyZWF0ZUN1c3Rv bUZvbnREYXRhKTogUmVmYWN0b3IgdG8gbm90IHJlcXVpcmUgdW5uZWNlc3NhcnkgUmVmLWNodXJu IGluIHRoZSBjb21tb24gY2FzZS4KKwogMjAxNi0wNS0xNiAgTWljaGFlbCBDYXRhbnphcm8gIDxt Y2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgQ1NTUGFyc2VyLmNwcCB0cmlnZ2VycyAt V3VudXNlZC1wYXJhbWV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRGb250LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250 LmNwcAppbmRleCBiZmE0MTBhNWQ2NzA2YWZjYWIxYWI2ODg3MmJkNDZiODNlZDI3NzY0Li5mZDgz MTVkNmM4ZjUwOGUwOGJlNzQzOWNmZDI5ZmMzNmY3ZGVhZDNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZEZvbnQuY3BwCkBAIC05MSw5ICs5MSw4IEBAIGJvb2wgQ2FjaGVk Rm9udDo6ZW5zdXJlQ3VzdG9tRm9udERhdGEoY29uc3QgQXRvbWljU3RyaW5nJikKIGJvb2wgQ2Fj aGVkRm9udDo6ZW5zdXJlQ3VzdG9tRm9udERhdGEoU2hhcmVkQnVmZmVyKiBkYXRhKQogewogICAg IGlmICghbV9mb250Q3VzdG9tUGxhdGZvcm1EYXRhICYmICFlcnJvck9jY3VycmVkKCkgJiYgIWlz TG9hZGluZygpICYmIGRhdGEpIHsKLSAgICAgICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gYnVmZmVy KGRhdGEpOwogICAgICAgICBib29sIHdyYXBwaW5nOwotICAgICAgICBtX2ZvbnRDdXN0b21QbGF0 Zm9ybURhdGEgPSBjcmVhdGVDdXN0b21Gb250RGF0YSgqYnVmZmVyLCB3cmFwcGluZyk7CisgICAg ICAgIG1fZm9udEN1c3RvbVBsYXRmb3JtRGF0YSA9IGNyZWF0ZUN1c3RvbUZvbnREYXRhKCpkYXRh LCB3cmFwcGluZyk7CiAgICAgICAgIG1faGFzQ3JlYXRlZEZvbnREYXRhV3JhcHBpbmdSZXNvdXJj ZSA9IG1fZm9udEN1c3RvbVBsYXRmb3JtRGF0YSAmJiB3cmFwcGluZzsKICAgICAgICAgaWYgKCFt X2ZvbnRDdXN0b21QbGF0Zm9ybURhdGEpCiAgICAgICAgICAgICBzZXRTdGF0dXMoRGVjb2RlRXJy b3IpOwpAQCAtMTA0LDIxICsxMDMsMjEgQEAgYm9vbCBDYWNoZWRGb250OjplbnN1cmVDdXN0b21G b250RGF0YShTaGFyZWRCdWZmZXIqIGRhdGEpCiAKIHN0ZDo6dW5pcXVlX3B0cjxGb250Q3VzdG9t UGxhdGZvcm1EYXRhPiBDYWNoZWRGb250OjpjcmVhdGVDdXN0b21Gb250RGF0YShTaGFyZWRCdWZm ZXImIGJ5dGVzLCBib29sJiB3cmFwcGluZykKIHsKLSAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBi dWZmZXIgPSAmYnl0ZXM7CiAgICAgd3JhcHBpbmcgPSB0cnVlOwogCiAjaWYgIVBMQVRGT1JNKENP Q09BKQotICAgIGlmIChpc1dPRkYoKmJ1ZmZlcikpIHsKLSAgICAgICAgVmVjdG9yPGNoYXI+IGNv bnZlcnRlZEZvbnQ7Ci0gICAgICAgIGlmICghY29udmVydFdPRkZUb1NmbnQoKmJ1ZmZlciwgY29u dmVydGVkRm9udCkpCi0gICAgICAgICAgICBidWZmZXIgPSBudWxscHRyOwotICAgICAgICBlbHNl Ci0gICAgICAgICAgICBidWZmZXIgPSBTaGFyZWRCdWZmZXI6OmFkb3B0VmVjdG9yKGNvbnZlcnRl ZEZvbnQpOworICAgIGlmIChpc1dPRkYoYnl0ZXMpKSB7CiAgICAgICAgIHdyYXBwaW5nID0gZmFs c2U7CisgICAgICAgIFZlY3RvcjxjaGFyPiBjb252ZXJ0ZWRGb250OworICAgICAgICBpZiAoIWNv bnZlcnRXT0ZGVG9TZm50KGJ5dGVzLCBjb252ZXJ0ZWRGb250KSkKKyAgICAgICAgICAgIHJldHVy biBudWxscHRyOworCisgICAgICAgIGF1dG8gYnVmZmVyID0gU2hhcmVkQnVmZmVyOjphZG9wdFZl Y3Rvcihjb252ZXJ0ZWRGb250KTsKKyAgICAgICAgcmV0dXJuIGNyZWF0ZUZvbnRDdXN0b21QbGF0 Zm9ybURhdGEoKmJ1ZmZlcik7CiAgICAgfQogI2VuZGlmCiAKLSAgICByZXR1cm4gYnVmZmVyID8g Y3JlYXRlRm9udEN1c3RvbVBsYXRmb3JtRGF0YSgqYnVmZmVyKSA6IG51bGxwdHI7CisgICAgcmV0 dXJuIGNyZWF0ZUZvbnRDdXN0b21QbGF0Zm9ybURhdGEoYnl0ZXMpOwogfQogCiBSZWZQdHI8Rm9u dD4gQ2FjaGVkRm9udDo6Y3JlYXRlRm9udChjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnREZXNj cmlwdGlvbiwgY29uc3QgQXRvbWljU3RyaW5nJiwgYm9vbCBzeW50aGV0aWNCb2xkLCBib29sIHN5 bnRoZXRpY0l0YWxpYywgY29uc3QgRm9udEZlYXR1cmVTZXR0aW5ncyYgZm9udEZhY2VGZWF0dXJl cywgY29uc3QgRm9udFZhcmlhbnRTZXR0aW5ncyYgZm9udEZhY2VWYXJpYW50U2V0dGluZ3MpCg==