157711 2016-05-14 13:31:12 -0700 Use new Web IDL dictionary support for MediaSession.setMetadata() 2022-09-02 15:54:33 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 157725 1 cdumez cdumez ahmad.saleem792 ap bfulgham cdumez commit-queue darin eric.carlson jer.noble rniwa oldest_to_newest 1193133 0 cdumez 2016-05-14 13:31:12 -0700 Use new Web IDL dictionary support for MediaSession.setMetadata() 1193134 1 278944 cdumez 2016-05-14 13:34:09 -0700 Created attachment 278944 Patch 1193161 2 278944 commit-queue 2016-05-14 16:51:07 -0700 Comment on attachment 278944 Patch Clearing flags on attachment: 278944 Committed r200925: <http://trac.webkit.org/changeset/200925> 1193162 3 commit-queue 2016-05-14 16:51:13 -0700 All reviewed patches have been landed. Closing bug. 1193195 4 278944 darin 2016-05-15 01:41:15 -0700 Comment on attachment 278944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278944&action=review > Source/WebCore/Modules/mediasession/MediaSession.h:56 > + struct MediaMetadataInit { I am surprised this works. Maybe the bindings are inside an #if and not compiling. The name for the struct is supposed to be MediaSession::MetadataInit, not MediaSession::MediaMetadataInit. Maybe there is a bug in the GetNestedClassName function in CodeGeneratorJS.pm? 1193196 5 darin 2016-05-15 01:42:34 -0700 Yes, looks like this will fail to compile if ENABLE(MEDIA_SESSION) is true. 1193211 6 commit-queue 2016-05-15 08:34:07 -0700 Re-opened since this is blocked by bug 157725 1193212 7 cdumez 2016-05-15 08:34:12 -0700 (In reply to comment #5) > Yes, looks like this will fail to compile if ENABLE(MEDIA_SESSION) is true. Ok, I will roll out :( I was convinced this was enabled on Mac for some reason. 1193223 8 darin 2016-05-15 10:15:07 -0700 We can definitely redo it; we just need to turn on compiling on some platform. I find it really hard to maintain code that is not compiled! 1895908 9 ahmad.saleem792 2022-09-02 15:54:17 -0700 This was rolled out and I noticed that there are difference in Webkit MediaSession.IDL with Chrome / Blink: Webkit Link - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/mediasession/MediaSession.idl Chromium / Blink - https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediasession/media_session.idl?q=media_Session.idl Chris - is this needed? Thanks! 278944 2016-05-14 13:34:09 -0700 2016-05-14 16:51:07 -0700 Patch bug-157711-20160514133503.patch text/plain 4962 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFkYzFmOWU5YjFmNjUy ZWRlZTM0ZGE5MjE2NDRhM2VmYjFiYTM4Zi4uOTBmZTcwOGY5YjM3NTdmNzczNzYyYWIzYzMxODZm NzM0NDFhNzA5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTA1LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIG5ldyBXZWIgSURMIGRp Y3Rpb25hcnkgc3VwcG9ydCBmb3IgTWVkaWFTZXNzaW9uLnNldE1ldGFkYXRhKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzcxMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBuZXcgV2ViIElETCBk aWN0aW9uYXJ5IHN1cHBvcnQgZm9yIE1lZGlhU2Vzc2lvbi5zZXRNZXRhZGF0YSgpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gaW50ZW5kZWQgV2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vzc2lvbjo6c2V0TWV0YWRhdGEpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFTZXNzaW9uOjpkZWFjdGl2YXRlKTogRGVsZXRlZC4KKyAgICAgICAgKiBNb2R1 bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaDoKKyAgICAgICAgKiBNb2R1bGVzL21lZGlh c2Vzc2lvbi9NZWRpYVNlc3Npb24uaWRsOgorCisyMDE2LTA1LTE0ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKICAgICAgICAgW1dlYklETF0gQWRkIHN1cHBvcnQgZm9yIGRpY3Rp b25hcnkgbWVtYmVycyBvZiBpbnRlZ2VyIHR5cGVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc3MDMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAKaW5kZXggM2E4MjE2NmYxMDE1 OTQzNWI3NmU5Zjg1Y2RmZTQ4YzUxYjliNGVjNy4uNzNiMTY3MDIyYTkyMDQxNTY5NzM4MjI2YzVj MDgxMGM0ZGI2OTE2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNl c3Npb24vTWVkaWFTZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwCkBAIC0zMCw3ICszMCw2IEBACiAKICNpbmNsdWRlICJD aHJvbWUuaCIKICNpbmNsdWRlICJDaHJvbWVDbGllbnQuaCIKLSNpbmNsdWRlICJEaWN0aW9uYXJ5 LmgiCiAjaW5jbHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJIVE1MTWVkaWFFbGVtZW50LmgiCiAj aW5jbHVkZSAiTWVkaWFTZXNzaW9uTWFuYWdlci5oIgpAQCAtMTEzLDMxICsxMTIsMTUgQEAgYm9v bCBNZWRpYVNlc3Npb246Omhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSBjb25zdAogICAgIHJldHVy biAhbV9hY3RpdmVQYXJ0aWNpcGF0aW5nRWxlbWVudHMuaXNFbXB0eSgpOwogfQogCi12b2lkIE1l ZGlhU2Vzc2lvbjo6c2V0TWV0YWRhdGEoY29uc3QgRGljdGlvbmFyeSYgbWV0YWRhdGEpCit2b2lk IE1lZGlhU2Vzc2lvbjo6c2V0TWV0YWRhdGEoY29uc3QgTWVkaWFNZXRhZGF0YUluaXQmIG1ldGFk YXRhKQogewotICAgIC8vIDUuMS4zCi0gICAgLy8gMS4gTGV0IG1lZGlhIHNlc3Npb24gYmUgdGhl IGN1cnJlbnQgbWVkaWEgc2Vzc2lvbi4KLSAgICAvLyAyLiBMZXQgYmFzZVVSTCBiZSB0aGUgQVBJ IGJhc2UgVVJMIHNwZWNpZmllZCBieSB0aGUgZW50cnkgc2V0dGluZ3Mgb2JqZWN0LgotICAgIC8v IDMuIFNldCBtZWRpYSBzZXNzaW9uJ3MgdGl0bGUgdG8gbWV0YWRhdGEncyB0aXRsZS4KLSAgICBT dHJpbmcgdGl0bGU7Ci0gICAgbWV0YWRhdGEuZ2V0KCJ0aXRsZSIsIHRpdGxlKTsKLQotICAgIC8v IDQuIFNldCBtZWRpYSBzZXNzaW9uJ3MgYXJ0aXN0IG5hbWUgdG8gbWV0YWRhdGEncyBhcnRpc3Qu Ci0gICAgU3RyaW5nIGFydGlzdDsKLSAgICBtZXRhZGF0YS5nZXQoImFydGlzdCIsIGFydGlzdCk7 Ci0KLSAgICAvLyA1LiBTZXQgbWVkaWEgc2Vzc2lvbidzIGFsYnVtIG5hbWUgdG8gbWV0YWRhdGEn cyBhbGJ1bS4KLSAgICBTdHJpbmcgYWxidW07Ci0gICAgbWV0YWRhdGEuZ2V0KCJhbGJ1bSIsIGFs YnVtKTsKLQotICAgIC8vIDYuIElmIG1ldGFkYXRhJ3MgYXJ0d29yayBpcyBwcmVzZW50LCBwYXJz ZSBpdCB1c2luZyBiYXNlVVJMLCBhbmQgaWYgdGhhdCBkb2VzIG5vdCByZXR1cm4gZmFpbHVyZSwg c2V0IG1lZGlhCi0gICAgLy8gICAgc2Vzc2lvbidzIGFydHdvcmsgVVJMIHRvIHRoZSByZXR1cm4g dmFsdWUuCisgICAgLy8gSWYgbWV0YWRhdGEncyBhcnR3b3JrIGlzIHByZXNlbnQsIHBhcnNlIGl0 IHVzaW5nIGJhc2VVUkwsIGFuZCBpZiB0aGF0IGRvZXMgbm90IHJldHVybiBmYWlsdXJlLCBzZXQg bWVkaWEKKyAgICAvLyBzZXNzaW9uJ3MgYXJ0d29yayBVUkwgdG8gdGhlIHJldHVybiB2YWx1ZS4K ICAgICBVUkwgYXJ0d29ya1VSTDsKLSAgICBTdHJpbmcgYXJ0d29ya1BhdGg7Ci0gICAgaWYgKG1l dGFkYXRhLmdldCgiYXJ0d29yayIsIGFydHdvcmtQYXRoKSkKLSAgICAgICAgYXJ0d29ya1VSTCA9 IG1fZG9jdW1lbnQuY29tcGxldGVVUkwoYXJ0d29ya1BhdGgpOworICAgIGlmICghbWV0YWRhdGEu YXJ0d29yay5pc051bGwoKSkKKyAgICAgICAgYXJ0d29ya1VSTCA9IG1fZG9jdW1lbnQuY29tcGxl dGVVUkwobWV0YWRhdGEuYXJ0d29yayk7CiAKLSAgICBtX21ldGFkYXRhID0gTWVkaWFTZXNzaW9u TWV0YWRhdGEodGl0bGUsIGFydGlzdCwgYWxidW0sIGFydHdvcmtVUkwpOworICAgIG1fbWV0YWRh dGEgPSBNZWRpYVNlc3Npb25NZXRhZGF0YShtZXRhZGF0YS50aXRsZSwgbWV0YWRhdGEuYXJ0aXN0 LCBtZXRhZGF0YS5hbGJ1bSwgYXJ0d29ya1VSTCk7CiAKICAgICBpZiAoUGFnZSAqcGFnZSA9IG1f ZG9jdW1lbnQucGFnZSgpKQogICAgICAgICBwYWdlLT5jaHJvbWUoKS5jbGllbnQoKS5tZWRpYVNl c3Npb25NZXRhZGF0YURpZENoYW5nZShtX21ldGFkYXRhKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmgKaW5kZXggNTExMDE5MWRlYmFk MzY0N2NkMDI2OTkwNGFmOGE2OTMxZDEwYzRhOC4uZjg3ZDk5YmU1ZTlhYWM5YWU2NTE3NTA5MTM0 MzcxOTAxZGZiODU2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNl c3Npb24vTWVkaWFTZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNl c3Npb24vTWVkaWFTZXNzaW9uLmgKQEAgLTMyLDcgKzMyLDYgQEAKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCi1jbGFzcyBEaWN0aW9uYXJ5OwogY2xhc3MgRG9jdW1lbnQ7CiBjbGFzcyBIVE1MTWVk aWFFbGVtZW50OwogCkBAIC01NCw3ICs1MywxNCBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBP UlQgU3RhdGUgY3VycmVudFN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9jdXJyZW50U3RhdGU7IH0K ICAgICBib29sIGhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSBjb25zdDsKIAotICAgIHZvaWQgc2V0 TWV0YWRhdGEoY29uc3QgRGljdGlvbmFyeSYpOworICAgIHN0cnVjdCBNZWRpYU1ldGFkYXRhSW5p dCB7CisgICAgICAgIFN0cmluZyB0aXRsZTsKKyAgICAgICAgU3RyaW5nIGFydGlzdDsKKyAgICAg ICAgU3RyaW5nIGFsYnVtOworICAgICAgICBTdHJpbmcgYXJ0d29yazsKKyAgICB9OworCisgICAg dm9pZCBzZXRNZXRhZGF0YShjb25zdCBNZWRpYU1ldGFkYXRhSW5pdCYpOwogCiAgICAgdm9pZCBk ZWFjdGl2YXRlKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vz c2lvbi9NZWRpYVNlc3Npb24uaWRsCmluZGV4IDQ5OWMxOWEwMDgyOGM1YzU3NzA4MTBmZmRlZDU0 ZTY0OGM4ZjhiMzAuLmZlZThhOWVhMzg2NWZlN2JiN2ZmMGJmM2FkZjUzYzkzZjc3MzQ1MWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lv bi5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNz aW9uLmlkbApAQCAtMzMsNyArMzMsOSBAQAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBNZWRpYVNl c3Npb25LaW5kIGtpbmQ7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE1lZGlhUmVtb3RlQ29udHJv bHM/IGNvbnRyb2xzOwogCi0gICAgdm9pZCBzZXRNZXRhZGF0YShEaWN0aW9uYXJ5IG1ldGFkYXRh KTsKKyAgICAvLyBGSVhNRTogVGhlIGxhdGVzdCBzcGVjaWZpY2F0aW9uIHNheXMgdGhpcyBzaG91 bGQgYmU6CisgICAgLy8gYXR0cmlidXRlIE1lZGlhTWV0YWRhdGE/IG1ldGFkYXRhOworICAgIHZv aWQgc2V0TWV0YWRhdGEoTWVkaWFNZXRhZGF0YUluaXQgbWV0YWRhdGEpOwogCiAgICAgdm9pZCBk ZWFjdGl2YXRlKCk7CiB9OwpAQCAtNDQsMyArNDYsMTAgQEAgZW51bSBNZWRpYVNlc3Npb25LaW5k IHsKICAgICAidHJhbnNpZW50LXNvbG8iLAogICAgICJhbWJpZW50IgogfTsKKworZGljdGlvbmFy eSBNZWRpYU1ldGFkYXRhSW5pdCB7CisgICAgRE9NU3RyaW5nIHRpdGxlOworICAgIERPTVN0cmlu ZyBhcnRpc3Q7CisgICAgRE9NU3RyaW5nIGFsYnVtOworICAgIERPTVN0cmluZyBhcnR3b3JrOwor fTsK