157704 2016-05-13 20:58:03 -0700 jsc: samplingProfilerStackTraces() without starting sampling should not cause jsc to crash 2016-05-13 22:50:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1193039 0 joepeck 2016-05-13 20:58:03 -0700 * SUMMARY samplingProfilerStackTraces() without starting sampling should not cause jsc to crash Instead of crashing, lets throw an exception instead. * STEPS TO REPRODUCE >>> samplingProfilerStackTraces() => RELEASE_ASSERT 1193040 1 278918 joepeck 2016-05-13 20:59:29 -0700 Created attachment 278918 [PATCH] Proposed Fix 1193062 2 278918 commit-queue 2016-05-13 22:50:45 -0700 Comment on attachment 278918 [PATCH] Proposed Fix Clearing flags on attachment: 278918 Committed r200916: <http://trac.webkit.org/changeset/200916> 1193063 3 commit-queue 2016-05-13 22:50:48 -0700 All reviewed patches have been landed. Closing bug. 278918 2016-05-13 20:59:29 -0700 2016-05-13 22:50:45 -0700 [PATCH] Proposed Fix ensure-1.patch text/plain 4692 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU1ZWFjMDIuLmZiNTFmMzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA1LTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAganNjOiBzYW1wbGluZ1Byb2ZpbGVy U3RhY2tUcmFjZXMoKSB3aXRob3V0IHN0YXJ0aW5nIHNhbXBsaW5nIHNob3VsZCBub3QgY2F1c2Ug anNjIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTc3MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGpzYy5jcHA6CisgICAgICAgIChmdW5jdGlvblN0YXJ0U2FtcGxpbmdQcm9maWxlcik6 CisgICAgICAgIChmdW5jdGlvblNhbXBsaW5nUHJvZmlsZXJTdGFja1RyYWNlcyk6CisgICAgICAg IFRocm93IGFuIGV4Y2VwdGlvbiBpbnN0ZWFkIG9mIGNyYXNoaW5nIGlmIHdlIGhhdmVuJ3Qgc3Rh cnRlZCBzYW1wbGluZy4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2Ny aXB0UHJvZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvclNjcmlw dFByb2ZpbGVyQWdlbnQ6OnN0YXJ0VHJhY2tpbmcpOgorICAgICAgICAqIHJ1bnRpbWUvVk0uaDoK KyAgICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OmVuc3VyZVNhbXBs aW5nUHJvZmlsZXIpOgorICAgICAgICBTd2l0Y2ggZW5zdXJlIHRvIHJldHVybmluZyBhIHJlZmVy ZW5jZSwgbGlrZSBtb3N0IG90aGVyIGVuc3VyZXMuCisKKzIwMTYtMDUtMTMgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgTGVnYWN5UHJvZmls ZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzU2 NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9J bnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwCmluZGV4IGRm ZWI2NjQuLmU0YWU5MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdl bnQuY3BwCkBAIC02NywxMSArNjcsOSBAQCB2b2lkIEluc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdl bnQ6OnN0YXJ0VHJhY2tpbmcoRXJyb3JTdHJpbmcmLCBjb25zdCBib29sKiBpbmNsdQogI2lmIEVO QUJMRShTQU1QTElOR19QUk9GSUxFUikKICAgICBpZiAoaW5jbHVkZVNhbXBsZXMgJiYgKmluY2x1 ZGVTYW1wbGVzKSB7CiAgICAgICAgIFZNJiB2bSA9IG1fZW52aXJvbm1lbnQuc2NyaXB0RGVidWdT ZXJ2ZXIoKS52bSgpOwotICAgICAgICB2bS5lbnN1cmVTYW1wbGluZ1Byb2ZpbGVyKG1fZW52aXJv bm1lbnQuZXhlY3V0aW9uU3RvcHdhdGNoKCkpOworICAgICAgICBTYW1wbGluZ1Byb2ZpbGVyJiBz YW1wbGluZ1Byb2ZpbGVyID0gdm0uZW5zdXJlU2FtcGxpbmdQcm9maWxlcihtX2Vudmlyb25tZW50 LmV4ZWN1dGlvblN0b3B3YXRjaCgpKTsKIAotICAgICAgICBTYW1wbGluZ1Byb2ZpbGVyJiBzYW1w bGluZ1Byb2ZpbGVyID0gKnZtLnNhbXBsaW5nUHJvZmlsZXIoKTsKICAgICAgICAgTG9ja0hvbGRl ciBsb2NrZXIoc2FtcGxpbmdQcm9maWxlci5nZXRMb2NrKCkpOwotCiAgICAgICAgIHNhbXBsaW5n UHJvZmlsZXIuc2V0U3RvcFdhdGNoKGxvY2tlciwgbV9lbnZpcm9ubWVudC5leGVjdXRpb25TdG9w d2F0Y2goKSk7CiAgICAgICAgIHNhbXBsaW5nUHJvZmlsZXIubm90aWNlQ3VycmVudFRocmVhZEFz SlNDRXhlY3V0aW9uVGhyZWFkKGxvY2tlcik7CiAgICAgICAgIHNhbXBsaW5nUHJvZmlsZXIuc3Rh cnQobG9ja2VyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggZTdlZGU3MS4uZTE3NTM2ZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2pzYy5jcHAKQEAgLTE4NDgsMTUgKzE4NDgsMTcgQEAgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkdlbmVyYXRlSGVhcFNuYXBzaG90KEV4ZWNTdGF0ZSogZXhl YykKICNpZiBFTkFCTEUoU0FNUExJTkdfUFJPRklMRVIpCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGZ1bmN0aW9uU3RhcnRTYW1wbGluZ1Byb2ZpbGVyKEV4ZWNTdGF0ZSogZXhlYykKIHsK LSAgICBleGVjLT52bSgpLmVuc3VyZVNhbXBsaW5nUHJvZmlsZXIoV1RGOjpTdG9wd2F0Y2g6OmNy ZWF0ZSgpKTsKLSAgICBleGVjLT52bSgpLnNhbXBsaW5nUHJvZmlsZXIoKS0+bm90aWNlQ3VycmVu dFRocmVhZEFzSlNDRXhlY3V0aW9uVGhyZWFkKCk7Ci0gICAgZXhlYy0+dm0oKS5zYW1wbGluZ1By b2ZpbGVyKCktPnN0YXJ0KCk7CisgICAgU2FtcGxpbmdQcm9maWxlciYgc2FtcGxpbmdQcm9maWxl ciA9IGV4ZWMtPnZtKCkuZW5zdXJlU2FtcGxpbmdQcm9maWxlcihXVEY6OlN0b3B3YXRjaDo6Y3Jl YXRlKCkpOworICAgIHNhbXBsaW5nUHJvZmlsZXIubm90aWNlQ3VycmVudFRocmVhZEFzSlNDRXhl Y3V0aW9uVGhyZWFkKCk7CisgICAgc2FtcGxpbmdQcm9maWxlci5zdGFydCgpOwogICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpT Q19IT1NUX0NBTEwgZnVuY3Rpb25TYW1wbGluZ1Byb2ZpbGVyU3RhY2tUcmFjZXMoRXhlY1N0YXRl KiBleGVjKQogewotICAgIFJFTEVBU0VfQVNTRVJUKGV4ZWMtPnZtKCkuc2FtcGxpbmdQcm9maWxl cigpKTsKKyAgICBpZiAoIWV4ZWMtPnZtKCkuc2FtcGxpbmdQcm9maWxlcigpKQorICAgICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGV4ZWMtPnZtKCkudGhyb3dFeGNlcHRpb24oZXhlYywgY3Jl YXRlRXJyb3IoZXhlYywgQVNDSUlMaXRlcmFsKCJTYW1wbGluZyBwcm9maWxlciB3YXMgbmV2ZXIg c3RhcnRlZCIpKSkpOworCiAgICAgU3RyaW5nIGpzb25TdHJpbmcgPSBleGVjLT52bSgpLnNhbXBs aW5nUHJvZmlsZXIoKS0+c3RhY2tUcmFjZXNBc0pTT04oKTsKICAgICBFbmNvZGVkSlNWYWx1ZSBy ZXN1bHQgPSBKU1ZhbHVlOjplbmNvZGUoSlNPTlBhcnNlKGV4ZWMsIGpzb25TdHJpbmcpKTsKICAg ICBSRUxFQVNFX0FTU0VSVCghZXhlYy0+aGFkRXhjZXB0aW9uKCkpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvVk0uY3BwCmluZGV4IDM4YzFmNDMuLmQ0N2Y0NDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9WTS5jcHAKQEAgLTQ1MiwxMCArNDUyLDExIEBAIEhlYXBQcm9maWxlciYgVk06 OmVuc3VyZUhlYXBQcm9maWxlcigpCiB9CiAKICNpZiBFTkFCTEUoU0FNUExJTkdfUFJPRklMRVIp Ci12b2lkIFZNOjplbnN1cmVTYW1wbGluZ1Byb2ZpbGVyKFJlZlB0cjxTdG9wd2F0Y2g+JiYgc3Rv cHdhdGNoKQorU2FtcGxpbmdQcm9maWxlciYgVk06OmVuc3VyZVNhbXBsaW5nUHJvZmlsZXIoUmVm UHRyPFN0b3B3YXRjaD4mJiBzdG9wd2F0Y2gpCiB7CiAgICAgaWYgKCFtX3NhbXBsaW5nUHJvZmls ZXIpCiAgICAgICAgIG1fc2FtcGxpbmdQcm9maWxlciA9IGFkb3B0UmVmKG5ldyBTYW1wbGluZ1By b2ZpbGVyKCp0aGlzLCBXVEZNb3ZlKHN0b3B3YXRjaCkpKTsKKyAgICByZXR1cm4gKm1fc2FtcGxp bmdQcm9maWxlcjsKIH0KICNlbmRpZiAvLyBFTkFCTEUoU0FNUExJTkdfUFJPRklMRVIpCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCmluZGV4IGJkNWNiNDguLjJiYTI1NjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvVk0uaApAQCAtMjUzLDcgKzI1Myw3IEBAIHB1YmxpYzoKIAogI2lm IEVOQUJMRShTQU1QTElOR19QUk9GSUxFUikKICAgICBKU19FWFBPUlRfUFJJVkFURSBTYW1wbGlu Z1Byb2ZpbGVyKiBzYW1wbGluZ1Byb2ZpbGVyKCkgeyByZXR1cm4gbV9zYW1wbGluZ1Byb2ZpbGVy LmdldCgpOyB9Ci0gICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBlbnN1cmVTYW1wbGluZ1Byb2Zp bGVyKFJlZlB0cjxTdG9wd2F0Y2g+JiYpOworICAgIEpTX0VYUE9SVF9QUklWQVRFIFNhbXBsaW5n UHJvZmlsZXImIGVuc3VyZVNhbXBsaW5nUHJvZmlsZXIoUmVmUHRyPFN0b3B3YXRjaD4mJik7CiAj ZW5kaWYKIAogcHJpdmF0ZToK