157696 2016-05-13 17:12:15 -0700 DFG/FTL have a few bugs in their reasoning about the scope 2020-05-23 06:01:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren giffypap79 gskachkov joepeck keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1192977 0 saam 2016-05-13 17:12:15 -0700 1. We should ensure that the scope is always flushed to the stack. This means claiming every node reads the scope when the debugger is enabled. 2. The FTL just has a bug where it doesn't properly set the scope register. 1192978 1 278897 saam 2016-05-13 17:15:54 -0700 Created attachment 278897 patch 1192979 2 278898 saam 2016-05-13 17:16:50 -0700 Created attachment 278898 patch 1193004 3 278898 commit-queue 2016-05-13 19:02:19 -0700 Comment on attachment 278898 patch Clearing flags on attachment: 278898 Committed r200906: <http://trac.webkit.org/changeset/200906> 1193005 4 commit-queue 2016-05-13 19:02:24 -0700 All reviewed patches have been landed. Closing bug. 278897 2016-05-13 17:15:54 -0700 2016-05-13 17:16:50 -0700 patch c-backup.diff text/plain 3306 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwOTAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE2LTA1LTEzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGRy9GVEwgaGF2ZSBhIGZldyBidWdzIGluIHRoZWlyIHJlYXNvbmluZyBhYm91dCB0aGUgc2Nv cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzY5 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDEuIFdo ZW4gdGhlIGRlYnVnZ2VyIGlzIGVuYWJsZWQsIGl0IGlzIGVhc2llciBmb3IgdGhlIERGRyB0byBy ZWFzb24KKyAgICAgICAgYWJvdXQgdGhlIHNjb3BlIHJlZ2lzdGVyIGJ5IHNpbXBseSBjbGFpbWlu ZyBhbGwgbm9kZXMgcmVhZCB0aGUgc2NvcGUKKyAgICAgICAgcmVnaXN0ZXIuIFRoaXMgcHJldmVu dHMgdXMgZnJvbSBldmVyIGVudGVyaW5nIHRoZSBydW50aW1lIHdoZXJlIHdlCisgICAgICAgIG1h eSB0YWtlIGEgc3RhY2sgdHJhY2UgYnV0IHRoZXJlIGlzbid0IGEgc2NvcGUgb24gdGhlIHN0YWNr LgorCisgICAgICAgIDIuIFRoaXMgcGF0Y2ggZml4ZXMgYSBidWcgd2hlcmUgdGhlIEZUTCBjb21w aWxhdGlvbiB3YXNuJ3QgcHJvcGVybHkKKyAgICAgICAgc2V0dGluZyB0aGUgQ29kZUJsb2NrIHJl Z2lzdGVyLiBJdCB3YXMgb25seSBkb2luZyB0aGlzIHdoZW4gdGhlcmUKKyAgICAgICAgd2FzIGlu bGluZSBkYXRhLCBidXQgd2hlbiB0aGUgZGVidWdnZXIgaXMgZW5hYmxlZCwgd2UgbmV2ZXIgaW5s aW5lLgorICAgICAgICBTbyB0aGlzIGNvZGUganVzdCBuZWVkZWQgdG8gYmUgcmVtb3ZlZCBmcm9t IHRoYXQgbG9vcC4gSXQgd2FzIG5ldmVyCisgICAgICAgIHJpZ2h0IGZvciBpdCB0byBiZSBpbnNp ZGUgdGhlIGxvb3AuCisKKyAgICAgICAgKiBkZmcvREZHQ2xvYmJlcml6ZS5oOgorICAgICAgICAo SlNDOjpERkc6OmNsb2JiZXJpemUpOgorICAgICAgICAqIGZ0bC9GVExDb21waWxlLmNwcDoKKyAg ICAgICAgKEpTQzo6RlRMOjpjb21waWxlKToKKwogMjAxNi0wNS0xMyAgQmVuamFtaW4gUG91bGFp biAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBTZXRMb2NhbCB3aXRob3V0 IGV4aXQgZG8gbm90IG5lZWQgcGhhbnRvbXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ2xvYmJlcml6ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ2xvYmJlcml6ZS5oCShyZXZpc2lvbiAyMDA5MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDYgKzExNywx NyBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlCiAgICAgICAgIGlm IChpbmxpbmVDYWxsRnJhbWUtPmlzVmFyYXJncygpKQogICAgICAgICAgICAgcmVhZChBYnN0cmFj dEhlYXAoU3RhY2ssIGlubGluZUNhbGxGcmFtZS0+c3RhY2tPZmZzZXQgKyBKU1N0YWNrOjpBcmd1 bWVudENvdW50KSk7CiAgICAgfQorCisgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBzcGVjaWZpY2Fs bHkgYWNjb3VudCB3aGljaCBub2RlcyBjYW4gcmVhZCBmcm9tIHRoZSBzY29wZQorICAgIC8vIHdo ZW4gdGhlIGRlYnVnZ2VyIGlzIGVuYWJsZWQuIEl0J3MgaGVscGZ1bCB0byBqdXN0IGNsYWltIGFs bCBub2RlcyBkby4KKyAgICAvLyBTcGVjaWZpY2FsbHksIGlmIGEgbm9kZSBhbGxvY2F0ZXMsIHRo aXMgbWF5IGNhbGwgaW50byB0aGUgZGVidWdnZXJzIG1hY2hpbmVyeS4KKyAgICAvLyBUaGUgZGVi dWdnZXIncyBtYWNoaW5lcnkgaXMgZnJlZSB0byB0YWtlIGEgc3RhY2sgdHJhY2UgYW5kIHRyeSB0 byByZWFkIGZyb20KKyAgICAvLyBhIHNjb3BlIHdoaWNoIGlzIGV4cGVjdGVkIHRvIGJlIGZsdXNo ZWQgdG8gdGhlIHN0YWNrLgorICAgIGlmIChncmFwaC5oYXNEZWJ1Z2dlckVuYWJsZWQoKSkgewor ICAgICAgICBBU1NFUlQoIW5vZGUtPm9yaWdpbi5zZW1hbnRpYy5pbmxpbmVDYWxsRnJhbWUpOwor ICAgICAgICByZWFkKEFic3RyYWN0SGVhcChTdGFjaywgZ3JhcGgubV9jb2RlQmxvY2stPnNjb3Bl UmVnaXN0ZXIoKSkpOworICAgIH0KKyAgICAgICAgCiAgICAgCiAgICAgc3dpdGNoIChub2RlLT5v cCgpKSB7CiAgICAgY2FzZSBKU0NvbnN0YW50OgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExDb21waWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTENvbXBpbGUuY3BwCShyZXZpc2lvbiAyMDA5MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsOSArMTAzLDEx IEBAIHZvaWQgY29tcGlsZShTdGF0ZSYgc3RhdGUsIFNhZmVwb2ludDo6UmUKICAgICAgICAgICAg ICAgICBpbmxpbmVDYWxsRnJhbWUtPmNhbGxlZVJlY292ZXJ5LndpdGhMb2NhbHNPZmZzZXQobG9j YWxzT2Zmc2V0KTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChncmFwaC5oYXNEZWJ1Z2dlckVu YWJsZWQoKSkKLSAgICAgICAgICAgIGNvZGVCbG9jay0+c2V0U2NvcGVSZWdpc3Rlcihjb2RlQmxv Y2stPnNjb3BlUmVnaXN0ZXIoKSArIGxvY2Fsc09mZnNldCk7CiAgICAgfQorCisgICAgaWYgKGdy YXBoLmhhc0RlYnVnZ2VyRW5hYmxlZCgpKQorICAgICAgICBjb2RlQmxvY2stPnNldFNjb3BlUmVn aXN0ZXIoY29kZUJsb2NrLT5zY29wZVJlZ2lzdGVyKCkgKyBsb2NhbHNPZmZzZXQpOworCiAgICAg Zm9yIChPU1JFeGl0RGVzY3JpcHRvciYgZGVzY3JpcHRvciA6IHN0YXRlLmppdENvZGUtPm9zckV4 aXREZXNjcmlwdG9ycykgewogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBkZXNjcmlwdG9yLm1f dmFsdWVzLnNpemUoKTsgaS0tOykKICAgICAgICAgICAgIGRlc2NyaXB0b3IubV92YWx1ZXNbaV0g PSBkZXNjcmlwdG9yLm1fdmFsdWVzW2ldLndpdGhMb2NhbHNPZmZzZXQobG9jYWxzT2Zmc2V0KTsK 278898 2016-05-13 17:16:50 -0700 2016-05-13 19:02:19 -0700 patch c-backup.diff text/plain 3307 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwOTAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE2LTA1LTEzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGRy9GVEwgaGF2ZSBhIGZldyBidWdzIGluIHRoZWlyIHJlYXNvbmluZyBhYm91dCB0aGUgc2Nv cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzY5 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDEuIFdo ZW4gdGhlIGRlYnVnZ2VyIGlzIGVuYWJsZWQsIGl0IGlzIGVhc2llciBmb3IgdGhlIERGRyB0byBy ZWFzb24KKyAgICAgICAgYWJvdXQgdGhlIHNjb3BlIHJlZ2lzdGVyIGJ5IHNpbXBseSBjbGFpbWlu ZyBhbGwgbm9kZXMgcmVhZCB0aGUgc2NvcGUKKyAgICAgICAgcmVnaXN0ZXIuIFRoaXMgcHJldmVu dHMgdXMgZnJvbSBldmVyIGVudGVyaW5nIHRoZSBydW50aW1lIHdoZXJlIHdlCisgICAgICAgIG1h eSB0YWtlIGEgc3RhY2sgdHJhY2UgYnV0IHRoZXJlIGlzbid0IGEgc2NvcGUgb24gdGhlIHN0YWNr LgorCisgICAgICAgIDIuIFRoaXMgcGF0Y2ggZml4ZXMgYSBidWcgd2hlcmUgdGhlIEZUTCBjb21w aWxhdGlvbiB3YXNuJ3QgcHJvcGVybHkKKyAgICAgICAgc2V0dGluZyB0aGUgQ29kZUJsb2NrIHJl Z2lzdGVyLiBJdCB3YXMgb25seSBkb2luZyB0aGlzIHdoZW4gdGhlcmUKKyAgICAgICAgd2FzIGlu bGluZSBkYXRhLCBidXQgd2hlbiB0aGUgZGVidWdnZXIgaXMgZW5hYmxlZCwgd2UgbmV2ZXIgaW5s aW5lLgorICAgICAgICBTbyB0aGlzIGNvZGUganVzdCBuZWVkZWQgdG8gYmUgcmVtb3ZlZCBmcm9t IHRoYXQgbG9vcC4gSXQgd2FzIG5ldmVyCisgICAgICAgIHJpZ2h0IGZvciBpdCB0byBiZSBpbnNp ZGUgdGhlIGxvb3AuCisKKyAgICAgICAgKiBkZmcvREZHQ2xvYmJlcml6ZS5oOgorICAgICAgICAo SlNDOjpERkc6OmNsb2JiZXJpemUpOgorICAgICAgICAqIGZ0bC9GVExDb21waWxlLmNwcDoKKyAg ICAgICAgKEpTQzo6RlRMOjpjb21waWxlKToKKwogMjAxNi0wNS0xMyAgQmVuamFtaW4gUG91bGFp biAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBTZXRMb2NhbCB3aXRob3V0 IGV4aXQgZG8gbm90IG5lZWQgcGhhbnRvbXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ2xvYmJlcml6ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQ2xvYmJlcml6ZS5oCShyZXZpc2lvbiAyMDA5MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDYgKzExNywx NyBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlCiAgICAgICAgIGlm IChpbmxpbmVDYWxsRnJhbWUtPmlzVmFyYXJncygpKQogICAgICAgICAgICAgcmVhZChBYnN0cmFj dEhlYXAoU3RhY2ssIGlubGluZUNhbGxGcmFtZS0+c3RhY2tPZmZzZXQgKyBKU1N0YWNrOjpBcmd1 bWVudENvdW50KSk7CiAgICAgfQorCisgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBzcGVjaWZpY2Fs bHkgYWNjb3VudCB3aGljaCBub2RlcyBjYW4gcmVhZCBmcm9tIHRoZSBzY29wZQorICAgIC8vIHdo ZW4gdGhlIGRlYnVnZ2VyIGlzIGVuYWJsZWQuIEl0J3MgaGVscGZ1bCB0byBqdXN0IGNsYWltIGFs bCBub2RlcyBkby4KKyAgICAvLyBTcGVjaWZpY2FsbHksIGlmIGEgbm9kZSBhbGxvY2F0ZXMsIHRo aXMgbWF5IGNhbGwgaW50byB0aGUgZGVidWdnZXIncyBtYWNoaW5lcnkuCisgICAgLy8gVGhlIGRl YnVnZ2VyJ3MgbWFjaGluZXJ5IGlzIGZyZWUgdG8gdGFrZSBhIHN0YWNrIHRyYWNlIGFuZCB0cnkg dG8gcmVhZCBmcm9tCisgICAgLy8gYSBzY29wZSB3aGljaCBpcyBleHBlY3RlZCB0byBiZSBmbHVz aGVkIHRvIHRoZSBzdGFjay4KKyAgICBpZiAoZ3JhcGguaGFzRGVidWdnZXJFbmFibGVkKCkpIHsK KyAgICAgICAgQVNTRVJUKCFub2RlLT5vcmlnaW4uc2VtYW50aWMuaW5saW5lQ2FsbEZyYW1lKTsK KyAgICAgICAgcmVhZChBYnN0cmFjdEhlYXAoU3RhY2ssIGdyYXBoLm1fY29kZUJsb2NrLT5zY29w ZVJlZ2lzdGVyKCkpKTsKKyAgICB9CisgICAgICAgIAogICAgIAogICAgIHN3aXRjaCAobm9kZS0+ b3AoKSkgewogICAgIGNhc2UgSlNDb25zdGFudDoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQ29tcGlsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExDb21waWxlLmNwcAkocmV2aXNpb24gMjAwOTAxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExDb21waWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAzLDkgKzEwMywx MSBAQCB2b2lkIGNvbXBpbGUoU3RhdGUmIHN0YXRlLCBTYWZlcG9pbnQ6OlJlCiAgICAgICAgICAg ICAgICAgaW5saW5lQ2FsbEZyYW1lLT5jYWxsZWVSZWNvdmVyeS53aXRoTG9jYWxzT2Zmc2V0KGxv Y2Fsc09mZnNldCk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoZ3JhcGguaGFzRGVidWdnZXJF bmFibGVkKCkpCi0gICAgICAgICAgICBjb2RlQmxvY2stPnNldFNjb3BlUmVnaXN0ZXIoY29kZUJs b2NrLT5zY29wZVJlZ2lzdGVyKCkgKyBsb2NhbHNPZmZzZXQpOwogICAgIH0KKworICAgIGlmIChn cmFwaC5oYXNEZWJ1Z2dlckVuYWJsZWQoKSkKKyAgICAgICAgY29kZUJsb2NrLT5zZXRTY29wZVJl Z2lzdGVyKGNvZGVCbG9jay0+c2NvcGVSZWdpc3RlcigpICsgbG9jYWxzT2Zmc2V0KTsKKwogICAg IGZvciAoT1NSRXhpdERlc2NyaXB0b3ImIGRlc2NyaXB0b3IgOiBzdGF0ZS5qaXRDb2RlLT5vc3JF eGl0RGVzY3JpcHRvcnMpIHsKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gZGVzY3JpcHRvci5t X3ZhbHVlcy5zaXplKCk7IGktLTspCiAgICAgICAgICAgICBkZXNjcmlwdG9yLm1fdmFsdWVzW2ld ID0gZGVzY3JpcHRvci5tX3ZhbHVlc1tpXS53aXRoTG9jYWxzT2Zmc2V0KGxvY2Fsc09mZnNldCk7 Cg==