157693 2016-05-13 16:41:14 -0700 Extend protector naming code style guideline to cover operator= assignment 2016-05-13 21:44:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157591 P2 Normal --- 1 beidson beidson commit-queue darin glenn lforschler oldest_to_newest 1192957 0 beidson 2016-05-13 16:41:14 -0700 Extend protector naming code style guideline to = assignment https://bugs.webkit.org/show_bug.cgi?id=157591 implemented protector naming rules like so: RefPtr<Node> protector(node); RefPtr<Node> protectedThis(this); But we need to cover operator= assignment, as well. RefPtr<Node> protector = node; RefPtr<Node> protectedThis = this; 1192960 1 beidson 2016-05-13 16:43:33 -0700 (In reply to comment #0) > > But we need to cover operator= assignment, as well. > RefPtr<Node> protector = node; > RefPtr<Node> protectedThis = this; There's two ways to cover these cases: 1 - Extend the rule to enforce proper naming in these cases 2 - Extend the rule to disallow these cases and to prefer protector(node)-style initialization, instead. 1192966 2 beidson 2016-05-13 16:44:58 -0700 Since a consensus has been reached on the name of these variables, but no discussion has taken place on disallowing operator= style assignment to these protectors, I'm going to go with #1 and just enforce the name. If contributors later decide to disallow operator= style, that can be an easy change. 1192969 3 278895 beidson 2016-05-13 16:57:24 -0700 Created attachment 278895 Patch 1193048 4 278895 commit-queue 2016-05-13 21:44:49 -0700 Comment on attachment 278895 Patch Clearing flags on attachment: 278895 Committed r200913: <http://trac.webkit.org/changeset/200913> 1193049 5 commit-queue 2016-05-13 21:44:53 -0700 All reviewed patches have been landed. Closing bug. 278895 2016-05-13 16:57:24 -0700 2016-05-13 21:44:49 -0700 Patch bug-157693-20160513165816.patch text/plain 7976 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwODYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmNkNGIzMDAxYmNkNGRmOGVhMDZkZjVmNjIxMTk5ZTU1 MTBmNjdmNi4uOWQ5M2MzZDgwYmM3NDUwNWU0Y2M2ZTIwMmY3ZWJiZmZhNDUxODU2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDE2LTA1LTEzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAg ICAgICBFeHRlbmQgcHJvdGVjdG9yIG5hbWluZyBjb2RlIHN0eWxlIGd1aWRlbGluZSB0byBjb3Zl ciBvcGVyYXRvcj0gYXNzaWdubWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1NzY5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6 CisgICAgICAgIChjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24pOgorICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAg ICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfbmFtZXMpOgorCisyMDE2LTA1LTEzICBCcmFkeSBF aWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBQcm90ZWN0b3IgUmVmL1JlZlB0 cnMgc2hvdWxkIGhhdmUgYSBzcGVjaWZpZWQgbmFtaW5nIHN0eWxlLgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTkxCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMmEzYWY0ZTM0OTZhYTA0NmIz YjY1ZjI1NGU1NWQyMzVkMzJlMzgxNi4uOWYxYTM1OGFmYzg4NmJlOTFmZDBiMjM5OTgxMjVmOGM4 OThhZWMwMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkKQEAgLTMyOTIsNyArMzI5Miw3IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVj bGFyYXRpb24oZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCBsaW5lLCBmaWxlX3N0YXRlCiAgICAgICAg IHJldHVybgogCiAgICAgIyBNYWtlIHN1cmUgUmVmL1JlZlB0cnMgdXNlZCBhcyBwcm90ZWN0b3Jz IGFyZSBuYW1lZCBjb3JyZWN0bHksIGFuZCBkbyB0aGlzIGJlZm9yZSB3ZSBzdGFydCBzdHJpcHBp bmcgdGhpbmdzIG9mZiB0aGUgaW5wdXQuCi0gICAgcmVmX3JlZ2V4cCA9IHInXlxzKlJlZihQdHIp PzwoW1x3X118OjopKz4gKD9QPHByb3RlY3Rvcl9uYW1lPltcd19dKylcKChcKnwmKSoobV8pPyg/ UDxwcm90ZWN0ZWRfbmFtZT5bXHdfXSspXCk7JworICAgIHJlZl9yZWdleHAgPSByJ15ccypSZWYo UHRyKT88KFtcd19dfDo6KSs+ICg/UDxwcm90ZWN0b3JfbmFtZT5bXHdfXSspKFwofCA9ICkoXCp8 JikqKG1fKT8oP1A8cHJvdGVjdGVkX25hbWU+W1x3X10rKVwpPzsnCiAgICAgcmVmX2NoZWNrID0g bWF0Y2gocmVmX3JlZ2V4cCwgbGluZSkKICAgICBpZiByZWZfY2hlY2s6CiAgICAgICAgIHByb3Rl Y3Rvcl9uYW1lID0gcmVmX2NoZWNrLmdyb3VwKCdwcm90ZWN0b3JfbmFtZScpCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Cmlu ZGV4IGU2M2E2YTQwZDg5Zjc5MTc1NWJiMDUzZjFkYTIxN2UyMDI2MDRjZDguLmVlMzNlZWZhMjhj NWM1MDFlODFkMzVkNGRhMWRiNmViMjc1NmJlYTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC01MjA0LDEwICs1 MjA0LDIzIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnUmVmPFdpZGdldD4gcHJvdGVjdG9yKCptX3dpZGdldCk7Jywg JycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZlB0cjxTb21lTmFtZXNwYWNlOjpOb2Rl PiBwcm90ZWN0ZWRUaGlzKHRoaXMpOycsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdS ZWZQdHI8U29tZUNsYXNzOjpJbnRlcm5hbENsYXNzOjpOb2RlPiBwcm90ZWN0ZWRUaGlzKHRoaXMp OycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdSZWZQdHI8Tm9kZT4gcHJvdGVjdGVk VGhpcyA9IHRoaXM7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZjxOb2RlPiBw cm90ZWN0ZWRUaGlzID0gKnRoaXM7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1Jl ZlB0cjxOb2RlPiBwcm90ZWN0ZWROb2RlID0gbm9kZTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgnUmVmUHRyPE5vZGU+IHByb3RlY3RlZE5vZGUgPSAmbm9kZTsnLCAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnUmVmUHRyPE5vZGU+IHByb3RlY3RvciA9IG5vZGU7JywgJycp CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZlB0cjxOb2RlPiBwcm90ZWN0b3IgPSAmbm9k ZTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnUmVmPE5vZGU+IHByb3RlY3RlZE5v ZGUgPSBub2RlOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdSZWY8Tm9kZT4gcHJv dGVjdGVkTm9kZSA9Km5vZGU7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZjxO b2RlPiBwcm90ZWN0b3IgPSBub2RlOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdS ZWY8Tm9kZT4gcHJvdGVjdG9yID0gKm5vZGU7JywgJycpCisKIAogICAgICAgICAjIEludmFsaWQg cHJvdGVjdG9yIFJlZlB0ci9SZWYgdmFyaWFibGUgbmFtZXMuCiAgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJ1JlZlB0cjxOb2RlPiBwcm90ZWN0b3IodGhpcyk7JywgIidwcm90ZWN0b3InIGlzIGlu Y29ycmVjdGx5IG5hbWVkLiBJdCBzaG91bGQgYmUgbmFtZWQgJ3Byb3RlY3RlZFRoaXMnLiAgW3Jl YWRhYmlsaXR5L25hbWluZy9wcm90ZWN0ZWRdIFs0XSIpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xp bnQoJ1JlZjxOb2RlPiBwcm90ZWN0b3IoKnRoaXMpOycsICIncHJvdGVjdG9yJyBpcyBpbmNvcnJl Y3RseSBuYW1lZC4gSXQgc2hvdWxkIGJlIG5hbWVkICdwcm90ZWN0ZWRUaGlzJy4gIFtyZWFkYWJp bGl0eS9uYW1pbmcvcHJvdGVjdGVkXSBbNF0iKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdS ZWZQdHI8Tm9kZT4gcHJvdGVjdG9yID0gdGhpczsnLCAiJ3Byb3RlY3RvcicgaXMgaW5jb3JyZWN0 bHkgbmFtZWQuIEl0IHNob3VsZCBiZSBuYW1lZCAncHJvdGVjdGVkVGhpcycuICBbcmVhZGFiaWxp dHkvbmFtaW5nL3Byb3RlY3RlZF0gWzRdIikKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnUmVm PE5vZGU+IHByb3RlY3RvciA9ICp0aGlzOycsICIncHJvdGVjdG9yJyBpcyBpbmNvcnJlY3RseSBu YW1lZC4gSXQgc2hvdWxkIGJlIG5hbWVkICdwcm90ZWN0ZWRUaGlzJy4gIFtyZWFkYWJpbGl0eS9u YW1pbmcvcHJvdGVjdGVkXSBbNF0iKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdSZWZQdHI8 Tm9kZT4gc2VsZih0aGlzKTsnLCAiJ3NlbGYnIGlzIGluY29ycmVjdGx5IG5hbWVkLiBJdCBzaG91 bGQgYmUgbmFtZWQgJ3Byb3RlY3RlZFRoaXMnLiAgW3JlYWRhYmlsaXR5L25hbWluZy9wcm90ZWN0 ZWRdIFs0XSIpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZjxOb2RlPiBzZWxmKCp0aGlz KTsnLCAiJ3NlbGYnIGlzIGluY29ycmVjdGx5IG5hbWVkLiBJdCBzaG91bGQgYmUgbmFtZWQgJ3By b3RlY3RlZFRoaXMnLiAgW3JlYWRhYmlsaXR5L25hbWluZy9wcm90ZWN0ZWRdIFs0XSIpCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZlB0cjxOb2RlPiBwcm90ZWN0ZWRUaGlzKG5vZGUpOycs ICIncHJvdGVjdGVkVGhpcycgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIEl0IHNob3VsZCBiZSBuYW1l ZCAncHJvdGVjdG9yJyBvciAncHJvdGVjdGVkTm9kZScuICBbcmVhZGFiaWxpdHkvbmFtaW5nL3By b3RlY3RlZF0gWzRdIikKQEAgLTUyMTgsNiArNTIzMSwxMCBAQCBjbGFzcyBXZWJLaXRTdHlsZVRl c3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZlB0cjxO b2RlPiBwcm90ZWN0ZWROb2RlKCZvdGhlck5vZGUpOycsICIncHJvdGVjdGVkTm9kZScgaXMgaW5j b3JyZWN0bHkgbmFtZWQuIEl0IHNob3VsZCBiZSBuYW1lZCAncHJvdGVjdG9yJyBvciAncHJvdGVj dGVkT3RoZXJOb2RlJy4gIFtyZWFkYWJpbGl0eS9uYW1pbmcvcHJvdGVjdGVkXSBbNF0iKQogICAg ICAgICBzZWxmLmFzc2VydF9saW50KCdSZWY8Tm9kZT4gcHJvdGVjdGVkTm9kZShvdGhlck5vZGUp OycsICIncHJvdGVjdGVkTm9kZScgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIEl0IHNob3VsZCBiZSBu YW1lZCAncHJvdGVjdG9yJyBvciAncHJvdGVjdGVkT3RoZXJOb2RlJy4gIFtyZWFkYWJpbGl0eS9u YW1pbmcvcHJvdGVjdGVkXSBbNF0iKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdSZWY8Tm9k ZT4gcHJvdGVjdGVkTm9kZSgqb3RoZXJOb2RlKTsnLCAiJ3Byb3RlY3RlZE5vZGUnIGlzIGluY29y cmVjdGx5IG5hbWVkLiBJdCBzaG91bGQgYmUgbmFtZWQgJ3Byb3RlY3Rvcicgb3IgJ3Byb3RlY3Rl ZE90aGVyTm9kZScuICBbcmVhZGFiaWxpdHkvbmFtaW5nL3Byb3RlY3RlZF0gWzRdIikKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnUmVmUHRyPE5vZGU+IHByb3RlY3RlZE5vZGUgPSBvdGhlck5v ZGU7JywgIidwcm90ZWN0ZWROb2RlJyBpcyBpbmNvcnJlY3RseSBuYW1lZC4gSXQgc2hvdWxkIGJl IG5hbWVkICdwcm90ZWN0b3InIG9yICdwcm90ZWN0ZWRPdGhlck5vZGUnLiAgW3JlYWRhYmlsaXR5 L25hbWluZy9wcm90ZWN0ZWRdIFs0XSIpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1JlZlB0 cjxOb2RlPiBwcm90ZWN0ZWROb2RlID0gJm90aGVyTm9kZTsnLCAiJ3Byb3RlY3RlZE5vZGUnIGlz IGluY29ycmVjdGx5IG5hbWVkLiBJdCBzaG91bGQgYmUgbmFtZWQgJ3Byb3RlY3Rvcicgb3IgJ3By b3RlY3RlZE90aGVyTm9kZScuICBbcmVhZGFiaWxpdHkvbmFtaW5nL3Byb3RlY3RlZF0gWzRdIikK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnUmVmPE5vZGU+IHByb3RlY3RlZE5vZGUgPSBvdGhl ck5vZGU7JywgIidwcm90ZWN0ZWROb2RlJyBpcyBpbmNvcnJlY3RseSBuYW1lZC4gSXQgc2hvdWxk IGJlIG5hbWVkICdwcm90ZWN0b3InIG9yICdwcm90ZWN0ZWRPdGhlck5vZGUnLiAgW3JlYWRhYmls aXR5L25hbWluZy9wcm90ZWN0ZWRdIFs0XSIpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1Jl ZjxOb2RlPiBwcm90ZWN0ZWROb2RlID0gKm90aGVyTm9kZTsnLCAiJ3Byb3RlY3RlZE5vZGUnIGlz IGluY29ycmVjdGx5IG5hbWVkLiBJdCBzaG91bGQgYmUgbmFtZWQgJ3Byb3RlY3Rvcicgb3IgJ3By b3RlY3RlZE90aGVyTm9kZScuICBbcmVhZGFiaWxpdHkvbmFtaW5nL3Byb3RlY3RlZF0gWzRdIikK ICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnUmVmUHRyPE5vZGU+IG5vZGVSZWYobm9kZSk7Jywg Iidub2RlUmVmJyBpcyBpbmNvcnJlY3RseSBuYW1lZC4gSXQgc2hvdWxkIGJlIG5hbWVkICdwcm90 ZWN0b3InIG9yICdwcm90ZWN0ZWROb2RlJy4gIFtyZWFkYWJpbGl0eS9uYW1pbmcvcHJvdGVjdGVk XSBbNF0iKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdSZWY8Tm9kZT4gbm9kZVJlZigqbm9k ZSk7JywgIidub2RlUmVmJyBpcyBpbmNvcnJlY3RseSBuYW1lZC4gSXQgc2hvdWxkIGJlIG5hbWVk ICdwcm90ZWN0b3InIG9yICdwcm90ZWN0ZWROb2RlJy4gIFtyZWFkYWJpbGl0eS9uYW1pbmcvcHJv dGVjdGVkXSBbNF0iKQogCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL0NoYW5nZUxv ZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDI0ZjAzYzVmNDVkYmZkM2Nk YjEzNjBjMGQxMWNjN2JlZmE4MjIxYjMuLmQzMzNlNzkwODU4Mjg3OWQ5ZTE2YjEzYzZhN2JjOTNj M2ZjNGRhODEgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBi L1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTYtMDUt MTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEV4dGVuZCBw cm90ZWN0b3IgbmFtaW5nIGNvZGUgc3R5bGUgZ3VpZGVsaW5lIHRvIGNvdmVyIG9wZXJhdG9yPSBh c3NpZ25tZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3NjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjb2RlLXN0eWxlLm1kOgorCisyMDE2LTA1LTEzICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KKwogICAgICAgICBQcm90ZWN0b3IgUmVmL1JlZlB0cnMgc2hvdWxkIGhhdmUg YSBzcGVjaWZpZWQgbmFtaW5nIHN0eWxlLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NTkxCiAKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5v cmcvY29kZS1zdHlsZS5tZCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5tZAppbmRl eCAwMzllZTQzYmY5YWIyOGNjNDg5NjAzNzJhZWNlYmZlMzgzMDFmYmE3Li5kOGRmOGI5NTg2MjJh Mzc5OWQ0ZGU2ZjU0OTRjZjhlNjI1YWIwNmU3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQu b3JnL2NvZGUtc3R5bGUubWQKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1k CkBAIC03MjAsMTIgKzcyMCwxNCBAQCBzZXRSZXNpemFibGUoTm90UmVzaXphYmxlKTsKIGBgYGNw cAogUmVmUHRyPE5vZGU+IHByb3RlY3RlZFRoaXModGhpcyk7CiBSZWY8RWxlbWVudD4gcHJvdGVj dGVkVGhpcygqdGhpcyk7CitSZWZQdHI8V2lkZ2V0PiBwcm90ZWN0ZWRUaGlzID0gdGhpczsKIGBg YAogCiAjIyMjIyMgV3Jvbmc6CiAKIGBgYGNwcAogUmVmUHRyPE5vZGU+IHByb3RlY3Rvcih0aGlz KTsKK1JlZjxOb2RlPiBwcm90ZWN0b3IgPSAqdGhpczsKIFJlZlB0cjxXaWRnZXQ+IHNlbGYodGhp cyk7CiBSZWY8RWxlbWVudD4gZWxlbWVudFJlZigqdGhpcyk7CiBgYGAKQEAgLTczNiw4ICs3Mzgs MTAgQEAgUmVmPEVsZW1lbnQ+IGVsZW1lbnRSZWYoKnRoaXMpOwogCiBgYGBjcHAKIFJlZlB0cjxF bGVtZW50PiBwcm90ZWN0b3IoJmVsZW1lbnQpOworUmVmUHRyPEVsZW1lbnQ+IHByb3RlY3RvciA9 ICZlbGVtZW50OwogUmVmUHRyPE5vZGU+IHByb3RlY3RlZE5vZGUobm9kZSk7CiBSZWZQdHI8V2lk Z2V0PiBwcm90ZWN0ZWRNYWluV2lkZ2V0KG1fbWFpbldpZGdldCk7CitSZWZQdHI8TG9hZGVyPiBw cm90ZWN0ZWRGb250TG9hZGVyID0gbV9mb250TG9hZGVyOwogYGBgCiAKICMjIyMjIyBXcm9uZzoK QEAgLTc0NSw4ICs3NDksOCBAQCBSZWZQdHI8V2lkZ2V0PiBwcm90ZWN0ZWRNYWluV2lkZ2V0KG1f bWFpbldpZGdldCk7CiBgYGBjcHAKIFJlZlB0cjxOb2RlPiBub2RlUmVmKCZyb290Tm9kZSk7CiBS ZWY8RWxlbWVudD4gcHJvdGVjdCgqZWxlbWVudCk7Ci1SZWZQdHI8V2lkZ2V0PiBwcm90ZWN0ZWQo d2lkZ2V0KTsKIFJlZlB0cjxOb2RlPiBwcm90ZWN0b3JOb2RlKG5vZGUpOworUmVmUHRyPFdpZGdl dD4gcHJvdGVjdGVkID0gd2lkZ2V0OwogYGBgCiAKICMjIyBPdGhlciBQdW5jdHVhdGlvbgo=