157691 2016-05-13 16:21:22 -0700 v3 UI shows full git hash instead of the first 8 characters for a blame range 2016-05-13 17:00:28 -0700 1 1 1 Unclassified WebKit Perf Dashboard Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu kling koivisto rniwa slewis oldest_to_newest 1192946 0 rniwa 2016-05-13 16:21:22 -0700 In v3 UI's commit viewer, we show the full 40 character git hash instead of the first 8 character as done in v2 UI. Fix that. 1192949 1 278891 rniwa 2016-05-13 16:26:13 -0700 Created attachment 278891 Fixes the bug 1192970 2 rniwa 2016-05-13 17:00:28 -0700 Committed r200900: <http://trac.webkit.org/changeset/200900> 278891 2016-05-13 16:26:13 -0700 2016-05-13 16:33:15 -0700 Fixes the bug bug-157691-20160513162705.patch text/plain 7268 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwODkwKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIHYzIFVJIHNob3dzIGZ1bGwgZ2l0IGhhc2ggaW5zdGVhZCBvZiB0aGUgZmlyc3Qg OCBjaGFyYWN0ZXJzIGZvciBhIGJsYW1lIHJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc2OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgYnVnIHRoYXQgdjMgVUkgc2hvd3MgdGhl IGZ1bGwgNDAgY2hhcmFjdGVyIGdpdCBoYXNoIGluc3RlYWQgb2YgdGhlIGZpcnN0IDggY2hhcmFj dGVyIGFzIGRvbmUgaW4gdjIgVUkuCisKKyAgICAgICAgKiBwdWJsaWMvdjMvbW9kZWxzL2NvbW1p dC1sb2cuanM6CisgICAgICAgIChDb21taXRMb2cucHJvdG90eXBlLmRpZmYpOiBGaXhlZCB0aGUg YnVnLgorICAgICAgICAqIHRvb2xzL3J1bi10ZXN0cy5weToKKyAgICAgICAgKG1haW4pOiBBZGQg dGhlIHN1cHBvcnQgZm9yIHJ1bm5pbmcgYSBzdWJzZXQgb2YgdGVzdHMgYXMgbW9jaGEgZG9lcy4K KyAgICAgICAgKiB1bml0LXRlc3RzL2NvbW1pdC1sb2ctdGVzdHMuanM6IEFkZGVkLgorCiAyMDE2 LTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIEFkZGVkIHRoZSBtaXNzaW5nIGV4ZWN1dGFibGUgYml0cy4KSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL2NvbW1pdC1sb2cuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9tb2RlbHMvY29tbWl0LWxv Zy5qcwkocmV2aXNpb24gMjAwODg1KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvY29tbWl0LWxvZy5qcwkod29ya2luZyBjb3B5KQpAQCAtNjAsNyArNjAsNyBA QCBjbGFzcyBDb21taXRMb2cgZXh0ZW5kcyBEYXRhTW9kZWxPYmplY3QgCiAgICAgICAgICAgICBm cm9tID0gcGFyc2VJbnQoZnJvbSkgKyAxOwogICAgICAgICAgICAgbGFiZWwgPSBgciR7ZnJvbX0t ciR7dGhpcy5yZXZpc2lvbigpfWA7CiAgICAgICAgIH0gZWxzZSBpZiAodG8ubGVuZ3RoID09IDQw KSB7IC8vIGUuZy4gZ2l0IGhhc2gKLSAgICAgICAgICAgIGxhYmVsID0gYCR7ZnJvbX0uLiR7dG99 YDsKKyAgICAgICAgICAgIGxhYmVsID0gYCR7ZnJvbS5zdWJzdHJpbmcoMCwgOCl9Li4ke3RvLnN1 YnN0cmluZygwLCA4KX1gOwogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIGxhYmVsID0gYCR7 ZnJvbX0gLSAke3RvfWA7CiAKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29scy9y dW4tdGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xz L3J1bi10ZXN0cy5weQkocmV2aXNpb24gMjAwODg1KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3Rvb2xzL3J1bi10ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMiw2ICsyLDcgQEAKIAog aW1wb3J0IG9zCiBpbXBvcnQgc3VicHJvY2VzcworaW1wb3J0IHN5cwogCiAKIGRlZiBtYWluKCk6 CkBAIC0xNyw3ICsxOCw4IEBAIGRlZiBtYWluKCk6CiAgICAgICAgICAgICBzdWJwcm9jZXNzLmNh bGwoWyducG0nLCAnaW5zdGFsbCcsIHBhY2thZ2VfbmFtZV0pCiAKICAgICBtb2NoYV9wYXRoID0g b3MucGF0aC5qb2luKG5vZGVfbW9kdWxlc19kaXIsICdtb2NoYS9iaW4vbW9jaGEnKQotICAgIHJl dHVybiBzdWJwcm9jZXNzLmNhbGwoW21vY2hhX3BhdGgsICd1bml0LXRlc3RzJywgJ3NlcnZlci10 ZXN0cyddKQorICAgIHRlc3RfcGF0aHMgPSBzeXMuYXJndlsxOl0gb3IgWyd1bml0LXRlc3RzJywg J3NlcnZlci10ZXN0cyddCisgICAgcmV0dXJuIHN1YnByb2Nlc3MuY2FsbChbbW9jaGFfcGF0aF0g KyB0ZXN0X3BhdGhzKQogCiBpZiBfX25hbWVfXyA9PSAiX19tYWluX18iOgogICAgIG1haW4oKQpJ bmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3VuaXQtdGVzdHMvY29tbWl0LWxvZy10ZXN0 cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdW5pdC10ZXN0cy9j b21taXQtbG9nLXRlc3RzLmpzCShyZXZpc2lvbiAwKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3VuaXQtdGVzdHMvY29tbWl0LWxvZy10ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCww ICsxLDE1MCBAQAorJ3VzZSBzdHJpY3QnOworCitjb25zdCBhc3NlcnQgPSByZXF1aXJlKCdhc3Nl cnQnKTsKKworcmVxdWlyZSgnLi4vdG9vbHMvanMvdjMtbW9kZWxzLmpzJyk7Citjb25zdCBNb2Nr TW9kZWxzID0gcmVxdWlyZSgnLi9yZXNvdXJjZXMvbW9jay12My1tb2RlbHMuanMnKS5Nb2NrTW9k ZWxzOworCitmdW5jdGlvbiB3ZWJraXRDb21taXQoKQoreworICAgIHJldHVybiBuZXcgQ29tbWl0 TG9nKDEsIHsKKyAgICAgICAgcmVwb3NpdG9yeTogTW9ja01vZGVscy53ZWJraXQsCisgICAgICAg IHJldmlzaW9uOiAnMjAwODA1JywKKyAgICAgICAgdGltZTogKyhuZXcgRGF0ZSgnMjAxNi0wNS0x M1QwMDo1NTo1Ny44NDEzNDRaJykpLAorICAgIH0pOworfQorCitmdW5jdGlvbiBvbGRXZWJLaXRD b21taXQoKQoreworICAgIHJldHVybiBuZXcgQ29tbWl0TG9nKDIsIHsKKyAgICAgICAgcmVwb3Np dG9yeTogTW9ja01vZGVscy53ZWJraXQsCisgICAgICAgIHJldmlzaW9uOiAnMjAwNTc0JywKKyAg ICAgICAgdGltZTogKyhuZXcgRGF0ZSgnMjAxNi0wNS0wOVQxNDo1OToyMy41NTM3NjdaJykpLAor ICAgIH0pOworfQorCitmdW5jdGlvbiBnaXRXZWJLaXRDb21taXQoKQoreworICAgIHJldHVybiBu ZXcgQ29tbWl0TG9nKDMsIHsKKyAgICAgICAgcmVwb3NpdG9yeTogTW9ja01vZGVscy53ZWJraXQs CisgICAgICAgIHJldmlzaW9uOiAnNmY4YjBkYmJkYTk1YTQ0MDUwM2I4OGRiMWRkMDNkYWQzYTdi MDdmYicsCisgICAgICAgIHRpbWU6ICsobmV3IERhdGUoJzIwMTYtMDUtMTNUMDA6NTU6NTcuODQx MzQ0WicpKSwKKyAgICB9KTsKK30KKworZnVuY3Rpb24gb2xkR2l0V2ViS2l0Q29tbWl0KCkKK3sK KyAgICByZXR1cm4gbmV3IENvbW1pdExvZyg0LCB7CisgICAgICAgIHJlcG9zaXRvcnk6IE1vY2tN b2RlbHMud2Via2l0LAorICAgICAgICByZXZpc2lvbjogJ2ZmZGExNGU2ZGIwNzQ2ZDEwZDBmMDUw OTA3ZTRhNzMyNTg1MWU1MDInLAorICAgICAgICB0aW1lOiArKG5ldyBEYXRlKCcyMDE2LTA1LTA5 VDE0OjU5OjIzLjU1Mzc2N1onKSksCisgICAgfSk7Cit9CisKK2Z1bmN0aW9uIG9zeENvbW1pdCgp Cit7CisgICAgcmV0dXJuIG5ldyBDb21taXRMb2coNSwgeworICAgICAgICByZXBvc2l0b3J5OiBN b2NrTW9kZWxzLm9zeCwKKyAgICAgICAgcmV2aXNpb246ICcxMC4xMS40IDE1RTY1JywKKyAgICAg ICAgdGltZTogbnVsbCwKKyAgICB9KTsKK30KKworZnVuY3Rpb24gb2xkT1NYQ29tbWl0KCkKK3sK KyAgICByZXR1cm4gbmV3IENvbW1pdExvZyg2LCB7CisgICAgICAgIHJlcG9zaXRvcnk6IE1vY2tN b2RlbHMub3N4LAorICAgICAgICByZXZpc2lvbjogJzEwLjExLjMgMTVEMjEnLAorICAgICAgICB0 aW1lOiBudWxsLAorICAgIH0pOworfQorCitkZXNjcmliZSgnQ29tbWl0TG9nJywgZnVuY3Rpb24g KCkgeworICAgIE1vY2tNb2RlbHMuaW5qZWN0KCk7CisKKyAgICBkZXNjcmliZSgnbGFiZWwnLCBm dW5jdGlvbiAoKSB7CisgICAgICAgIGl0KCdzaG91bGQgcHJlZml4IFNWTiByZXZpc2lvbiB3aXRo ICJyIicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGFzc2VydC5lcXVhbCh3ZWJraXRDb21t aXQoKS5sYWJlbCgpLCAncjIwMDgwNScpOworICAgICAgICB9KTsKKworICAgICAgICBpdCgnc2hv dWxkIHRydW5jYXRlIGEgR2l0IGhhc2ggYXQgOHRoIGNoYXJhY3RlcicsIGZ1bmN0aW9uICgpIHsK KyAgICAgICAgICAgIGFzc2VydC5lcXVhbChnaXRXZWJLaXRDb21taXQoKS5sYWJlbCgpLCAnNmY4 YjBkYmInKTsKKyAgICAgICAgfSk7CisKKyAgICAgICAgaXQoJ3Nob3VsZCBub3QgbW9kaWZ5IE9T IFggdmVyc2lvbicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGFzc2VydC5lcXVhbChvc3hD b21taXQoKS5sYWJlbCgpLCAnMTAuMTEuNCAxNUU2NScpOworICAgICAgICB9KTsKKyAgICB9KTsK KworICAgIGRlc2NyaWJlKCd0aXRsZScsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgaXQoJ3Nob3Vs ZCBwcmVmaXggU1ZOIHJldmlzaW9uIHdpdGggInIiJywgZnVuY3Rpb24gKCkgeworICAgICAgICAg ICAgYXNzZXJ0LmVxdWFsKHdlYmtpdENvbW1pdCgpLnRpdGxlKCksICdXZWJLaXQgYXQgcjIwMDgw NScpOworICAgICAgICB9KTsKKworICAgICAgICBpdCgnc2hvdWxkIHRydW5jYXRlIGEgR2l0IGhh c2ggYXQgOHRoIGNoYXJhY3RlcicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGFzc2VydC5l cXVhbChnaXRXZWJLaXRDb21taXQoKS50aXRsZSgpLCAnV2ViS2l0IGF0IDZmOGIwZGJiJyk7Cisg ICAgICAgIH0pOworCisgICAgICAgIGl0KCdzaG91bGQgbm90IG1vZGlmeSBPUyBYIHZlcnNpb24n LCBmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBhc3NlcnQuZXF1YWwob3N4Q29tbWl0KCkudGl0 bGUoKSwgJ09TIFggYXQgMTAuMTEuNCAxNUU2NScpOworICAgICAgICB9KTsKKyAgICB9KTsKKwor ICAgIGRlc2NyaWJlKCdkaWZmJywgZnVuY3Rpb24gKCkgeworICAgICAgICBpdCgnc2hvdWxkIHVz ZSBsYWJlbCgpIGFzIHRoZSBsYWJlbCB0aGUgcHJldmlvdXMgY29tbWl0IGlzIG1pc3NpbmcnLCBm dW5jdGlvbiAoKSB7CisgICAgICAgICAgICBhc3NlcnQuZGVlcEVxdWFsKHdlYmtpdENvbW1pdCgp LmRpZmYoKSwgeworICAgICAgICAgICAgICAgIGZyb206IG51bGwsCisgICAgICAgICAgICAgICAg dG86ICcyMDA4MDUnLAorICAgICAgICAgICAgICAgIGxhYmVsOiAncjIwMDgwNScsCisgICAgICAg ICAgICAgICAgdXJsOiAnaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjAwODA1JywK KyAgICAgICAgICAgICAgICByZXBvc2l0b3J5OiBNb2NrTW9kZWxzLndlYmtpdAorICAgICAgICAg ICAgfSk7CisKKyAgICAgICAgICAgIGFzc2VydC5kZWVwRXF1YWwoZ2l0V2ViS2l0Q29tbWl0KCku ZGlmZigpLCB7CisgICAgICAgICAgICAgICAgZnJvbTogbnVsbCwKKyAgICAgICAgICAgICAgICB0 bzogJzZmOGIwZGJiZGE5NWE0NDA1MDNiODhkYjFkZDAzZGFkM2E3YjA3ZmInLAorICAgICAgICAg ICAgICAgIGxhYmVsOiAnNmY4YjBkYmInLAorICAgICAgICAgICAgICAgIHVybDogJ2h0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzZmOGIwZGJiZGE5NWE0NDA1MDNiODhkYjFkZDAzZGFk M2E3YjA3ZmInLAorICAgICAgICAgICAgICAgIHJlcG9zaXRvcnk6IE1vY2tNb2RlbHMud2Via2l0 LAorICAgICAgICAgICAgfSk7CisKKyAgICAgICAgICAgIGFzc2VydC5kZWVwRXF1YWwob3N4Q29t bWl0KCkuZGlmZigpLCB7CisgICAgICAgICAgICAgICAgZnJvbTogbnVsbCwKKyAgICAgICAgICAg ICAgICB0bzogJzEwLjExLjQgMTVFNjUnLAorICAgICAgICAgICAgICAgIGxhYmVsOiAnMTAuMTEu NCAxNUU2NScsCisgICAgICAgICAgICAgICAgdXJsOiAnJywKKyAgICAgICAgICAgICAgICByZXBv c2l0b3J5OiBNb2NrTW9kZWxzLm9zeCwKKyAgICAgICAgICAgIH0pOworICAgICAgICB9KTsKKwor ICAgICAgICBpdCgnc2hvdWxkIHVzZSBpbmNyZW1lbnQgdGhlIG9sZCBTVk4gcmV2aXNpb24gYnkg MScsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGFzc2VydC5kZWVwRXF1YWwod2Via2l0Q29t bWl0KCkuZGlmZihvbGRXZWJLaXRDb21taXQoKSksIHsKKyAgICAgICAgICAgICAgICBmcm9tOiAn MjAwNTc1JywKKyAgICAgICAgICAgICAgICB0bzogJzIwMDgwNScsCisgICAgICAgICAgICAgICAg bGFiZWw6ICdyMjAwNTc1LXIyMDA4MDUnLAorICAgICAgICAgICAgICAgIHVybDogJycsCisgICAg ICAgICAgICAgICAgcmVwb3NpdG9yeTogTW9ja01vZGVscy53ZWJraXQKKyAgICAgICAgICAgIH0p OworICAgICAgICB9KTsKKworICAgICAgICBpdCgnc2hvdWxkIHRydW5jYXRlIGEgR2l0IGhhc2gg YXQgOHRoIGNoYXJhY3RlcicsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGFzc2VydC5kZWVw RXF1YWwoZ2l0V2ViS2l0Q29tbWl0KCkuZGlmZihvbGRHaXRXZWJLaXRDb21taXQoKSksIHsKKyAg ICAgICAgICAgICAgICBmcm9tOiAnZmZkYTE0ZTZkYjA3NDZkMTBkMGYwNTA5MDdlNGE3MzI1ODUx ZTUwMicsCisgICAgICAgICAgICAgICAgdG86ICc2ZjhiMGRiYmRhOTVhNDQwNTAzYjg4ZGIxZGQw M2RhZDNhN2IwN2ZiJywKKyAgICAgICAgICAgICAgICBsYWJlbDogJ2ZmZGExNGU2Li42ZjhiMGRi YicsCisgICAgICAgICAgICAgICAgdXJsOiAnJywKKyAgICAgICAgICAgICAgICByZXBvc2l0b3J5 OiBNb2NrTW9kZWxzLndlYmtpdAorICAgICAgICAgICAgfSk7CisgICAgICAgIH0pOworCisgICAg ICAgIGl0KCdzaG91bGQgc3Vycm91bmQgIi0iIHdpdGggc3BhY2VzJywgZnVuY3Rpb24gKCkgewor ICAgICAgICAgICAgYXNzZXJ0LmRlZXBFcXVhbChvc3hDb21taXQoKS5kaWZmKG9sZE9TWENvbW1p dCgpKSwgeworICAgICAgICAgICAgICAgIGZyb206ICcxMC4xMS4zIDE1RDIxJywKKyAgICAgICAg ICAgICAgICB0bzogJzEwLjExLjQgMTVFNjUnLAorICAgICAgICAgICAgICAgIGxhYmVsOiAnMTAu MTEuMyAxNUQyMSAtIDEwLjExLjQgMTVFNjUnLAorICAgICAgICAgICAgICAgIHVybDogJycsCisg ICAgICAgICAgICAgICAgcmVwb3NpdG9yeTogTW9ja01vZGVscy5vc3gKKyAgICAgICAgICAgIH0p OworICAgICAgICB9KTsKKyAgICB9KTsKK30pOwo=