157675 2016-05-13 08:53:07 -0700 Give CrossThreadCopier a default specialization for Vectors of objects 2016-05-13 13:17:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson commit-queue oldest_to_newest 1192757 0 beidson 2016-05-13 08:53:07 -0700 Give CrossThreadCopier a generic specialization for Vectors of objects 1192762 1 278838 beidson 2016-05-13 09:00:59 -0700 Created attachment 278838 Patch v1 1192763 2 commit-queue 2016-05-13 09:02:56 -0700 Attachment 278838 did not pass style-queue: ERROR: Source/WebCore/platform/CrossThreadCopier.h:170: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1192766 3 278839 beidson 2016-05-13 09:07:47 -0700 Created attachment 278839 Patch 1192772 4 278839 darin 2016-05-13 09:31:25 -0700 Comment on attachment 278839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278839&action=review > Source/WebCore/platform/CrossThreadCopier.h:170 > + static Type copy(const Vector<T>& source) I would have written const Type&. > Source/WebCore/platform/CrossThreadCopier.h:176 > + I would have omitted this blank line. 1192774 5 278839 darin 2016-05-13 09:31:45 -0700 Comment on attachment 278839 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278839&action=review > Source/WebCore/platform/CrossThreadCopier.h:168 > +template<typename T> struct CrossThreadCopierBase<false, false, Vector<T>> { Could consider making this work for vectors with inline capacity too. 1192786 6 beidson 2016-05-13 10:23:07 -0700 (In reply to comment #5) > Comment on attachment 278839 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278839&action=review > > > Source/WebCore/platform/CrossThreadCopier.h:168 > > +template<typename T> struct CrossThreadCopierBase<false, false, Vector<T>> { > > Could consider making this work for vectors with inline capacity too. I think this would require a second specialization, so I'll punt until it's actually needed (Which, since these are rare enough, might be never) 1192792 7 beidson 2016-05-13 10:36:48 -0700 http://trac.webkit.org/changeset/200861 278838 2016-05-13 09:00:59 -0700 2016-05-13 09:07:47 -0700 Patch v1 patch text/plain 2977 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Y2IwZjg2Li4wNWExZDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDUtMTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEdpdmUgQ3Jvc3NUaHJlYWRDb3BpZXIgYSBkZWZhdWx0IHNwZWNpYWxpemF0aW9uIGZvciBW ZWN0b3JzIG9mIG9iamVjdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTc2NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMgKFJlZmFjdG9yLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3Ip LgorCisgICAgICAgICogcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VmVjdG9yPFN0cmluZz4+Ojpjb3B5KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9Dcm9zc1RocmVhZENvcGllci5oOiBBZGQgYSBkZWZhdWx0IHNwZWNpYWxpemF0aW9uIGZv ciBWZWN0b3I8VD4gd2hlcmUgVCBpcyBhIHR5cGUKKyAgICAgICAgICB0aGF0IGlzIENyb3NzVGhy ZWFkQ29weWFibGUgaXRzZWxmLgorCiAyMDE2LTA1LTEyICBLb25zdGFudGluIFRva2FyZXYgIDxh bm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBVc2UgcmVmZXJlbmNlIGluc3RlYWQgb2YgcG9p bnRlciBpbiBGcmFtZUxvYWRlckNsaWVudDo6c2F2ZVZpZXdTdGF0ZVRvSXRlbS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmNwcAppbmRleCBhYTc5ZTYyLi40 ZmYzMzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Dcm9zc1RocmVhZENv cGllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIu Y3BwCkBAIC04NSwxNiArODUsNiBAQCBDcm9zc1RocmVhZENvcGllckJhc2U8ZmFsc2UsIGZhbHNl LCBUaHJlYWRTYWZlRGF0YUJ1ZmZlcj46OlR5cGUgQ3Jvc3NUaHJlYWRDb3BpZQogICAgIHJldHVy biBUaHJlYWRTYWZlRGF0YUJ1ZmZlcihidWZmZXIpOwogfQogCi1Dcm9zc1RocmVhZENvcGllckJh c2U8ZmFsc2UsIGZhbHNlLCBWZWN0b3I8U3RyaW5nPj46OlR5cGUgQ3Jvc3NUaHJlYWRDb3BpZXJC YXNlPGZhbHNlLCBmYWxzZSwgVmVjdG9yPFN0cmluZz4+Ojpjb3B5KGNvbnN0IFZlY3RvcjxTdHJp bmc+JiBzdHJpbmdzKQotewotICAgIFZlY3RvcjxTdHJpbmc+IHJlc3VsdDsKLSAgICByZXN1bHQu cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzdHJpbmdzLnNpemUoKSk7Ci0gICAgZm9yIChhdXRvJiBz dHJpbmcgOiBzdHJpbmdzKQotICAgICAgICByZXN1bHQudW5jaGVja2VkQXBwZW5kKHN0cmluZy5p c29sYXRlZENvcHkoKSk7Ci0KLSAgICByZXR1cm4gcmVzdWx0OwotfQotCiAvLyBUZXN0IENyb3Nz VGhyZWFkQ29waWVyIHVzaW5nIENPTVBJTEVfQVNTRVJULgogCiAvLyBWZXJpZnkgdGhhdCBUaHJl YWRTYWZlUmVmQ291bnRlZCBvYmplY3RzIGdldCBoYW5kbGVkIGNvcnJlY3RseS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Dcm9zc1RocmVhZENvcGllci5oCmluZGV4IDMzNTAyYzMuLjI4MTAy MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIuaApAQCAt MTYwLDEzICsxNjAsMjEgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQ3Jvc3NUaHJlYWRDb3BpZXJCYXNl PGZhbHNlLCBmYWxzZSwgVGhyZWFkU2FmZURhdGFCdWZmZXI+IHsKICAgICBzdGF0aWMgVHlwZSBj b3B5KGNvbnN0IFRocmVhZFNhZmVEYXRhQnVmZmVyJik7CiB9OwogCi10ZW1wbGF0ZTw+IHN0cnVj dCBDcm9zc1RocmVhZENvcGllckJhc2U8ZmFsc2UsIGZhbHNlLCBWZWN0b3I8U3RyaW5nPj4gewot ICAgIHR5cGVkZWYgVmVjdG9yPFN0cmluZz4gVHlwZTsKLSAgICBzdGF0aWMgVHlwZSBjb3B5KGNv bnN0IFZlY3RvcjxTdHJpbmc+Jik7Ci19OwotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogc3RydWN0 IENyb3NzVGhyZWFkQ29waWVyIDogcHVibGljIENyb3NzVGhyZWFkQ29waWVyQmFzZTxDcm9zc1Ro cmVhZENvcGllckJhc2VIZWxwZXI6OklzRW51bU9yQ29udmVydGlibGVUb0ludGVnZXI8VD46OnZh bHVlLCBDcm9zc1RocmVhZENvcGllckJhc2VIZWxwZXI6OklzVGhyZWFkU2FmZVJlZkNvdW50ZWRQ b2ludGVyPFQ+Ojp2YWx1ZSwgVD4gewogfTsKIAorLy8gRGVmYXVsdCBzcGVjaWFsaXphdGlvbiBm b3IgVmVjdG9ycyBvZiBDcm9zc1RocmVhZENvcHlhYmxlIGNsYXNzZXMuCit0ZW1wbGF0ZTx0eXBl bmFtZSBUPiBzdHJ1Y3QgQ3Jvc3NUaHJlYWRDb3BpZXJCYXNlPGZhbHNlLCBmYWxzZSwgVmVjdG9y PFQ+PiB7CisgICAgdHlwZWRlZiBWZWN0b3I8VD4gVHlwZTsKKyAgICBzdGF0aWMgVHlwZSBjb3B5 KGNvbnN0IFZlY3RvcjxUPiYgc291cmNlKSB7CisgICAgICAgIFR5cGUgZGVzdGluYXRpb247Cisg ICAgICAgIGRlc3RpbmF0aW9uLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoc291cmNlLnNpemUoKSk7 CisgICAgICAgIGZvciAoYXV0byYgb2JqZWN0IDogc291cmNlKQorICAgICAgICAgICAgZGVzdGlu YXRpb24udW5jaGVja2VkQXBwZW5kKENyb3NzVGhyZWFkQ29waWVyPFQ+Ojpjb3B5KG9iamVjdCkp OworCisgICAgICAgIHJldHVybiBkZXN0aW5hdGlvbjsKKyAgICB9Cit9OworCiB9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCg== 278839 2016-05-13 09:07:47 -0700 2016-05-13 13:17:37 -0700 Patch patch text/plain 2982 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3Y2IwZjg2Li4wNWExZDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMDUtMTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEdpdmUgQ3Jvc3NUaHJlYWRDb3BpZXIgYSBkZWZhdWx0IHNwZWNpYWxpemF0aW9uIGZvciBW ZWN0b3JzIG9mIG9iamVjdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTc2NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMgKFJlZmFjdG9yLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3Ip LgorCisgICAgICAgICogcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VmVjdG9yPFN0cmluZz4+Ojpjb3B5KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9Dcm9zc1RocmVhZENvcGllci5oOiBBZGQgYSBkZWZhdWx0IHNwZWNpYWxpemF0aW9uIGZv ciBWZWN0b3I8VD4gd2hlcmUgVCBpcyBhIHR5cGUKKyAgICAgICAgICB0aGF0IGlzIENyb3NzVGhy ZWFkQ29weWFibGUgaXRzZWxmLgorCiAyMDE2LTA1LTEyICBLb25zdGFudGluIFRva2FyZXYgIDxh bm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBVc2UgcmVmZXJlbmNlIGluc3RlYWQgb2YgcG9p bnRlciBpbiBGcmFtZUxvYWRlckNsaWVudDo6c2F2ZVZpZXdTdGF0ZVRvSXRlbS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmNwcAppbmRleCBhYTc5ZTYyLi40 ZmYzMzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Dcm9zc1RocmVhZENv cGllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIu Y3BwCkBAIC04NSwxNiArODUsNiBAQCBDcm9zc1RocmVhZENvcGllckJhc2U8ZmFsc2UsIGZhbHNl LCBUaHJlYWRTYWZlRGF0YUJ1ZmZlcj46OlR5cGUgQ3Jvc3NUaHJlYWRDb3BpZQogICAgIHJldHVy biBUaHJlYWRTYWZlRGF0YUJ1ZmZlcihidWZmZXIpOwogfQogCi1Dcm9zc1RocmVhZENvcGllckJh c2U8ZmFsc2UsIGZhbHNlLCBWZWN0b3I8U3RyaW5nPj46OlR5cGUgQ3Jvc3NUaHJlYWRDb3BpZXJC YXNlPGZhbHNlLCBmYWxzZSwgVmVjdG9yPFN0cmluZz4+Ojpjb3B5KGNvbnN0IFZlY3RvcjxTdHJp bmc+JiBzdHJpbmdzKQotewotICAgIFZlY3RvcjxTdHJpbmc+IHJlc3VsdDsKLSAgICByZXN1bHQu cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzdHJpbmdzLnNpemUoKSk7Ci0gICAgZm9yIChhdXRvJiBz dHJpbmcgOiBzdHJpbmdzKQotICAgICAgICByZXN1bHQudW5jaGVja2VkQXBwZW5kKHN0cmluZy5p c29sYXRlZENvcHkoKSk7Ci0KLSAgICByZXR1cm4gcmVzdWx0OwotfQotCiAvLyBUZXN0IENyb3Nz VGhyZWFkQ29waWVyIHVzaW5nIENPTVBJTEVfQVNTRVJULgogCiAvLyBWZXJpZnkgdGhhdCBUaHJl YWRTYWZlUmVmQ291bnRlZCBvYmplY3RzIGdldCBoYW5kbGVkIGNvcnJlY3RseS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Dcm9zc1RocmVhZENvcGllci5oCmluZGV4IDMzNTAyYzMuLjgzMDRl ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nyb3NzVGhyZWFkQ29waWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Jvc3NUaHJlYWRDb3BpZXIuaApAQCAt MTYwLDEzICsxNjAsMjIgQEAgdGVtcGxhdGU8PiBzdHJ1Y3QgQ3Jvc3NUaHJlYWRDb3BpZXJCYXNl PGZhbHNlLCBmYWxzZSwgVGhyZWFkU2FmZURhdGFCdWZmZXI+IHsKICAgICBzdGF0aWMgVHlwZSBj b3B5KGNvbnN0IFRocmVhZFNhZmVEYXRhQnVmZmVyJik7CiB9OwogCi10ZW1wbGF0ZTw+IHN0cnVj dCBDcm9zc1RocmVhZENvcGllckJhc2U8ZmFsc2UsIGZhbHNlLCBWZWN0b3I8U3RyaW5nPj4gewot ICAgIHR5cGVkZWYgVmVjdG9yPFN0cmluZz4gVHlwZTsKLSAgICBzdGF0aWMgVHlwZSBjb3B5KGNv bnN0IFZlY3RvcjxTdHJpbmc+Jik7Ci19OwotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogc3RydWN0 IENyb3NzVGhyZWFkQ29waWVyIDogcHVibGljIENyb3NzVGhyZWFkQ29waWVyQmFzZTxDcm9zc1Ro cmVhZENvcGllckJhc2VIZWxwZXI6OklzRW51bU9yQ29udmVydGlibGVUb0ludGVnZXI8VD46OnZh bHVlLCBDcm9zc1RocmVhZENvcGllckJhc2VIZWxwZXI6OklzVGhyZWFkU2FmZVJlZkNvdW50ZWRQ b2ludGVyPFQ+Ojp2YWx1ZSwgVD4gewogfTsKIAorLy8gRGVmYXVsdCBzcGVjaWFsaXphdGlvbiBm b3IgVmVjdG9ycyBvZiBDcm9zc1RocmVhZENvcHlhYmxlIGNsYXNzZXMuCit0ZW1wbGF0ZTx0eXBl bmFtZSBUPiBzdHJ1Y3QgQ3Jvc3NUaHJlYWRDb3BpZXJCYXNlPGZhbHNlLCBmYWxzZSwgVmVjdG9y PFQ+PiB7CisgICAgdHlwZWRlZiBWZWN0b3I8VD4gVHlwZTsKKyAgICBzdGF0aWMgVHlwZSBjb3B5 KGNvbnN0IFZlY3RvcjxUPiYgc291cmNlKQorICAgIHsKKyAgICAgICAgVHlwZSBkZXN0aW5hdGlv bjsKKyAgICAgICAgZGVzdGluYXRpb24ucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzb3VyY2Uuc2l6 ZSgpKTsKKyAgICAgICAgZm9yIChhdXRvJiBvYmplY3QgOiBzb3VyY2UpCisgICAgICAgICAgICBk ZXN0aW5hdGlvbi51bmNoZWNrZWRBcHBlbmQoQ3Jvc3NUaHJlYWRDb3BpZXI8VD46OmNvcHkob2Jq ZWN0KSk7CisKKyAgICAgICAgcmV0dXJuIGRlc3RpbmF0aW9uOworICAgIH0KK307CisKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUK