157674 2016-05-13 06:16:41 -0700 Web Inspector: Computed style shows both prefixed and unprefixed variants of properties 2016-05-16 11:27:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192730 0 graouts 2016-05-13 06:16:41 -0700 If you set an animation property, which is supported both prefixed and unprefixed in WebKit, both the prefixed and unprefixed variants will show in the computed styles. Only properties that are explicitly set should be shown. 1192731 1 webkit-bug-importer 2016-05-13 06:17:01 -0700 <rdar://problem/26266679> 1192732 2 graouts 2016-05-13 06:17:11 -0700 <rdar://problem/24339756> 1192733 3 278837 graouts 2016-05-13 06:19:37 -0700 Created attachment 278837 Patch 1192779 4 278837 timothy 2016-05-13 09:54:34 -0700 Comment on attachment 278837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:962 > + return this._orderedStyles.some(function(style) { > + return style.properties.some(function (property) { We have been using arrow functions for things like this. They are fast! Also no space before (. 1192870 5 278837 mattbaker 2016-05-13 13:41:47 -0700 Comment on attachment 278837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review > Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:211 > + Lately we've been making simple getters/settings one line: set implicit(implicit) { this._implicit = implicit; } 1193441 6 279029 graouts 2016-05-16 11:24:55 -0700 Created attachment 279029 Patch for landing 1193443 7 bburg 2016-05-16 11:25:41 -0700 Committed r200952: <http://trac.webkit.org/changeset/200952> 1193444 8 279029 bburg 2016-05-16 11:26:14 -0700 Comment on attachment 279029 Patch for landing Already landed it through my local checkout. 278837 2016-05-13 06:19:37 -0700 2016-05-16 11:24:49 -0700 Patch bug-157674-20160513152027.patch text/plain 3383 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YzViZGZiMzVmNjA2YTc5ZWQ4MDgyM2U1YTAyNDAzYTg2NTIzNTM1Li43NTVkMGM1YWY5ZjNkMzJk NTA0ZDAxNjhlNzkzOGM1MjQxZGU2MjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNi0wNS0xMyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbXB1dGVkIHN0eWxlIHNob3dzIGJvdGggcHJl Zml4ZWQgYW5kIHVucHJlZml4ZWQgdmFyaWFudHMgb2YgcHJvcGVydGllcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3Njc0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNDMzOTc1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZSBtYWtlIHRoZSBDU1NQcm9wZXJ0eSBgaW1wbGljaXRgIHByb3BlcnR5 IHJlYWQtd3JpdGUsIGFuZCBpbiB0aGUgY2FzZSB3aGVyZSBhIGNvbXB1dGVkIHN0eWxlCisgICAg ICAgIGhhcyBhIHByb3BlcnR5IG1hcmtlZCBhcyBleHBsaWNpdCwgd2UgYWxzbyBjaGVjayB0aGF0 IGl0J3MgZm91bmQgaW4gbWF0Y2hpbmcgcnVsZXMgdG8gY29uc2lkZXIKKyAgICAgICAgaXQgbm9u LWltcGxpY2l0LiBUaGlzIGNvcnJlY3RseSBmaWx0ZXJzIG91dCB2YXJpYW50cyBvZiBwcm9wZXJ0 aWVzIHNldCBleHBsaWNpdGx5LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NT UHJvcGVydHkuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTUHJvcGVydHkucHJvdG90eXBl LnNldCBpbXBsaWNpdCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0 eWxlcy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5bGVzLnByb3RvdHlwZS5y ZWZyZXNoLmZldGNoZWRDb21wdXRlZFN0eWxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01O b2RlU3R5bGVzLnByb3RvdHlwZS5yZWZyZXNoKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01O b2RlU3R5bGVzLnByb3RvdHlwZS5faXNQcm9wZXJ0eUZvdW5kSW5NYXRjaGluZ1J1bGVzKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5bGVzKToKKwogMjAxNi0wNS0xMiAgRnVqaWkg SGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBXaW5kb3dzIFBlcmwgZmFpbHMgdG8gcnVuIGNvcHktdXNlci1pbnRlcmZhY2UtcmVzb3Vy Y2VzLnBsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTUHJvcGVydHkuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvQ1NTUHJvcGVydHkuanMKaW5kZXggZDkyYjNjNDNlOWQ2NTk2ZjcwMjMxMzk2ZDUz ZjI0ZjM3NzJhMTAxMS4uM2NkMmUwZTdlMWEwMzg1YmVlZWIxNWE3OGRjMjgyMzIxZGU5ODUxYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NT U1Byb3BlcnR5LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9DU1NQcm9wZXJ0eS5qcwpAQCAtMjA0LDYgKzIwNCwxMSBAQCBXZWJJbnNwZWN0b3IuQ1NT UHJvcGVydHkgPSBjbGFzcyBDU1NQcm9wZXJ0eSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QK ICAgICAgICAgcmV0dXJuIHRoaXMuX2ltcGxpY2l0OwogICAgIH0KIAorICAgIHNldCBpbXBsaWNp dChpbXBsaWNpdCkKKyAgICB7CisgICAgICAgIHRoaXMuX2ltcGxpY2l0ID0gaW1wbGljaXQ7Cisg ICAgfQorCiAgICAgZ2V0IGFub255bW91cygpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5f YW5vbnltb3VzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL0RPTU5vZGVTdHlsZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qcwppbmRleCAyM2ViZDVmODFlZTRmZDA2Nzhj NjUyYTk1MzI2YTIwZWEzZWY0NDI3Li5jODdjZWZiN2IzOTkxZGM1MWFmNjgyMmQzODY0YTg1OGE4 Njg4ODhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvRE9NTm9kZVN0eWxlcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0eWxlcy5qcwpAQCAtMTUwLDYgKzE1MCw4IEBAIFdlYklu c3BlY3Rvci5ET01Ob2RlU3R5bGVzID0gY2xhc3MgRE9NTm9kZVN0eWxlcyBleHRlbmRzIFdlYklu c3BlY3Rvci5PYmplY3QKICAgICAgICAgICAgICAgICBwcm9wZXJ0eVBheWxvYWQuaW1wbGljaXQg PSAhdGhpcy5fcHJvcGVydHlOYW1lVG9FZmZlY3RpdmVQcm9wZXJ0eU1hcFtjYW5vbmljYWxOYW1l XTsKIAogICAgICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IHRoaXMuX3BhcnNlU3R5bGVQcm9w ZXJ0eVBheWxvYWQocHJvcGVydHlQYXlsb2FkLCBOYU4sIHRoaXMuX2NvbXB1dGVkU3R5bGUpOwor ICAgICAgICAgICAgICAgIGlmICghcHJvcGVydHkuaW1wbGljaXQpCisgICAgICAgICAgICAgICAg ICAgIHByb3BlcnR5LmltcGxpY2l0ID0gIXRoaXMuX2lzUHJvcGVydHlGb3VuZEluTWF0Y2hpbmdS dWxlcyhwcm9wZXJ0eS5uYW1lKTsKICAgICAgICAgICAgICAgICBwcm9wZXJ0aWVzLnB1c2gocHJv cGVydHkpOwogICAgICAgICAgICAgfQogCkBAIC05NTMsNiArOTU1LDE1IEBAIFdlYkluc3BlY3Rv ci5ET01Ob2RlU3R5bGVzID0gY2xhc3MgRE9NTm9kZVN0eWxlcyBleHRlbmRzIFdlYkluc3BlY3Rv ci5PYmplY3QKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KKworICAgIF9pc1Byb3Bl cnR5Rm91bmRJbk1hdGNoaW5nUnVsZXMocHJvcGVydHlOYW1lKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIHRoaXMuX29yZGVyZWRTdHlsZXMuc29tZShmdW5jdGlvbihzdHlsZSkgeworICAgICAgICAg ICAgcmV0dXJuIHN0eWxlLnByb3BlcnRpZXMuc29tZShmdW5jdGlvbiAocHJvcGVydHkpIHsKKyAg ICAgICAgICAgICAgICByZXR1cm4gcHJvcGVydHkubmFtZSA9PT0gcHJvcGVydHlOYW1lOworICAg ICAgICAgICAgfSk7CisgICAgICAgIH0pOworICAgIH0KIH07CiAKIFdlYkluc3BlY3Rvci5ET01O b2RlU3R5bGVzLkV2ZW50ID0gewo= 279029 2016-05-16 11:24:55 -0700 2016-05-16 11:26:14 -0700 Patch for landing bug-157674-20160516202550.patch text/plain 3311 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YzViZGZiMzVmNjA2YTc5ZWQ4MDgyM2U1YTAyNDAzYTg2NTIzNTM1Li41NjhjOTBhMTkxNGRkMTA0 MTFjYzQ2MzE4YTBlMWE0NGIxOGZkY2YxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNi0wNS0xMyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbXB1dGVkIHN0eWxlIHNob3dzIGJvdGggcHJl Zml4ZWQgYW5kIHVucHJlZml4ZWQgdmFyaWFudHMgb2YgcHJvcGVydGllcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3Njc0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNDMzOTc1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNo ZXIuCisKKyAgICAgICAgV2UgbWFrZSB0aGUgQ1NTUHJvcGVydHkgYGltcGxpY2l0YCBwcm9wZXJ0 eSByZWFkLXdyaXRlLCBhbmQgaW4gdGhlIGNhc2Ugd2hlcmUgYSBjb21wdXRlZCBzdHlsZQorICAg ICAgICBoYXMgYSBwcm9wZXJ0eSBtYXJrZWQgYXMgZXhwbGljaXQsIHdlIGFsc28gY2hlY2sgdGhh dCBpdCdzIGZvdW5kIGluIG1hdGNoaW5nIHJ1bGVzIHRvIGNvbnNpZGVyCisgICAgICAgIGl0IG5v bi1pbXBsaWNpdC4gVGhpcyBjb3JyZWN0bHkgZmlsdGVycyBvdXQgdmFyaWFudHMgb2YgcHJvcGVy dGllcyBzZXQgZXhwbGljaXRseS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NT U1Byb3BlcnR5LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1Byb3BlcnR5LnByb3RvdHlw ZS5zZXQgaW1wbGljaXQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGVT dHlsZXMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZVN0eWxlcy5wcm90b3R5cGUu cmVmcmVzaC5mZXRjaGVkQ29tcHV0ZWRTdHlsZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9N Tm9kZVN0eWxlcy5wcm90b3R5cGUucmVmcmVzaCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9N Tm9kZVN0eWxlcy5wcm90b3R5cGUuX2lzUHJvcGVydHlGb3VuZEluTWF0Y2hpbmdSdWxlcyk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuRE9NTm9kZVN0eWxlcyk6CisKIDIwMTYtMDUtMTIgIEZ1amlp IEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogV2luZG93cyBQZXJsIGZhaWxzIHRvIHJ1biBjb3B5LXVzZXItaW50ZXJmYWNlLXJlc291 cmNlcy5wbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0NTU1Byb3BlcnR5LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL0NTU1Byb3BlcnR5LmpzCmluZGV4IGQ5MmIzYzQzZTlkNjU5NmY3MDIzMTM5NmQ1 M2YyNGYzNzcyYTEwMTEuLmRiMzZiOWEwYzkxODMyNjdhMzNkNDIyMGJlNWZiNjBjYzQ1MjBhMjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D U1NQcm9wZXJ0eS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTUHJvcGVydHkuanMKQEAgLTIwNCw2ICsyMDQsOCBAQCBXZWJJbnNwZWN0b3IuQ1NT UHJvcGVydHkgPSBjbGFzcyBDU1NQcm9wZXJ0eSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QK ICAgICAgICAgcmV0dXJuIHRoaXMuX2ltcGxpY2l0OwogICAgIH0KIAorICAgIHNldCBpbXBsaWNp dChpbXBsaWNpdCkgeyB0aGlzLl9pbXBsaWNpdCA9IGltcGxpY2l0OyB9CisKICAgICBnZXQgYW5v bnltb3VzKCkKICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9hbm9ueW1vdXM7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NTm9kZVN0 eWxlcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01O b2RlU3R5bGVzLmpzCmluZGV4IDIzZWJkNWY4MWVlNGZkMDY3OGM2NTJhOTUzMjZhMjBlYTNlZjQ0 MjcuLmY5ZGNkNmZiNWViN2UxNDNmMTA1OTFiZTU2MjY0NTIxM2FjZjdjNjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2RlU3R5bGVz LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01O b2RlU3R5bGVzLmpzCkBAIC0xNTAsNiArMTUwLDggQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGVTdHls ZXMgPSBjbGFzcyBET01Ob2RlU3R5bGVzIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICAgICAgICAgIHByb3BlcnR5UGF5bG9hZC5pbXBsaWNpdCA9ICF0aGlzLl9wcm9wZXJ0eU5h bWVUb0VmZmVjdGl2ZVByb3BlcnR5TWFwW2Nhbm9uaWNhbE5hbWVdOwogCiAgICAgICAgICAgICAg ICAgdmFyIHByb3BlcnR5ID0gdGhpcy5fcGFyc2VTdHlsZVByb3BlcnR5UGF5bG9hZChwcm9wZXJ0 eVBheWxvYWQsIE5hTiwgdGhpcy5fY29tcHV0ZWRTdHlsZSk7CisgICAgICAgICAgICAgICAgaWYg KCFwcm9wZXJ0eS5pbXBsaWNpdCkKKyAgICAgICAgICAgICAgICAgICAgcHJvcGVydHkuaW1wbGlj aXQgPSAhdGhpcy5faXNQcm9wZXJ0eUZvdW5kSW5NYXRjaGluZ1J1bGVzKHByb3BlcnR5Lm5hbWUp OwogICAgICAgICAgICAgICAgIHByb3BlcnRpZXMucHVzaChwcm9wZXJ0eSk7CiAgICAgICAgICAg ICB9CiAKQEAgLTk1Myw2ICs5NTUsMTMgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGVTdHlsZXMgPSBj bGFzcyBET01Ob2RlU3R5bGVzIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICAg ICAgfQogICAgICAgICB9CiAgICAgfQorCisgICAgX2lzUHJvcGVydHlGb3VuZEluTWF0Y2hpbmdS dWxlcyhwcm9wZXJ0eU5hbWUpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5fb3JkZXJlZFN0 eWxlcy5zb21lKChzdHlsZSkgPT4geworICAgICAgICAgICAgcmV0dXJuIHN0eWxlLnByb3BlcnRp ZXMuc29tZSgocHJvcGVydHkpID0+IHByb3BlcnR5Lm5hbWUgPT09IHByb3BlcnR5TmFtZSk7Cisg ICAgICAgIH0pOworICAgIH0KIH07CiAKIFdlYkluc3BlY3Rvci5ET01Ob2RlU3R5bGVzLkV2ZW50 ID0gewo=