157658 2016-05-12 20:01:58 -0700 Show a spinner while fetching data on summary page 2016-05-13 00:31:11 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez commit-queue rniwa oldest_to_newest 1192602 0 rniwa 2016-05-12 20:01:58 -0700 Show a spinner while fetching data on summary page 1192631 1 rniwa 2016-05-12 21:32:50 -0700 <rdar://problem/25832800> 1192632 2 278812 rniwa 2016-05-12 21:33:48 -0700 Created attachment 278812 Adds a spinner 1192684 3 278812 commit-queue 2016-05-13 00:31:07 -0700 Comment on attachment 278812 Adds a spinner Clearing flags on attachment: 278812 Committed r200818: <http://trac.webkit.org/changeset/200818> 1192685 4 commit-queue 2016-05-13 00:31:11 -0700 All reviewed patches have been landed. Closing bug. 278812 2016-05-12 21:33:48 -0700 2016-05-13 00:31:07 -0700 Adds a spinner bug-157658-20160512213439.patch text/plain 6099 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwODA3KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI4IEBACisyMDE2LTA1LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFNob3cgYSBzcGlubmVyIHdoaWxlIGZldGNoaW5nIGRhdGEgb24gc3VtbWFyeSBw YWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTc2 NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaG93 IGEgc3Bpbm5lciB3aGlsZSBmZXRjaGluZyBKU09OIGZpbGVzIG9uIHRoZSBzdW1tYXJ5IHBhZ2Uu CisKKyAgICAgICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy9iYXNlLmpzOgorICAgICAgICAoQ29t cG9uZW50QmFzZS5wcm90b3R5cGUucmVuZGVyUmVwbGFjZSk6IEFkZGVkIGEgbmV3IGltcGxlbWVu dGF0aW9uIHRoYXQgc2ltcGx5IGNhbGxzIHRoZSBzdGF0aWMgdmVyc2lvbi4KKyAgICAgICAgKENv bXBvbmVudEJhc2UucmVuZGVyUmVwbGFjZSk6IE1hZGUgdGhpcyBzdGF0aWMuCisKKyAgICAgICAg KiBwdWJsaWMvdjMvcGFnZXMvc3VtbWFyeS1wYWdlLmpzOgorICAgICAgICAoU3VtbWFyeVBhZ2Uu cHJvdG90eXBlLl9jb25zdHJ1Y3RSYXRpb0dyYXBoKTogU2hvdyBhIHNwaW5uZXIgaWNvbiB3aGVu IFN1bW1hcnlQYWdlQ29uZmlndXJhdGlvbkdyb3VwJ3MKKyAgICAgICAgaXNGZXRjaGluZyByZXR1 cm5zIHRydWUuCisgICAgICAgIChTdW1tYXJ5UGFnZS5jc3NUZW1wbGF0ZSk6IEZvcmNlIHRoZSBo ZWlnaHQgb2YgZWFjaCBjZWxsIHRvIGJlIDIuNXJlbSBzbyB0aGF0IHRoZSBoZWlnaHQgb2YgY2Vs bCBkb2Vzbid0CisgICAgICAgIGNoYW5nZSB3aGVuIGEgc3Bpbm5lciBpcyByZXBsYWNlZCBieSBh IHJhdGlvIGJhciBncmFwaC4KKworICAgICAgICAoU3VtbWFyeVBhZ2VDb25maWd1cmF0aW9uR3Jv dXApOiBBZGRlZCB0aGlzLl9pc0ZldGNoaW5nIGFzIGFuIGluc3RhbmNlIHZhcmlhYmxlLgorICAg ICAgICAoU3VtbWFyeVBhZ2VDb25maWd1cmF0aW9uR3JvdXAucHJvdG90eXBlLmlzRmV0Y2hpbmcp OiBBZGRlZC4KKyAgICAgICAgKFN1bW1hcnlQYWdlQ29uZmlndXJhdGlvbkdyb3VwLnByb3RvdHlw ZS5mZXRjaEFuZENvbXB1dGVTdW1tYXJ5KTogU2V0IHRoaXMuX2lzRmV0Y2hpbmcgd2hpbGUgd2Fp dGluZyBmb3IKKyAgICAgICAgdGhlIHByb21pc2VzIHRvIHJlc29sdmUgYWZ0ZXIgNTBtcy4gV2Ug ZG9uJ3QgaW1tZWRpYXRlbHkgc2V0IHRoaXMuX2lzRmV0Y2hpbmcgdG8gYXZvaWQgRk9DIHdoZW4g YWxsIEpTT04KKyAgICAgICAgZmlsZXMgaGF2ZSBiZWVuIGNhY2hlZC4KKwogMjAxNi0wNS0wNyAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgaG9yaXpvbnRh bCBiZXR3ZWVuIGNhdGVnb3JpZXMgb2YgdGVzdHMKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0 Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9iYXNlLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9iYXNlLmpzCShyZXZpc2lvbiAy MDA4MDUpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMv YmFzZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsOSBAQCBjbGFzcyBDb21wb25lbnRC YXNlIHsKICAgICBjb250ZW50KCkgeyByZXR1cm4gdGhpcy5fc2hhZG93OyB9CiAgICAgcmVuZGVy KCkgeyB9CiAKLSAgICByZW5kZXJSZXBsYWNlKGVsZW1lbnQsIGNvbnRlbnQpCisgICAgcmVuZGVy UmVwbGFjZShlbGVtZW50LCBjb250ZW50KSB7IENvbXBvbmVudEJhc2UucmVuZGVyUmVwbGFjZShl bGVtZW50LCBjb250ZW50KTsgfQorCisgICAgc3RhdGljIHJlbmRlclJlcGxhY2UoZWxlbWVudCwg Y29udGVudCkKICAgICB7CiAgICAgICAgIGVsZW1lbnQuaW5uZXJIVE1MID0gJyc7CiAgICAgICAg IGlmIChjb250ZW50KQpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9w YWdlcy9zdW1tYXJ5LXBhZ2UuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy92My9wYWdlcy9zdW1tYXJ5LXBhZ2UuanMJKHJldmlzaW9uIDIwMDgwNSkKKysr IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMvc3VtbWFyeS1wYWdlLmpz CSh3b3JraW5nIGNvcHkpCkBAIC05NCw4ICs5NCwyMCBAQCBjbGFzcyBTdW1tYXJ5UGFnZSBleHRl bmRzIFBhZ2VXaXRoSGVhZGluCiAgICAgICAgIHZhciByYXRpb0dyYXBoID0gbmV3IFJhdGlvQmFy R3JhcGgoKTsKIAogICAgICAgICB2YXIgc3RhdGUgPSBDaGFydHNQYWdlLmNyZWF0ZVN0YXRlRm9y Q29uZmlndXJhdGlvbkxpc3QoY29uZmlndXJhdGlvbkxpc3QpOwotICAgICAgICB2YXIgYW5jaG9y ID0gbGluayhyYXRpb0dyYXBoLCB0aGlzLnJvdXRlcigpLnVybCgnY2hhcnRzJywgc3RhdGUpKTsK KworICAgICAgICBpZiAoY29uZmlndXJhdGlvbkxpc3QubGVuZ3RoID09IDApIHsKKyAgICAgICAg ICAgIHRoaXMuX3JlbmRlclF1ZXVlLnB1c2goZnVuY3Rpb24gKCkgeyByYXRpb0dyYXBoLnJlbmRl cigpOyB9KTsKKyAgICAgICAgICAgIHJldHVybiBlbGVtZW50KCd0ZCcsIHJhdGlvR3JhcGgpOwor ICAgICAgICB9CisKKyAgICAgICAgdmFyIGNlbGwgPSBlbGVtZW50KCd0ZCcpOworICAgICAgICB2 YXIgdXJsID0gdGhpcy5yb3V0ZXIoKS51cmwoJ2NoYXJ0cycsIHN0YXRlKTsKICAgICAgICAgdGhp cy5fcmVuZGVyUXVldWUucHVzaChmdW5jdGlvbiAoKSB7CisgICAgICAgICAgICBpZiAoY29uZmln dXJhdGlvbkdyb3VwLmlzRmV0Y2hpbmcoKSkgeworICAgICAgICAgICAgICAgIENvbXBvbmVudEJh c2UucmVuZGVyUmVwbGFjZShjZWxsLCBuZXcgU3Bpbm5lckljb24pOworICAgICAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgdmFyIHdhcm5pbmdzID0gY29u ZmlndXJhdGlvbkdyb3VwLndhcm5pbmdzKCk7CiAgICAgICAgICAgICB2YXIgd2FybmluZ1RleHQg PSAnJzsKICAgICAgICAgICAgIGZvciAodmFyIHR5cGUgaW4gd2FybmluZ3MpIHsKQEAgLTEwMywx NCArMTE1LDEzIEBAIGNsYXNzIFN1bW1hcnlQYWdlIGV4dGVuZHMgUGFnZVdpdGhIZWFkaW4KICAg ICAgICAgICAgICAgICB3YXJuaW5nVGV4dCArPSBgTWlzc2luZyAke3R5cGV9IGZvciBmb2xsb3dp bmcgcGxhdGZvcm0ocyk6ICR7cGxhdGZvcm1TdHJpbmd9YDsKICAgICAgICAgICAgIH0KIAotICAg ICAgICAgICAgYW5jaG9yLnRpdGxlID0gd2FybmluZ1RleHQgfHwgJ09wZW4gY2hhcnRzJzsKKyAg ICAgICAgICAgIENvbXBvbmVudEJhc2UucmVuZGVyUmVwbGFjZShjZWxsLCBsaW5rKHJhdGlvR3Jh cGgsIHdhcm5pbmdUZXh0IHx8ICdPcGVuIGNoYXJ0cycsIHVybCkpOworCiAgICAgICAgICAgICBy YXRpb0dyYXBoLnVwZGF0ZShjb25maWd1cmF0aW9uR3JvdXAucmF0aW8oKSwgY29uZmlndXJhdGlv bkdyb3VwLmxhYmVsKCksICEhd2FybmluZ1RleHQpOwogICAgICAgICAgICAgcmF0aW9HcmFwaC5y ZW5kZXIoKTsKICAgICAgICAgfSk7Ci0gICAgICAgIGlmIChjb25maWd1cmF0aW9uTGlzdC5sZW5n dGggPT0gMCkKLSAgICAgICAgICAgIHJldHVybiBlbGVtZW50KCd0ZCcsIHJhdGlvR3JhcGgpOwog Ci0gICAgICAgIHJldHVybiBlbGVtZW50KCd0ZCcsIGFuY2hvcik7CisgICAgICAgIHJldHVybiBj ZWxsOwogICAgIH0KIAogICAgIHN0YXRpYyBodG1sVGVtcGxhdGUoKQpAQCAtMTY3LDE0ICsxNzgs MjQgQEAgY2xhc3MgU3VtbWFyeVBhZ2UgZXh0ZW5kcyBQYWdlV2l0aEhlYWRpbgogICAgICAgICAg ICAgfQogCiAgICAgICAgICAgICAuc3VtbWFyeS10YWJsZSB0Ym9keSB0ZCB7CisgICAgICAgICAg ICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICAgICAgICAgICAgIGZvbnQtd2VpZ2h0OiBp bmhlcml0OwogICAgICAgICAgICAgICAgIGZvbnQtc2l6ZTogMC45cmVtOworICAgICAgICAgICAg ICAgIGhlaWdodDogMi41cmVtOwogICAgICAgICAgICAgICAgIHBhZGRpbmc6IDA7CiAgICAgICAg ICAgICB9CiAKICAgICAgICAgICAgIC5zdW1tYXJ5LXRhYmxlIHRkID4gKiB7CiAgICAgICAgICAg ICAgICAgaGVpZ2h0OiAxMDAlOwogICAgICAgICAgICAgfQorCisgICAgICAgICAgICAuc3VtbWFy eS10YWJsZSB0ZCBzcGlubmVyLWljb24geworICAgICAgICAgICAgICAgIGRpc3BsYXk6IGJsb2Nr OworICAgICAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgICAgICB0 b3A6IDAuMjVyZW07CisgICAgICAgICAgICAgICAgbGVmdDogY2FsYyg1MCUgLSAxcmVtKTsKKyAg ICAgICAgICAgICAgICB6LWluZGV4OiAxMDA7CisgICAgICAgICAgICB9CiAgICAgICAgIGA7CiAg ICAgfQogfQpAQCAtMTg4LDYgKzIwOSw3IEBAIGNsYXNzIFN1bW1hcnlQYWdlQ29uZmlndXJhdGlv bkdyb3VwIHsKICAgICAgICAgdGhpcy5fcmF0aW8gPSBudWxsOwogICAgICAgICB0aGlzLl9sYWJl bCA9IG51bGw7CiAgICAgICAgIHRoaXMuX3dhcm5pbmdzID0ge307CisgICAgICAgIHRoaXMuX2lz RmV0Y2hpbmcgPSBmYWxzZTsKICAgICAgICAgdGhpcy5fc21hbGxlcklzQmV0dGVyID0gbWV0cmlj cy5sZW5ndGggPyBtZXRyaWNzWzBdLmlzU21hbGxlckJldHRlcigpIDogbnVsbDsKIAogICAgICAg ICBmb3IgKHZhciBwbGF0Zm9ybSBvZiBwbGF0Zm9ybXMpIHsKQEAgLTIxMiw2ICsyMzQsNyBAQCBj bGFzcyBTdW1tYXJ5UGFnZUNvbmZpZ3VyYXRpb25Hcm91cCB7CiAgICAgd2FybmluZ3MoKSB7IHJl dHVybiB0aGlzLl93YXJuaW5nczsgfQogICAgIGNoYW5nZVR5cGUoKSB7IHJldHVybiB0aGlzLl9j aGFuZ2VUeXBlOyB9CiAgICAgY29uZmlndXJhdGlvbkxpc3QoKSB7IHJldHVybiB0aGlzLl9jb25m aWd1cmF0aW9uTGlzdDsgfQorICAgIGlzRmV0Y2hpbmcoKSB7IHJldHVybiB0aGlzLl9pc0ZldGNo aW5nOyB9CiAKICAgICBmZXRjaEFuZENvbXB1dGVTdW1tYXJ5KHRpbWVSYW5nZSkKICAgICB7CkBA IC0yMjMsNyArMjQ2LDE5IEBAIGNsYXNzIFN1bW1hcnlQYWdlQ29uZmlndXJhdGlvbkdyb3VwIHsK ICAgICAgICAgZm9yICh2YXIgc2V0IG9mIHRoaXMuX21lYXN1cmVtZW50U2V0cykKICAgICAgICAg ICAgIHByb21pc2VzLnB1c2godGhpcy5fZmV0Y2hBbmRDb21wdXRlUmF0aW8oc2V0LCB0aW1lUmFu Z2UpKTsKIAotICAgICAgICByZXR1cm4gUHJvbWlzZS5hbGwocHJvbWlzZXMpLnRoZW4odGhpcy5f Y29tcHV0ZVN1bW1hcnkuYmluZCh0aGlzKSk7CisgICAgICAgIHZhciBzZWxmID0gdGhpczsKKyAg ICAgICAgdmFyIGZldGNoZWQgPSBmYWxzZTsKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbiAo KSB7CisgICAgICAgICAgICAvLyBEb24ndCBzZXQgX2lzRmV0Y2hpbmcgdG8gdHJ1ZSBpZiBhbGwg cHJvbWlzZXMgd2VyZSB0byByZXNvbHZlIGltbWVkaWF0ZWx5IChjYWNoZWQpLgorICAgICAgICAg ICAgaWYgKCFmZXRjaGVkKQorICAgICAgICAgICAgICAgIHNlbGYuX2lzRmV0Y2hpbmcgPSB0cnVl OworICAgICAgICB9LCA1MCk7CisKKyAgICAgICAgcmV0dXJuIFByb21pc2UuYWxsKHByb21pc2Vz KS50aGVuKGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGZldGNoZWQgPSB0cnVlOworICAgICAg ICAgICAgc2VsZi5faXNGZXRjaGluZyA9IGZhbHNlOworICAgICAgICAgICAgc2VsZi5fY29tcHV0 ZVN1bW1hcnkoKTsKKyAgICAgICAgfSk7CiAgICAgfQogCiAgICAgX2NvbXB1dGVTdW1tYXJ5KCkK