157642 2016-05-12 15:44:04 -0700 Add machine-readable results for JSC API tests to the Buildbot log 2016-05-16 11:56:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 157270 1 webkit webkit-unassigned ap commit-queue ggaren oldest_to_newest 1192501 0 webkit 2016-05-12 15:44:04 -0700 Add machine-readable results for JSC API tests to the Buildbot log 1192502 1 278772 webkit 2016-05-12 15:47:22 -0700 Created attachment 278772 Patch 1192505 2 278772 webkit 2016-05-12 15:52:04 -0700 Comment on attachment 278772 Patch I abstracted out the function that writes JSON to the file. This minimizes the number of conditionals (i.e. checking whether --json-output is specified, which is indicated by $jsonFileName being defined) and also reduces the amount of refactoring. Open to suggestions on how to do this better. 1193454 3 278772 ggaren 2016-05-16 11:49:45 -0700 Comment on attachment 278772 Patch r=me 1193455 4 ggaren 2016-05-16 11:50:01 -0700 Would be nice to hook up crash logs to the bot results too. 1193458 5 278772 commit-queue 2016-05-16 11:56:31 -0700 Comment on attachment 278772 Patch Clearing flags on attachment: 278772 Committed r200956: <http://trac.webkit.org/changeset/200956> 1193459 6 commit-queue 2016-05-16 11:56:36 -0700 All reviewed patches have been landed. Closing bug. 278772 2016-05-12 15:47:22 -0700 2016-05-16 11:56:31 -0700 Patch bug-157642-20160512154813.patch text/plain 3513 webkit SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMDc5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA1LTEyICBTcmluaXZhc2FuIFZpamF5YXJhZ2hhdmFuICA8c3ZpamF5 YXJhZ2hhdmFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbWFjaGluZS1yZWFkYWJsZSByZXN1 bHRzIGZvciBKU0MgQVBJIHRlc3RzIHRvIHRoZSBCdWlsZGJvdCBqc29uIGxvZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NjQyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoUnVuSmF2YVNj cmlwdENvcmVUZXN0cyk6IFVzZSAtLW5vLWZhaWwtZmFzdCBvcHRpb24gb24gcnVuLWphdmFzY3Jp cHRjb3JlLXRlc3RzCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6 CisgICAgICAgIChydW5KU0NTdHJlc3NUZXN0cyk6IEFic3RyYWN0ZWQgb3V0IHdyaXRpbmcgSlNP TiB0byBmaWxlIChuZXcgZnVuY3Rpb24gYmVsb3cpCisgICAgICAgICh3cml0ZUpzb25EYXRhSWZB cHBsaWNhYmxlKTogQWRkZWQKKwogMjAxNi0wNS0xMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEUoRVM2X0FSUk9XRlVOQ1RJT05f U1lOVEFYKSBndWFyZHMKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkocmV2aXNpb24gMjAwNzg1 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMjk5LDcgKzI5OSw3IEBAIGNsYXNzIFJ1bkphdmFT Y3JpcHRDb3JlVGVzdHMoVGVzdFdpdGhGYWkKICAgICBkZXNjcmlwdGlvbiA9IFsianNjb3JlLXRl c3RzIHJ1bm5pbmciXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsianNjb3JlLXRlc3RzIl0KICAg ICBqc29uRmlsZU5hbWUgPSAianNjX3Jlc3VsdHMuanNvbiIKLSAgICBjb21tYW5kID0gWyJwZXJs IiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMiLCAiLS1uby1idWls ZCIsICItLWpzb24tb3V0cHV0PXswfSIuZm9ybWF0KGpzb25GaWxlTmFtZSksIFdpdGhQcm9wZXJ0 aWVzKCItLSUoY29uZmlndXJhdGlvbilzIildCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rv b2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIiwgIi0tbm8tYnVpbGQiLCAiLS1u by1mYWlsLWZhc3QiLCAiLS1qc29uLW91dHB1dD17MH0iLmZvcm1hdChqc29uRmlsZU5hbWUpLCBX aXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQogICAgIGZhaWxlZFRlc3RzRm9y bWF0U3RyaW5nID0gIiVkIEpTQyB0ZXN0JXMgZmFpbGVkIgogICAgIGxvZ2ZpbGVzID0geyJqc29u IjoganNvbkZpbGVOYW1lfQogCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29y ZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10 ZXN0cwkocmV2aXNpb24gMjAwNzg1KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNv cmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTY4LDYgKzY4LDcgQEAgbXkgJGVuYWJsZUZUTCA9 IGlzQXBwbGVNYWNXZWJLaXQoKSB8fCBpcwogbXkgJGNyZWF0ZVRhcmJhbGwgPSAwOwogbXkgJHJl bW90ZUhvc3QgPSAwOwogbXkgJGZhaWxGYXN0ID0gMTsKK215ICVqc29uRGF0YSA9ICgpOwogbXkg JHJlbW90ZUNvbmZpZ0ZpbGU7CiBteSAkanNvbkZpbGVOYW1lOwogCkBAIC0yMDcsNyArMjA4LDE0 IEBAIGlmICgkcnVuVGVzdEFQSSkgewogICAgIG15ICR0ZXN0YXBpUmVzdWx0ID0gc3lzdGVtIHsg JGNvbW1hbmRbMF0gfSBAY29tbWFuZDsKICAgICBteSAkZXhpdFN0YXR1cyA9IGV4aXRTdGF0dXMo JHRlc3RhcGlSZXN1bHQpOwogICAgIHByaW50ICJ0ZXN0QVBJIGNvbXBsZXRlZCB3aXRoIHJjPSR0 ZXN0YXBpUmVzdWx0ICgkZXhpdFN0YXR1cylcbiI7CisKKyAgICBpZiAoZGVmaW5lZCgkanNvbkZp bGVOYW1lKSkgeworICAgICAgICBteSAkYXBpU3RhdHVzID0gKCRleGl0U3RhdHVzID09IDApPyBK U09OOjpQUDo6dHJ1ZTogSlNPTjo6UFA6OmZhbHNlOworICAgICAgICAkanNvbkRhdGF7J2FwaVRl c3RSZXN1bHQnfSA9ICRhcGlTdGF0dXM7CisgICAgfQorCiAgICAgaWYgKCR0ZXN0YXBpUmVzdWx0 ICYmICRmYWlsRmFzdCkgeworICAgICAgICB3cml0ZUpzb25EYXRhSWZBcHBsaWNhYmxlKCk7CiAg ICAgICAgIGV4aXQgZXhpdFN0YXR1cygkdGVzdGFwaVJlc3VsdCk7CiAgICAgfQogfQpAQCAtMzM3 LDE1ICszNDUsMTAgQEAgc3ViIHJ1bkpTQ1N0cmVzc1Rlc3RzCiAgICAgcHJpbnQgIlxuIjsKIAog ICAgIGlmIChkZWZpbmVkKCRqc29uRmlsZU5hbWUpKSB7Ci0gICAgICAgIG15ICVqc29uRGF0YSA9 ICgKLSAgICAgICAgICAgICJmYWlsdXJlcyIgPT4gXEBqc2NTdHJlc3NGYWlsTGlzdCwKLSAgICAg ICAgKTsKLQotICAgICAgICBvcGVuKG15ICRmaWxlSGFuZGxlciwgIj4iLCAkanNvbkZpbGVOYW1l KSBvciBkaWU7Ci0gICAgICAgIHByaW50ICRmaWxlSGFuZGxlciAiJHtcZW5jb2RlX2pzb24oXCVq c29uRGF0YSl9XG4iOwotICAgICAgICBjbG9zZSgkZmlsZUhhbmRsZXIpOworICAgICAgICAkanNv bkRhdGF7J2ZhaWx1cmVzJ30gPSBcQGpzY1N0cmVzc0ZhaWxMaXN0OwogICAgIH0KIAorICAgIHdy aXRlSnNvbkRhdGFJZkFwcGxpY2FibGUoKTsKICAgICBleGl0KDEpIGlmICRudW1KU0NTdHJlc3NG YWlsdXJlczsKIH0KIApAQCAtMzc1LDMgKzM3OCwxMiBAQCBzdWIgcHJpbnRUaGluZ3NGb3VuZAog ICAgIH0KICAgICBwcmludCAiICR2ZXJiLlxuIjsKIH0KKworc3ViIHdyaXRlSnNvbkRhdGFJZkFw cGxpY2FibGUKK3sKKyAgICBpZiAoZGVmaW5lZCgkanNvbkZpbGVOYW1lKSkgeworICAgICAgICBv cGVuKG15ICRmaWxlSGFuZGxlciwgIj4iLCAkanNvbkZpbGVOYW1lKSBvciBkaWU7CisgICAgICAg IHByaW50ICRmaWxlSGFuZGxlciAiJHtcZW5jb2RlX2pzb24oXCVqc29uRGF0YSl9XG4iOworICAg ICAgICBjbG9zZSgkZmlsZUhhbmRsZXIpOworICAgIH0KK30K