157640 2016-05-12 14:16:46 -0700 Web Inspector: Layout timeline popovers are inconsistently shown 2016-05-12 15:07:41 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192461 0 joepeck 2016-05-12 14:16:46 -0700 * SUMMARY Layout timeline popovers are inconsistently shown * STEPS TO REPRODUCE 1. Record a timeline with Layout records containing JavaScript backtraces 2. Click around Layout Timeline datagrid => Sometimes Popovers do not show up 1192462 1 webkit-bug-importer 2016-05-12 14:17:26 -0700 <rdar://problem/26253394> 1192463 2 278759 joepeck 2016-05-12 14:19:24 -0700 Created attachment 278759 [PATCH] Proposed Fix 1192484 3 278759 timothy 2016-05-12 15:01:55 -0700 Comment on attachment 278759 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278759&action=review > Source/WebInspectorUI/ChangeLog:18 > + Updating with presentNewContentWithFrame animates the popover to the correct > + position instead of jumping and ending up at the wrong location. I don't think we should ever animate a popover from one spot to another. It should only ever animate in/out. Not move. This sin't new, but we should consider changing it. It just looks silly. 1192489 4 278759 commit-queue 2016-05-12 15:07:37 -0700 Comment on attachment 278759 [PATCH] Proposed Fix Clearing flags on attachment: 278759 Committed r200792: <http://trac.webkit.org/changeset/200792> 1192490 5 commit-queue 2016-05-12 15:07:41 -0700 All reviewed patches have been landed. Closing bug. 278759 2016-05-12 14:19:24 -0700 2016-05-12 15:07:37 -0700 [PATCH] Proposed Fix layout-1.patch text/plain 5509 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzOWUzNmUuLjRkOGIxNDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA1LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTGF5b3V0 IHRpbWVsaW5lIHBvcG92ZXJzIGFyZSBpbmNvbnNpc3RlbnRseSBzaG93bgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NjQwCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNjI1MzM5ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkLnByb3RvdHlwZS5fc2hvd1Bv cG92ZXJGb3JTZWxlY3RlZE5vZGVTb29uKToKKyAgICAgICAgRml4IHRoZSBidWcgYnkgY2xlYXJp bmcgX3Nob3dQb3BvdmVyVGltZW91dCB3aGVuIHdlIHNob3cgdGhlIHBvcG92ZXIuCisKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkLnByb3RvdHlwZS5faGlkZVBvcG92ZXIp OgorICAgICAgICBNb2Rlcm5pemUgdGhlIGNvZGUgdG8gdXNlIGFycm93IGZ1bmN0aW9ucyBhbmQg YXZvaWQgYmluZHMuCisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkLnBy b3RvdHlwZS5fdXBkYXRlUG9wb3ZlckZvclNlbGVjdGVkTm9kZSk6CisgICAgICAgIFVwZGF0aW5n IHdpdGggcHJlc2VudE5ld0NvbnRlbnRXaXRoRnJhbWUgYW5pbWF0ZXMgdGhlIHBvcG92ZXIgdG8g dGhlIGNvcnJlY3QKKyAgICAgICAgcG9zaXRpb24gaW5zdGVhZCBvZiBqdW1waW5nIGFuZCBlbmRp bmcgdXAgYXQgdGhlIHdyb25nIGxvY2F0aW9uLgorCisyMDE2LTA1LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgUmVzZXQgYnV0dG9uIG9ubHkgcmVzZXRzIHRoZSBvbmUgYWN0aXZlIFNjcmlwdCBUaW1lbGlu ZVZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NzYzOAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZURhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcwppbmRleCBkZWYxM2U5Li40YjMwOWM0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZURhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMKQEAgLTQ1MCwxNSArNDUwLDEyIEBAIFdlYkluc3Bl Y3Rvci5UaW1lbGluZURhdGFHcmlkID0gY2xhc3MgVGltZWxpbmVEYXRhR3JpZCBleHRlbmRzIFdl Ykluc3BlY3Rvci5EYXRhCiAgICAgICAgIGlmICh0aGlzLl9zaG93UG9wb3ZlclRpbWVvdXQpCiAg ICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgZnVuY3Rpb24gZGVsYXllZFdvcmsoKQotICAg ICAgICB7CisgICAgICAgIHRoaXMuX3Nob3dQb3BvdmVyVGltZW91dCA9IHNldFRpbWVvdXQoKCkg PT4gewogICAgICAgICAgICAgaWYgKCF0aGlzLl9wb3BvdmVyKQogICAgICAgICAgICAgICAgIHRo aXMuX3BvcG92ZXIgPSBuZXcgV2ViSW5zcGVjdG9yLlBvcG92ZXI7Ci0KICAgICAgICAgICAgIHRo aXMuX3VwZGF0ZVBvcG92ZXJGb3JTZWxlY3RlZE5vZGUodHJ1ZSk7Ci0gICAgICAgIH0KLQotICAg ICAgICB0aGlzLl9zaG93UG9wb3ZlclRpbWVvdXQgPSBzZXRUaW1lb3V0KGRlbGF5ZWRXb3JrLmJp bmQodGhpcyksIFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkLkRlbGF5ZWRQb3BvdmVyU2hv d1RpbWVvdXQpOworICAgICAgICAgICAgdGhpcy5fc2hvd1BvcG92ZXJUaW1lb3V0ID0gdW5kZWZp bmVkOworICAgICAgICB9LCBXZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZC5EZWxheWVkUG9w b3ZlclNob3dUaW1lb3V0KTsKICAgICB9CiAKICAgICBfaGlkZVBvcG92ZXIoKQpAQCAtNDcxLDE1 ICs0NjgsMTMgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGlu ZURhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLkRhdGEKICAgICAgICAgaWYgKHRoaXMuX3Bv cG92ZXIpCiAgICAgICAgICAgICB0aGlzLl9wb3BvdmVyLmRpc21pc3MoKTsKIAotICAgICAgICBm dW5jdGlvbiBkZWxheWVkV29yaygpCi0gICAgICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2hpZGVQ b3BvdmVyQ29udGVudENsZWFyVGltZW91dCkKKyAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlz Ll9oaWRlUG9wb3ZlckNvbnRlbnRDbGVhclRpbWVvdXQpOworCisgICAgICAgIHRoaXMuX2hpZGVQ b3BvdmVyQ29udGVudENsZWFyVGltZW91dCA9IHNldFRpbWVvdXQoKCkgPT4gewogICAgICAgICAg ICAgaWYgKHRoaXMuX3BvcG92ZXJDYWxsU3RhY2tUcmVlT3V0bGluZSkKICAgICAgICAgICAgICAg ICB0aGlzLl9wb3BvdmVyQ2FsbFN0YWNrVHJlZU91dGxpbmUucmVtb3ZlQ2hpbGRyZW4oKTsKLSAg ICAgICAgfQotCi0gICAgICAgIGlmICh0aGlzLl9oaWRlUG9wb3ZlckNvbnRlbnRDbGVhclRpbWVv dXQpCi0gICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5faGlkZVBvcG92ZXJDb250ZW50Q2xl YXJUaW1lb3V0KTsKLSAgICAgICAgdGhpcy5faGlkZVBvcG92ZXJDb250ZW50Q2xlYXJUaW1lb3V0 ID0gc2V0VGltZW91dChkZWxheWVkV29yay5iaW5kKHRoaXMpLCBXZWJJbnNwZWN0b3IuVGltZWxp bmVEYXRhR3JpZC5EZWxheWVkUG9wb3ZlckhpZGVDb250ZW50Q2xlYXJUaW1lb3V0KTsKKyAgICAg ICAgfSwgV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQuRGVsYXllZFBvcG92ZXJIaWRlQ29u dGVudENsZWFyVGltZW91dCk7CiAgICAgfQogCiAgICAgX3VwZGF0ZVBvcG92ZXJGb3JTZWxlY3Rl ZE5vZGUodXBkYXRlQ29udGVudCkKQEAgLTQ4NywxNSArNDgyLDE0IEBAIFdlYkluc3BlY3Rvci5U aW1lbGluZURhdGFHcmlkID0gY2xhc3MgVGltZWxpbmVEYXRhR3JpZCBleHRlbmRzIFdlYkluc3Bl Y3Rvci5EYXRhCiAgICAgICAgIGlmICghdGhpcy5fcG9wb3ZlciB8fCAhdGhpcy5zZWxlY3RlZE5v ZGUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdmFyIHRhcmdldFBvcG92ZXJFbGVt ZW50ID0gdGhpcy5jYWxsRnJhbWVQb3BvdmVyQW5jaG9yRWxlbWVudCgpOworICAgICAgICBsZXQg dGFyZ2V0UG9wb3ZlckVsZW1lbnQgPSB0aGlzLmNhbGxGcmFtZVBvcG92ZXJBbmNob3JFbGVtZW50 KCk7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRhcmdldFBvcG92ZXJFbGVtZW50LCAiVGltZWxp bmVEYXRhR3JpZCBzdWJjbGFzcyBzaG91bGQgYWx3YXlzIHJldHVybiBhIHZhbGlkIGVsZW1lbnQg ZnJvbSBjYWxsRnJhbWVQb3BvdmVyQW5jaG9yRWxlbWVudC4iKTsKICAgICAgICAgaWYgKCF0YXJn ZXRQb3BvdmVyRWxlbWVudCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgdGFy Z2V0RnJhbWUgPSBXZWJJbnNwZWN0b3IuUmVjdC5yZWN0RnJvbUNsaWVudFJlY3QodGFyZ2V0UG9w b3ZlckVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkpOwotCiAgICAgICAgIC8vIFRoZSBl bGVtZW50IG1pZ2h0IGJlIGhpZGRlbiBpZiBpdCBkb2VzIG5vdCBoYXZlIGEgd2lkdGggYW5kIGhl aWdodC4KLSAgICAgICAgaWYgKCF0YXJnZXRGcmFtZS5zaXplLndpZHRoICYmICF0YXJnZXRGcmFt ZS5zaXplLmhlaWdodCkKKyAgICAgICAgbGV0IHJlY3QgPSBXZWJJbnNwZWN0b3IuUmVjdC5yZWN0 RnJvbUNsaWVudFJlY3QodGFyZ2V0UG9wb3ZlckVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0 KCkpOworICAgICAgICBpZiAoIXJlY3Quc2l6ZS53aWR0aCAmJiAhdGFyZ2V0RnJhbWUucmVjdC5o ZWlnaHQpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgaWYgKHRoaXMuX2hpZGVQb3Bv dmVyQ29udGVudENsZWFyVGltZW91dCkgewpAQCAtNTAzLDEwICs0OTcsMTMgQEAgV2ViSW5zcGVj dG9yLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGluZURhdGFHcmlkIGV4dGVuZHMgV2Vi SW5zcGVjdG9yLkRhdGEKICAgICAgICAgICAgIHRoaXMuX2hpZGVQb3BvdmVyQ29udGVudENsZWFy VGltZW91dCA9IHVuZGVmaW5lZDsKICAgICAgICAgfQogCisgICAgICAgIGxldCB0YXJnZXRGcmFt ZSA9IHJlY3QucGFkKDIpOworICAgICAgICBsZXQgcHJlZmVycmVkRWRnZXMgPSBbV2ViSW5zcGVj dG9yLlJlY3RFZGdlLk1BWF9ZLCBXZWJJbnNwZWN0b3IuUmVjdEVkZ2UuTUlOX1ksIFdlYkluc3Bl Y3Rvci5SZWN0RWRnZS5NQVhfWF07CisKICAgICAgICAgaWYgKHVwZGF0ZUNvbnRlbnQpCi0gICAg ICAgICAgICB0aGlzLl9wb3BvdmVyLmNvbnRlbnQgPSB0aGlzLl9jcmVhdGVQb3BvdmVyQ29udGVu dCgpOwotCi0gICAgICAgIHRoaXMuX3BvcG92ZXIucHJlc2VudCh0YXJnZXRGcmFtZS5wYWQoMiks IFtXZWJJbnNwZWN0b3IuUmVjdEVkZ2UuTUFYX1ksIFdlYkluc3BlY3Rvci5SZWN0RWRnZS5NSU5f WSwgV2ViSW5zcGVjdG9yLlJlY3RFZGdlLk1BWF9YXSk7CisgICAgICAgICAgICB0aGlzLl9wb3Bv dmVyLnByZXNlbnROZXdDb250ZW50V2l0aEZyYW1lKHRoaXMuX2NyZWF0ZVBvcG92ZXJDb250ZW50 KCksIHRhcmdldEZyYW1lLCBwcmVmZXJyZWRFZGdlcyk7CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgIHRoaXMuX3BvcG92ZXIucHJlc2VudCh0YXJnZXRGcmFtZSwgcHJlZmVycmVkRWRnZXMpOwog ICAgIH0KIAogICAgIF9jcmVhdGVQb3BvdmVyQ29udGVudCgpCkBAIC01NDgsOCArNTQ1LDYgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGluZURhdGFHcmlkIGV4 dGVuZHMgV2ViSW5zcGVjdG9yLkRhdGEKICAgICB9CiB9OwogCi1XZWJJbnNwZWN0b3IuVGltZWxp bmVEYXRhR3JpZC5XYXNFeHBhbmRlZER1cmluZ0ZpbHRlcmluZ1N5bWJvbCA9IFN5bWJvbCgid2Fz LWV4cGFuZGVkLWR1cmluZy1maWx0ZXJpbmciKTsKLQogV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0 YUdyaWQuSGFzTm9uRGVmYXVsdEZpbHRlclN0eWxlQ2xhc3NOYW1lID0gImhhcy1ub24tZGVmYXVs dC1maWx0ZXIiOwogV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWQuRGVsYXllZFBvcG92ZXJT aG93VGltZW91dCA9IDI1MDsKIFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFHcmlkLkRlbGF5ZWRQ b3BvdmVySGlkZUNvbnRlbnRDbGVhclRpbWVvdXQgPSA1MDA7Cg==