15764 2007-10-30 07:39:11 -0700 compiler warning 2007-11-02 16:27:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Other OS X 10.4 RESOLVED FIXED P2 Trivial --- 1 dacarson dacarson oldest_to_newest 59848 0 dacarson 2007-10-30 07:39:11 -0700 Some compilers give a warning for the following function: inline bool JSValue::isNumber() const { return JSImmediate::isNumber(this) || !JSImmediate::isImmediate(this) && asCell()->isNumber(); } "warning: suggest parentheses around && within ||" This file is compiled into a lot of the JSCore files and the warning is seen for every file. 59850 1 16948 dacarson 2007-10-30 07:48:56 -0700 Created attachment 16948 patch insert suggested braces, also makes it easier to read. 59851 2 16948 darin 2007-10-30 07:56:15 -0700 Comment on attachment 16948 patch Parentheses look fine. But not the spaces within the parentheses! We don't use spaces there in our expressions. 60109 3 darin 2007-11-02 16:27:38 -0700 Committed revision 27381. 16948 2007-10-30 07:48:56 -0700 2007-10-30 07:56:15 -0700 patch warning.txt text/plain 1110 dacarson SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MjU2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTAtMzAgIERhdmlkIENh cnNvbiAgPGRhY2Fyc29uQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworCUZpeCBjb21waWxlciB3YXJuaW5nICJ3YXJuaW5nOiBzdWdnZXN0IHBhcmVu dGhlc2VzIGFyb3VuZCAmJiB3aXRoaW4gfHwiCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NzY0CisKKyAgICAgICAgKiBranMvdmFsdWUuaDoKKyAgICAg ICAgKEtKUzo6SlNWYWx1ZTo6aXNOdW1iZXIpOgorCiAyMDA3LTEwLTI5ICBPbGl2ZXIgSHVudCAg PG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqLgpJbmRleDog SmF2YVNjcmlwdENvcmUva2pzL3ZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv a2pzL3ZhbHVlLmgJKHJldmlzaW9uIDI3MjU2KQorKysgSmF2YVNjcmlwdENvcmUva2pzL3ZhbHVl LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3NCw3ICsyNzQsNyBAQCBpbmxpbmUgYm9vbCBKU1ZhbHVl Ojppc0Jvb2xlYW4oKSBjb25zdAogCiBpbmxpbmUgYm9vbCBKU1ZhbHVlOjppc051bWJlcigpIGNv bnN0CiB7Ci0gICAgcmV0dXJuIEpTSW1tZWRpYXRlOjppc051bWJlcih0aGlzKSB8fCAhSlNJbW1l ZGlhdGU6OmlzSW1tZWRpYXRlKHRoaXMpICYmIGFzQ2VsbCgpLT5pc051bWJlcigpOworICAgIHJl dHVybiBKU0ltbWVkaWF0ZTo6aXNOdW1iZXIodGhpcykgfHwgKCAhSlNJbW1lZGlhdGU6OmlzSW1t ZWRpYXRlKHRoaXMpICYmIGFzQ2VsbCgpLT5pc051bWJlcigpICk7CiB9CiAKIGlubGluZSBib29s IEpTVmFsdWU6OmlzU3RyaW5nKCkgY29uc3QK