157639 2016-05-12 14:00:04 -0700 Web Inspector: Uncaught exception when removing selected Timeline instrument 2016-05-12 17:55:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192453 0 joepeck 2016-05-12 14:00:04 -0700 * SUMMARY Uncaught exception when removing selected Timeline instrument * STEPS TO REPRODUCE 1. Open inspector 2. Show Timelines Tab 3. Select a Timeline 4. Edit 5. Remove the selected Timeline 6. Done => Uncaught Exception 1192454 1 webkit-bug-importer 2016-05-12 14:01:13 -0700 <rdar://problem/26252938> 1192533 2 278783 mattbaker 2016-05-12 17:05:46 -0700 Created attachment 278783 [Patch] Proposed Fix 1192558 3 278783 commit-queue 2016-05-12 17:55:06 -0700 Comment on attachment 278783 [Patch] Proposed Fix Clearing flags on attachment: 278783 Committed r200805: <http://trac.webkit.org/changeset/200805> 1192559 4 commit-queue 2016-05-12 17:55:10 -0700 All reviewed patches have been landed. Closing bug. 278783 2016-05-12 17:05:46 -0700 2016-05-12 17:55:06 -0700 [Patch] Proposed Fix bug-157639-20160512170637.patch text/plain 2891 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz YWRjOTA0ZjU2MjQ3OTUzZGI1YTdiOTE4OGE0ZmJmMmU5MThlMDFmLi5jNzgzNTJmMDdkMTY1MjUz ZWY1Y2M0ZDgwNDUwNDU3MzdmNjQ0YWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNS0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgZXhjZXB0aW9uIHdoZW4gcmVtb3Zp bmcgc2VsZWN0ZWQgVGltZWxpbmUgaW5zdHJ1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NjM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NjI1MjkzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LnByb3RvdHlwZS5faW5zdHJ1bWVudFJlbW92ZWQp OgorICAgICAgICBSZW1vdmUgdGltZWxpbmUgdHJlZSBlbGVtZW50IGJlZm9yZSBtb2RpZnlpbmcg c3RhdGUuIFJlbW92aW5nIHRoZSB0cmVlCisgICAgICAgIGVsZW1lbnQgdHJpZ2dlcnMgYSBTZWxl Y3Rpb25EaWRDaGFuZ2UgZXZlbnQsIHdoaWNoIGNhbiBoYXZlIHNpZGUgZWZmZWN0cy4KKwogMjAx Ni0wNS0xMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIFJlc2V0IGJ1dHRvbiBvbmx5IHJlc2V0cyB0aGUgb25l IGFjdGl2ZSBTY3JpcHQgVGltZWxpbmVWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcwppbmRl eCBlMDY2MGI4NDAyMjNkNTNhODc3Y2M2M2QyNGE5ZGRhYjJkNTIzODA5Li44NjRmOGMyZGExMWNj ZmYyNTJlYTI1MmQ1MzQwYWEyYTRkNTY1ZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMK QEAgLTYzNCwxNiArNjM0LDE5IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3ID0gY2xh c3MgVGltZWxpbmVPdmVydmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgIGNv bnNvbGUuYXNzZXJ0KGluc3RydW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuSW5zdHJ1bWVu dCwgaW5zdHJ1bWVudCk7CiAKICAgICAgICAgbGV0IHRpbWVsaW5lID0gdGhpcy5fcmVjb3JkaW5n LnRpbWVsaW5lRm9ySW5zdHJ1bWVudChpbnN0cnVtZW50KTsKLSAgICAgICAgY29uc29sZS5hc3Nl cnQodGhpcy5fb3ZlcnZpZXdHcmFwaHNCeVR5cGVNYXAuaGFzKHRpbWVsaW5lLnR5cGUpLCB0aW1l bGluZSk7Ci0KLSAgICAgICAgbGV0IG92ZXJ2aWV3R3JhcGggPSB0aGlzLl9vdmVydmlld0dyYXBo c0J5VHlwZU1hcC50YWtlKHRpbWVsaW5lLnR5cGUpOwotICAgICAgICBvdmVydmlld0dyYXBoLnJl bW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5FdmVu dC5SZWNvcmRTZWxlY3RlZCwgdGhpcy5fcmVjb3JkU2VsZWN0ZWQsIHRoaXMpOwotICAgICAgICB0 aGlzLl9ncmFwaHNDb250YWluZXJWaWV3LnJlbW92ZVN1YnZpZXcob3ZlcnZpZXdHcmFwaCk7Cisg ICAgICAgIGxldCBvdmVydmlld0dyYXBoID0gdGhpcy5fb3ZlcnZpZXdHcmFwaHNCeVR5cGVNYXAu Z2V0KHRpbWVsaW5lLnR5cGUpOworICAgICAgICBjb25zb2xlLmFzc2VydChvdmVydmlld0dyYXBo LCAiTWlzc2luZyBvdmVydmlldyBncmFwaCBmb3IgdGltZWxpbmUgdHlwZSIsIHRpbWVsaW5lLnR5 cGUpOwogCi0gICAgICAgIGxldCB0cmVlRWxlbWVudCA9IHRoaXMuX3RyZWVFbGVtZW50c0J5VHlw ZU1hcC50YWtlKHRpbWVsaW5lLnR5cGUpOworICAgICAgICBsZXQgdHJlZUVsZW1lbnQgPSB0aGlz Ll90cmVlRWxlbWVudHNCeVR5cGVNYXAuZ2V0KHRpbWVsaW5lLnR5cGUpOwogICAgICAgICBsZXQg c2hvdWxkU3VwcHJlc3NPbkRlc2VsZWN0ID0gZmFsc2U7CiAgICAgICAgIGxldCBzaG91bGRTdXBw cmVzc1NlbGVjdFNpYmxpbmcgPSB0cnVlOwogICAgICAgICB0aGlzLl90aW1lbGluZXNUcmVlT3V0 bGluZS5yZW1vdmVDaGlsZCh0cmVlRWxlbWVudCwgc2hvdWxkU3VwcHJlc3NPbkRlc2VsZWN0LCBz aG91bGRTdXBwcmVzc1NlbGVjdFNpYmxpbmcpOworCisgICAgICAgIG92ZXJ2aWV3R3JhcGgucmVt b3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlld0dyYXBoLkV2ZW50 LlJlY29yZFNlbGVjdGVkLCB0aGlzLl9yZWNvcmRTZWxlY3RlZCwgdGhpcyk7CisgICAgICAgIHRo aXMuX2dyYXBoc0NvbnRhaW5lclZpZXcucmVtb3ZlU3VidmlldyhvdmVydmlld0dyYXBoKTsKKwor ICAgICAgICB0aGlzLl9vdmVydmlld0dyYXBoc0J5VHlwZU1hcC5kZWxldGUodGltZWxpbmUudHlw ZSk7CisgICAgICAgIHRoaXMuX3RyZWVFbGVtZW50c0J5VHlwZU1hcC5kZWxldGUodGltZWxpbmUu dHlwZSk7CiAgICAgfQogCiAgICAgX21hcmtlckFkZGVkKGV2ZW50KQo=