157638 2016-05-12 13:15:09 -0700 Web Inspector: Timeline Reset button only resets the one active Script TimelineView 2016-05-12 15:08:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192442 0 joepeck 2016-05-12 13:15:09 -0700 * SUMMARY Timeline Reset button only resets the one active Script TimelineView. It should reset both Script TimelineViews (Events and Call Frames) * STEPS TO REPRODUCE 1. Record a timeline with script events 2. Select Scripts Timeline 3. Select Call Frame 4. Click Timeline Reset button => Call Frames clears 5. Switch to Events => There are records! Expected it to be cleared 1192443 1 webkit-bug-importer 2016-05-12 13:15:56 -0700 <rdar://problem/26251756> 1192445 2 278755 joepeck 2016-05-12 13:16:19 -0700 Created attachment 278755 [PATCH] Proposed Fix 1192491 3 278755 commit-queue 2016-05-12 15:08:12 -0700 Comment on attachment 278755 [PATCH] Proposed Fix Clearing flags on attachment: 278755 Committed r200793: <http://trac.webkit.org/changeset/200793> 1192492 4 commit-queue 2016-05-12 15:08:16 -0700 All reviewed patches have been landed. Closing bug. 278755 2016-05-12 13:16:19 -0700 2016-05-12 15:08:12 -0700 [PATCH] Proposed Fix reset-1.patch text/plain 4057 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJjNDJkYTEuLmUzOWUzNmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA1LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgUmVzZXQgYnV0dG9uIG9ubHkgcmVzZXRzIHRoZSBvbmUgYWN0aXZlIFNjcmlwdCBUaW1lbGlu ZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NzYzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDbHVzdGVyVGltZWxpbmVWaWV3LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNjcmlwdENsdXN0ZXJUaW1lbGluZVZpZXcucHJvdG90eXBlLnJlc2V0 KToKKyAgICAgICAgUmVzZXQgc2hvdWxkIHJlc2V0IGFsbCB0aGUgdmlld3MuCisKKyAgICAgICAg KFdlYkluc3BlY3Rvci5TY3JpcHRDbHVzdGVyVGltZWxpbmVWaWV3LnByb3RvdHlwZS5nZXQgbmF2 aWdhdGlvblNpZGViYXJUcmVlT3V0bGluZSk6IERlbGV0ZWQuCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9OZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLk5ldHdvcmtHcmlkQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBuYXZpZ2F0aW9uU2lkZWJh clRyZWVPdXRsaW5lKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Rp bWVsaW5lVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVZpZXcucHJvdG90 eXBlLmdldCBuYXZpZ2F0aW9uU2lkZWJhclRyZWVPdXRsaW5lU2NvcGVCYXIpOiBEZWxldGVkLgor ICAgICAgICBSZW1vdmUgZGVhZCBjb2RlLiBOb2JvZHkgY2FsbHMgdGhlc2UgZ2V0dGVycy4KKwog MjAxNi0wNS0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogMTElIG9mIHRpbWUgaW4gVGltZWxpbmVSZWNvcmRpbmcgc3BlbnQgdXBk YXRpbmcgRGF0YUdyaWQgdGhhdCBpcyBub3QgdmlzaWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlk Q29udGVudFZpZXcuanMKaW5kZXggNTE2MGYzNC4uNTliZThmNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3 b3JrR3JpZENvbnRlbnRWaWV3LmpzCkBAIC0xMDAsMTEgKzEwMCw2IEBAIFdlYkluc3BlY3Rvci5O ZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya0dyaWRDb250ZW50VmlldyBleHRl bmRzIFdlYkluCiAKICAgICAvLyBQdWJsaWMKIAotICAgIGdldCBuYXZpZ2F0aW9uU2lkZWJhclRy ZWVPdXRsaW5lKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLl9jb250ZW50VHJlZU91dGxp bmU7Ci0gICAgfQotCiAgICAgZ2V0IHNlbGVjdGlvblBhdGhDb21wb25lbnRzKCkKICAgICB7CiAg ICAgICAgIGlmICghdGhpcy5fY29udGVudFRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQg fHwgdGhpcy5fY29udGVudFRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQuaGlkZGVuKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2Ny aXB0Q2x1c3RlclRpbWVsaW5lVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1NjcmlwdENsdXN0ZXJUaW1lbGluZVZpZXcuanMKaW5kZXggYjEzODhjYi4u Y2NlMWE0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvU2NyaXB0Q2x1c3RlclRpbWVsaW5lVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDbHVzdGVyVGltZWxpbmVWaWV3LmpzCkBA IC03MSwxMiArNzEsMTggQEAgV2ViSW5zcGVjdG9yLlNjcmlwdENsdXN0ZXJUaW1lbGluZVZpZXcg PSBjbGFzcyBTY3JpcHRDbHVzdGVyVGltZWxpbmVWaWV3IGV4dGVuZHMKICAgICBzZXQgZW5kVGlt ZSh4KSB7IHRoaXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmN1cnJlbnRDb250ZW50Vmlldy5lbmRU aW1lID0geDsgfQogICAgIGdldCBjdXJyZW50VGltZSgpIHsgcmV0dXJuIHRoaXMuX2NvbnRlbnRW aWV3Q29udGFpbmVyLmN1cnJlbnRDb250ZW50Vmlldy5jdXJyZW50VGltZTsgfQogICAgIHNldCBj dXJyZW50VGltZSh4KSB7IHRoaXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmN1cnJlbnRDb250ZW50 Vmlldy5jdXJyZW50VGltZSA9IHg7IH0KLSAgICBnZXQgbmF2aWdhdGlvblNpZGViYXJUcmVlT3V0 bGluZSgpIHsgcmV0dXJuIHRoaXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmN1cnJlbnRDb250ZW50 Vmlldy5uYXZpZ2F0aW9uU2lkZWJhclRyZWVPdXRsaW5lOyB9Ci0gICAgcmVzZXQoKSB7IHJldHVy biB0aGlzLl9jb250ZW50Vmlld0NvbnRhaW5lci5jdXJyZW50Q29udGVudFZpZXcucmVzZXQoKTsg fQogICAgIHVwZGF0ZUZpbHRlcihmaWx0ZXJzKSB7IHJldHVybiB0aGlzLl9jb250ZW50Vmlld0Nv bnRhaW5lci5jdXJyZW50Q29udGVudFZpZXcudXBkYXRlRmlsdGVyKGZpbHRlcnMpOyB9CiAgICAg ZmlsdGVyRGlkQ2hhbmdlKCkgeyByZXR1cm4gdGhpcy5fY29udGVudFZpZXdDb250YWluZXIuY3Vy cmVudENvbnRlbnRWaWV3LmZpbHRlckRpZENoYW5nZSgpOyB9CiAgICAgbWF0Y2hEYXRhR3JpZE5v ZGVBZ2FpbnN0Q3VzdG9tRmlsdGVycyhub2RlKSB7IHJldHVybiB0aGlzLl9jb250ZW50Vmlld0Nv bnRhaW5lci5jdXJyZW50Q29udGVudFZpZXcubWF0Y2hEYXRhR3JpZE5vZGVBZ2FpbnN0Q3VzdG9t RmlsdGVycyhub2RlKTsgfQogCisgICAgcmVzZXQoKQorICAgIHsKKyAgICAgICAgdGhpcy5fZXZl bnRzQ29udGVudFZpZXcucmVzZXQoKTsKKworICAgICAgICBpZiAodGhpcy5fcHJvZmlsZUNvbnRl bnRWaWV3KQorICAgICAgICAgICAgdGhpcy5fcHJvZmlsZUNvbnRlbnRWaWV3LnJlc2V0KCk7Cisg ICAgfQorCiAgICAgLy8gUHVibGljCiAKICAgICBnZXQgZXZlbnRzQ29udGVudFZpZXcoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVWaWV3LmpzCmluZGV4IGFiN2VjMmEuLjYyOGM3NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVZpZXcuanMK QEAgLTYwLDExICs2MCw2IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVZpZXcgPSBjbGFzcyBUaW1l bGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcKICAgICAgICAgcmV0dXJu IHRoaXMuX3Njb3BlQmFyID8gW3RoaXMuX3Njb3BlQmFyXSA6IFtdOwogICAgIH0KIAotICAgIGdl dCBuYXZpZ2F0aW9uU2lkZWJhclRyZWVPdXRsaW5lU2NvcGVCYXIoKQotICAgIHsKLSAgICAgICAg cmV0dXJuIHRoaXMuX3Njb3BlQmFyOwotICAgIH0KLQogICAgIGdldCBzZWxlY3Rpb25QYXRoQ29t cG9uZW50cygpCiAgICAgewogICAgICAgICAvLyBJbXBsZW1lbnRlZCBieSBzdWItY2xhc3NlcyBp ZiBuZWVkZWQuCg==