157618 2016-05-12 01:24:07 -0700 Web Inspector: Reduce rAF churn in DefaultDashboardView on pages with lots of resources 2016-05-12 08:41:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192270 0 joepeck 2016-05-12 01:24:07 -0700 * SUMMARY Reduce rAF churn in DefaultDashboardView on pages with lots of resources. Each resource added would cause a separate rAF to be added. That means there would be lots of duplicate work when the rAFs do fire with the same callback and data all at the same time. 1192271 1 278714 joepeck 2016-05-12 01:25:10 -0700 Created attachment 278714 [PATCH] Proposed Fix 1192328 2 278714 timothy 2016-05-12 08:20:18 -0700 Comment on attachment 278714 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=278714&action=review > Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:68 > + _updateDisplaySoon() I wonder if we should add a soon Proxy using rAF? 1192331 3 278714 commit-queue 2016-05-12 08:41:46 -0700 Comment on attachment 278714 [PATCH] Proposed Fix Clearing flags on attachment: 278714 Committed r200772: <http://trac.webkit.org/changeset/200772> 1192332 4 commit-queue 2016-05-12 08:41:50 -0700 All reviewed patches have been landed. Closing bug. 278714 2016-05-12 01:25:10 -0700 2016-05-12 08:41:46 -0700 [PATCH] Proposed Fix coalesce.patch text/plain 2522 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgxYTE5MGYuLjdhNThlOWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTA1LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IHJBRiBjaHVybiBpbiBEZWZhdWx0RGFzaGJvYXJkVmlldyBvbiBwYWdlcyB3aXRoIGxvdHMgb2Yg cmVzb3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTc2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGVmYXVsdERhc2hib2FyZFZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuRGVmYXVsdERhc2hib2FyZFZpZXcpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRlZmF1bHREYXNoYm9hcmRWaWV3LnByb3RvdHlwZS5fdXBkYXRlRGlzcGxheVNvb24pOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRlZmF1bHREYXNoYm9hcmRWaWV3LnByb3RvdHlwZS5fdXBk YXRlRGlzcGxheSk6CisgICAgICAgIFByZXZpb3VzbHkgd2Ugd2VyZSBzY2hlZHVsaW5nIG11bHRp cGxlIHJBRnMgdGhhdCB3b3VsZCBhbGwgZmlyZSB3aXRoCisgICAgICAgIHRoZSBzYW1lIGRhdGEs IGVhY2ggdGltZSBhIHJlc291cmNlIHdhcyBhZGRlZC4gQ29hbGVzY2UgaW50byBvbmUuCisKKzIw MTYtMDUtMTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiAzLjglIG9mIHRpbWVsaW5lIHJlY29yZGluZyBzcGVudCBpbiBOYXZp Z2F0aW9uU2lkZWJhclBhbmVsIF91cGRhdGVDb250ZW50T3ZlcmZsb3dTaGFkb3dWaXNpYmlsaXR5 IGZvciBiYWNrZ3JvdW5kIHRhYgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU3NjE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RlZmF1bHREYXNoYm9hcmRWaWV3LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVmYXVsdERhc2hib2FyZFZpZXcuanMKaW5k ZXggODJhZDk5NS4uMTNiZDYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRGVmYXVsdERhc2hib2FyZFZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVmYXVsdERhc2hib2FyZFZpZXcuanMK QEAgLTI5LDcgKzI5LDggQEAgV2ViSW5zcGVjdG9yLkRlZmF1bHREYXNoYm9hcmRWaWV3ID0gY2xh c3MgRGVmYXVsdERhc2hib2FyZFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICB7CiAgICAgICAg IHN1cGVyKHJlcHJlc2VudGVkT2JqZWN0LCAiZGVmYXVsdCIpOwogCi0gICAgICAgIHJlcHJlc2Vu dGVkT2JqZWN0LmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRlZmF1bHREYXNoYm9hcmQu RXZlbnQuRGF0YURpZENoYW5nZSwgd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZS5iaW5kKG51 bGwsIHRoaXMuX3VwZGF0ZURpc3BsYXkuYmluZCh0aGlzKSkpOworICAgICAgICByZXByZXNlbnRl ZE9iamVjdC5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5EZWZhdWx0RGFzaGJvYXJkLkV2 ZW50LkRhdGFEaWRDaGFuZ2UsICgpID0+IHsgdGhpcy5fdXBkYXRlRGlzcGxheVNvb24oKSB9KTsK KyAgICAgICAgdGhpcy5fc2NoZWR1bGVkVXBkYXRlSWRlbnRpZmllciA9IHVuZGVmaW5lZDsKIAog ICAgICAgICB0aGlzLl9pdGVtcyA9IHsKICAgICAgICAgICAgIHJlc291cmNlc0NvdW50OiB7CkBA IC02NCw4ICs2NSwxOCBAQCBXZWJJbnNwZWN0b3IuRGVmYXVsdERhc2hib2FyZFZpZXcgPSBjbGFz cyBEZWZhdWx0RGFzaGJvYXJkVmlldyBleHRlbmRzIFdlYkluc3BlYwogICAgIAogICAgIC8vIFBy aXZhdGUKIAorICAgIF91cGRhdGVEaXNwbGF5U29vbigpCisgICAgeworICAgICAgICBpZiAodGhp cy5fc2NoZWR1bGVkVXBkYXRlSWRlbnRpZmllcikKKyAgICAgICAgICAgIHJldHVybjsKKworICAg ICAgICB0aGlzLl9zY2hlZHVsZWRVcGRhdGVJZGVudGlmaWVyID0gcmVxdWVzdEFuaW1hdGlvbkZy YW1lKHRoaXMuX3VwZGF0ZURpc3BsYXkuYmluZCh0aGlzKSk7CisgICAgfQorCiAgICAgX3VwZGF0 ZURpc3BsYXkoKQogICAgIHsKKyAgICAgICAgdGhpcy5fc2NoZWR1bGVkVXBkYXRlSWRlbnRpZmll ciA9IHVuZGVmaW5lZDsKKwogICAgICAgICB2YXIgZGFzaGJvYXJkID0gdGhpcy5yZXByZXNlbnRl ZE9iamVjdDsKIAogICAgICAgICBmb3IgKHZhciBjYXRlZ29yeSBvZiBbImxvZ3MiLCAiaXNzdWVz IiwgImVycm9ycyJdKQo=