157607 2016-05-11 20:36:07 -0700 Web Inspector: 4% of time in TimelineOverviewGraph adding/removing classList styles on TimelineRecordBar 2016-05-11 21:32:08 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1192198 0 joepeck 2016-05-11 20:36:07 -0700 4% of time in TimelineOverviewGraph on theverge.com is adding/removing classList styles on TimelineRecordBar. We can eliminate a lot of these by just being smarter about only toggling them when they change. 1192200 1 278691 joepeck 2016-05-11 20:38:24 -0700 Created attachment 278691 [PATCH] Proposed Fix 1192208 2 278691 bburg 2016-05-11 21:10:16 -0700 Comment on attachment 278691 [PATCH] Proposed Fix r=me Good catch. 1192210 3 278691 commit-queue 2016-05-11 21:32:04 -0700 Comment on attachment 278691 [PATCH] Proposed Fix Clearing flags on attachment: 278691 Committed r200740: <http://trac.webkit.org/changeset/200740> 1192211 4 commit-queue 2016-05-11 21:32:08 -0700 All reviewed patches have been landed. Closing bug. 278691 2016-05-11 20:38:24 -0700 2016-05-11 21:32:04 -0700 [PATCH] Proposed Fix classlist-1.patch text/plain 4635 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkMjUzYTcuLmU5ODhmNzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA1LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogNCUgb2Yg dGltZSBpbiBUaW1lbGluZU92ZXJ2aWV3R3JhcGggYWRkaW5nL3JlbW92aW5nIGNsYXNzTGlzdCBz dHlsZXMgb24gVGltZWxpbmVSZWNvcmRCYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NzYwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgZ2V0cyB1cyBkb3duIHRvIGFib3V0IDAuNSUgb2YgdGlt ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRCYXIuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRCYXIucHJvdG90eXBlLnNldCBy ZWNvcmRzKToKKyAgICAgICAgT25seSBtb2RpZnkgdGhlIGNsYXNzTGlzdHMgd2hlbiB0aGUgcmVj b3JkIGNoYW5nZXMuCisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZEJhci5w cm90b3R5cGUucmVmcmVzaCk6CisgICAgICAgIFNldCB1bmZpbmlzaGVkIG9uY2UgZm9yIGVpdGhl ciB0aGUgdXNlcyBhY3RpdmUgb3Igbm90IHVzZXMgYWN0aXZlIGNhc2VzLgorCisyMDE2LTA1LTEx ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIElu c3BlY3RvcjogVW5leHBlY3RlZCB1bnJlYWQgbm90aWZpY2F0aW9uIGljb24gbmV4dCB0byBMb2cg YWZ0ZXIgY2xlYXJpbmcgdmlhIGNsZWFyKCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NzU5OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZEJhci5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkQmFyLmpzCmlu ZGV4IDE3YzIzMmYuLmE2MjNhMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkQmFyLmpzCkBAIC0x OTAsMjMgKzE5MCwzNSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRCYXIgPSBjbGFzcyBU aW1lbGluZVJlY29yZEJhciBleHRlbmRzIFdlYkluc3BlY3Rvci5PYgogCiAgICAgc2V0IHJlY29y ZHMocmVjb3JkcykKICAgICB7CisgICAgICAgIGxldCBvbGRSZWNvcmRUeXBlOworICAgICAgICBs ZXQgb2xkUmVjb3JkRXZlbnRUeXBlOworICAgICAgICBsZXQgb2xkUmVjb3JkVXNlc0FjdGl2ZVN0 YXJ0VGltZSA9IGZhbHNlOwogICAgICAgICBpZiAodGhpcy5fcmVjb3JkcyAmJiB0aGlzLl9yZWNv cmRzLmxlbmd0aCkgewotICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QucmVtb3Zl KHRoaXMuX3JlY29yZHNbMF0udHlwZSk7Ci0gICAgICAgICAgICBpZiAodGhpcy5fcmVjb3Jkc1sw XS5ldmVudFR5cGUpCi0gICAgICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QucmVt b3ZlKHRoaXMuX3JlY29yZHNbMF0uZXZlbnRUeXBlKTsKKyAgICAgICAgICAgIGxldCBvbGRSZWNv cmQgPSB0aGlzLl9yZWNvcmRzWzBdOworICAgICAgICAgICAgb2xkUmVjb3JkVHlwZSA9IG9sZFJl Y29yZC50eXBlOworICAgICAgICAgICAgb2xkUmVjb3JkRXZlbnRUeXBlID0gb2xkUmVjb3JkLmV2 ZW50VHlwZTsKKyAgICAgICAgICAgIG9sZFJlY29yZFVzZXNBY3RpdmVTdGFydFRpbWUgPSBvbGRS ZWNvcmQudXNlc0FjdGl2ZVN0YXJ0VGltZTsKICAgICAgICAgfQogCiAgICAgICAgIHJlY29yZHMg PSByZWNvcmRzIHx8IFtdOwogCiAgICAgICAgIHRoaXMuX3JlY29yZHMgPSByZWNvcmRzOwogCi0g ICAgICAgIC8vIEFzc3VtZSBhbGwgcmVjb3JkcyBhcmUgdGhlIHNhbWUgdHlwZS4KKyAgICAgICAg Ly8gQXNzdW1lIGFsbCByZWNvcmRzIGluIHRoZSBncm91cCBhcmUgdGhlIHNhbWUgdHlwZS4KICAg ICAgICAgaWYgKHRoaXMuX3JlY29yZHMubGVuZ3RoKSB7Ci0gICAgICAgICAgICB0aGlzLl9lbGVt ZW50LmNsYXNzTGlzdC5hZGQodGhpcy5fcmVjb3Jkc1swXS50eXBlKTsKKyAgICAgICAgICAgIGxl dCBuZXdSZWNvcmQgPSB0aGlzLl9yZWNvcmRzWzBdOworICAgICAgICAgICAgaWYgKG5ld1JlY29y ZC50eXBlICE9PSBvbGRSZWNvcmRUeXBlKSB7CisgICAgICAgICAgICAgICAgdGhpcy5fZWxlbWVu dC5jbGFzc0xpc3QucmVtb3ZlKG9sZFJlY29yZFR5cGUpOworICAgICAgICAgICAgICAgIHRoaXMu X2VsZW1lbnQuY2xhc3NMaXN0LmFkZChuZXdSZWNvcmQudHlwZSk7CisgICAgICAgICAgICB9CiAg ICAgICAgICAgICAvLyBBbHRob3VnaCBhbGwgcmVjb3JkcyBtYXkgbm90IGhhdmUgdGhlIHNhbWUg ZXZlbnQgdHlwZSwgdGhlIGZpcnN0IHJlY29yZCBpcwogICAgICAgICAgICAgLy8gc3VmZmljaWVu dCB0byBkZXRlcm1pbmUgdGhlIGNvcnJlY3Qgc3R5bGUgZm9yIHRoZSByZWNvcmQgYmFyLgotICAg ICAgICAgICAgaWYgKHRoaXMuX3JlY29yZHNbMF0uZXZlbnRUeXBlKQotICAgICAgICAgICAgICAg IHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCh0aGlzLl9yZWNvcmRzWzBdLmV2ZW50VHlwZSk7 CisgICAgICAgICAgICBpZiAobmV3UmVjb3JkLmV2ZW50VHlwZSAhPT0gb2xkUmVjb3JkRXZlbnRU eXBlKSB7CisgICAgICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QucmVtb3ZlKG9s ZFJlY29yZEV2ZW50VHlwZSk7CisgICAgICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xp c3QuYWRkKG5ld1JlY29yZC5ldmVudFR5cGUpOworICAgICAgICAgICAgfQorICAgICAgICAgICAg aWYgKG5ld1JlY29yZC51c2VzQWN0aXZlU3RhcnRUaW1lICE9PSBvbGRSZWNvcmRVc2VzQWN0aXZl U3RhcnRUaW1lKQorICAgICAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnRvZ2ds ZSgiaGFzLWluYWN0aXZlLXNlZ21lbnQiLCBuZXdSZWNvcmQudXNlc0FjdGl2ZVN0YXJ0VGltZSk7 CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTI0Miw4ICsyNTQsNiBAQCBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVSZWNvcmRCYXIgPSBjbGFzcyBUaW1lbGluZVJlY29yZEJhciBleHRlbmRzIFdlYkluc3Bl Y3Rvci5PYgogCiAgICAgICAgIHZhciBncmFwaER1cmF0aW9uID0gZ3JhcGhFbmRUaW1lIC0gZ3Jh cGhTdGFydFRpbWU7CiAKLSAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QudG9nZ2xlKCJ1 bmZpbmlzaGVkIiwgYmFyVW5maW5pc2hlZCk7Ci0KICAgICAgICAgdmFyIG5ld0JhckxlZnRQb3Np dGlvbiA9IChiYXJTdGFydFRpbWUgLSBncmFwaFN0YXJ0VGltZSkgLyBncmFwaER1cmF0aW9uOwog ICAgICAgICB0aGlzLl91cGRhdGVFbGVtZW50UG9zaXRpb24odGhpcy5fZWxlbWVudCwgbmV3QmFy TGVmdFBvc2l0aW9uLCAibGVmdCIpOwogCkBAIC0yNTYsNyArMjY2LDcgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lUmVjb3JkQmFyID0gY2xhc3MgVGltZWxpbmVSZWNvcmRCYXIgZXh0ZW5kcyBXZWJJ bnNwZWN0b3IuT2IKICAgICAgICAgfQogCiAgICAgICAgIGlmICghZmlyc3RSZWNvcmQudXNlc0Fj dGl2ZVN0YXJ0VGltZSkgewotICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QucmVt b3ZlKCJoYXMtaW5hY3RpdmUtc2VnbWVudCIpOworICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5j bGFzc0xpc3QudG9nZ2xlKCJ1bmZpbmlzaGVkIiwgYmFyVW5maW5pc2hlZCk7CiAKICAgICAgICAg ICAgIGlmICh0aGlzLl9pbmFjdGl2ZUJhckVsZW1lbnQpCiAgICAgICAgICAgICAgICAgdGhpcy5f aW5hY3RpdmVCYXJFbGVtZW50LnJlbW92ZSgpOwpAQCAtMjc4LDggKzI4OCw2IEBAIFdlYkluc3Bl Y3Rvci5UaW1lbGluZVJlY29yZEJhciA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkQmFyIGV4dGVuZHMg V2ViSW5zcGVjdG9yLk9iCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogCi0g ICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgiaGFzLWluYWN0aXZlLXNlZ21lbnQi KTsKLQogICAgICAgICAvLyBGaW5kIHRoZSBlYXJsaWVzdCBhY3RpdmUgc3RhcnQgdGltZSBmb3Ig YWN0aXZlIG9ubHkgcmVuZGVyaW5nLCBhbmQgdGhlIGxhdGVzdCBmb3IgdGhlIG90aGVyIG1vZGVz LgogICAgICAgICAvLyBUaGlzIG1hdGNoZXMgdGhlIHZhbHVlcyB0aGF0IFRpbWVsaW5lUmVjb3Jk QmFyLmNyZWF0ZUNvbWJpbmVkQmFycyB1c2VzIHdoZW4gY29tYmluaW5nLgogICAgICAgICBpZiAo dGhpcy5fcmVuZGVyTW9kZSA9PT0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyLlJlbmRl ck1vZGUuQWN0aXZlT25seSkK