157603 2016-05-11 18:37:54 -0700 [JSC] Make sure StringRange is passed to Vector by register 2016-05-11 23:33:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1192182 0 benjamin 2016-05-11 18:37:54 -0700 [JSC] Make sure StringRange is passed to Vector by register 1192184 1 278689 benjamin 2016-05-11 18:45:24 -0700 Created attachment 278689 Patch 1192236 2 benjamin 2016-05-11 23:14:36 -0700 After updating to a more recent LLVM, I see the same thing. Vector::append() is not inlined in this case. It is just weird. 1192242 3 278689 commit-queue 2016-05-11 23:33:51 -0700 Comment on attachment 278689 Patch Clearing flags on attachment: 278689 Committed r200743: <http://trac.webkit.org/changeset/200743> 1192243 4 commit-queue 2016-05-11 23:33:56 -0700 All reviewed patches have been landed. Closing bug. 278689 2016-05-11 18:45:24 -0700 2016-05-11 23:33:51 -0700 Patch bug-157603-20160511184614.patch text/plain 4778 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZDY5OTNiZDc5NTFiZDAwOTJlYWY4MDliMjAwYjNmOTVhZjNjNWRhLi4wNzViNjNlYjAyN2ZlYjM4 M2Q4YzliNmRiZjYwZTE3MWY3N2ExMDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxNi0wNS0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIHN1cmUgU3RyaW5nUmFuZ2UgaXMgcGFzc2VkIHRv IFZlY3RvciBieSByZWdpc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU3NjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhpcyBpcyBiaXphcnJlLCBidXQgb24gbXkgU0RLLCBWZWN0b3I6OmFwcGVu ZChTdHJpbmdSYW5nZSkKKyAgICAgICAgaXMgcGFzc2luZyB0aGUgdmFsdWVzIG9uIHRoZSBzdGFj ay4KKyAgICAgICAgVGhlIHR3byBpbnRlZ2VycyBhcmUgd3JpdHRlbiB0byB0aGUgc3RhY2ssIHRo ZSBhZGRyZXNzIGdpdmVuCisgICAgICAgIHRvIGFwcGVuZCgpLCB0aGVuIGFwcGVuZCgpIHJlYWRz IGl0IGJhY2sgYW5kIHN0b3JlIGl0LgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUg Y29kZSB0byB1c2UgY29uc3RydWN0QW5kQXBwZW5kKCksIGVuc3VyaW5nCisgICAgICAgIHRoZSB2 YWx1ZXMgYXJlIHVzZWQgZGlyZWN0bHkuCisKKyAgICAgICAgT24gbXkgbWFjaGluZSwgdGhpcyBo ZWxwcyBTdW5zcGlkZXIgYW5kIE9jdGFuZS4KKyAgICAgICAgVGhpcyBtaWdodCBiZSBzb21ldGhp bmcgd3Jvbmcgd2l0aCBteSBTREsgYnV0IHRoZSBmaXggaXMgc28gZWFzeQorICAgICAgICB0aGF0 IHdlIG1pZ2h0IGFzIHdlbGwgZG8gdGhpcy4KKworICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJv dG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6cmVtb3ZlVXNpbmdSZWdFeHBTZWFyY2gpOgorICAg ICAgICAoSlNDOjpyZXBsYWNlVXNpbmdSZWdFeHBTZWFyY2gpOgorCiAyMDE2LTA1LTA5ICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENhbGxPYmplY3RD b25zdHJ1Y3RvciBzaG91bGQgbm90IGNhbGwgb3BlcmF0aW9uVG9UaGlzIGluIHRoZSBGVEwKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCmlu ZGV4IGQzNzhlMmYxMmFlOWQ5YTQ0NzAxMTQ0YjE1MTkzNGYxODEwZWZlNzkuLmFlZjM0M2JhZGI4 ZjAyMzNhNzQ4YTBmZGUwM2JkODc0MGJkNDZiODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcApAQCAtNDQ4LDcgKzQ0OCw3IEBAIHN0 YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHJlbW92ZVVzaW5nUmVnRXhwU2VhcmNo KFZNJiB2bSwgRXhlY1N0YXRlKiBlCiAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICBpZiAo bGFzdEluZGV4IDwgcmVzdWx0LnN0YXJ0KQotICAgICAgICAgICAgc291cmNlUmFuZ2VzLmFwcGVu ZChTdHJpbmdSYW5nZShsYXN0SW5kZXgsIHJlc3VsdC5zdGFydCAtIGxhc3RJbmRleCkpOworICAg ICAgICAgICAgc291cmNlUmFuZ2VzLmNvbnN0cnVjdEFuZEFwcGVuZChsYXN0SW5kZXgsIHJlc3Vs dC5zdGFydCAtIGxhc3RJbmRleCk7CiAKICAgICAgICAgbGFzdEluZGV4ID0gcmVzdWx0LmVuZDsK ICAgICAgICAgc3RhcnRQb3NpdGlvbiA9IGxhc3RJbmRleDsKQEAgLTQ2NSw3ICs0NjUsNyBAQCBz dGF0aWMgQUxXQVlTX0lOTElORSBFbmNvZGVkSlNWYWx1ZSByZW1vdmVVc2luZ1JlZ0V4cFNlYXJj aChWTSYgdm0sIEV4ZWNTdGF0ZSogZQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHN0 cmluZyk7CiAKICAgICBpZiAoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGxhc3RJbmRleCkgPCBzb3Vy Y2VMZW4pCi0gICAgICAgIHNvdXJjZVJhbmdlcy5hcHBlbmQoU3RyaW5nUmFuZ2UobGFzdEluZGV4 LCBzb3VyY2VMZW4gLSBsYXN0SW5kZXgpKTsKKyAgICAgICAgc291cmNlUmFuZ2VzLmNvbnN0cnVj dEFuZEFwcGVuZChsYXN0SW5kZXgsIHNvdXJjZUxlbiAtIGxhc3RJbmRleCk7CiAKICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3BsaWNlU3Vic3RyaW5ncyhleGVjLCBzdHJpbmcsIHNvdXJj ZSwgc291cmNlUmFuZ2VzLmRhdGEoKSwgc291cmNlUmFuZ2VzLnNpemUoKSkpOwogfQpAQCAtNTE3 LDcgKzUxNyw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHJlcGxhY2VV c2luZ1JlZ0V4cFNlYXJjaCgKICAgICAgICAgICAgICAgICBpZiAoIXJlc3VsdCkKICAgICAgICAg ICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgICAgICAgICBzb3VyY2VSYW5nZXMuYXBwZW5k KFN0cmluZ1JhbmdlKGxhc3RJbmRleCwgcmVzdWx0LnN0YXJ0IC0gbGFzdEluZGV4KSk7CisgICAg ICAgICAgICAgICAgc291cmNlUmFuZ2VzLmNvbnN0cnVjdEFuZEFwcGVuZChsYXN0SW5kZXgsIHJl c3VsdC5zdGFydCAtIGxhc3RJbmRleCk7CiAKICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpID0g MDsKICAgICAgICAgICAgICAgICBmb3IgKDsgaSA8IHJlZ0V4cC0+bnVtU3VicGF0dGVybnMoKSAr IDE7ICsraSkgewpAQCAtNTU2LDcgKzU1Niw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29k ZWRKU1ZhbHVlIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaCgKICAgICAgICAgICAgICAgICBpZiAo IXJlc3VsdCkKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgICAgICAgICBz b3VyY2VSYW5nZXMuYXBwZW5kKFN0cmluZ1JhbmdlKGxhc3RJbmRleCwgcmVzdWx0LnN0YXJ0IC0g bGFzdEluZGV4KSk7CisgICAgICAgICAgICAgICAgc291cmNlUmFuZ2VzLmNvbnN0cnVjdEFuZEFw cGVuZChsYXN0SW5kZXgsIHJlc3VsdC5zdGFydCAtIGxhc3RJbmRleCk7CiAKICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpID0gMDsKICAgICAgICAgICAgICAgICBmb3IgKDsgaSA8IHJlZ0V4cC0+ bnVtU3VicGF0dGVybnMoKSArIDE7ICsraSkgewpAQCAtNTk3LDcgKzU5Nyw3IEBAIHN0YXRpYyBB TFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaCgKICAg ICAgICAgICAgICAgICBicmVhazsKIAogICAgICAgICAgICAgaWYgKGNhbGxUeXBlICE9IENhbGxU eXBlOjpOb25lKSB7Ci0gICAgICAgICAgICAgICAgc291cmNlUmFuZ2VzLmFwcGVuZChTdHJpbmdS YW5nZShsYXN0SW5kZXgsIHJlc3VsdC5zdGFydCAtIGxhc3RJbmRleCkpOworICAgICAgICAgICAg ICAgIHNvdXJjZVJhbmdlcy5jb25zdHJ1Y3RBbmRBcHBlbmQobGFzdEluZGV4LCByZXN1bHQuc3Rh cnQgLSBsYXN0SW5kZXgpOwogCiAgICAgICAgICAgICAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIg YXJnczsKIApAQCAtNjIwLDcgKzYyMCw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRK U1ZhbHVlIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaCgKICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgaW50IHJlcGxMZW4gPSByZXBsYWNlbWVudFN0cmluZy5sZW5ndGgoKTsK ICAgICAgICAgICAgICAgICBpZiAobGFzdEluZGV4IDwgcmVzdWx0LnN0YXJ0IHx8IHJlcGxMZW4p IHsKLSAgICAgICAgICAgICAgICAgICAgc291cmNlUmFuZ2VzLmFwcGVuZChTdHJpbmdSYW5nZShs YXN0SW5kZXgsIHJlc3VsdC5zdGFydCAtIGxhc3RJbmRleCkpOworICAgICAgICAgICAgICAgICAg ICBzb3VyY2VSYW5nZXMuY29uc3RydWN0QW5kQXBwZW5kKGxhc3RJbmRleCwgcmVzdWx0LnN0YXJ0 IC0gbGFzdEluZGV4KTsKIAogICAgICAgICAgICAgICAgICAgICBpZiAocmVwbExlbikKICAgICAg ICAgICAgICAgICAgICAgICAgIHJlcGxhY2VtZW50cy5hcHBlbmQoc3Vic3RpdHV0ZUJhY2tyZWZl cmVuY2VzKHJlcGxhY2VtZW50U3RyaW5nLCBzb3VyY2UsIG92ZWN0b3IsIHJlZ0V4cCkpOwpAQCAt NjQ1LDcgKzY0NSw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHJlcGxh Y2VVc2luZ1JlZ0V4cFNlYXJjaCgKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShzdHJp bmcpOwogCiAgICAgaWYgKHN0YXRpY19jYXN0PHVuc2lnbmVkPihsYXN0SW5kZXgpIDwgc291cmNl TGVuKQotICAgICAgICBzb3VyY2VSYW5nZXMuYXBwZW5kKFN0cmluZ1JhbmdlKGxhc3RJbmRleCwg c291cmNlTGVuIC0gbGFzdEluZGV4KSk7CisgICAgICAgIHNvdXJjZVJhbmdlcy5jb25zdHJ1Y3RB bmRBcHBlbmQobGFzdEluZGV4LCBzb3VyY2VMZW4gLSBsYXN0SW5kZXgpOwogCiAgICAgcmV0dXJu IEpTVmFsdWU6OmVuY29kZShqc1NwbGljZVN1YnN0cmluZ3NXaXRoU2VwYXJhdG9ycyhleGVjLCBz dHJpbmcsIHNvdXJjZSwgc291cmNlUmFuZ2VzLmRhdGEoKSwgc291cmNlUmFuZ2VzLnNpemUoKSwg cmVwbGFjZW1lbnRzLmRhdGEoKSwgcmVwbGFjZW1lbnRzLnNpemUoKSkpOwogfQo=