157599 2016-05-11 17:03:47 -0700 Kill Node::ancestorElement() 2016-05-11 21:34:30 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin esprehn+autocc kangil.han rniwa oldest_to_newest 1192160 0 cdumez 2016-05-11 17:03:47 -0700 Kill Node::ancestorElement() and use Node::parentElement() instead. If our parent is not an Element then none of our ancestors will be. 1192161 1 278684 cdumez 2016-05-11 17:04:44 -0700 Created attachment 278684 Patch 1192212 2 278684 commit-queue 2016-05-11 21:34:25 -0700 Comment on attachment 278684 Patch Clearing flags on attachment: 278684 Committed r200741: <http://trac.webkit.org/changeset/200741> 1192213 3 commit-queue 2016-05-11 21:34:30 -0700 All reviewed patches have been landed. Closing bug. 278684 2016-05-11 17:04:44 -0700 2016-05-11 21:34:25 -0700 Patch bug-157599-20160511170533.patch text/plain 5553 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNmY1NTRmODYzMWE3 MzgwY2VjNDZlZTEyYWIyYzYwOWQ5ODFiMS4uODJhMWJkMjBkZTdhYzlkYWNmNzU5NjNiMzQ4Zjlh NjRiMjkxNGY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE2LTA1LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgS2lsbCBOb2RlOjphbmNlc3Rv ckVsZW1lbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU3NTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgS2lsbCBOb2RlOjphbmNlc3RvckVsZW1lbnQoKSBhbmQgdXNlIE5vZGU6OnBhcmVudEVsZW1l bnQoKSBpbnN0ZWFkLiBJZgorICAgICAgICBvdXIgcGFyZW50IGlzIG5vdCBhbiBFbGVtZW50IHRo ZW4gbm9uZSBvZiBvdXIgYW5jZXN0b3JzIHdpbGwgYmUuCisKKyAgICAgICAgKiBkb20vTm9kZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjppc0RlZmF1bHROYW1lc3BhY2UpOgorICAgICAg ICAoV2ViQ29yZTo6Tm9kZTo6bG9va3VwUHJlZml4KToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6 Omxvb2t1cE5hbWVzcGFjZVVSSSk6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpsb29rdXBOYW1l c3BhY2VQcmVmaXgpOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6Y29udmVydFRvUGFnZSk6Cisg ICAgICAgIChXZWJDb3JlOjpOb2RlOjpjb252ZXJ0RnJvbVBhZ2UpOgorICAgICAgICAoV2ViQ29y ZTo6Tm9kZTo6YW5jZXN0b3JFbGVtZW50KTogRGVsZXRlZC4KKyAgICAgICAgKiBkb20vTm9kZS5o OgorCisyMDE2LTA1LTExICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAg ICAgVW5yZXZpZXdlZCBhdHRlbXB0IHRvIGZpeCB0aGUgV2luZG93cyBidWlsZCBhZnRlciByMjAw Njk5LgogCiAgICAgICAgICogYmluZGluZ3MvanMvSlNJREJPYmplY3RTdG9yZUN1c3RvbS5jcHA6 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vTm9kZS5jcHAKaW5kZXggMjVmMDdkMjZkMGQ2MGViMzk3ZTM3ZWY2ZGNkZjU3NmIzYzI2 NWUzNi4uMTliY2Y4ZWFiOGE2NDE4YTc3Y2NiOWU5NzQ1ZTg1MzBhOTdmNjhiNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmNwcApAQCAtMTMyMCw4ICsxMzIwLDggQEAgYm9vbCBOb2RlOjppc0RlZmF1bHROYW1lc3Bh Y2UoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUklNYXliZUVtcHR5KSBjb25zdAogICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgaWYgKEVsZW1lbnQq IGFuY2VzdG9yID0gYW5jZXN0b3JFbGVtZW50KCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGFu Y2VzdG9yLT5pc0RlZmF1bHROYW1lc3BhY2UobmFtZXNwYWNlVVJJKTsKKyAgICAgICAgICAgIGlm IChhdXRvKiBwYXJlbnQgPSBwYXJlbnRFbGVtZW50KCkpCisgICAgICAgICAgICAgICAgcmV0dXJu IHBhcmVudC0+aXNEZWZhdWx0TmFtZXNwYWNlKG5hbWVzcGFjZVVSSSk7CiAKICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICAgICAgfQpAQCAtMTMzOSw4ICsxMzM5LDggQEAgYm9vbCBOb2Rl Ojppc0RlZmF1bHROYW1lc3BhY2UoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUklNYXli ZUVtcHR5KSBjb25zdAogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAgICAg ICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBpZiAoRWxlbWVudCogYW5jZXN0b3IgPSBhbmNlc3Rv ckVsZW1lbnQoKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gYW5jZXN0b3ItPmlzRGVmYXVsdE5h bWVzcGFjZShuYW1lc3BhY2VVUkkpOworICAgICAgICAgICAgaWYgKGF1dG8qIHBhcmVudCA9IHBh cmVudEVsZW1lbnQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gcGFyZW50LT5pc0RlZmF1bHRO YW1lc3BhY2UobmFtZXNwYWNlVVJJKTsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiB9CkBAIC0xMzcwLDggKzEzNzAsOCBAQCBTdHJpbmcgTm9kZTo6bG9va3VwUHJlZml4KGNvbnN0 IEF0b21pY1N0cmluZyAmbmFtZXNwYWNlVVJJKSBjb25zdAogICAgICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwogICAgICAgICB9CiAgICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBpZiAoRWxl bWVudCogYW5jZXN0b3IgPSBhbmNlc3RvckVsZW1lbnQoKSkKLSAgICAgICAgICAgICAgICByZXR1 cm4gYW5jZXN0b3ItPmxvb2t1cFByZWZpeChuYW1lc3BhY2VVUkkpOworICAgICAgICAgICAgaWYg KGF1dG8qIHBhcmVudCA9IHBhcmVudEVsZW1lbnQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4g cGFyZW50LT5sb29rdXBQcmVmaXgobmFtZXNwYWNlVVJJKTsKICAgICAgICAgICAgIHJldHVybiBT dHJpbmcoKTsKICAgICB9CiB9CkBAIC0xNDA4LDggKzE0MDgsOCBAQCBTdHJpbmcgTm9kZTo6bG9v a3VwTmFtZXNwYWNlVVJJKGNvbnN0IFN0cmluZyAmcHJlZml4KSBjb25zdAogICAgICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQotICAgICAgICAgICAg aWYgKEVsZW1lbnQqIGFuY2VzdG9yID0gYW5jZXN0b3JFbGVtZW50KCkpCi0gICAgICAgICAgICAg ICAgcmV0dXJuIGFuY2VzdG9yLT5sb29rdXBOYW1lc3BhY2VVUkkocHJlZml4KTsKKyAgICAgICAg ICAgIGlmIChhdXRvKiBwYXJlbnQgPSBwYXJlbnRFbGVtZW50KCkpCisgICAgICAgICAgICAgICAg cmV0dXJuIHBhcmVudC0+bG9va3VwTmFtZXNwYWNlVVJJKHByZWZpeCk7CiAgICAgICAgICAgICBy ZXR1cm4gU3RyaW5nKCk7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBET0NVTUVOVF9OT0RFOgpA QCAtMTQyOCw4ICsxNDI4LDggQEAgU3RyaW5nIE5vZGU6Omxvb2t1cE5hbWVzcGFjZVVSSShjb25z dCBTdHJpbmcgJnByZWZpeCkgY29uc3QKICAgICAgICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7 CiAgICAgICAgIH0KICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGlmIChFbGVtZW50KiBh bmNlc3RvciA9IGFuY2VzdG9yRWxlbWVudCgpKQotICAgICAgICAgICAgICAgIHJldHVybiBhbmNl c3Rvci0+bG9va3VwTmFtZXNwYWNlVVJJKHByZWZpeCk7CisgICAgICAgICAgICBpZiAoYXV0byog cGFyZW50ID0gcGFyZW50RWxlbWVudCgpKQorICAgICAgICAgICAgICAgIHJldHVybiBwYXJlbnQt Pmxvb2t1cE5hbWVzcGFjZVVSSShwcmVmaXgpOwogICAgICAgICAgICAgcmV0dXJuIFN0cmluZygp OwogICAgIH0KIH0KQEAgLTE0NTIsOCArMTQ1Miw4IEBAIFN0cmluZyBOb2RlOjpsb29rdXBOYW1l c3BhY2VQcmVmaXgoY29uc3QgQXRvbWljU3RyaW5nICZfbmFtZXNwYWNlVVJJLCBjb25zdCBFbGVt CiAgICAgICAgIH0KICAgICB9CiAgICAgCi0gICAgaWYgKEVsZW1lbnQqIGFuY2VzdG9yID0gYW5j ZXN0b3JFbGVtZW50KCkpCi0gICAgICAgIHJldHVybiBhbmNlc3Rvci0+bG9va3VwTmFtZXNwYWNl UHJlZml4KF9uYW1lc3BhY2VVUkksIG9yaWdpbmFsRWxlbWVudCk7CisgICAgaWYgKGF1dG8qIHBh cmVudCA9IHBhcmVudEVsZW1lbnQoKSkKKyAgICAgICAgcmV0dXJuIHBhcmVudC0+bG9va3VwTmFt ZXNwYWNlUHJlZml4KF9uYW1lc3BhY2VVUkksIG9yaWdpbmFsRWxlbWVudCk7CiAgICAgcmV0dXJu IFN0cmluZygpOwogfQogCkBAIC0xNTMwLDE1ICsxNTMwLDYgQEAgdm9pZCBOb2RlOjpzZXRUZXh0 Q29udGVudChjb25zdCBTdHJpbmcmIHRleHQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOwogfQogCi1FbGVtZW50KiBOb2RlOjphbmNlc3RvckVsZW1lbnQoKSBj b25zdAotewotICAgIGZvciAoQ29udGFpbmVyTm9kZSogYW5jZXN0b3IgPSBwYXJlbnROb2RlKCk7 IGFuY2VzdG9yOyBhbmNlc3RvciA9IGFuY2VzdG9yLT5wYXJlbnROb2RlKCkpIHsKLSAgICAgICAg aWYgKGlzPEVsZW1lbnQ+KCphbmNlc3RvcikpCi0gICAgICAgICAgICByZXR1cm4gZG93bmNhc3Q8 RWxlbWVudD4oYW5jZXN0b3IpOwotICAgIH0KLSAgICByZXR1cm4gbnVsbHB0cjsKLX0KLQogYm9v bCBOb2RlOjpvZmZzZXRJbkNoYXJhY3RlcnMoKSBjb25zdAogewogICAgIHJldHVybiBmYWxzZTsK QEAgLTE2NzUsOCArMTY2Niw3IEBAIEZsb2F0UG9pbnQgTm9kZTo6Y29udmVydFRvUGFnZShjb25z dCBGbG9hdFBvaW50JiBwKSBjb25zdAogICAgICAgICByZXR1cm4gcmVuZGVyZXIoKS0+bG9jYWxU b0Fic29sdXRlKHAsIFVzZVRyYW5zZm9ybXMpOwogICAgIAogICAgIC8vIE90aGVyd2lzZSBnbyB1 cCB0aGUgdHJlZSBsb29raW5nIGZvciBhIHJlbmRlcmVyCi0gICAgRWxlbWVudCAqcGFyZW50ID0g YW5jZXN0b3JFbGVtZW50KCk7Ci0gICAgaWYgKHBhcmVudCkKKyAgICBpZiAoYXV0byogcGFyZW50 ID0gcGFyZW50RWxlbWVudCgpKQogICAgICAgICByZXR1cm4gcGFyZW50LT5jb252ZXJ0VG9QYWdl KHApOwogCiAgICAgLy8gTm8gcGFyZW50IC0gbm8gY29udmVyc2lvbiBuZWVkZWQKQEAgLTE2OTAs OCArMTY4MCw3IEBAIEZsb2F0UG9pbnQgTm9kZTo6Y29udmVydEZyb21QYWdlKGNvbnN0IEZsb2F0 UG9pbnQmIHApIGNvbnN0CiAgICAgICAgIHJldHVybiByZW5kZXJlcigpLT5hYnNvbHV0ZVRvTG9j YWwocCwgVXNlVHJhbnNmb3Jtcyk7CiAKICAgICAvLyBPdGhlcndpc2UgZ28gdXAgdGhlIHRyZWUg bG9va2luZyBmb3IgYSByZW5kZXJlcgotICAgIEVsZW1lbnQgKnBhcmVudCA9IGFuY2VzdG9yRWxl bWVudCgpOwotICAgIGlmIChwYXJlbnQpCisgICAgaWYgKGF1dG8qIHBhcmVudCA9IHBhcmVudEVs ZW1lbnQoKSkKICAgICAgICAgcmV0dXJuIHBhcmVudC0+Y29udmVydEZyb21QYWdlKHApOwogCiAg ICAgLy8gTm8gcGFyZW50IC0gbm8gY29udmVyc2lvbiBuZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IGE2 ODBhY2NjNzRhZjIzNTRhNDIwYzI0YjJhNDdjZmE2NjExMWYwMDIuLmUzM2JiMjFkNjY1NzgzZjc4 YzRmZjdjNDQwNzc2N2E2MGYwNzI5MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaApAQCAtNjc1LDggKzY3NSw2IEBA IHByaXZhdGU6CiAgICAgdm9pZCByZWZFdmVudFRhcmdldCgpIG92ZXJyaWRlOwogICAgIHZvaWQg ZGVyZWZFdmVudFRhcmdldCgpIG92ZXJyaWRlOwogCi0gICAgRWxlbWVudCogYW5jZXN0b3JFbGVt ZW50KCkgY29uc3Q7Ci0KICAgICB2b2lkIHRyYWNrRm9yRGVidWdnaW5nKCk7CiAgICAgdm9pZCBt YXRlcmlhbGl6ZVJhcmVEYXRhKCk7CiAK